[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1507: HDDS-4307.Start Background Service for Trash Deletion in Ozone Manager

2020-10-21 Thread GitBox
rakeshadr commented on a change in pull request #1507: URL: https://github.com/apache/hadoop-ozone/pull/1507#discussion_r509870897 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/TrashDeletingService.java ## @@ -0,0 +1,114 @@ +/** + *

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1507: HDDS-4307.Start Background Service for Trash Deletion in Ozone Manager

2020-10-21 Thread GitBox
rakeshadr commented on a change in pull request #1507: URL: https://github.com/apache/hadoop-ozone/pull/1507#discussion_r509870311 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java ## @@ -1228,17 +1236,34 @@ public void

[GitHub] [hadoop-ozone] prashantpogde commented on pull request #1507: HDDS-4307.Start Background Service for Trash Deletion in Ozone Manager

2020-10-21 Thread GitBox
prashantpogde commented on pull request #1507: URL: https://github.com/apache/hadoop-ozone/pull/1507#issuecomment-714205605 Can you address the CI failures ? This is an automated message from the Apache Git Service. To

[jira] [Updated] (HDDS-4365) SCMBlockLocationFailoverProxyProvider should use ScmBlockLocationProtocolPB.class in RPC.setProtocolEngine

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-4365: - Labels: pull-request-available (was: ) > SCMBlockLocationFailoverProxyProvider should use >

[GitHub] [hadoop-ozone] GlenGeng opened a new pull request #1512: HDDS-4365: SCMBlockLocationFailoverProxyProvider should use ScmBlockLocationProtocolPB.class in RPC.setProtocolEngine

2020-10-21 Thread GitBox
GlenGeng opened a new pull request #1512: URL: https://github.com/apache/hadoop-ozone/pull/1512 ## What changes were proposed in this pull request? In SCMBlockLocationFailoverProxyProvider, currently it is ``` private ScmBlockLocationProtocolPB createSCMProxy(

[jira] [Updated] (HDDS-4365) SCMBlockLocationFailoverProxyProvider should use ScmBlockLocationProtocolPB.class in RPC.setProtocolEngine

2020-10-21 Thread Glen Geng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Glen Geng updated HDDS-4365: Description: in SCMBlockLocationFailoverProxyProvider, currently it is {code:java} private

[jira] [Assigned] (HDDS-4365) SCMBlockLocationFailoverProxyProvider should use ScmBlockLocationProtocolPB.class in RPC.setProtocolEngine

2020-10-21 Thread Glen Geng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Glen Geng reassigned HDDS-4365: --- Assignee: Glen Geng > SCMBlockLocationFailoverProxyProvider should use >

[jira] [Updated] (HDDS-4365) SCMBlockLocationFailoverProxyProvider should use ScmBlockLocationProtocolPB.class in RPC.setProtocolEngine

2020-10-21 Thread Glen Geng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Glen Geng updated HDDS-4365: Description: in SCMBlockLocationFailoverProxyProvider, currently it is {code:java} private

[jira] [Updated] (HDDS-4365) SCMBlockLocationFailoverProxyProvider should use ScmBlockLocationProtocolPB.class in RPC.setProtocolEngine

2020-10-21 Thread Glen Geng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Glen Geng updated HDDS-4365: Description: in SCMBlockLocationFailoverProxyProvider, it should be  {code:java} private

[jira] [Updated] (HDDS-4365) SCMBlockLocationFailoverProxyProvider should use ScmBlockLocationProtocolPB.class in RPC.setProtocolEngine

2020-10-21 Thread Glen Geng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Glen Geng updated HDDS-4365: Priority: Minor (was: Major) > SCMBlockLocationFailoverProxyProvider should use >

[jira] [Created] (HDDS-4365) SCMBlockLocationFailoverProxyProvider should use ScmBlockLocationProtocolPB.class in RPC.setProtocolEngine

2020-10-21 Thread Glen Geng (Jira)
Glen Geng created HDDS-4365: --- Summary: SCMBlockLocationFailoverProxyProvider should use ScmBlockLocationProtocolPB.class in RPC.setProtocolEngine Key: HDDS-4365 URL: https://issues.apache.org/jira/browse/HDDS-4365

[jira] [Updated] (HDDS-4332) ListFileStatus - do lookup in directory and file tables

2020-10-21 Thread Rakesh Radhakrishnan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh Radhakrishnan updated HDDS-4332: --- Status: Patch Available (was: In Progress) > ListFileStatus - do lookup in directory

[jira] [Created] (HDDS-4364) List FileStatus : startKey can be a non-existed path

2020-10-21 Thread Rakesh Radhakrishnan (Jira)
Rakesh Radhakrishnan created HDDS-4364: -- Summary: List FileStatus : startKey can be a non-existed path Key: HDDS-4364 URL: https://issues.apache.org/jira/browse/HDDS-4364 Project: Hadoop

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-21 Thread GitBox
rakeshadr commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r509846900 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void

[GitHub] [hadoop-ozone] prashantpogde edited a comment on pull request #1486: HDDS-4296. SCM changes to process Layout Info in heartbeat request/response

2020-10-21 Thread GitBox
prashantpogde edited a comment on pull request #1486: URL: https://github.com/apache/hadoop-ozone/pull/1486#issuecomment-713919301 Updated with new set of changes after taking care of all review comments. Please take a look.

[GitHub] [hadoop-ozone] prashantpogde commented on pull request #1486: HDDS-4296. SCM changes to process Layout Info in heartbeat request/response

2020-10-21 Thread GitBox
prashantpogde commented on pull request #1486: URL: https://github.com/apache/hadoop-ozone/pull/1486#issuecomment-713919301 Updates new set of changes after taking care of all review comments. Please take a look. This is an

[jira] [Updated] (HDDS-4123) Integrate OM Open Key Cleanup Service Into Existing Code

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-4123: - Labels: pull-request-available (was: ) > Integrate OM Open Key Cleanup Service Into Existing

[GitHub] [hadoop-ozone] errose28 opened a new pull request #1511: HDDS-4123. Integrate OM Open Key Cleanup Service Into Existing Code

2020-10-21 Thread GitBox
errose28 opened a new pull request #1511: URL: https://github.com/apache/hadoop-ozone/pull/1511 ## What changes were proposed in this pull request? This pull request completes the open key cleanup service outlined in the parent Jira HDDS-4120. It implements the

[jira] [Updated] (HDDS-4123) Integrate OM Open Key Cleanup Service Into Existing Code

2020-10-21 Thread Ethan Rose (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ethan Rose updated HDDS-4123: - Description: Implement the `OpenKeyCleanupService` class, and start and stop the service in

[jira] [Updated] (HDDS-4123) Integrate OM Open Key Cleanup Service Into Existing Code

2020-10-21 Thread Ethan Rose (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ethan Rose updated HDDS-4123: - Description: Finish the existing implementation of OpenKeyDeletingService#call. Start the

[jira] [Updated] (HDDS-4363) Add metric to track the number of RocksDB open/close operations

2020-10-21 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HDDS-4363: -- Target Version/s: 1.1.0 > Add metric to track the number of RocksDB open/close operations >

[jira] [Assigned] (HDDS-4363) Add metric to track the number of RocksDB open/close operations

2020-10-21 Thread Mukul Kumar Singh (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukul Kumar Singh reassigned HDDS-4363: --- Assignee: Aryan Gupta > Add metric to track the number of RocksDB open/close

[jira] [Created] (HDDS-4363) Add metric to track the number of RocksDB open/close operations

2020-10-21 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created HDDS-4363: - Summary: Add metric to track the number of RocksDB open/close operations Key: HDDS-4363 URL: https://issues.apache.org/jira/browse/HDDS-4363 Project: Hadoop

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-21 Thread GitBox
rakeshadr commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r509548807 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void

[jira] [Commented] (HDDS-4358) Delete : make delete an atomic ops for leaf node(empty directory or file)

2020-10-21 Thread Rakesh Radhakrishnan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218477#comment-17218477 ] Rakesh Radhakrishnan commented on HDDS-4358: +Note:+ Please revisit {{ozoneFS#listStatus}} and

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-21 Thread GitBox
rakeshadr commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r509543716 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-21 Thread GitBox
rakeshadr commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r509543376 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-21 Thread GitBox
rakeshadr commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r509543538 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-21 Thread GitBox
rakeshadr commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r509535852 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-21 Thread GitBox
rakeshadr commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r509534970 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -1831,6 +1838,62 @@ private

[jira] [Updated] (HDDS-4359) Expose VolumeIOStats in DN JMX

2020-10-21 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HDDS-4359: - Fix Version/s: 1.1.0 Resolution: Fixed Status: Resolved (was: Patch Available) >

[GitHub] [hadoop-ozone] smengcl merged pull request #1506: HDDS-4359. Expose VolumeIOStats in DN JMX

2020-10-21 Thread GitBox
smengcl merged pull request #1506: URL: https://github.com/apache/hadoop-ozone/pull/1506 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop-ozone] sodonnel merged pull request #1491: HDDS-4340. Add Operational State to the datanode list command

2020-10-21 Thread GitBox
sodonnel merged pull request #1491: URL: https://github.com/apache/hadoop-ozone/pull/1491 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (HDDS-4362) Change hadoop32 test to use 3.2 image

2020-10-21 Thread Attila Doroszlai (Jira)
Attila Doroszlai created HDDS-4362: -- Summary: Change hadoop32 test to use 3.2 image Key: HDDS-4362 URL: https://issues.apache.org/jira/browse/HDDS-4362 Project: Hadoop Distributed Data Store

[GitHub] [hadoop-ozone] sodonnel merged pull request #1501: HDDS-4323. Add integration tests for putting nodes into maintenance and fix any issues uncovered in the tests

2020-10-21 Thread GitBox
sodonnel merged pull request #1501: URL: https://github.com/apache/hadoop-ozone/pull/1501 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (HDDS-4323) Add integration tests for putting nodes into maintenance and fix any issues uncovered in the tests

2020-10-21 Thread Stephen O'Donnell (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen O'Donnell resolved HDDS-4323. - Fix Version/s: 1.1.0 Resolution: Fixed > Add integration tests for putting nodes

[GitHub] [hadoop-ozone] GlenGeng opened a new pull request #1510: [Draft]HDDS-4191: failover proxy for container location protocol

2020-10-21 Thread GitBox
GlenGeng opened a new pull request #1510: URL: https://github.com/apache/hadoop-ozone/pull/1510 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## What is the link to the Apache JIRA (Please create an issue in ASF JIRA

[GitHub] [hadoop-ozone] GlenGeng closed pull request #1509: HDDS-4191: Please ignore.

2020-10-21 Thread GitBox
GlenGeng closed pull request #1509: URL: https://github.com/apache/hadoop-ozone/pull/1509 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HDDS-4191) Add failover proxy for SCM container client

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-4191: - Labels: pull-request-available (was: ) > Add failover proxy for SCM container client >

[GitHub] [hadoop-ozone] GlenGeng opened a new pull request #1509: HDDS-4191: Please ignore.

2020-10-21 Thread GitBox
GlenGeng opened a new pull request #1509: URL: https://github.com/apache/hadoop-ozone/pull/1509 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## What is the link to the Apache JIRA (Please create an issue in ASF JIRA

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-21 Thread GitBox
linyiqun commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r509163394 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #1498: HDDS-4339. Allow AWSSignatureProcessor init when aws signature is absent.

2020-10-21 Thread GitBox
timmylicheng commented on a change in pull request #1498: URL: https://github.com/apache/hadoop-ozone/pull/1498#discussion_r509089823 ## File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java ## @@ -116,6 +116,13 @@ private

[jira] [Created] (HDDS-4361) S3 native error messages when header is illegal

2020-10-21 Thread Li Cheng (Jira)
Li Cheng created HDDS-4361: -- Summary: S3 native error messages when header is illegal Key: HDDS-4361 URL: https://issues.apache.org/jira/browse/HDDS-4361 Project: Hadoop Distributed Data Store

[GitHub] [hadoop-ozone] smengcl commented on pull request #1506: HDDS-4359. Expose VolumeIOStats in DN JMX

2020-10-21 Thread GitBox
smengcl commented on pull request #1506: URL: https://github.com/apache/hadoop-ozone/pull/1506#issuecomment-713336320 > I see you have manually tested this change and share the result above. > +1 from me, : ). Thanks for reviewing and +1'ing this @linyiqun :) Just added test in