adoroszlai commented on a change in pull request #1192:
URL: https://github.com/apache/hadoop-ozone/pull/1192#discussion_r481025587
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/fs/OzoneManagerFS.java
##########
@@ -31,7 +31,18 @@
* Ozone Manager FileSystem interface.
*/
public interface OzoneManagerFS extends IOzoneAcl {
- OzoneFileStatus getFileStatus(OmKeyArgs args) throws IOException;
+
+ /**
+ * Get file status for a file or a directory.
+ *
+ * @param args the args of the key provided by client.
+ * @param clientAddress a hint to key manager, order the datanode in returned
+ * pipeline by distance between client and datanode.
+ * @return file status.
+ * @throws IOException
+ */
+ OzoneFileStatus getFileStatus(OmKeyArgs args, String clientAddress)
Review comment:
Should we also keep the two original methods? Even if backwards
compatibility is not required for this interface, it would let us avoid
changing lots of calls just to pass `null`.
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/fs/OzoneManagerFS.java
##########
@@ -31,7 +31,18 @@
* Ozone Manager FileSystem interface.
*/
public interface OzoneManagerFS extends IOzoneAcl {
- OzoneFileStatus getFileStatus(OmKeyArgs args) throws IOException;
+
+ /**
+ * Get file status for a file or a directory.
+ *
+ * @param args the args of the key provided by client.
+ * @param clientAddress a hint to key manager, order the datanode in returned
+ * pipeline by distance between client and datanode.
+ * @return file status.
+ * @throws IOException
Review comment:
Thank you for adding updated doc from `KeyManagerImpl` to the interface.
Is there a reason exception is not described (the cases when they are thrown)?
Also, can you please remove the old javadoc from the implementation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
