cxorm commented on pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#issuecomment-685179614
Thank you @captainzmc for updating the PR.
Could you rebase it with latest master branch ?
This PR looks good to me, +1 (cc @ChenSammi )
cxorm commented on pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#issuecomment-669071164
> Update PR, like
[HDDS-3991](https://issues.apache.org/jira/browse/HDDS-3991), Ignore protobuf
lock files.
> Hi @cxorm. Previous issues has been solved. Could you help
cxorm commented on pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#issuecomment-66287
Sorry for my careless huge "Add single comment" yesterday.
There are Test-related-part and API-backward-compatibility-part to be
reviewed. (If anyone continue
cxorm commented on pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#issuecomment-662824611
Thanks @captainzmc for the work.
Overall the functionalily-part is good and some suggestions is added inline,
test-related-part would be reviewd soon.
Here I have
