[GitHub] [hadoop-ozone] elek commented on issue #710: HDDS-3173. Provide better default JVM options

2020-04-03 Thread GitBox
elek commented on issue #710: HDDS-3173. Provide better default JVM options URL: https://github.com/apache/hadoop-ozone/pull/710#issuecomment-608378597 No more concerns in the last two days and I got +1 from @arp7 Thanks the review for all of you. @fapifta If you are not happy

[GitHub] [hadoop-ozone] elek commented on issue #710: HDDS-3173. Provide better default JVM options

2020-04-01 Thread GitBox
elek commented on issue #710: HDDS-3173. Provide better default JVM options URL: https://github.com/apache/hadoop-ozone/pull/710#issuecomment-607125264 ``` om_1| No '-XX:...' jvm parameters are used. Adding safer GC settings to the HADOOP_OPTS om_1| OpenJDK 64-Bit Serv

[GitHub] [hadoop-ozone] elek commented on issue #710: HDDS-3173. Provide better default JVM options

2020-04-01 Thread GitBox
elek commented on issue #710: HDDS-3173. Provide better default JVM options URL: https://github.com/apache/hadoop-ozone/pull/710#issuecomment-607121589 I feel myself uncomfortable to print out warning ("JVM paraters are NOT added") _when_ the app is used in the normal way (properly configur

[GitHub] [hadoop-ozone] elek commented on issue #710: HDDS-3173. Provide better default JVM options

2020-03-27 Thread GitBox
elek commented on issue #710: HDDS-3173. Provide better default JVM options URL: https://github.com/apache/hadoop-ozone/pull/710#issuecomment-605005247 > What do you think? I think it's a very good idea to print out the flags when we touch them, but not sure what is your suggestion e

[GitHub] [hadoop-ozone] elek commented on issue #710: HDDS-3173. Provide better default JVM options

2020-03-25 Thread GitBox
elek commented on issue #710: HDDS-3173. Provide better default JVM options URL: https://github.com/apache/hadoop-ozone/pull/710#issuecomment-603768420 > It would be better to restrict the regex to something which is more close to GC stuff, like something that matches to GC case insensitive