[GitHub] [hadoop-ozone] leosunli commented on a change in pull request #1033: HDDS-3667. If we gracefully stop datanode it would be better to notify scm and r…

2020-07-24 Thread GitBox
leosunli commented on a change in pull request #1033: URL: https://github.com/apache/hadoop-ozone/pull/1033#discussion_r459992764 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java ## @@ -708,6 +707,21 @@ private void

[GitHub] [hadoop-ozone] leosunli commented on a change in pull request #1033: HDDS-3667. If we gracefully stop datanode it would be better to notify scm and r…

2020-07-22 Thread GitBox
leosunli commented on a change in pull request #1033: URL: https://github.com/apache/hadoop-ozone/pull/1033#discussion_r459203434 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java ## @@ -164,9 +171,29 @@ public Void

[GitHub] [hadoop-ozone] leosunli commented on a change in pull request #1033: HDDS-3667. If we gracefully stop datanode it would be better to notify scm and r…

2020-07-22 Thread GitBox
leosunli commented on a change in pull request #1033: URL: https://github.com/apache/hadoop-ozone/pull/1033#discussion_r459203399 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java ## @@ -708,6 +707,21 @@ private void

[GitHub] [hadoop-ozone] leosunli commented on a change in pull request #1033: HDDS-3667. If we gracefully stop datanode it would be better to notify scm and r…

2020-06-10 Thread GitBox
leosunli commented on a change in pull request #1033: URL: https://github.com/apache/hadoop-ozone/pull/1033#discussion_r438540923 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/endpoint/UnRegisterEndpointTask.java ##

[GitHub] [hadoop-ozone] leosunli commented on a change in pull request #1033: HDDS-3667. If we gracefully stop datanode it would be better to notify scm and r…

2020-06-09 Thread GitBox
leosunli commented on a change in pull request #1033: URL: https://github.com/apache/hadoop-ozone/pull/1033#discussion_r437524947 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/StateContext.java ## @@ -384,10