[GitHub] [hadoop-ozone] sodonnel commented on pull request #1339: HDDS-4131. Container report should update container key count and bytes used if they differ in SCM

2020-09-01 Thread GitBox
sodonnel commented on pull request #1339: URL: https://github.com/apache/hadoop-ozone/pull/1339#issuecomment-684505875 I think this change is good to commit now? @adoroszlai gave a thumbs up a few days back and I have addressed the only concern @ChenSammi raised. I will commit

[GitHub] [hadoop-ozone] sodonnel commented on pull request #1339: HDDS-4131. Container report should update container key count and bytes used if they differ in SCM

2020-08-25 Thread GitBox
sodonnel commented on pull request #1339: URL: https://github.com/apache/hadoop-ozone/pull/1339#issuecomment-680275842 @adoroszlai @ChenSammi Are you happy with this change at this stage? Can we commit it? This is an

[GitHub] [hadoop-ozone] sodonnel commented on pull request #1339: HDDS-4131. Container report should update container key count and bytes used if they differ in SCM

2020-08-21 Thread GitBox
sodonnel commented on pull request #1339: URL: https://github.com/apache/hadoop-ozone/pull/1339#issuecomment-678312913 > Basically AbstractContainerReportHandler is not the perfect place to handle this because it doesn't have a global view while Replication Manager has.