[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1104: HDDS-3612. Allow mounting bucket under other volume

2020-07-02 Thread GitBox
adoroszlai commented on pull request #1104: URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-653003019 @ChenSammi this feature is continuation of S3 volume mapping changes. Can you please take a look?

[GitHub] [hadoop-ozone] GlenGeng commented on pull request #1151: HDDS-3191: switch from SCMPipelineManager to PipelineManagerV2Impl

2020-07-02 Thread GitBox
GlenGeng commented on pull request #1151: URL: https://github.com/apache/hadoop-ozone/pull/1151#issuecomment-652947720 Hello @elek @adoroszlai Would you please help check a GitHub CI problem ? I want to push 2 commit from my dev branch `GlenGeng:HDDS-3191` to branch

[GitHub] [hadoop-ozone] captainzmc commented on pull request #1150: HDDS-3903. OzoneRpcClient support batch rename keys.

2020-07-02 Thread GitBox
captainzmc commented on pull request #1150: URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-652965666 Thanks @xiaoyuyao for the review. I have fixed review issues. Can you take another look? This is an

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1150: HDDS-3903. OzoneRpcClient support batch rename keys.

2020-07-02 Thread GitBox
adoroszlai commented on a change in pull request #1150: URL: https://github.com/apache/hadoop-ozone/pull/1150#discussion_r448995364 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysRenameRequest.java ## @@ -0,0 +1,298 @@ +/**

[GitHub] [hadoop-ozone] captainzmc commented on a change in pull request #1150: HDDS-3903. OzoneRpcClient support batch rename keys.

2020-07-02 Thread GitBox
captainzmc commented on a change in pull request #1150: URL: https://github.com/apache/hadoop-ozone/pull/1150#discussion_r449052061 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysRenameRequest.java ## @@ -0,0 +1,298 @@ +/**

[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #1143: HDDS-3891. Add the usage of ofs in doc.

2020-07-02 Thread GitBox
xiaoyuyao merged pull request #1143: URL: https://github.com/apache/hadoop-ozone/pull/1143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #1053: HDDS-3737. Avoid serialization between UUID and String

2020-07-02 Thread GitBox
xiaoyuyao merged pull request #1053: URL: https://github.com/apache/hadoop-ozone/pull/1053 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (HDDS-3763) Avoid serialization between UUID and String

2020-07-02 Thread Xiaoyu Yao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoyu Yao resolved HDDS-3763. -- Fix Version/s: 0.7.0 Resolution: Fixed Thanks [~yjxxtd] for the contribution and all for the

[GitHub] [hadoop-ozone] cku328 commented on pull request #1153: HDDS-3440. Enable TestFreonWithPipelineDestroy test cases

2020-07-02 Thread GitBox
cku328 commented on pull request #1153: URL: https://github.com/apache/hadoop-ozone/pull/1153#issuecomment-653120161 Thanks @adoroszlai for merging this. For #1106 commit, do I need to modify this test case? This is an

[GitHub] [hadoop-ozone] adoroszlai merged pull request #1128: HDDS-3862. Prepare checks for running some tests multiple times

2020-07-02 Thread GitBox
adoroszlai merged pull request #1128: URL: https://github.com/apache/hadoop-ozone/pull/1128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1128: HDDS-3862. Prepare checks for running some tests multiple times

2020-07-02 Thread GitBox
adoroszlai commented on pull request #1128: URL: https://github.com/apache/hadoop-ozone/pull/1128#issuecomment-653175048 > +1 let's merge after a green build Build is finally green, merging it. Thanks @elek for the review.

[jira] [Updated] (HDDS-3900) Update default value of 'ozone.om.ratis.segment.size' and 'preallocated.size' to improve OM write perf

2020-07-02 Thread Rakesh Radhakrishnan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh Radhakrishnan updated HDDS-3900: --- Summary: Update default value of 'ozone.om.ratis.segment.size' and

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1150: HDDS-3903. OzoneRpcClient support batch rename keys.

2020-07-02 Thread GitBox
adoroszlai commented on a change in pull request #1150: URL: https://github.com/apache/hadoop-ozone/pull/1150#discussion_r449131416 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysRenameRequest.java ## @@ -0,0 +1,298 @@ +/**

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1145: HDDS-3895. Implement container related operations in ContainerManagerImpl

2020-07-02 Thread GitBox
xiaoyuyao commented on a change in pull request #1145: URL: https://github.com/apache/hadoop-ozone/pull/1145#discussion_r449190798 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManagerImpl.java ## @@ -93,94 +98,45 @@ public

[jira] [Updated] (HDDS-3900) Update default value of 'ozone.om.ratis.segment.size' and 'preallocated.size' to improve OM write perf

2020-07-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3900: - Labels: om-perf performance pull-request-available (was: om-perf performance) > Update default

[GitHub] [hadoop-ozone] rakeshadr opened a new pull request #1160: HDDS-3900: Update default value of 'ozone.om.ratis.segment.size' and …

2020-07-02 Thread GitBox
rakeshadr opened a new pull request #1160: URL: https://github.com/apache/hadoop-ozone/pull/1160 ## What changes were proposed in this pull request? Based on the OM write performance tests on **HDDs** - write heavy workload Synthetic NNLoadGenerator in single node HA, the default 16KB

[GitHub] [hadoop-ozone] nandakumar131 commented on pull request #1157: HDDS-3911. Compile error in acceptance test on HDDS-2823

2020-07-02 Thread GitBox
nandakumar131 commented on pull request #1157: URL: https://github.com/apache/hadoop-ozone/pull/1157#issuecomment-653140405 I have retriggered the prechecks. This is an automated message from the Apache Git Service. To

[GitHub] [hadoop-ozone] nandakumar131 commented on pull request #1157: HDDS-3911. Compile error in acceptance test on HDDS-2823

2020-07-02 Thread GitBox
nandakumar131 commented on pull request #1157: URL: https://github.com/apache/hadoop-ozone/pull/1157#issuecomment-653139679 The test failure doesn't seem to be related. Thanks @adoroszlai for the quick fix. This is an

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1145: HDDS-3895. Implement container related operations in ContainerManagerImpl

2020-07-02 Thread GitBox
xiaoyuyao commented on a change in pull request #1145: URL: https://github.com/apache/hadoop-ozone/pull/1145#discussion_r449292409 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManagerV2.java ## @@ -113,7 +90,7 @@ void

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1145: HDDS-3895. Implement container related operations in ContainerManagerImpl

2020-07-02 Thread GitBox
xiaoyuyao commented on a change in pull request #1145: URL: https://github.com/apache/hadoop-ozone/pull/1145#discussion_r449304483 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManagerImpl.java ## @@ -60,6 +64,7 @@ /**

[jira] [Commented] (HDDS-3834) We need a edge(master) docs website updated by nightly build

2020-07-02 Thread maobaolong (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150639#comment-17150639 ] maobaolong commented on HDDS-3834: -- Hi [~elek] How can we make this master branch document website come

[GitHub] [hadoop-ozone] timmylicheng commented on pull request #1157: HDDS-3911. Compile error in acceptance test on HDDS-2823

2020-07-02 Thread GitBox
timmylicheng commented on pull request #1157: URL: https://github.com/apache/hadoop-ozone/pull/1157#issuecomment-653295744 I will merge this. Thanks @adoroszlai for the contribution. This is an automated message from the

[GitHub] [hadoop-ozone] timmylicheng merged pull request #1157: HDDS-3911. Compile error in acceptance test on HDDS-2823

2020-07-02 Thread GitBox
timmylicheng merged pull request #1157: URL: https://github.com/apache/hadoop-ozone/pull/1157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop-ozone] GlenGeng commented on pull request #1151: HDDS-3191: switch from SCMPipelineManager to PipelineManagerV2Impl

2020-07-02 Thread GitBox
GlenGeng commented on pull request #1151: URL: https://github.com/apache/hadoop-ozone/pull/1151#issuecomment-653330301 also see this flaky case failure in `master` branch see https://github.com/apache/hadoop-ozone/pull/1147

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1145: HDDS-3895. Implement container related operations in ContainerManagerImpl

2020-07-02 Thread GitBox
xiaoyuyao commented on a change in pull request #1145: URL: https://github.com/apache/hadoop-ozone/pull/1145#discussion_r449309362 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerStateManagerV2.java ## @@ -130,6 +141,21 @@

[GitHub] [hadoop-ozone] GlenGeng commented on pull request #1159: HDDS-3913. Recon build should ignore proxies

2020-07-02 Thread GitBox
GlenGeng commented on pull request #1159: URL: https://github.com/apache/hadoop-ozone/pull/1159#issuecomment-653328134 > /ping @ChenSammi > > I guess, you have inernal builds. Do you cache npm artifacts in local maven proxy. Do you see any problem with this change? @elek

[jira] [Commented] (HDDS-2939) Ozone FS namespace

2020-07-02 Thread maobaolong (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150643#comment-17150643 ] maobaolong commented on HDDS-2939: -- Hi [~rakeshr], thank you for working on this feature, after read the

[jira] [Resolved] (HDDS-3891) Add the usage of ofs in doc.

2020-07-02 Thread Xiaoyu Yao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoyu Yao resolved HDDS-3891. -- Fix Version/s: 0.7.0 Resolution: Fixed Thanks [~micahzhao] for the contribution. I've merged the

[jira] [Updated] (HDDS-3440) Enable TestFreonWithPipelineDestroy test cases

2020-07-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3440: - Labels: pull-request-available (was: ) > Enable TestFreonWithPipelineDestroy test cases >

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1153: HDDS-3440. Enable TestFreonWithPipelineDestroy test cases

2020-07-02 Thread GitBox
adoroszlai commented on pull request #1153: URL: https://github.com/apache/hadoop-ozone/pull/1153#issuecomment-653151342 > For #1106 commit, do I need to modify this test case? No, thanks, I've already updated it in 809a1e28665a8b0d92b481fb09811178f84d4a3b.

[jira] [Comment Edited] (HDDS-3911) Compile error in acceptance test on HDDS-2823

2020-07-02 Thread Li Cheng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150672#comment-17150672 ] Li Cheng edited comment on HDDS-3911 at 7/3/20, 2:09 AM: -

[jira] [Commented] (HDDS-3911) Compile error in acceptance test on HDDS-2823

2020-07-02 Thread Li Cheng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150672#comment-17150672 ] Li Cheng commented on HDDS-3911: [https://github.com/apache/hadoop-ozone/pull/1157] is merged. Closing

[GitHub] [hadoop-ozone] codecov-commenter commented on pull request #1049: HDDS-3662 Decouple finalizeAndDestroyPipeline.

2020-07-02 Thread GitBox
codecov-commenter commented on pull request #1049: URL: https://github.com/apache/hadoop-ozone/pull/1049#issuecomment-65025 # [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1049?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base

[GitHub] [hadoop-ozone] adoroszlai merged pull request #1127: HDDS-3421. Enabling TestStorageContainerManager.

2020-07-02 Thread GitBox
adoroszlai merged pull request #1127: URL: https://github.com/apache/hadoop-ozone/pull/1127 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (HDDS-3421) Enable TestStorageContainerManager test cases

2020-07-02 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-3421. Fix Version/s: 0.6.0 Resolution: Fixed > Enable TestStorageContainerManager test

[jira] [Updated] (HDDS-3909) Use ContainerScrubberConfiguration in ChunkManagerFactory

2020-07-02 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-3909: --- Status: Patch Available (was: In Progress) > Use ContainerScrubberConfiguration in

[GitHub] [hadoop-ozone] captainzmc commented on a change in pull request #1150: HDDS-3903. OzoneRpcClient support batch rename keys.

2020-07-02 Thread GitBox
captainzmc commented on a change in pull request #1150: URL: https://github.com/apache/hadoop-ozone/pull/1150#discussion_r448730306 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysRenameRequest.java ## @@ -0,0 +1,289 @@ +/**

[jira] [Updated] (HDDS-3913) Recon build should ignore proxies

2020-07-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3913: - Labels: pull-request-available (was: ) > Recon build should ignore proxies >

[GitHub] [hadoop-ozone] elek commented on pull request #1133: HDDS-3875. Package classpath files to the jar files instead of uploading them as artifacts

2020-07-02 Thread GitBox
elek commented on pull request #1133: URL: https://github.com/apache/hadoop-ozone/pull/1133#issuecomment-652848754 Merging it. Hopefully we will have fewer problems with the 0.6.0. Thanks the review @adoroszlai This is an

[GitHub] [hadoop-ozone] elek commented on pull request #1159: HDDS-3913. Recon build should ignore proxies

2020-07-02 Thread GitBox
elek commented on pull request #1159: URL: https://github.com/apache/hadoop-ozone/pull/1159#issuecomment-652844533 /ping @ChenSammi I guess, you have inernal builds. Do you cache npm artifacts in local maven proxy. Do you see any problem with this change?

[jira] [Resolved] (HDDS-3632) HddsDatanodeService cannot be started if HDFS datanode running in same machine with same user.

2020-07-02 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek resolved HDDS-3632. --- Fix Version/s: 0.6.0 Resolution: Fixed > HddsDatanodeService cannot be started if HDFS

[GitHub] [hadoop-ozone] elek merged pull request #1133: HDDS-3875. Package classpath files to the jar files instead of uploading them as artifacts

2020-07-02 Thread GitBox
elek merged pull request #1133: URL: https://github.com/apache/hadoop-ozone/pull/1133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (HDDS-3875) Package classpath files to the jar files instead of uploading them as artifacts

2020-07-02 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek resolved HDDS-3875. --- Fix Version/s: 0.6.0 Resolution: Fixed > Package classpath files to the jar files instead of

[GitHub] [hadoop-ozone] elek commented on pull request #1115: HDDS-3632. starter scripts can't manage Ozone and HDFS datandodes on the same machine

2020-07-02 Thread GitBox
elek commented on pull request #1115: URL: https://github.com/apache/hadoop-ozone/pull/1115#issuecomment-652848067 Merging. Thanks the review @adoroszlai @arp7 and @umamaheswararao (and the report @umamaheswararao) This is

[GitHub] [hadoop-ozone] elek merged pull request #1115: HDDS-3632. starter scripts can't manage Ozone and HDFS datandodes on the same machine

2020-07-02 Thread GitBox
elek merged pull request #1115: URL: https://github.com/apache/hadoop-ozone/pull/1115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1157: HDDS-3911. Compile error in acceptance test on HDDS-2823

2020-07-02 Thread GitBox
adoroszlai commented on pull request #1157: URL: https://github.com/apache/hadoop-ozone/pull/1157#issuecomment-652888660 > Is this happening for master as well? No, it's specific to the `HDDS-2823` branch. I've updated the PR description with an explanation.