[jira] [Commented] (HDDS-2591) No tailMap needed for startIndex 0 in ContainerSet#listContainer

2019-11-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979928#comment-16979928 ] Attila Doroszlai commented on HDDS-2591: Thanks [~bharat], I submitted a PR to fix

[jira] [Updated] (HDDS-2609) Move plain unit tests out of integration tests

2019-11-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-2609: --- Status: Patch Available (was: In Progress) > Move plain unit tests out of integration tests >

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#discussion_r349457448 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hd

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #260: HDDS-2609. Move plain unit tests out of integration tests

2019-11-21 Thread GitBox
adoroszlai opened a new pull request #260: HDDS-2609. Move plain unit tests out of integration tests URL: https://github.com/apache/hadoop-ozone/pull/260 ## What changes were proposed in this pull request? Move a couple of tests from `integration-test` to `container-service` and `se

[jira] [Updated] (HDDS-2609) Move plain unit tests out of integration tests

2019-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-2609: - Labels: pull-request-available (was: ) > Move plain unit tests out of integration tests > ---

[jira] [Updated] (HDDS-2611) Sonar : resolve issues reported in ContainerSet

2019-11-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-2611: --- Labels: sonar (was: ) > Sonar : resolve issues reported in ContainerSet > ---

[jira] [Updated] (HDDS-2612) Sonar : Reduce Cognitive Complexity of dispatchRequest in HddsDispatcher

2019-11-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-2612: --- Labels: sonar (was: ) > Sonar : Reduce Cognitive Complexity of dispatchRequest in HddsDispatc

[jira] [Updated] (HDDS-2614) Sonar : reduce Cognitive Complexity of applyTransaction in ContainerStateMachine

2019-11-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-2614: --- Labels: sonar (was: ) > Sonar : reduce Cognitive Complexity of applyTransaction in > Contain

[jira] [Updated] (HDDS-2613) Sonar : reduce Cognitive Complexity of deleteBlocksCommandHandler

2019-11-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-2613: --- Labels: sonar (was: ) > Sonar : reduce Cognitive Complexity of deleteBlocksCommandHandler > -

[jira] [Updated] (HDDS-2615) Sonar : reduce Cognitive Complexity of scanData in KeyValueContainerCheck

2019-11-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-2615: --- Labels: sonar (was: ) > Sonar : reduce Cognitive Complexity of scanData in KeyValueContainerC

[jira] [Updated] (HDDS-2617) Sonar : reduce Cognitive Complexity of runIteration in ContainerDataScanner

2019-11-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-2617: --- Labels: sonar (was: ) > Sonar : reduce Cognitive Complexity of runIteration in ContainerDataS

[jira] [Updated] (HDDS-2616) Sonar : reduce Cognitive Complexity of isDeletionAllowed in BlockDeletingService

2019-11-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-2616: --- Labels: sonar (was: ) > Sonar : reduce Cognitive Complexity of isDeletionAllowed in > BlockD

[jira] [Updated] (HDDS-2618) Sonar : reduce Cognitive Complexity of readVolume in ContainerReader

2019-11-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-2618: --- Labels: sonar (was: ) > Sonar : reduce Cognitive Complexity of readVolume in ContainerReader

[jira] [Updated] (HDDS-2618) Sonar : reduce Cognitive Complexity of readVolume in ContainerReader

2019-11-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-2618: --- Summary: Sonar : reduce Cognitive Complexity of readVolume in ContainerReader (was: Sonar : r

[GitHub] [hadoop-ozone] adoroszlai commented on issue #255: HDDS-2603. Avoid unnecessary boxing in XceiverClientReply

2019-11-21 Thread GitBox
adoroszlai commented on issue #255: HDDS-2603. Avoid unnecessary boxing in XceiverClientReply URL: https://github.com/apache/hadoop-ozone/pull/255#issuecomment-557414807 Thanks @xiaoyuyao for the review and @dineshchitlangia for reviewing and merging it. --

[GitHub] [hadoop-ozone] adoroszlai commented on issue #256: HDDS-2605. Use LongSupplier to avoid boxing

2019-11-21 Thread GitBox
adoroszlai commented on issue #256: HDDS-2605. Use LongSupplier to avoid boxing URL: https://github.com/apache/hadoop-ozone/pull/256#issuecomment-557414611 Thanks @swagle and @dineshchitlangia for the review. This is an automa

[GitHub] [hadoop-ozone] adoroszlai commented on issue #248: HDDS-2602 Make auto creation for RATIS ONE pipeline configurable.

2019-11-21 Thread GitBox
adoroszlai commented on issue #248: HDDS-2602 Make auto creation for RATIS ONE pipeline configurable. URL: https://github.com/apache/hadoop-ozone/pull/248#issuecomment-557412042 > @adoroszlai Thanks for the review! I see you click approve these changes. Shall I assume you +1 for this PR?

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #248: HDDS-2602 Make auto creation for RATIS ONE pipeline configurable.

2019-11-21 Thread GitBox
adoroszlai commented on a change in pull request #248: HDDS-2602 Make auto creation for RATIS ONE pipeline configurable. URL: https://github.com/apache/hadoop-ozone/pull/248#discussion_r349451442 ## File path: hadoop-hdds/common/src/main/resources/ozone-default.xml ## @@ -

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
bharatviswa504 commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#discussion_r349441560 ## File path: hadoop-hdds/common/src/main/java/org/apache/hado

[GitHub] [hadoop-ozone] avijayanhwx opened a new pull request #259: HDDS-2619. Fix Sonar issues in ReconTaskControllerImpl.

2019-11-21 Thread GitBox
avijayanhwx opened a new pull request #259: HDDS-2619. Fix Sonar issues in ReconTaskControllerImpl. URL: https://github.com/apache/hadoop-ozone/pull/259 ## What changes were proposed in this pull request? Fix sonar issues in ReconTaskControllerImpl. https://sonarcloud.io/project/issu

[jira] [Updated] (HDDS-2619) Fix Sonar issues in ReconTaskControllerImpl

2019-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-2619: - Labels: pull-request-available sonar (was: sonar) > Fix Sonar issues in ReconTaskControllerImpl >

[jira] [Created] (HDDS-2619) Fix Sonar issues in ReconTaskControllerImpl

2019-11-21 Thread Aravindan Vijayan (Jira)
Aravindan Vijayan created HDDS-2619: --- Summary: Fix Sonar issues in ReconTaskControllerImpl Key: HDDS-2619 URL: https://issues.apache.org/jira/browse/HDDS-2619 Project: Hadoop Distributed Data Store

[jira] [Assigned] (HDDS-2382) Consider reducing number of file::exists() calls during write operation

2019-11-21 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aravindan Vijayan reassigned HDDS-2382: --- Assignee: (was: Aravindan Vijayan) > Consider reducing number of file::exists() c

[jira] [Assigned] (HDDS-2208) Propagate System Exceptions from OM transaction apply phase

2019-11-21 Thread Supratim Deka (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Supratim Deka reassigned HDDS-2208: --- Assignee: (was: Supratim Deka) > Propagate System Exceptions from OM transaction apply ph

[jira] [Assigned] (HDDS-1890) Add metrics for data pipeline performance monitoring in ContainerStateMachine

2019-11-21 Thread Supratim Deka (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Supratim Deka reassigned HDDS-1890: --- Assignee: (was: Supratim Deka) > Add metrics for data pipeline performance monitoring in

[jira] [Assigned] (HDDS-1243) DataNodes should propagate exceptions to clients

2019-11-21 Thread Supratim Deka (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Supratim Deka reassigned HDDS-1243: --- Assignee: (was: Supratim Deka) > DataNodes should propagate exceptions to clients > -

[jira] [Assigned] (HDDS-1485) Propogate correct errors from DN to Ozone client.

2019-11-21 Thread Supratim Deka (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Supratim Deka reassigned HDDS-1485: --- Assignee: (was: Supratim Deka) > Propogate correct errors from DN to Ozone client. >

[jira] [Assigned] (HDDS-2175) Propagate System Exceptions from the OzoneManager

2019-11-21 Thread Supratim Deka (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Supratim Deka reassigned HDDS-2175: --- Assignee: (was: Supratim Deka) > Propagate System Exceptions from the OzoneManager >

[jira] [Assigned] (HDDS-2206) Separate handling for OMException and IOException in the Ozone Manager

2019-11-21 Thread Supratim Deka (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Supratim Deka reassigned HDDS-2206: --- Assignee: (was: Supratim Deka) > Separate handling for OMException and IOException in the

[jira] [Assigned] (HDDS-2057) Incorrect Default OM Port in Ozone FS URI Error Message

2019-11-21 Thread Supratim Deka (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Supratim Deka reassigned HDDS-2057: --- Assignee: (was: Supratim Deka) > Incorrect Default OM Port in Ozone FS URI Error Message

[jira] [Updated] (HDDS-2614) Sonar : reduce Cognitive Complexity of applyTransaction in ContainerStateMachine

2019-11-21 Thread Supratim Deka (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Supratim Deka updated HDDS-2614: Description: Sonar reports CC of applyTransaction is 22: https://sonarcloud.io/project/issues?id=ha

[jira] [Created] (HDDS-2618) Sonar : reduce Cognitive Complexity of applyTransaction in ContainerStateMachinegnitive Complexity of readVolume in ContainerReader

2019-11-21 Thread Supratim Deka (Jira)
Supratim Deka created HDDS-2618: --- Summary: Sonar : reduce Cognitive Complexity of applyTransaction in ContainerStateMachinegnitive Complexity of readVolume in ContainerReader Key: HDDS-2618 URL: https://issues.apach

[jira] [Created] (HDDS-2617) Sonar : reduce Cognitive Complexity of runIteration in ContainerDataScanner

2019-11-21 Thread Supratim Deka (Jira)
Supratim Deka created HDDS-2617: --- Summary: Sonar : reduce Cognitive Complexity of runIteration in ContainerDataScanner Key: HDDS-2617 URL: https://issues.apache.org/jira/browse/HDDS-2617 Project: Hadoop

[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
bharatviswa504 edited a comment on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#issuecomment-557390815 > > So, in this case below flow looks incorrect or is this is fine?, as we are re

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
bharatviswa504 commented on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#issuecomment-557390815 > > So, in this case below flow looks incorrect or is this is fine?, as we are removing

[jira] [Created] (HDDS-2616) Sonar : reduce Cognitive Complexity of isDeletionAllowed in BlockDeletingService

2019-11-21 Thread Supratim Deka (Jira)
Supratim Deka created HDDS-2616: --- Summary: Sonar : reduce Cognitive Complexity of isDeletionAllowed in BlockDeletingService Key: HDDS-2616 URL: https://issues.apache.org/jira/browse/HDDS-2616 Project: H

[jira] [Created] (HDDS-2615) Sonar : reduce Cognitive Complexity of scanData in KeyValueContainerCheck

2019-11-21 Thread Supratim Deka (Jira)
Supratim Deka created HDDS-2615: --- Summary: Sonar : reduce Cognitive Complexity of scanData in KeyValueContainerCheck Key: HDDS-2615 URL: https://issues.apache.org/jira/browse/HDDS-2615 Project: Hadoop D

[jira] [Updated] (HDDS-2612) Sonar : Reduce Cognitive Complexity of dispatchRequest in HddsDispatcher

2019-11-21 Thread Supratim Deka (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Supratim Deka updated HDDS-2612: Description: Sonar reports CC of dispatchRequest is 49, reduce to 15. https://sonarcloud.io/project

[jira] [Updated] (HDDS-2510) Use isEmpty() to check whether the collection is empty or not in Ozone Manager module

2019-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-2510: - Labels: pull-request-available sonar (was: sonar) > Use isEmpty() to check whether the collection

[GitHub] [hadoop-ozone] avijayanhwx opened a new pull request #258: HDDS-2510. Use isEmpty() to check whether the collection is empty or not in Ozone Manager module

2019-11-21 Thread GitBox
avijayanhwx opened a new pull request #258: HDDS-2510. Use isEmpty() to check whether the collection is empty or not in Ozone Manager module URL: https://github.com/apache/hadoop-ozone/pull/258 ## What changes were proposed in this pull request? Replace an O(n) .size() check with the O(1

[jira] [Created] (HDDS-2614) Sonar : reduce Cognitive Complexity of applyTransaction in ContainerStateMachine

2019-11-21 Thread Supratim Deka (Jira)
Supratim Deka created HDDS-2614: --- Summary: Sonar : reduce Cognitive Complexity of applyTransaction in ContainerStateMachine Key: HDDS-2614 URL: https://issues.apache.org/jira/browse/HDDS-2614 Project: H

[jira] [Created] (HDDS-2613) Sonar : reduce Cognitive Complexity of deleteBlocksCommandHandler

2019-11-21 Thread Supratim Deka (Jira)
Supratim Deka created HDDS-2613: --- Summary: Sonar : reduce Cognitive Complexity of deleteBlocksCommandHandler Key: HDDS-2613 URL: https://issues.apache.org/jira/browse/HDDS-2613 Project: Hadoop Distribut

[jira] [Updated] (HDDS-2573) Handle InterruptedException in KeyOutputStream

2019-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-2573: - Labels: newbie pull-request-available sonar (was: newbie sonar) > Handle InterruptedException in

[GitHub] [hadoop-ozone] avijayanhwx opened a new pull request #257: HDDS-2573. Handle InterruptedException in KeyOutputStream.

2019-11-21 Thread GitBox
avijayanhwx opened a new pull request #257: HDDS-2573. Handle InterruptedException in KeyOutputStream. URL: https://github.com/apache/hadoop-ozone/pull/257 ## What changes were proposed in this pull request? https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-m5KcVY8lQ

[jira] [Created] (HDDS-2612) Sonar : Reduce Cognitive Complexity of dispatchRequest in HddsDispatcher

2019-11-21 Thread Supratim Deka (Jira)
Supratim Deka created HDDS-2612: --- Summary: Sonar : Reduce Cognitive Complexity of dispatchRequest in HddsDispatcher Key: HDDS-2612 URL: https://issues.apache.org/jira/browse/HDDS-2612 Project: Hadoop Di

[jira] [Updated] (HDDS-2611) Sonar : resolve issues reported in ContainerSet

2019-11-21 Thread Supratim Deka (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Supratim Deka updated HDDS-2611: Description: Sonar issues: https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-6RKcVY8

[jira] [Updated] (HDDS-2603) Avoid unnecessary boxing in XceiverClientReply

2019-11-21 Thread Dinesh Chitlangia (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Chitlangia updated HDDS-2603: Fix Version/s: 0.5.0 Resolution: Fixed Status: Resolved (was: Patch Availa

[jira] [Created] (HDDS-2611) Sonar : resolve issues reported in ContainerSet

2019-11-21 Thread Supratim Deka (Jira)
Supratim Deka created HDDS-2611: --- Summary: Sonar : resolve issues reported in ContainerSet Key: HDDS-2611 URL: https://issues.apache.org/jira/browse/HDDS-2611 Project: Hadoop Distributed Data Store

[GitHub] [hadoop-ozone] dineshchitlangia merged pull request #255: HDDS-2603. Avoid unnecessary boxing in XceiverClientReply

2019-11-21 Thread GitBox
dineshchitlangia merged pull request #255: HDDS-2603. Avoid unnecessary boxing in XceiverClientReply URL: https://github.com/apache/hadoop-ozone/pull/255 This is an automated message from the Apache Git Service. To respond t

[GitHub] [hadoop-ozone] dineshchitlangia merged pull request #256: HDDS-2605. Use LongSupplier to avoid boxing

2019-11-21 Thread GitBox
dineshchitlangia merged pull request #256: HDDS-2605. Use LongSupplier to avoid boxing URL: https://github.com/apache/hadoop-ozone/pull/256 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (HDDS-2605) Use LongSupplier to avoid boxing

2019-11-21 Thread Dinesh Chitlangia (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Chitlangia updated HDDS-2605: Fix Version/s: 0.5.0 Resolution: Fixed Status: Resolved (was: Patch Availa

[GitHub] [hadoop-ozone] dineshchitlangia commented on issue #205: HDDS-2386. Implement incremental ChunkBuffer.

2019-11-21 Thread GitBox
dineshchitlangia commented on issue #205: HDDS-2386. Implement incremental ChunkBuffer. URL: https://github.com/apache/hadoop-ozone/pull/205#issuecomment-557384710 @elek I was able to re-run all checks by Github Actions. How can we re-trigger ci/integration ? -

[GitHub] [hadoop-ozone] timmylicheng commented on issue #248: HDDS-2602 Make auto creation for RATIS ONE pipeline configurable.

2019-11-21 Thread GitBox
timmylicheng commented on issue #248: HDDS-2602 Make auto creation for RATIS ONE pipeline configurable. URL: https://github.com/apache/hadoop-ozone/pull/248#issuecomment-557377956 @adoroszlai Thanks for the review! I see you click approve these changes. Shall I assume you +1 for this PR?

[GitHub] [hadoop-ozone] mukul1987 commented on issue #236: HDDS-2284. XceiverClientMetrics should be initialised as part of XceiverClientManager constructor.

2019-11-21 Thread GitBox
mukul1987 commented on issue #236: HDDS-2284. XceiverClientMetrics should be initialised as part of XceiverClientManager constructor. URL: https://github.com/apache/hadoop-ozone/pull/236#issuecomment-557376360 Thanks for the review @xiaoyuyao. I have addressed the review comments -

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #248: HDDS-2602 Make auto creation for RATIS ONE pipeline configurable.

2019-11-21 Thread GitBox
timmylicheng commented on a change in pull request #248: HDDS-2602 Make auto creation for RATIS ONE pipeline configurable. URL: https://github.com/apache/hadoop-ozone/pull/248#discussion_r349419600 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #248: HDDS-2602 Make auto creation for RATIS ONE pipeline configurable.

2019-11-21 Thread GitBox
timmylicheng commented on a change in pull request #248: HDDS-2602 Make auto creation for RATIS ONE pipeline configurable. URL: https://github.com/apache/hadoop-ozone/pull/248#discussion_r349420024 ## File path: hadoop-hdds/common/src/main/resources/ozone-default.xml ## @@

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #248: HDDS-2602 Make auto creation for RATIS ONE pipeline configurable.

2019-11-21 Thread GitBox
timmylicheng commented on a change in pull request #248: HDDS-2602 Make auto creation for RATIS ONE pipeline configurable. URL: https://github.com/apache/hadoop-ozone/pull/248#discussion_r349419600 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#discussion_r349415988 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hd

[jira] [Updated] (HDDS-2466) Split OM Key into a Prefix Part and a Name Part

2019-11-21 Thread Supratim Deka (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Supratim Deka updated HDDS-2466: Description: This jira will track all changes required for introducing a separate prefix for keys i

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#discussion_r349415988 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hd

[jira] [Updated] (HDDS-2466) Split OM Key into a Prefix Part and a Name Part

2019-11-21 Thread Supratim Deka (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Supratim Deka updated HDDS-2466: Description: This is a OM stores every key in a Key table, which maps the key to a KeyInfo. FS sem

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#discussion_r349415988 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hd

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#discussion_r349415988 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hd

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#discussion_r349415988 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hd

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#discussion_r349415988 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hd

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#discussion_r349415988 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hd

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
ChenSammi commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#discussion_r349413015 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoo

[jira] [Resolved] (HDDS-1570) Refactor heartbeat reports to report all the pipelines that are open

2019-11-21 Thread Xiaoyu Yao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoyu Yao resolved HDDS-1570. -- Resolution: Duplicate > Refactor heartbeat reports to report all the pipelines that are open > -

[jira] [Resolved] (HDDS-1564) Ozone multi-raft support

2019-11-21 Thread Xiaoyu Yao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoyu Yao resolved HDDS-1564. -- Resolution: Duplicate > Ozone multi-raft support > > > Key: HDD

[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #117: HDDS-1576. Support configure more than one raft log storage to host m…

2019-11-21 Thread GitBox
xiaoyuyao commented on issue #117: HDDS-1576. Support configure more than one raft log storage to host m… URL: https://github.com/apache/hadoop-ozone/pull/117#issuecomment-557359881 /retest This is an automated message from t

[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
xiaoyuyao commented on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#issuecomment-557359389 > If we don't consider them, then it will be always like a fresh installed cluster, as none w

[GitHub] [hadoop-ozone] xiaoyuyao edited a comment on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
xiaoyuyao edited a comment on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#issuecomment-557358269 >So, in this case below flow looks incorrect or is this is fine?, as we are removing f

[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
xiaoyuyao commented on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#issuecomment-557358269 >So, in this case below flow looks incorrect or is this is fine?, as we are removing from DB,

[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
bharatviswa504 edited a comment on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#issuecomment-557328250 And also one more thing I have seen is in DeadnodeHandler, we fire the event to s

[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
bharatviswa504 edited a comment on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#issuecomment-557328250 And also one more thing I have seen is in DeadnodeHandler, we fire the event to s

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
bharatviswa504 commented on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#issuecomment-557328250 And also one more thing I have seen is in DeadnodeHandler, we fire the event to send clo

[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
bharatviswa504 edited a comment on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#issuecomment-557326252 > "I think we should consider AllocatedPipelines during pipelineCount." > >

[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
bharatviswa504 edited a comment on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#issuecomment-557326252 > "I think we should consider AllocatedPipelines during pipelineCount." > >

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
bharatviswa504 commented on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#issuecomment-557326252 > "I think we should consider AllocatedPipelines during pipelineCount." > > The al

[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
xiaoyuyao commented on issue #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#issuecomment-557324419 "I think we should consider AllocatedPipelines during pipelineCount." The allocated one

[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #255: HDDS-2603. Avoid unnecessary boxing in XceiverClientReply

2019-11-21 Thread GitBox
xiaoyuyao commented on issue #255: HDDS-2603. Avoid unnecessary boxing in XceiverClientReply URL: https://github.com/apache/hadoop-ozone/pull/255#issuecomment-557323896 LGTM, +1 pending CI. This is an automated message from t

[jira] [Updated] (HDDS-2591) No tailMap needed for startIndex 0 in ContainerSet#listContainer

2019-11-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-2591: --- Status: Patch Available (was: In Progress) > No tailMap needed for startIndex 0 in ContainerS

[jira] [Updated] (HDDS-2605) Use LongSupplier to avoid boxing

2019-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-2605: - Labels: pull-request-available (was: ) > Use LongSupplier to avoid boxing > -

[jira] [Updated] (HDDS-2603) Avoid unnecessary boxing in XceiverClientReply

2019-11-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-2603: --- Status: Patch Available (was: In Progress) > Avoid unnecessary boxing in XceiverClientReply >

[jira] [Updated] (HDDS-2605) Use LongSupplier to avoid boxing

2019-11-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-2605: --- Status: Patch Available (was: In Progress) > Use LongSupplier to avoid boxing > -

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #256: HDDS-2605. Use LongSupplier to avoid boxing

2019-11-21 Thread GitBox
adoroszlai opened a new pull request #256: HDDS-2605. Use LongSupplier to avoid boxing URL: https://github.com/apache/hadoop-ozone/pull/256 ## What changes were proposed in this pull request? Freon's `ProgressBar` uses `Supplier`, which could be replaced with `LongSupplier` to avoid

[jira] [Commented] (HDDS-2443) Python client/interface for Ozone

2019-11-21 Thread YiSheng Lien (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979689#comment-16979689 ] YiSheng Lien commented on HDDS-2443: Thanks [~elek] for the comments and share. It's

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
xiaoyuyao commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#discussion_r349362184 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoo

[jira] [Updated] (HDDS-2610) Fix the ObjectStore#listVolumes failure when argument is null

2019-11-21 Thread YiSheng Lien (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YiSheng Lien updated HDDS-2610: --- Description: As the description of the [listVolumes|https://github.com/apache/hadoop-ozone/blob/maste

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
bharatviswa504 commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#discussion_r349359239 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/

[jira] [Updated] (HDDS-2603) Avoid unnecessary boxing in XceiverClientReply

2019-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-2603: - Labels: pull-request-available (was: ) > Avoid unnecessary boxing in XceiverClientReply > ---

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #255: HDDS-2603. Avoid unnecessary boxing in XceiverClientReply

2019-11-21 Thread GitBox
adoroszlai opened a new pull request #255: HDDS-2603. Avoid unnecessary boxing in XceiverClientReply URL: https://github.com/apache/hadoop-ozone/pull/255 ## What changes were proposed in this pull request? `XceiverClientReply#logIndex` is unnecessarily boxed/unboxed. `null` value i

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
bharatviswa504 commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#discussion_r349359239 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
bharatviswa504 commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#discussion_r349359239 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/

[jira] [Assigned] (HDDS-2610) Fix the ObjectStore#listVolumes failure when argument is null

2019-11-21 Thread YiSheng Lien (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YiSheng Lien reassigned HDDS-2610: -- Assignee: YiSheng Lien > Fix the ObjectStore#listVolumes failure when argument is null > --

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #254: HDDS-2591. No tailMap needed for startIndex 0 in ContainerSet#listContainer

2019-11-21 Thread GitBox
adoroszlai opened a new pull request #254: HDDS-2591. No tailMap needed for startIndex 0 in ContainerSet#listContainer URL: https://github.com/apache/hadoop-ozone/pull/254 ## What changes were proposed in this pull request? Remove unnecessary `tailMap` call which returns a view of th

[jira] [Updated] (HDDS-2591) No tailMap needed for startIndex 0 in ContainerSet#listContainer

2019-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-2591: - Labels: pull-request-available (was: ) > No tailMap needed for startIndex 0 in ContainerSet#listC

[jira] [Created] (HDDS-2610) Fix the ObjectStore#listVolumes failure when argument is null

2019-11-21 Thread YiSheng Lien (Jira)
YiSheng Lien created HDDS-2610: -- Summary: Fix the ObjectStore#listVolumes failure when argument is null Key: HDDS-2610 URL: https://issues.apache.org/jira/browse/HDDS-2610 Project: Hadoop Distributed Dat

[GitHub] [hadoop-ozone] vivekratnavel commented on issue #253: HDDS-2587. Enable sonarcloud measurement as part of CI builds

2019-11-21 Thread GitBox
vivekratnavel commented on issue #253: HDDS-2587. Enable sonarcloud measurement as part of CI builds URL: https://github.com/apache/hadoop-ozone/pull/253#issuecomment-557306932 @elek Yes, I think it is good to merge. I am exploring on how to run sonar and code coverage report against pull

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands

2019-11-21 Thread GitBox
bharatviswa504 commented on a change in pull request #249: Reopen HDDS-2034 Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/249#discussion_r349355352 ## File path: hadoop-hdds/common/src/main/java/org/apache/hado

  1   2   >