[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1245: HDDS-4011. Update S3 related documentation.

2020-07-24 Thread GitBox


adoroszlai commented on a change in pull request #1245:
URL: https://github.com/apache/hadoop-ozone/pull/1245#discussion_r459868266



##
File path: hadoop-hdds/docs/content/start/StartFromDockerHub.md
##
@@ -72,7 +72,7 @@ connecting to the SCM's UI at 
[http://localhost:9876](http://localhost:9876).
 
 The S3 gateway endpoint will be exposed at port 9878. You can use Ozone's S3
 support as if you are working against the real S3.  S3 buckets are stored under
-the `/s3v` volume, which needs to be created by an administrator first:
+the `/s3v` volume:
 
 ```
 docker-compose exec scm ozone sh volume create /s3v

Review comment:
   Thanks @bharatviswa504 for updating the patch.  I think you missed this 
`volume create` command.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org



[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1245: HDDS-4011. Update S3 related documentation.

2020-07-23 Thread GitBox


adoroszlai commented on a change in pull request #1245:
URL: https://github.com/apache/hadoop-ozone/pull/1245#discussion_r459269878



##
File path: hadoop-hdds/docs/content/start/StartFromDockerHub.md
##
@@ -72,7 +72,7 @@ connecting to the SCM's UI at 
[http://localhost:9876](http://localhost:9876).
 
 The S3 gateway endpoint will be exposed at port 9878. You can use Ozone's S3
 support as if you are working against the real S3.  S3 buckets are stored under
-the `/s3v` volume, which needs to be created by an administrator first:
+the `/s3v` volume:
 
 ```
 docker-compose exec scm ozone sh volume create /s3v

Review comment:
   This code block can be removed, too.

##
File path: hadoop-hdds/docs/content/interface/S3.md
##
@@ -24,7 +24,7 @@ summary: Ozone supports Amazon's Simple Storage Service (S3) 
protocol. In fact,
 
 Ozone provides S3 compatible REST interface to use the object store data with 
any S3 compatible tools.
 
-S3 buckets are stored under the `/s3v`(Default is s3v, which can be setted 
through ozone.s3g.volume.name) volume, which needs to be created by an 
administrator first.
+S3 buckets are stored under the `/s3v`(Default is s3v, which can be setted 
through ozone.s3g.volume.name) volume.

Review comment:
   I think we can improve wording here:
   
   ```suggestion
   S3 buckets are stored under the `/s3v` volume.  The default name `s3v` can 
be changed by setting the `ozone.s3g.volume.name` config property in 
`ozone-site.xml`.
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org