[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1405: HDDS-4143. Implement a factory for OM Requests that returns an instance based on layout version.

2020-09-15 Thread GitBox
avijayanhwx commented on pull request #1405: URL: https://github.com/apache/hadoop-ozone/pull/1405#issuecomment-692869460 Thanks for the reviews. This is ongoing work on a branch, and the implementation can be revisited in case of any pitfall. Merging this now.

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1405: HDDS-4143. Implement a factory for OM Requests that returns an instance based on layout version.

2020-09-12 Thread GitBox
avijayanhwx commented on pull request #1405: URL: https://github.com/apache/hadoop-ozone/pull/1405#issuecomment-691330372 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1405: HDDS-4143. Implement a factory for OM Requests that returns an instance based on layout version.

2020-09-12 Thread GitBox
avijayanhwx commented on pull request #1405: URL: https://github.com/apache/hadoop-ozone/pull/1405#issuecomment-691330372 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1405: HDDS-4143. Implement a factory for OM Requests that returns an instance based on layout version.

2020-09-11 Thread GitBox
avijayanhwx commented on pull request #1405: URL: https://github.com/apache/hadoop-ozone/pull/1405#issuecomment-691330372 > Hi @avijayanhwx, thank you for working on this. > Please find some comments below. > > > First and foremost I would like to comment on the

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1405: HDDS-4143. Implement a factory for OM Requests that returns an instance based on layout version.

2020-09-08 Thread GitBox
avijayanhwx commented on pull request #1405: URL: https://github.com/apache/hadoop-ozone/pull/1405#issuecomment-688948787 cc @fapifta / @prashantpogde. This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1405: HDDS-4143. Implement a factory for OM Requests that returns an instance based on layout version.

2020-09-07 Thread GitBox
avijayanhwx commented on pull request #1405: URL: https://github.com/apache/hadoop-ozone/pull/1405#issuecomment-688623864 > @avijayanhwx , thanks for addressing the comments. LGTM now. > Following build check is not show all green, some steps are failed. Is that current change broken

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1405: HDDS-4143. Implement a factory for OM Requests that returns an instance based on layout version.

2020-09-07 Thread GitBox
avijayanhwx commented on pull request #1405: URL: https://github.com/apache/hadoop-ozone/pull/1405#issuecomment-688528407 cc @linyiqun Addressed the review comments from you in this PR. This is an automated message from the