captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-671682061
> @captainzmc is it a viable option to wait for
[HDDS-2939](https://issues.apache.org/jira/browse/HDDS-2939) which will add
atomic rename capability to OM?
Thanks
captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-671194357
hi @adoroszlai @bharatviswa504 Is there any progress here? I see that PR has
been approved but the status hasn't been updated yet.
-
captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-666932982
> Just a question will this change cause any compatibility issues? (As this
is new API, only new client code will use it, just seeing if I missed anything)
Thanks
captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-666395020
> Thanks @captainzmc for changing the protocol. I think it is much improved
now. I only have couple of minor comments left.
Thanks for @adoroszlai 's feedback. Up
captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-665672921
> > Thanks @captainzmc for updating the patch. It looks better now. However,
I'm still not convinced about adding half-baked support for multi-bucket batch
rename. Let's
captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-661664356
> Thanks @captainzmc for updating the patch. It looks better now. However,
I'm still not convinced about adding half-baked support for multi-bucket batch
rename. Let's w
captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-660969981
Status updates. Fixed review issues. For RpcClient#renameKeys, currently we
only support keys rename for the same bucket. To improve performance, I've
removed the logic
captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-660046911
> > Thanks @captainzmc for updating the PR based on #1195. I would like to
suggest waiting until that PR is merged before updating this one again, to
avoid having to res
captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-660045943
> > Thanks @captainzmc for updating the PR based on #1195. I would like to
suggest waiting until that PR is merged before updating this one again, to
avoid having to res
captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-659232064
> > Thanks @captainzmc for updating the PR based on #1195. I would like to
suggest waiting until that PR is merged before updating this one again, to
avoid having to res
captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-658717829
> > Thanks @captainzmc for updating the PR based on #1195. I would like to
suggest waiting until that PR is merged before updating this one again, to
avoid having to res
captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-658150187
> Thanks @captainzmc for updating the PR based on #1195. I would like to
suggest waiting until that PR is merged before updating this one again, to
avoid having to resol
captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-658073143
hi @xiaoyuyao @adoroszlai. I have updated this PR based on DeleteKeys #1195,
that Bharat had fixed some issues. Could you please review this PR again?
captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-658070412
> I have one comment regarding updateCache which i have seen during
OMKeysDeleteRequest, same applies to OMKeysRenameRequest also.
Hi @bharatviswa504. Thanks for f
captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-657252110
Status updates:
I have updated this PR based on DeleteKeys #1195. Make sure RenameKeys and
DeleteKeys can be implemented in the same way.
---
captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-652965666
Thanks @xiaoyuyao for the review. I have fixed review issues. Can you take
another look?
This is an aut
captainzmc commented on pull request #1150:
URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-651846590
Hi @xiaoyuyao，This PR implementation is consistent with HDDS-3286
batchDelete. And I split batchRename into two subtasks. This one, mainly OM
side implementation. Could
17 matches
Mail list logo
