[GitHub] [hadoop-ozone] elek commented on a change in pull request #956: HDDS-2720. Ozone Failure injection Service

2020-06-09 Thread GitBox


elek commented on a change in pull request #956:
URL: https://github.com/apache/hadoop-ozone/pull/956#discussion_r436794016



##
File path: tools/fault-injection-service/README.md
##
@@ -0,0 +1,56 @@
+Fault Injection Service

Review comment:
   ASF licence header is missing from here.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org



[GitHub] [hadoop-ozone] elek commented on a change in pull request #956: HDDS-2720. Ozone Failure injection Service

2020-05-22 Thread GitBox


elek commented on a change in pull request #956:
URL: https://github.com/apache/hadoop-ozone/pull/956#discussion_r429106622



##
File path: tools/FaultInjectionService/AUTHORS
##
@@ -0,0 +1,12 @@
+Current Maintainer 
 

Review comment:
   I am not sure if we need this file (but I can be convinced). Until now 
we didn't follow this pattern. There are no maintainers of SCM / Freon / OM. 
The community itself is the maintainers but we can check the git history for 
first contact.
   
   This file is also requires additional maintenance. I would suggest to remove 
it.

##
File path: tools/FaultInjectionService/README.md
##
@@ -0,0 +1,53 @@
+NoiseInjector
+==
+
+About
+--
+TBD

Review comment:
   Just one sentence please

##
File path: tools/FaultInjectionService/README.md
##
@@ -0,0 +1,53 @@
+NoiseInjector
+==
+
+About
+--
+TBD
+
+Development Status 
 
+--
+TBD

Review comment:
   One word, please ;-)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org