[GitHub] [hadoop-ozone] maobaolong commented on pull request #934: HDDS-3605. Support close all pipelines.
maobaolong commented on pull request #934: URL: https://github.com/apache/hadoop-ozone/pull/934#issuecomment-636564509 @nandakumar131 @ChenSammi Thank you for your review, let me have a think how to close all pipeline through this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on pull request #934: HDDS-3605. Support close all pipelines.
maobaolong commented on pull request #934: URL: https://github.com/apache/hadoop-ozone/pull/934#issuecomment-632583943 @xiaoyuyao Thank you for your suggestion - i've add two list to show the result of this batch operation - Add a tests - Remove the redundancy condition. PTAL. Please take another look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on pull request #934: HDDS-3605. Support close all pipelines.
maobaolong commented on pull request #934: URL: https://github.com/apache/hadoop-ozone/pull/934#issuecomment-630767176 @ChenSammi Thank you for your review. > can you explain in what situation this command is useful? The situation is that i want to close all pipeline and new some pipeline with my specify replication factor and replication type, so that, i can test which factor is supported by Ozone and ratis. And this command is very useful for me, i can't imagine without this command, how many works will i do to close pipeline one by one. > This command is too powerful, how can we prevent user from mis-operation? In fact, this command is the combine operation of list pipelines and close them, without this command, we also can do the same operation by writing a bash script to achieve the same goal. And, pipeline is already admin command, i think we can have a high level general works we should do is make the admin commands safe, such as verify the role of the user. The following JIRA to track this issue https://issues.apache.org/jira/browse/HDDS-3617 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
