[GitHub] [hadoop-ozone] smengcl commented on pull request #941: HDDS-3574. Implement ofs://: Override getTrashRoot

2020-06-02 Thread GitBox
smengcl commented on pull request #941: URL: https://github.com/apache/hadoop-ozone/pull/941#issuecomment-637594991 > +1, feel free to merge if there is no additional comments. Thanks. Will merge shortly. This is an

[GitHub] [hadoop-ozone] smengcl commented on pull request #941: HDDS-3574. Implement ofs://: Override getTrashRoot

2020-06-01 Thread GitBox
smengcl commented on pull request #941: URL: https://github.com/apache/hadoop-ozone/pull/941#issuecomment-637068626 > > > Just one thought about permissions. How will we ensure data deleted by one user and moved to `.Trash` is not made visible to another user who doesn't have permissions

[GitHub] [hadoop-ozone] smengcl commented on pull request #941: HDDS-3574. Implement ofs://: Override getTrashRoot

2020-05-20 Thread GitBox
smengcl commented on pull request #941: URL: https://github.com/apache/hadoop-ozone/pull/941#issuecomment-631710390 > Just one thought about permissions. How will we ensure data deleted by one user and moved to `.Trash` is not made visible to another user who doesn't have permissions to

[GitHub] [hadoop-ozone] smengcl commented on pull request #941: HDDS-3574. Implement ofs://: Override getTrashRoot

2020-05-20 Thread GitBox
smengcl commented on pull request #941: URL: https://github.com/apache/hadoop-ozone/pull/941#issuecomment-631704542 Also the `getTrashRoot` code doesn't handle the case where the input path is root, volume or bucket. Will post update in a moment.