[jira] [Commented] (HDDS-3001) NFS support for Ozone

2020-05-22 Thread Prashant Pogde (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114504#comment-17114504 ] Prashant Pogde commented on HDDS-3001: -- [~maobaolong] Yes I will access Ozone through

[jira] [Commented] (HDDS-3001) NFS support for Ozone

2020-05-22 Thread maobaolong (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114492#comment-17114492 ] maobaolong commented on HDDS-3001: -- [~ppogde] It's great, you mean you plan to access Ozone through

[jira] [Updated] (HDDS-3644) Failed to delete chunk file due to chunk size mismatch

2020-05-22 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-3644: --- Description: LOGs {noformat} 2020-05-19 13:45:30,493 [BlockDeletingService#8] WARN

[GitHub] [hadoop-ozone] prashantpogde opened a new pull request #956: Hdds 2720

2020-05-22 Thread GitBox
prashantpogde opened a new pull request #956: URL: https://github.com/apache/hadoop-ozone/pull/956 ## What changes were proposed in this pull request? Adding Fault Injection Service in Ozone:tools/FaultInjectionService directory ## What is the link to the Apache JIRA

[GitHub] [hadoop-ozone] captainzmc edited a comment on pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
captainzmc edited a comment on pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#issuecomment-632563724 Hi @bharatviswa504, Could you please help to review this PR? Let's see if there is any effect on OM HA.

[GitHub] [hadoop-ozone] elek commented on a change in pull request #956: HDDS-2720. Ozone Failure injection Service

2020-05-22 Thread GitBox
elek commented on a change in pull request #956: URL: https://github.com/apache/hadoop-ozone/pull/956#discussion_r429106622 ## File path: tools/FaultInjectionService/AUTHORS ## @@ -0,0 +1,12 @@ +Current Maintainer

[GitHub] [hadoop-ozone] captainzmc commented on pull request #940: HDDS-3614. Remove S3Table from OmMetadataManager.

2020-05-22 Thread GitBox
captainzmc commented on pull request #940: URL: https://github.com/apache/hadoop-ozone/pull/940#issuecomment-632582077 LGTM +1. The S3Table is no longer useful after HDDS-3385, and the original mapping relationship should not be needed.

[GitHub] [hadoop-ozone] captainzmc edited a comment on pull request #940: HDDS-3614. Remove S3Table from OmMetadataManager.

2020-05-22 Thread GitBox
captainzmc edited a comment on pull request #940: URL: https://github.com/apache/hadoop-ozone/pull/940#issuecomment-632582077 LGTM +1. The S3Table is no longer useful after HDDS-3385, and the original mapping relationship will not be needed.

[GitHub] [hadoop-ozone] maobaolong commented on a change in pull request #934: HDDS-3605. Support close all pipelines.

2020-05-22 Thread GitBox
maobaolong commented on a change in pull request #934: URL: https://github.com/apache/hadoop-ozone/pull/934#discussion_r429128650 ## File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/pipeline/ClosePipelineSubcommand.java ## @@ -38,14 +40,59 @@

[GitHub] [hadoop-ozone] maobaolong commented on a change in pull request #934: HDDS-3605. Support close all pipelines.

2020-05-22 Thread GitBox
maobaolong commented on a change in pull request #934: URL: https://github.com/apache/hadoop-ozone/pull/934#discussion_r429128112 ## File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/pipeline/ClosePipelineSubcommand.java ## @@ -38,14 +40,59 @@

[jira] [Commented] (HDDS-3630) Merge rocksdb into one in datanode

2020-05-22 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113815#comment-17113815 ] runzhiwang commented on HDDS-3630: -- [~msingh] Thanks for reminding, I will create a google doc to share

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
ChenSammi commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429091904 ## File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto ## @@ -830,7 +832,7 @@ message LookupKeyResponse { message

[jira] [Commented] (HDDS-3385) Simplify S3 -> Ozone volume mapping

2020-05-22 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113843#comment-17113843 ] Marton Elek commented on HDDS-3385: --- [~avijayan] What is the difference between incompatible and

[GitHub] [hadoop-ozone] captainzmc commented on pull request #957: HDDS-3477. Disable partial chunk write during flush() call in ozone client by default.

2020-05-22 Thread GitBox
captainzmc commented on pull request #957: URL: https://github.com/apache/hadoop-ozone/pull/957#issuecomment-632574456 Hi @bshashikant, Could you please help to review this PR? This is an automated message from the Apache

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
timmylicheng commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429095553 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystem.java ## @@ -248,6 +253,34 @@ private

[GitHub] [hadoop-ozone] captainzmc commented on pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
captainzmc commented on pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#issuecomment-632563724 Hi @bharatviswa504, Could you please help me review this PR? Let's see if there is any effect on OM HA.

[jira] [Updated] (HDDS-3477) Disable partial chunk write during flush() call in ozone client by default

2020-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3477: - Labels: pull-request-available (was: ) > Disable partial chunk write during flush() call in

[GitHub] [hadoop-ozone] captainzmc opened a new pull request #957: HDDS-3477. Disable partial chunk write during flush() call in ozone client by default.

2020-05-22 Thread GitBox
captainzmc opened a new pull request #957: URL: https://github.com/apache/hadoop-ozone/pull/957 ## What changes were proposed in this pull request? Currently, Ozone client flushes the partial chunks as well during flush() call by default.

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
timmylicheng commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429085745 ## File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto ## @@ -830,7 +832,7 @@ message LookupKeyResponse { message

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
timmylicheng commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429089141 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyArgs.java ## @@ -256,11 +263,16 @@ public Builder

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
timmylicheng commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429088871 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystem.java ## @@ -157,6 +159,7 @@ public void

[jira] [Updated] (HDDS-2720) Ozone Failure injection Service

2020-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-2720: - Labels: pull-request-available (was: ) > Ozone Failure injection Service >

[GitHub] [hadoop-ozone] captainzmc closed pull request #957: HDDS-3477. Disable partial chunk write during flush() call in ozone client by default.

2020-05-22 Thread GitBox
captainzmc closed pull request #957: URL: https://github.com/apache/hadoop-ozone/pull/957 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
timmylicheng commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429086029 ## File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto ## @@ -848,6 +850,7 @@ message DeleteKeyResponse { // (similar

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
timmylicheng commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429085904 ## File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto ## @@ -695,6 +695,8 @@ message KeyArgs { // This will be set

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
timmylicheng commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429087591 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequest.java ## @@ -111,51 +114,53 @@

[GitHub] [hadoop-ozone] elek commented on pull request #944: HDDS-3609. Avoid to use Hadoop3.x IOUtils in Ozone Client

2020-05-22 Thread GitBox
elek commented on pull request #944: URL: https://github.com/apache/hadoop-ozone/pull/944#issuecomment-632572966 Thanks the feedback @adoroszlai I started to write my first answer yesterday: "good idea, let me check the version of IO commons used by hadoop 2.x" But I started

[GitHub] [hadoop-ozone] captainzmc commented on pull request #957: HDDS-3477. Disable partial chunk write during flush() call in ozone client by default.

2020-05-22 Thread GitBox
captainzmc commented on pull request #957: URL: https://github.com/apache/hadoop-ozone/pull/957#issuecomment-632579658 Hi @bshashikant, Could you please help to review this PR? This is an automated message from the Apache

[GitHub] [hadoop-ozone] captainzmc removed a comment on pull request #957: HDDS-3477. Disable partial chunk write during flush() call in ozone client by default.

2020-05-22 Thread GitBox
captainzmc removed a comment on pull request #957: URL: https://github.com/apache/hadoop-ozone/pull/957#issuecomment-632574456 Hi @bshashikant, Could you please help to review this PR? This is an automated message from the

[GitHub] [hadoop-ozone] maobaolong commented on pull request #934: HDDS-3605. Support close all pipelines.

2020-05-22 Thread GitBox
maobaolong commented on pull request #934: URL: https://github.com/apache/hadoop-ozone/pull/934#issuecomment-632583943 @xiaoyuyao Thank you for your suggestion - i've add two list to show the result of this batch operation - Add a tests - Remove the redundancy condition.

[jira] [Updated] (HDDS-2426) Support recover-trash to an existing bucket.

2020-05-22 Thread YiSheng Lien (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YiSheng Lien updated HDDS-2426: --- Description: Support recovering trash to an existing bucket. *Note* 1. We should also add a config

[jira] [Updated] (HDDS-2426) Support recover-trash to an existing bucket.

2020-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-2426: - Labels: pull-request-available (was: ) > Support recover-trash to an existing bucket. >

[GitHub] [hadoop-ozone] cxorm opened a new pull request #958: HDDS-2426. Support recover-trash to an existing bucket.

2020-05-22 Thread GitBox
cxorm opened a new pull request #958: URL: https://github.com/apache/hadoop-ozone/pull/958 ## What changes were proposed in this pull request? This PR composed of changes including: - provide trash-enabled config when creating buckets. - provide recover-window config when

[GitHub] [hadoop-ozone] lokeshj1703 commented on pull request #767: HDDS-3064. Get Key is hung when READ delay is injected in chunk file path

2020-05-22 Thread GitBox
lokeshj1703 commented on pull request #767: URL: https://github.com/apache/hadoop-ozone/pull/767#issuecomment-632648835 @bshashikant Thanks for the contribution! @elek @adoroszlai Thanks for the reviews! I have committed the PR to master branch.

[GitHub] [hadoop-ozone] lokeshj1703 closed pull request #767: HDDS-3064. Get Key is hung when READ delay is injected in chunk file path

2020-05-22 Thread GitBox
lokeshj1703 closed pull request #767: URL: https://github.com/apache/hadoop-ozone/pull/767 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (HDDS-2823) SCM HA Support

2020-05-22 Thread Nanda kumar (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nanda kumar updated HDDS-2823: -- Target Version/s: 0.7.0 > SCM HA Support > --- > > Key: HDDS-2823 >

[jira] [Updated] (HDDS-3630) Merge rocksdb into one in datanode

2020-05-22 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] runzhiwang updated HDDS-3630: - Description: Currently, one rocksdb for one container. one container has 5GB capacity. 10TB data need

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #954: HDDS-3638. Add a cat command to show the text of a file in the Ozone server

2020-05-22 Thread GitBox
adoroszlai commented on a change in pull request #954: URL: https://github.com/apache/hadoop-ozone/pull/954#discussion_r429213813 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/keys/CatKeyHandler.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #900: HDDS-3500. Hide OMFailoverProxyProvider usage behind an interface

2020-05-22 Thread GitBox
bharatviswa504 commented on a change in pull request #900: URL: https://github.com/apache/hadoop-ozone/pull/900#discussion_r429255662 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OmTransportFactory.java ## @@ -0,0 +1,63 @@ +/** + *

[jira] [Commented] (HDDS-3644) Failed to delete chunk file due to chunk size mismatch

2020-05-22 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114120#comment-17114120 ] Attila Doroszlai commented on HDDS-3644: [~Sammi], after trying various scenarios I think having

[jira] [Updated] (HDDS-2949) mkdir : store directory entries in a separate table

2020-05-22 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aravindan Vijayan updated HDDS-2949: Labels: backward-incompatible (was: ozone-incompatible) > mkdir : store directory entries

[GitHub] [hadoop-ozone] maobaolong commented on pull request #954: HDDS-3638. Add a cat command to show the text of a file in the Ozone server

2020-05-22 Thread GitBox
maobaolong commented on pull request #954: URL: https://github.com/apache/hadoop-ozone/pull/954#issuecomment-632741195 @adoroszlai Thank you for the clarification, i use a const 4096 as chunk size, i think i have address @xiaoyuyao 's comments now, sorry for the misunderstand.

[GitHub] [hadoop-ozone] maobaolong commented on a change in pull request #954: HDDS-3638. Add a cat command to show the text of a file in the Ozone server

2020-05-22 Thread GitBox
maobaolong commented on a change in pull request #954: URL: https://github.com/apache/hadoop-ozone/pull/954#discussion_r429300590 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/keys/CatKeyHandler.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the

[jira] [Updated] (HDDS-3172) Use DBStore instead of MetadataStore in SCM

2020-05-22 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aravindan Vijayan updated HDDS-3172: Labels: backward-incompatible pull-request-available (was: backward-incompatible

[jira] [Commented] (HDDS-3385) Simplify S3 -> Ozone volume mapping

2020-05-22 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114060#comment-17114060 ] Aravindan Vijayan commented on HDDS-3385: - [~elek] We can go with *backward-incompatible* as

[jira] [Updated] (HDDS-3385) Simplify S3 -> Ozone volume mapping

2020-05-22 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aravindan Vijayan updated HDDS-3385: Labels: backward-incompatible imcompatible pull-request-available (was: imcompatible

[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #900: HDDS-3500. Hide OMFailoverProxyProvider usage behind an interface

2020-05-22 Thread GitBox
bharatviswa504 commented on pull request #900: URL: https://github.com/apache/hadoop-ozone/pull/900#issuecomment-632701755 I have one question, other than that it LGTM. This is an automated message from the Apache Git

[jira] [Created] (HDDS-3645) Add a replication type option for putkey command

2020-05-22 Thread maobaolong (Jira)
maobaolong created HDDS-3645: Summary: Add a replication type option for putkey command Key: HDDS-3645 URL: https://issues.apache.org/jira/browse/HDDS-3645 Project: Hadoop Distributed Data Store

[GitHub] [hadoop-ozone] prashantpogde commented on a change in pull request #956: HDDS-2720. Ozone Failure injection Service

2020-05-22 Thread GitBox
prashantpogde commented on a change in pull request #956: URL: https://github.com/apache/hadoop-ozone/pull/956#discussion_r429499942 ## File path: tools/FaultInjectionService/AUTHORS ## @@ -0,0 +1,12 @@ +Current Maintainer

[GitHub] [hadoop-ozone] prashantpogde commented on a change in pull request #956: HDDS-2720. Ozone Failure injection Service

2020-05-22 Thread GitBox
prashantpogde commented on a change in pull request #956: URL: https://github.com/apache/hadoop-ozone/pull/956#discussion_r429499987 ## File path: tools/FaultInjectionService/README.md ## @@ -0,0 +1,53 @@ +NoiseInjector +== + +About +-- +TBD Review comment:

[GitHub] [hadoop-ozone] maobaolong opened a new pull request #962: HDDS-3645. Add a replication type option for putkey command

2020-05-22 Thread GitBox
maobaolong opened a new pull request #962: URL: https://github.com/apache/hadoop-ozone/pull/962 ## What changes were proposed in this pull request? If we can put a key into Ozone by different type {RATIS, STAND_ALONE} , but i have to change the ozone-site.xml file, so, add

[jira] [Updated] (HDDS-3645) Add a replication type option for putkey command

2020-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3645: - Labels: pull-request-available (was: ) > Add a replication type option for putkey command >

[jira] [Created] (HDDS-3646) Add a copy command to copy key to a new one.

2020-05-22 Thread maobaolong (Jira)
maobaolong created HDDS-3646: Summary: Add a copy command to copy key to a new one. Key: HDDS-3646 URL: https://issues.apache.org/jira/browse/HDDS-3646 Project: Hadoop Distributed Data Store

[GitHub] [hadoop-ozone] maobaolong opened a new pull request #963: HDDS-3646. Add a copy command to copy key to a new one.

2020-05-22 Thread GitBox
maobaolong opened a new pull request #963: URL: https://github.com/apache/hadoop-ozone/pull/963 ## What changes were proposed in this pull request? A copy command can copy an exist key into a new one, It should support specify the replication factor and type. ## What is the

[jira] [Updated] (HDDS-3646) Add a copy command to copy key to a new one.

2020-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3646: - Labels: pull-request-available (was: ) > Add a copy command to copy key to a new one. >

[GitHub] [hadoop-ozone] smengcl commented on pull request #865: HDDS-2969. Implement ofs://: Add contract test

2020-05-22 Thread GitBox
smengcl commented on pull request #865: URL: https://github.com/apache/hadoop-ozone/pull/865#issuecomment-632967135 > @smengcl Please rebase the branch to pick up this change from master #867. That should fix the CI issue. > [HDDS-3373](https://issues.apache.org/jira/browse/HDDS-3373).

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
xiaoyuyao commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429341429 ## File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto ## @@ -830,7 +832,7 @@ message LookupKeyResponse { message

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
xiaoyuyao commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429346575 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequest.java ## @@ -196,7 +201,7 @@ public

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
xiaoyuyao commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429358962 ## File path: hadoop-hdds/common/src/main/resources/ozone-default.xml ## @@ -1966,6 +1966,14 @@ jar and false for the

[GitHub] [hadoop-ozone] xiaoyuyao commented on pull request #938: HDDS-3608. NPE while process a pipeline report when PipelineQuery absent in query2OpenPipelines

2020-05-22 Thread GitBox
xiaoyuyao commented on pull request #938: URL: https://github.com/apache/hadoop-ozone/pull/938#issuecomment-632776850 > @xiaoyuyao Sorry, i don't find your comments inline? Could you show me where is the inline comments you mean? The comments is just above:

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
xiaoyuyao commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429340218 ## File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto ## @@ -677,7 +677,7 @@ message ListBucketsResponse { message KeyArgs {

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
xiaoyuyao commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429348515 ## File path: hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneClientAdapterImpl.java ## @@ -272,15 +272,15 @@ public

[GitHub] [hadoop-ozone] xiaoyuyao commented on pull request #954: HDDS-3638. Add a cat command to show the text of a file in the Ozone server

2020-05-22 Thread GitBox
xiaoyuyao commented on pull request #954: URL: https://github.com/apache/hadoop-ozone/pull/954#issuecomment-632806385 LGTM, +1 pending CI. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #855: HDDS-3474. Create transactionInfo Table in OmMetadataManager.

2020-05-22 Thread GitBox
bharatviswa504 merged pull request #855: URL: https://github.com/apache/hadoop-ozone/pull/855 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #855: HDDS-3474. Create transactionInfo Table in OmMetadataManager.

2020-05-22 Thread GitBox
bharatviswa504 commented on pull request #855: URL: https://github.com/apache/hadoop-ozone/pull/855#issuecomment-632831227 Thank You @hanishakoneru for the review and @elek for the discussion and review. This is an

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
xiaoyuyao commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429339639 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyArgs.java ## @@ -256,11 +263,16 @@ public Builder

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
xiaoyuyao commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429346155 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequest.java ## @@ -187,7 +192,7 @@ public

[jira] [Commented] (HDDS-3617) SCM security

2020-05-22 Thread Xiaoyu Yao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114262#comment-17114262 ] Xiaoyu Yao commented on HDDS-3617: -- Thanks [~maobaolong] for open the issue. Please check the service

[jira] [Assigned] (HDDS-3272) Smoke Test: hdfs commands failing on hadoop 27 docker-compose

2020-05-22 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek reassigned HDDS-3272: - Assignee: Marton Elek > Smoke Test: hdfs commands failing on hadoop 27 docker-compose >

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
xiaoyuyao commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429342829 ## File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java ## @@ -382,6 +382,21 @@ public void

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
xiaoyuyao commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429344837 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequest.java ## @@ -111,51 +114,53 @@

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #814: HDDS-3286. BasicOzoneFileSystem support batchDelete.

2020-05-22 Thread GitBox
xiaoyuyao commented on a change in pull request #814: URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429349020 ## File path: hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OzoneClientAdapter.java ## @@ -48,7 +48,7 @@ OzoneFSOutputStream

[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #856: HDDS-3475. Use transactionInfo table to persist transaction information.

2020-05-22 Thread GitBox
bharatviswa504 commented on pull request #856: URL: https://github.com/apache/hadoop-ozone/pull/856#issuecomment-632835753 @hanishakoneru thanks for the review, addressed review comments and also rebased on top of apache/master as now HDDS-3474 went in.

[jira] [Updated] (HDDS-3474) Create transactionInfo Table in OmMetadataManager

2020-05-22 Thread Bharat Viswanadham (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharat Viswanadham updated HDDS-3474: - Fix Version/s: 0.6.0 Resolution: Fixed Status: Resolved (was: Patch

[GitHub] [hadoop-ozone] smengcl commented on pull request #865: HDDS-2969. Implement ofs://: Add contract test

2020-05-22 Thread GitBox
smengcl commented on pull request #865: URL: https://github.com/apache/hadoop-ozone/pull/865#issuecomment-632859113 Retest failed to download artifact. Retriggering again. ``` [ERROR] Failed to execute goal on project hadoop-hdds-common: Could not resolve dependencies for project

[GitHub] [hadoop-ozone] smengcl merged pull request #955: HDDS-3631. KeyInfo related changes to support fileHandle.

2020-05-22 Thread GitBox
smengcl merged pull request #955: URL: https://github.com/apache/hadoop-ozone/pull/955 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (HDDS-3186) Introduce generic SCMRatisRequest and SCMRatisResponse

2020-05-22 Thread Nanda kumar (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nanda kumar updated HDDS-3186: -- Summary: Introduce generic SCMRatisRequest and SCMRatisResponse (was: Client requests to SCM

[jira] [Commented] (HDDS-3186) Introduce generic SCMRatisRequest and SCMRatisResponse

2020-05-22 Thread Nanda kumar (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114347#comment-17114347 ] Nanda kumar commented on HDDS-3186: --- Uploading an initial version of the patch, will update the PR over

[GitHub] [hadoop-ozone] dineshchitlangia merged pull request #942: HDDS-2556. Handle InterruptedException in BlockOutputStream

2020-05-22 Thread GitBox
dineshchitlangia merged pull request #942: URL: https://github.com/apache/hadoop-ozone/pull/942 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop-ozone] dineshchitlangia commented on pull request #942: HDDS-2556. Handle InterruptedException in BlockOutputStream

2020-05-22 Thread GitBox
dineshchitlangia commented on pull request #942: URL: https://github.com/apache/hadoop-ozone/pull/942#issuecomment-632887322 Thanks @bharatviswa504 for review. I have merged this to master. This is an automated message from

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #813: HDDS-3309. Add TimedOutTestsListener to surefire and add timeout to integration tests

2020-05-22 Thread GitBox
adoroszlai commented on pull request #813: URL: https://github.com/apache/hadoop-ozone/pull/813#issuecomment-632898576 > I have addressed the whitespace and removed timeout from more ignored tests. Thanks, the update looks good.

[GitHub] [hadoop-ozone] nandakumar131 commented on pull request #959: HDDS-3186. Initial version.

2020-05-22 Thread GitBox
nandakumar131 commented on pull request #959: URL: https://github.com/apache/hadoop-ozone/pull/959#issuecomment-632868565 /pending "Not ready for review" This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop-ozone] smengcl commented on pull request #813: HDDS-3309. Add TimedOutTestsListener to surefire

2020-05-22 Thread GitBox
smengcl commented on pull request #813: URL: https://github.com/apache/hadoop-ozone/pull/813#issuecomment-632895939 > Thanks @smengcl for continuing work on this. There are few files with whitespace-only change, and several with ignored test class but timeout being added. Please let me

[jira] [Resolved] (HDDS-3638) Add a cat command to show the text of a file in the Ozone server

2020-05-22 Thread Xiaoyu Yao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoyu Yao resolved HDDS-3638. -- Fix Version/s: 0.6.0 Resolution: Fixed Thanks [~maobaolong] for the contribution and all for the

[GitHub] [hadoop-ozone] xiaoyuyao commented on pull request #865: HDDS-2969. Implement ofs://: Add contract test

2020-05-22 Thread GitBox
xiaoyuyao commented on pull request #865: URL: https://github.com/apache/hadoop-ozone/pull/865#issuecomment-632902658 @smengcl Please rebase the branch to pick up this change from master #867. That should fix the CI issue. HDDS-3373. Intermittent failure in TestOMRatisLogParser (#867)

[GitHub] [hadoop-ozone] hanishakoneru commented on pull request #925: HDDS-3586. OM HA can be started with 3 isolated LEADER instead of one OM ring

2020-05-22 Thread GitBox
hanishakoneru commented on pull request #925: URL: https://github.com/apache/hadoop-ozone/pull/925#issuecomment-632843809 Thanks @elek for the review. I was planning to add unit tests but got side-tracked. I will update the PR with unit tests today.

[jira] [Updated] (HDDS-3186) Introduce generic SCMRatisRequest and SCMRatisResponse

2020-05-22 Thread Nanda kumar (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nanda kumar updated HDDS-3186: -- Description: This jira will introduce generic SCMRatisRequest and SCMRatisResponse which will be used

[jira] [Updated] (HDDS-3186) Introduce generic SCMRatisRequest and SCMRatisResponse

2020-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3186: - Labels: pull-request-available (was: ) > Introduce generic SCMRatisRequest and SCMRatisResponse

[GitHub] [hadoop-ozone] nandakumar131 opened a new pull request #959: HDDS-3186. Initial version.

2020-05-22 Thread GitBox
nandakumar131 opened a new pull request #959: URL: https://github.com/apache/hadoop-ozone/pull/959 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## What is the link to the Apache JIRA (Please create an issue in ASF

[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #941: HDDS-3574. Implement ofs://: Override getTrashRoot

2020-05-22 Thread GitBox
smengcl commented on a change in pull request #941: URL: https://github.com/apache/hadoop-ozone/pull/941#discussion_r429422602 ## File path: hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OFSPath.java ## @@ -238,4 +248,23 @@ static String

[jira] [Updated] (HDDS-2556) Handle InterruptedException in BlockOutputStream

2020-05-22 Thread Dinesh Chitlangia (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Chitlangia updated HDDS-2556: Fix Version/s: 0.6.0 Resolution: Fixed Status: Resolved (was: Patch

[jira] [Updated] (HDDS-3309) Add TimedOutTestsListener to surefire and add timeout to integration tests

2020-05-22 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HDDS-3309: - Summary: Add TimedOutTestsListener to surefire and add timeout to integration tests (was: Add

[jira] [Updated] (HDDS-3309) Add TimedOutTestsListener to surefire and add timeouts to integration tests

2020-05-22 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HDDS-3309: - Summary: Add TimedOutTestsListener to surefire and add timeouts to integration tests (was: Add

[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #954: HDDS-3638. Add a cat command to show the text of a file in the Ozone server

2020-05-22 Thread GitBox
xiaoyuyao merged pull request #954: URL: https://github.com/apache/hadoop-ozone/pull/954 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HDDS-2694) HddsVolume#readVersionFile fails when reading older versions

2020-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-2694: - Labels: pull-request-available upgrade (was: upgrade) > HddsVolume#readVersionFile fails when

[GitHub] [hadoop-ozone] avijayanhwx closed pull request #913: HDDS-2694. HddsVolume#readVersionFile fails when reading older versions.

2020-05-22 Thread GitBox
avijayanhwx closed pull request #913: URL: https://github.com/apache/hadoop-ozone/pull/913 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (HDDS-2572) Handle InterruptedException in SCMSecurityProtocolServer

2020-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-2572: - Labels: newbie pull-request-available sonar (was: newbie sonar) > Handle InterruptedException in

[GitHub] [hadoop-ozone] dineshchitlangia opened a new pull request #960: HDDS-2572. Handle InterruptedException in SCMSecurityProtocolServer

2020-05-22 Thread GitBox
dineshchitlangia opened a new pull request #960: URL: https://github.com/apache/hadoop-ozone/pull/960 ## What changes were proposed in this pull request? Handled InterruptedException to address Sonar violations. Also resolved other sonar violations in this file. ## What is the

[jira] [Updated] (HDDS-2572) Handle InterruptedException in SCMSecurityProtocolServer

2020-05-22 Thread Dinesh Chitlangia (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Chitlangia updated HDDS-2572: Status: Patch Available (was: Open) > Handle InterruptedException in

[jira] [Updated] (HDDS-2572) Handle InterruptedException in SCMSecurityProtocolServer

2020-05-22 Thread Dinesh Chitlangia (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Chitlangia updated HDDS-2572: Target Version/s: 0.6.0 (was: 0.5.0) > Handle InterruptedException in

  1   2   >