[GitHub] [hadoop-ozone] adoroszlai commented on issue #271: HDDS-1812. Du while calculating used disk space reports that chunk files are file not found
adoroszlai commented on issue #271: HDDS-1812. Du while calculating used disk space reports that chunk files are file not found URL: https://github.com/apache/hadoop-ozone/pull/271#issuecomment-575045589 Thanks again @arp7, @elek and @hanishakoneru for the reviews, and @arp7 for merging this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #271: HDDS-1812. Du while calculating used disk space reports that chunk files are file not found
adoroszlai commented on issue #271: HDDS-1812. Du while calculating used disk space reports that chunk files are file not found URL: https://github.com/apache/hadoop-ozone/pull/271#issuecomment-574809800 Thanks @hanishakoneru for the kind review. Updated the patch based on your comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #271: HDDS-1812. Du while calculating used disk space reports that chunk files are file not found
adoroszlai commented on issue #271: HDDS-1812. Du while calculating used disk space reports that chunk files are file not found URL: https://github.com/apache/hadoop-ozone/pull/271#issuecomment-561280453 Thanks @elek for the review and offline discussion. I updated the patch to use `@Config` objects for the factories (both for specific implementations and the global one that creates it). I agree that this makes the code more encapsulated, instead of scattering config info around several files (`ozone-default.xml`, `HddsConfigKey`, etc.) I also renamed the factory config property a bit (`...class` to `...classname`, since it's a string). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org