adoroszlai commented on pull request #1104:
URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-659851288
Thanks @arp7, @elek for high-level review, @bharatviswa504 for the detailed
reviews, @ChenSammi for testing and committing it.
-
adoroszlai commented on pull request #1104:
URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-659518247
> I take back this comment. This feature helps to expose buckets created via
shell/ofs to S3. So making it configurable is not needed. (As by default if
user decides to
adoroszlai commented on pull request #1104:
URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-659517803
> I have one suggestion, can we make this mount configurable option, as this
is required only when old S3 buckets needs to be exposed via O3fs/ofs. In this
way, we can a
adoroszlai commented on pull request #1104:
URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-659220643
> 1. When the source bucket is deleted, bucket link still exists. It's an
expected behavior, right?
Yes.
> 2. (Unlike previous per-user S3 volume mapping)
adoroszlai commented on pull request #1104:
URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-659108416
> > > When deleting a bucket, we check bucket is empty or not. Do we need to
check resolvedBucket is empty or not?
> >
> > Link can be deleted regardless of the ex
adoroszlai commented on pull request #1104:
URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-658561325
Thanks @bharatviswa504 for the review. I have updated the patch based on
your comments.
> When deleting a bucket, we check bucket is empty or not. Do we need to
adoroszlai commented on pull request #1104:
URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-658382641
> This patch needs a rebase. (This has been due to one of my commit only).
Done.
> I will take a final look at it today, and will post my comments.
Th
adoroszlai commented on pull request #1104:
URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-654620400
> > > Question: Now when list at the root "/" with ofs filesystem, for link
buckets they will be displayed as a new entry of only resolved buckets will be
shown. What sh
adoroszlai commented on pull request #1104:
URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-653003019
@ChenSammi this feature is continuation of S3 volume mapping changes. Can
you please take a look?
This
adoroszlai commented on pull request #1104:
URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-651590619
Thanks @bharatviswa504 for the review. I have updated the patch based on
your code comments.
This is a
adoroszlai commented on pull request #1104:
URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-651495214
> Question: Now when list at the root "/" with ofs filesystem, for link
buckets they will be displayed as a new entry of only resolved buckets will be
shown. What should
adoroszlai commented on pull request #1104:
URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-649939780
@bharatviswa504 may I ask you to review this?
This is an automated message from the Apache Git Service.
12 matches
Mail list logo
