elek commented on a change in pull request #1107:
URL: https://github.com/apache/hadoop-ozone/pull/1107#discussion_r447545366



##########
File path: 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/XceiverServerSpi.java
##########
@@ -83,4 +85,12 @@ default void removeGroup(HddsProtos.PipelineID pipelineId)
    * @return list of report for each pipeline.
    */
   List<PipelineReport> getPipelineReport();
+
+  /**
+   * Get storage report for the XceiverServer instance.
+   * @return list of report for each storage location.
+   */
+  default List<MetadataStorageReportProto> getStorageReport() throws 
IOException {

Review comment:
       It seems to be a good time the remove XceiverServerSpi interface. 
Originally we had two separated implementation to connect to the datanode. 
Today we have only one. One interface is used between the client and the 
datanode, and the other one between datanode and ratis (datanode). As this 
example shows, the two interface shouldn't be the same.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org

Reply via email to