[GitHub] [hadoop-ozone] elek commented on a change in pull request #282: HDDS-2646. Start acceptance tests only if at least one THREE pipeline is available
elek commented on a change in pull request #282: HDDS-2646. Start acceptance tests only if at least one THREE pipeline is available URL: https://github.com/apache/hadoop-ozone/pull/282#discussion_r353151747 ## File path: hadoop-ozone/dist/src/main/compose/ozone/docker-config ## @@ -25,6 +25,7 @@ OZONE-SITE.XML_ozone.scm.client.address=scm OZONE-SITE.XML_ozone.replication=3 OZONE-SITE.XML_hdds.datanode.dir=/data/hdds OZONE-SITE.XML_hdds.profiler.endpoint.enabled=true +OZONE-SITE.XML_hdds.scm.safemode.min.datanode=3 Review comment: During an offline conversation I understood your use case: at some cases it can be useful to make the compose folder usable just with one datanode (eg. when ui / recon or shell scripts is tested). I pushed a new commit to experiment with your proposal. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #282: HDDS-2646. Start acceptance tests only if at least one THREE pipeline is available
elek commented on a change in pull request #282: HDDS-2646. Start acceptance tests only if at least one THREE pipeline is available URL: https://github.com/apache/hadoop-ozone/pull/282#discussion_r353124009 ## File path: hadoop-ozone/dist/src/main/compose/ozoneblockade/docker-config ## @@ -34,6 +34,8 @@ OZONE-SITE.XML_hdds.scm.wait.time.after.safemode.exit=30s OZONE-SITE.XML_hdds.scm.replication.thread.interval=6s OZONE-SITE.XML_hdds.scm.replication.event.timeout=10s OZONE-SITE.XML_dfs.ratis.server.failure.duration=35s +OZONE-SITE.XML_hdds.scm.safemode.min.datanode=3 Review comment: This is different because it's used by the python script from `hadoop-ozone/fault-injection-test/network-tests/src/test/blockade` which scales up the docker-compose cluster. In this case we need full cluster. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #282: HDDS-2646. Start acceptance tests only if at least one THREE pipeline is available
elek commented on a change in pull request #282: HDDS-2646. Start acceptance tests only if at least one THREE pipeline is available URL: https://github.com/apache/hadoop-ozone/pull/282#discussion_r353123517 ## File path: hadoop-ozone/dist/src/main/compose/ozone-mr/common-config ## @@ -22,6 +22,7 @@ OZONE-SITE.XML_ozone.scm.block.client.address=scm OZONE-SITE.XML_ozone.metadata.dirs=/data/metadata OZONE-SITE.XML_ozone.scm.client.address=scm OZONE-SITE.XML_ozone.replication=3 +OZONE-SITE.XML_hdds.scm.safemode.min.datanode=3 Review comment: `test.sh` calls `start_docker_env` from the `testlib.sh` which calls `docker-compose scale datanode=3`. Unfortunately there is no easy way to define the expected number of the containers in the `docker-compose.yaml`. ( There is a `deploy` / `replicas` but it's available only for docker swarm and not for docker-compose) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #282: HDDS-2646. Start acceptance tests only if at least one THREE pipeline is available
elek commented on a change in pull request #282: HDDS-2646. Start acceptance tests only if at least one THREE pipeline is available URL: https://github.com/apache/hadoop-ozone/pull/282#discussion_r352132216 ## File path: hadoop-ozone/dist/src/main/compose/ozone/docker-config ## @@ -25,6 +25,7 @@ OZONE-SITE.XML_ozone.scm.client.address=scm OZONE-SITE.XML_ozone.replication=3 OZONE-SITE.XML_hdds.datanode.dir=/data/hdds OZONE-SITE.XML_hdds.profiler.endpoint.enabled=true +OZONE-SITE.XML_hdds.scm.safemode.min.datanode=3 Review comment: Yes, this is the problem what I tried to describe in #238 I am fine with the suggested approach but it makes more complex the definition. What I am thinking is to create a `simple` compose definition which can work with one datanode (and we can adjust there the replication factor and the s3 storage type as well). Almost all the tested functionality requires datanode=3, it seems to be enough to have one cluster which can work with one datanode... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
