[GitHub] [hadoop-ozone] sodonnel commented on issue #719: HDDS-3270. Allow safemode listeners to be notified when some precheck rules pass

2020-04-07 Thread GitBox
sodonnel commented on issue #719: HDDS-3270. Allow safemode listeners to be notified when some precheck rules pass URL: https://github.com/apache/hadoop-ozone/pull/719#issuecomment-610477803 @elek I believe @avijayanhwx is going to give this one a review later today. Once he is happy I bel

[GitHub] [hadoop-ozone] sodonnel commented on issue #719: HDDS-3270. Allow safemode listeners to be notified when some precheck rules pass

2020-04-07 Thread GitBox
sodonnel commented on issue #719: HDDS-3270. Allow safemode listeners to be notified when some precheck rules pass URL: https://github.com/apache/hadoop-ozone/pull/719#issuecomment-610227799 Note this still needs a binding +1 before it can be merged. ---

[GitHub] [hadoop-ozone] sodonnel commented on issue #719: HDDS-3270. Allow safemode listeners to be notified when some precheck rules pass

2020-04-07 Thread GitBox
sodonnel commented on issue #719: HDDS-3270. Allow safemode listeners to be notified when some precheck rules pass URL: https://github.com/apache/hadoop-ozone/pull/719#issuecomment-610212684 @elek Yes I agree we should go ahead with #745, but we should merge this one first as it is already

[GitHub] [hadoop-ozone] sodonnel commented on issue #719: HDDS-3270. Allow safemode listeners to be notified when some precheck rules pass

2020-03-31 Thread GitBox
sodonnel commented on issue #719: HDDS-3270. Allow safemode listeners to be notified when some precheck rules pass URL: https://github.com/apache/hadoop-ozone/pull/719#issuecomment-606514103 @fapifta Thanks for the review. I have taken on your suggested changes and also added some info rel

[GitHub] [hadoop-ozone] sodonnel commented on issue #719: HDDS-3270. Allow safemode listeners to be notified when some precheck rules pass

2020-03-25 Thread GitBox
sodonnel commented on issue #719: HDDS-3270. Allow safemode listeners to be notified when some precheck rules pass URL: https://github.com/apache/hadoop-ozone/pull/719#issuecomment-604029510 Getting intermitted unit test failure on: ``` [ERROR] Errors: [ERROR] TestDeadNodeHa