https://bugzilla.redhat.com/show_bug.cgi?id=1515053
--- Comment #11 from Elliott Sales de Andrade ---
(In reply to Ankur Sinha (FranciscoD) from comment #10)
> (In reply to Elliott Sales de Andrade from comment #9)
> > (In reply to Ankur Sinha (FranciscoD) from comment #8)
> > > -
https://bugzilla.redhat.com/show_bug.cgi?id=1645329
--- Comment #12 from Fedora Update System ---
python-fsleyes-widgets-0.7.0-3.fc28, python-fslpy-1.12.0-3.fc28 has been pushed
to the Fedora 28 stable repository. If problems still persist, please make note
of it in this bug report.
--
You
https://bugzilla.redhat.com/show_bug.cgi?id=1645661
--- Comment #11 from Fedora Update System ---
python-fsleyes-widgets-0.7.0-3.fc28, python-fslpy-1.12.0-3.fc28 has been pushed
to the Fedora 28 stable repository. If problems still persist, please make note
of it in this bug report.
--
You
https://bugzilla.redhat.com/show_bug.cgi?id=1290995
--- Comment #15 from Fedora Update System ---
python-visionegg-quest-1.1-2.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1631987
--- Comment #14 from Fedora Update System ---
python-deepdiff-3.3.0-3.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See
https://bugzilla.redhat.com/show_bug.cgi?id=1631987
Fedora Update System changed:
What|Removed |Added
Status|MODIFIED|ON_QA
--- Comment #13 from
https://bugzilla.redhat.com/show_bug.cgi?id=1645661
Fedora Update System changed:
What|Removed |Added
Status|ON_QA |CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1645329
Fedora Update System changed:
What|Removed |Added
Status|ON_QA |CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1280141
Bug 1280141 depends on bug 1290995, which changed state.
Bug 1290995 Summary: Review Request: python-visionegg-quest - QUEST algorithm
for finding threshold
https://bugzilla.redhat.com/show_bug.cgi?id=1290995
What|Removed
https://bugzilla.redhat.com/show_bug.cgi?id=1290995
Fedora Update System changed:
What|Removed |Added
Status|ON_QA |CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1645172
--- Comment #7 from Jaroslav Škarvada ---
(In reply to Ondrej Dubaj from comment #4)
> Bugs in spec file fixed, but must use %attr. Without it I cannot build rpm
> package.
It works for me without %attr by just using:
chmod 0755
https://bugzilla.redhat.com/show_bug.cgi?id=1645172
--- Comment #6 from Jaroslav Škarvada ---
Please just use:
%make_build
not '%make_build %{?_smp_mflags -j3}'
You can check what the macros finally expand to by using the 'rpm --eval
MACRO', e.g. on my system:
$ rpm --eval %make_build
https://bugzilla.redhat.com/show_bug.cgi?id=1645172
--- Comment #5 from Jaroslav Škarvada ---
(In reply to Ondrej Dubaj from comment #4)
> Bugs in spec file fixed, but must use %attr. Without it I cannot build rpm
> package.
>
> Spec URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1648728
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Blocks||1276941 (fedora-neuro)
https://bugzilla.redhat.com/show_bug.cgi?id=1648728
Bug ID: 1648728
Summary: Review Request: python-progressbar2 - A Progressbar
library to provide visual progress to long running
operations
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1646795
--- Comment #5 from Michael DePaulo ---
I thought that %doc & %license only copy files when you specify relative paths.
But these are absolute paths, it doesn't copy them, correct?
--
You are receiving this mail because:
You are on the CC
https://bugzilla.redhat.com/show_bug.cgi?id=1648709
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Blocks||1276941 (fedora-neuro)
https://bugzilla.redhat.com/show_bug.cgi?id=1648709
Bug ID: 1648709
Summary: Review Request: python-indexed_gzip - Fast random
access of gzip files in Python
Product: Fedora
Version: rawhide
Component: Package Review
https://bugzilla.redhat.com/show_bug.cgi?id=1534067
--- Comment #14 from Ankur Sinha (FranciscoD) ---
(In reply to Marcel Plch from comment #3)
> Note that I am not a packager yet and this is an informal review.
> -
Thanks for
https://bugzilla.redhat.com/show_bug.cgi?id=1534067
--- Comment #13 from Ankur Sinha (FranciscoD) ---
Thank you for the review, Athmane. SCM requested:
https://pagure.io/releng/fedora-scm-requests/issue/8802
--
You are receiving this mail because:
You are on the CC list for the bug.
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1646795
--- Comment #4 from Robert-André Mauchin ---
%doc copies file to /usr/share/doc/%{name}, %license to
/usr/share/licenses/%{name}
If you %doc or %license different files with the same name, they'll be copied
to /usr/share/doc/%{name} or
https://bugzilla.redhat.com/show_bug.cgi?id=1631987
--- Comment #11 from Fedora Update System ---
python-deepdiff-3.3.0-3.fc29 has been submitted as an update to Fedora 29.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-a892d5f0c8
--
You are receiving this mail because:
You are on the
https://bugzilla.redhat.com/show_bug.cgi?id=1631987
--- Comment #12 from Fedora Update System ---
python-deepdiff-3.3.0-3.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1ecea94ef5
--
You are receiving this mail because:
You are on the
https://bugzilla.redhat.com/show_bug.cgi?id=1646795
--- Comment #3 from Michael DePaulo ---
WRT the entire command by Robert-André Mauchin:
Overwriting them? I do not think we are. Are you saying that RPM installs them
twice? `rpm -qlp` & `rpm -ql` list them once.
I am open to the idea of
https://bugzilla.redhat.com/show_bug.cgi?id=1534067
Athmane Madjoudj changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1534067
--- Comment #12 from Athmane Madjoudj ---
(In reply to Marcel Plch from comment #3)
<...snip...>
> = SHOULD items =
>
> Generic:
> [!]: If the source package does not include license text(s) as a separate
> file from upstream,
https://bugzilla.redhat.com/show_bug.cgi?id=1631987
--- Comment #10 from Fedora Update System ---
python-deepdiff-3.3.0-3.fc29 has been submitted as an update to Fedora 29.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-a892d5f0c8
--
You are receiving this mail because:
You are on the
https://bugzilla.redhat.com/show_bug.cgi?id=1631987
Fedora Update System changed:
What|Removed |Added
Status|POST|MODIFIED
--- Comment #9 from
https://bugzilla.redhat.com/show_bug.cgi?id=1648595
--- Comment #4 from Manas Mangaonkar (Pac23) ---
(In reply to Robert-André Mauchin from comment #3)
> You're supposed to fill the [ ] of fedora-review.
>
> I don't understand what's wrong with the current description.
Noted!
Maybe a link
https://bugzilla.redhat.com/show_bug.cgi?id=1648584
--- Comment #3 from Manas Mangaonkar (Pac23) ---
(In reply to Robert-André Mauchin from comment #2)
> There's no typo, it should be golang-github-dgryski-bitstream, not
> golang-github-dgryski-go-bitstream
yes that's what i meant by the
https://bugzilla.redhat.com/show_bug.cgi?id=1648584
--- Comment #2 from Robert-André Mauchin ---
There's no typo, it should be golang-github-dgryski-bitstream, not
golang-github-dgryski-go-bitstream
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always
https://bugzilla.redhat.com/show_bug.cgi?id=1648595
--- Comment #3 from Robert-André Mauchin ---
You're supposed to fill the [ ] of fedora-review.
I don't understand what's wrong with the current description.
--
You are receiving this mail because:
You are on the CC list for the bug.
You
https://bugzilla.redhat.com/show_bug.cgi?id=1645764
--- Comment #5 from Till Hofmann ---
> Issues:
> ===
> - Upstream files are not properly licensed, most (if not all) files are
> missing
> license headers. This should at least be reported to upstream.
Have you contacted upstream about
https://bugzilla.redhat.com/show_bug.cgi?id=1509679
--- Comment #20 from Till Hofmann ---
Thank you again for your detailed comments!
As you suggested, I removed *.md5 and *.map files and I ditched the shebang
scriptlet -- I thought the mangler would eventually fail instead of fixing
https://bugzilla.redhat.com/show_bug.cgi?id=1645913
--- Comment #6 from Mukundan Ragavan ---
Rest of the review.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
https://bugzilla.redhat.com/show_bug.cgi?id=1645913
--- Comment #5 from Mukundan Ragavan ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation
https://bugzilla.redhat.com/show_bug.cgi?id=1648584
Manas Mangaonkar (Pac23) changed:
What|Removed |Added
CC||manasmangaon...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1534067
--- Comment #11 from Ankur Sinha (FranciscoD) ---
Great. Please post when you've done a full review (and make a note of it so
that we can show it to the sponsors). In the meantime, please check new
packages against rawhide, not a stable
https://bugzilla.redhat.com/show_bug.cgi?id=1534067
--- Comment #10 from Manas Mangaonkar (Pac23) ---
(In reply to Ankur Sinha (FranciscoD) from comment #8)
> (In reply to Manas Mangaonkar (Pac23) from comment #7)
> > I am not a official Packager yet,this is a unofficial review.
> >
https://bugzilla.redhat.com/show_bug.cgi?id=1534067
--- Comment #9 from Manas Mangaonkar (Pac23) ---
(In reply to Ankur Sinha (FranciscoD) from comment #8)
> (In reply to Manas Mangaonkar (Pac23) from comment #7)
> > I am not a official Packager yet,this is a unofficial review.
> >
https://bugzilla.redhat.com/show_bug.cgi?id=1509679
--- Comment #19 from Jan Pokorný ---
Hmm, just dropping *.md5 and *.map will save some 8 MB in -doc-devel
without any change in usability.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified
https://bugzilla.redhat.com/show_bug.cgi?id=1509679
--- Comment #18 from Jan Pokorný ---
> For the sake of completeness, I'd suggest:
>
> s#/usr/bin/${interpreter}#%{_bindir}/${interpreter}#
>
> but is not a blocker here (note that possibly python* dealing in the same
> location in the
https://bugzilla.redhat.com/show_bug.cgi?id=1546459
Luya Tshimbalanga changed:
What|Removed |Added
Depends On||1648629
--- Comment #8 from Luya
https://bugzilla.redhat.com/show_bug.cgi?id=1647803
MartinKG changed:
What|Removed |Added
Status|POST|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1648595
--- Comment #2 from Manas Mangaonkar (Pac23) ---
> Package builds fine,Please add a description in the readme or add a link to
> some sort of in detailed readme/man.
* in the spec file
--
You are receiving this mail because:
You are on
https://bugzilla.redhat.com/show_bug.cgi?id=1648595
Manas Mangaonkar (Pac23) changed:
What|Removed |Added
CC||manasmangaon...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1534067
--- Comment #8 from Ankur Sinha (FranciscoD) ---
(In reply to Manas Mangaonkar (Pac23) from comment #7)
> I am not a official Packager yet,this is a unofficial review.
> ---
>
47 matches
Mail list logo
