[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #32 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/andy-super-great-park -- You are receiving this mail because: You are on the CC list for the

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #31 from MartinKG --- @Jeremy many thanks for your assistance ! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 Jeremy Newton changed: What|Removed |Added Flags||fedora-review+

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #29 from MartinKG --- (In reply to Jeremy Newton from comment #28) > (In reply to MartinKG from comment #27) > > (In reply to Jeremy Newton from comment #26) > > > [!]: License field in the package spec file

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #28 from Jeremy Newton --- (In reply to MartinKG from comment #27) > (In reply to Jeremy Newton from comment #26) > > [!]: License field in the package spec file matches the actual license. > > Note:

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #27 from MartinKG --- (In reply to Jeremy Newton from comment #26) > Package Review > == > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > = MUST items = >

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #26 from Jeremy Newton --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated = MUST items = C/C++: [x]: Package does not contain kernel modules.

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 Bug 1176273 depends on bug 1398949, which changed state. Bug 1398949 Summary: Review Request: bear - Game engine and editors dedicated to creating great 2D games https://bugzilla.redhat.com/show_bug.cgi?id=1398949 What|Removed

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #25 from MartinKG --- new rpms: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/asgp.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/asgp-1.0.18-3.fc25.src.rpm %changelog * Fri Dec 23

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #24 from Jeremy Newton --- Just from a quick glance. Source1 shouldn't be necessary, please remove it. I have some additional comments, but I need to look into it further to give you better feedback. -- You

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #23 from MartinKG --- asgp runs now, new rpm packages: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/asgp.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/asgp-1.0.18-2.fc25.src.rpm

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #22 from MartinKG --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/asgp.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/asgp-1.0.18-2.fc25.src.rpm %changelog * Tue Dec 13 2016 Martin

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #21 from Jeremy Newton --- (In reply to MartinKG from comment #20) > I have only uploaded the spec file due my thin internet bandwidth. > Spec URL: >

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #20 from MartinKG --- I have only uploaded the spec file due my thin internet bandwidth. Spec URL: https://martinkg.fedorapeople.org/Review/asgp-1.0.18/test2/asgp.spec there's a problem with asgp/CMakeLists.txt

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #19 from Jeremy Newton --- I still get the claw error when building in mock. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #18 from MartinKG --- Spec URL: https://martinkg.fedorapeople.org/Review/asgp-1.0.18/test1/asgp.spec SRPM URL: https://martinkg.fedorapeople.org/Review/asgp-1.0.18/test1/asgp-1.0.18-1.fc25.src.rpm %changelog *

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #17 from Jeremy Newton --- (In reply to Jeremy Newton from comment #16) > (In reply to MartinKG from comment #15) > for bear, where longhash is the bear git commit hash: >

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #16 from Jeremy Newton --- (In reply to MartinKG from comment #15) > @Jeremy, > Now I have managed to build a running asgp, but with a bundled bear-engine > package. Can you have a look at it. > > Spec URL: >

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #15 from MartinKG --- @Jeremy, Now I have managed to build a running asgp, but with a bundled bear-engine package. Can you have a look at it. Spec URL:

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 MartinKG changed: What|Removed |Added Depends On||1398949 --- Comment

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #13 from Jeremy Newton --- Actually, it looks like the "bear engine" (https://github.com/j-jorge/bear) is being bundled with plee-the-bear. I'm not 100% familiar with the code, but it looks like it should

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #12 from Jeremy Newton --- Ok, so I've looked into it. Looks like the maintainer for plee the bear has moved the library files to %{_libdir}/plee-the-bear, so you'll have to add the following to cmake:

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #11 from Jeremy Newton --- (In reply to MartinKG from comment #10) > I still testing asgp to compile, but it fails with this error message: > > [ 96%] Linking CXX shared library ../../../bin/librp.so > cd

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #10 from MartinKG --- I still testing asgp to compile, but it fails with this error message: [ 96%] Linking CXX shared library ../../../bin/librp.so cd /home/martin/rpmbuild/BUILD/asgp-1.0.16/asgp/lib/src/rp &&

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #9 from Jeremy Newton --- More notes: Please make use of the make macros as well: make %{?_smp_mflags} -> %make_build make install DESTDIR=%{buildroot} INSTALL="install -p" -> %make_install As well, please

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 Jeremy Newton changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #7 from MartinKG --- (In reply to Jeremy Newton from comment #6) > > Any status on this? Are you still interested in packaging this? > I can review this if you're interested in a review swap. ok lets us swap

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 Jeremy Newton changed: What|Removed |Added CC|

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 Ben Rosser changed: What|Removed |Added Blocks||1364745

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #5 from MartinKG mgans...@alice.de --- (In reply to Raphael Groner from comment #3) * SHOULD what is Plee the Bear? How is it related to this package? You won't be able to create two individual subpackges for that 'bear' and

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added CC||volke...@gmx.at

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #2 from Volker Fröhlich volke...@gmx.at --- Please make the build verbose and make Source0 a URL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 Raphael Groner projects...@smart.ms changed: What|Removed |Added CC|

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #4 from MartinKG mgans...@alice.de --- Hi Raphael, thanks for your reply, (In reply to Raphael Groner from comment #3) Hi Martin, there are some hints for your spec file. Maybe I can do the official review as well. *