[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED CC|

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #30 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pysword -- You are receiving this mail because: You are on the CC list for the

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #28 from TR Bentley --- https://trb143.fedorapeople.org/python-pysword-0.2.5-1.fc27.src.rpm https://trb143.fedorapeople.org/python-pysword.spec Next attempt. -- You are receiving this mail because: You are

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #27 from Robert-André Mauchin --- -n %{srcname}-%{version} indicates the directory to change to before -b 1 extract the second sources, thus it needs to be the same as the previous directory in order to be

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #26 from TR Bentley --- %autosetup -N -T -D -b 1 -n %{srcname}-%{version} This is correct as this tar.gz only contains the test files which Koji is unable to download. These are not version controlled. If

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #25 from Robert-André Mauchin --- You need to add commit to the second autosetup, otherwise it won't extract to the right directory: %autosetup -n %{srcname}-%{version}-%{commit} %autosetup -N -T -D -b 1 -n

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #24 from TR Bentley --- Ah got it now, I think https://trb143.fedorapeople.org/python-pysword-0.2.5-1.fc27.src.rpm https://trb143.fedorapeople.org/python-pysword.spec I build the tar from git clone, not

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #23 from Robert-André Mauchin --- When I download https://gitlab.com/tgc-dk/%{srcname}/repository/archive.tar.gz?ref=%{version}#/%{srcname}-%{version}.tar.gz, the root folder of the archive I get is named

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #22 from TR Bentley --- https://trb143.fedorapeople.org/python-pysword-0.2.5-1.fc27.src.rpm https://trb143.fedorapeople.org/python-pysword.spec Rebuilt from scratch using fedpkg. Unable to find any

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #21 from Robert-André Mauchin --- You didn't fix this: - Build error: + cd pysword-0.2.5 BUILDSTDERR: /var/tmp/rpm-tmp.if9CI4: line 40: cd: pysword-0.2.5: No such file or directory Seems the directory in

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #20 from TR Bentley --- https://trb143.fedorapeople.org/python-pysword-0.2.5-1.fc27.src.rpm https://trb143.fedorapeople.org/python-pysword.spec Tried to fix the issues identified above. Not sure the test

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #18 from TR Bentley --- https://trb143.fedorapeople.org/python-pysword-0.2.4-1.fc27.src.rpm https://trb143.fedorapeople.org/python-pysword.spec Should have fixed the desc issue. -- You are receiving this

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #17 from Robert-André Mauchin --- %description -n python3-%{srcname} %{desc} desc must be defined beforehand, otherwise this macro is empty. For example, in the header you define it: %global desc %{expand: A

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #16 from TR Bentley --- Revised based on the previous comments. https://trb143.fedorapeople.org/python-pysword-0.2.4-1.fc27.src.rpm https://trb143.fedorapeople.org/python-pysword.spec Thanks for the

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #15 from Robert-André Mauchin --- (In reply to TR Bentley from comment #13) > I only want a python3 version. > Do you have an example of a spec file as I am very confused as this is based > on other packages I

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 Itamar Reis Peixoto changed: What|Removed |Added CC|

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #13 from TR Bentley --- I only want a python3 version. Do you have an example of a spec file as I am very confused as this is based on other packages I have found. -- You are receiving this mail because:

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #12 from Robert-André Mauchin --- You should provide Python 2 and Python 3 versions. If you only provide Python 3 you should still make a Python 3 subpackage to the main one. -- You are receiving this mail

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #11 from TR Bentley --- https://trb143.fedorapeople.org/python-pysword.spec https://trb143.fedorapeople.org/python-pysword-0.2.4-1.fc27.src.rpm New 0.2.4 release -- You are receiving this mail because:

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #10 from TR Bentley --- https://trb143.fedorapeople.org/python-pysword-0.2.3-1.fc27.src.rpm https://trb143.fedorapeople.org/python-pysword.spec Sorry wrong files uploaded. -- You are receiving this mail

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #9 from Robert-André Mauchin --- %{__python3} setup.py build → %py3_build %{__python3} setup.py install --skip-build -O1 --root %{buildroot} → %py3_install Also you should provide packages for both python2 and

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #8 from TR Bentley --- Another set of updates https://trb143.fedorapeople.org/python-pysword.spec https://trb143.fedorapeople.org/python-pysword-0.2.3-0.fc25.src.rpm -- You are receiving this mail

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 Robert-André Mauchin changed: What|Removed |Added CC|

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 kaiwang changed: What|Removed |Added CC||kaiw...@redhat.com ---

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #5 from TR Bentley --- Update files as per review comments a uploaded a revised version. https://trb143.fedorapeople.org/python-pysword-0.2.3-0.fc25.src.rpm

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 Filip Szymański changed: What|Removed |Added CC|

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #3 from TR Bentley --- Looking at the packaging again I can see errors. The inital question is the upstream package is called pysword and that is how it is built. Should I package it as pysword or

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 --- Comment #2 from Zbigniew Jędrzejewski-Szmek --- Drop %gittag0, just specify the version in Version. You have python-pysword (the main src package), and python3-pysword (the only binary package). So there should be just

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

https://bugzilla.redhat.com/show_bug.cgi?id=1328248 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Summary|Review Request: |Review