[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Mattia Verga changed: What|Removed |Added Status|POST|NEW Assignee|ho...@redhat.com

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Scott Breyer changed: What|Removed |Added Flags|needinfo?(scott.j.breyer@in | |tel.com)

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #30 from Honggang LI --- Hi, Scott https://pagure.io/releng/fedora-scm-requests/issue/11429 You are a packager now. If nobody re-open this ticket when you back to work on this. Please submit a new request. BTW, we will be

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Honggang LI changed: What|Removed |Added Status|ASSIGNED|POST --- Comment #29 from Honggang LI

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Honggang LI changed: What|Removed |Added Flags||needinfo?(scott.j.breyer@in

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #28 from Honggang LI --- Hi, Scott Please see https://fedoraproject.org/wiki/Package_Review_Process for next step. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Honggang LI changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #27 from Honggang LI --- Fedora review result of spec and tarball, which had been upload to http://people.redhat.com/honli/opa-fm-10.9.1.1-1-review/ NOTE: The fedora-review tool of fedora-rawhide distro always failed. So, I run

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #26 from Honggang LI --- (In reply to Scott Breyer from comment #23) > Created attachment 1555632 [details] > Updated spec file cat -n opa-fm.spec 1 # BEGIN_ICS_COPYRIGHT8 2

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #25 from Honggang LI --- (In reply to Scott Breyer from comment #22) > Having trouble getting fedpkg to work, probably a kerberos or proxy issue. > > I looked at your log and see another missing dependency, uploading a new > spec

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Scott Breyer changed: What|Removed |Added Attachment|0 |1 #1555305 is|

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Scott Breyer changed: What|Removed |Added Attachment|0 |1 #1555304 is|

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Scott Breyer changed: What|Removed |Added Flags|needinfo?(scott.j.breyer@in | |tel.com)

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Honggang LI changed: What|Removed |Added Flags||needinfo?(scott.j.breyer@in

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Scott Breyer changed: What|Removed |Added Attachment|0 |1 #1554626 is|

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Scott Breyer changed: What|Removed |Added Attachment|0 |1 #1554625 is|

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Honggang LI changed: What|Removed |Added Flags||needinfo?(scott.j.breyer@in

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #17 from Scott Breyer --- Created attachment 1554626 --> https://bugzilla.redhat.com/attachment.cgi?id=1554626=edit Source package to address Fedora issues -- You are receiving this mail because: You are on the CC list for the

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #16 from Scott Breyer --- Created attachment 1554625 --> https://bugzilla.redhat.com/attachment.cgi?id=1554625=edit Spec file to address Fedora issues -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Honggang LI changed: What|Removed |Added Assignee|mschm...@redhat.com |ho...@redhat.com --- Comment #15 from

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #14 from Scott Breyer --- New tag/sha has been pushed to v10_3_1-spec-rework temporary branch of 01org/opa-fm for your review: tag v10.3.1.0.7-pre : d8485ef -- You are receiving this mail because: You

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 John Fleck changed: What|Removed |Added Fixed In Version|anton.bod...@intel.com | -- You are

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 John Fleck changed: What|Removed |Added Fixed In Version|

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #13 from Honggang LI --- opa-fm require /var/usr/lib/opa-fm/ to run, oap-fm must create and own this directory. === %install mkdir -p %{buildroot}/%{_localstatedir}/usr/lib/opa-fm/ ... %file

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #12 from Honggang LI --- Please consider to fix these issues: 1) opafm.service is executable. The opafm.service file was installed by copy opa-fm/Esm/ib/src/linux/startup/opafm.service, which is executable in

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #11 from Scott Breyer --- New tag/sha has been pushed to v10_3_1 branch of 01org/opa-fm: tag v10.3.1.0.6 : 4a98a65 -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #10 from Michal Schmidt --- Please do not test for the presence of systemctl at package install time (as in "if [ $(command -v systemctl) ]"). In fact I would recommend to drop the chkconfig branches entirely.

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #9 from Michal Schmidt --- (In reply to Scott Breyer from comment #7) When referring to the directory with systemd units the %_unitdir macro should be used.

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #8 from Scott Breyer --- We've made changes to our spec file that should be in line with what you are asking. The patch is presently making its way through our internal review and test process. -- You

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #7 from Scott Breyer --- Hello Michal, Regarding the guidelines for systemd, our subject matter expert is confident after review that we are in compliance with the Fedora Packaging Guidelines. Can you

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #6 from Scott Breyer --- Hi Michal, As stated in bug 1333531, we will work a solution as per your suggestion (for and install script) into an upcoming release. Thank you for your help, and again,

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #5 from Michal Schmidt --- Same as opa-ff (bug 1333531), I believe opa-fm would benefit from having a separate install script instead of having the install logic only in the spec file. For opa-fm, the Fedora

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #4 from Erik E. Kahn --- Spec file and SRPM updated to address more issues identified in review of sibling package opa-ff (bug 1333531): Spec URL:

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Erik E. Kahn changed: What|Removed |Added CC||erik.k...@intel.com

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #2 from Michal Schmidt --- Many of the issues I pointed out in opa-ff in https://bugzilla.redhat.com/show_bug.cgi?id=1333531#c3 apply to opa-fm as well. In addition to those, opa-fm has the following issues:

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 --- Comment #1 from Michal Schmidt --- Hi Scott, the spec file needs significant changes to satisfy the Fedora packaging guidelines. For reference, here's opa-fm.spec from RHEL 7.2:

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Michal Schmidt changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager

https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Honggang LI changed: What|Removed |Added CC||ddut...@redhat.com,