[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 Germano Massullo changed: What|Removed |Added Status|NEW |CLOSED

[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 Fabio Alessandro Locati changed: What|Removed |Added Assignee|f...@redhat.com

[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 Fabio Alessandro Locati changed: What|Removed |Added Flags|

[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 Germano Massullo changed: What|Removed |Added Flags|

[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 --- Comment #14 from Fabio Alessandro Locati --- ok, then use it, because ATM you are adding it to the package but you are not using it -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 --- Comment #13 from Germano Massullo --- (In reply to Fabio Alessandro Locati from comment #11) > SOURCE1 is not used anywhere. It should be used somewhere or removed it is still required in lastest em-proxy

[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 --- Comment #12 from Vít Ondruch --- BTW it would be also good idea to execute some test suite, if that is available ... -- You are receiving this mail because: You are on the CC list for the bug. You are always

[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 --- Comment #11 from Fabio Alessandro Locati --- SOURCE1 is not used anywhere. It should be used somewhere or removed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 Germano Massullo changed: What|Removed |Added Flags|needinfo?(germano.massullo@ |

[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 Vít Ondruch changed: What|Removed |Added CC||vondr...@redhat.com

[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 Fabio Alessandro Locati changed: What|Removed |Added CC|

[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 --- Comment #7 from Francesco Frassinelli (frafra) --- I would suggest to avoid env for Fedora packages for two reasons: 1. Fedora wiki suggests to use #!/usr/bin/ruby and #!/usr/bin/python 2. You don't want to get

[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 --- Comment #6 from Germano Massullo --- (In reply to Fabio Alessandro Locati from comment #5) > @Germano: You _should_ probably rebase this package on 0.1.9 I know but I am waiting for Francesco Frassinelli

[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 --- Comment #5 from Fabio Alessandro Locati --- @Germano: You _should_ probably rebase this package on 0.1.9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes

[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 --- Comment #4 from Germano Massullo --- Personal reminder: LICENSE file included in rubygem version 0.1.9 https://github.com/igrigorik/em-proxy/issues/56 -- You are receiving this mail because: You are on the CC

[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 --- Comment #3 from Fabio Alessandro Locati --- @Germano: The result for both is the same, so I would say that it does not really matter. If upstream uses `env ruby` is ok. That phrase compares using ruby vs ruby-mri/jruby

[Bug 1348160] Review Request: rubygem-em-proxy - EventMachine Proxy DSL

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 Igor Gnatenko changed: What|Removed |Added Summary|Review Request: |Review Request:

[Bug 1348160] Review Request: rubygem-em-proxy

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 --- Comment #2 from Germano Massullo --- Should I patch also other Shebangs in source code, as written in Ruby guidelines? https://fedoraproject.org/wiki/Packaging:Ruby#Shebang_lines Example: #!/usr/bin/ruby

[Bug 1348160] Review Request: rubygem-em-proxy

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 --- Comment #1 from Fabio Alessandro Locati --- Things to fix/improve: - Include the LICENSE file in the package - Exclude the .rspec folder from the rpm package - Fix script-without-shebang

[Bug 1348160] Review Request: rubygem-em-proxy

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 Fabio Alessandro Locati changed: What|Removed |Added CC|

[Bug 1348160] Review Request: rubygem-em-proxy

https://bugzilla.redhat.com/show_bug.cgi?id=1348160 Germano Massullo changed: What|Removed |Added Blocks||1348005