[Bug 1394250] Review Request: python-async_timeout - asyncio-compatible timeout context manager

2016-11-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394250 --- Comment #7 from Athmane Madjoudj --- Thanks for the feedback, update below. SPEC: https://athmane.fedorapeople.org/pkgs/python-async-timeout.spec SRPM:

[Bug 1394250] Review Request: python-async_timeout - asyncio-compatible timeout context manager

2016-11-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394250 --- Comment #6 from Igor Gnatenko --- * I would prefer to name it `python-async-timeout`. * Missing BR: pythonX-setuptools * %{python3_sitelib}/async_timeout-*%{python3_version}.egg-info ->

[Bug 1394250] Review Request: python-async_timeout - asyncio-compatible timeout context manager

2016-11-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394250 --- Comment #5 from Zbigniew Jędrzejewski-Szmek --- "_" was commonly used, but nowadays "-" is preferred. There's no strict rule, but if you e.g. look at python packages it's pretty clear: F24 has 3597 'python*' packages,

[Bug 1394250] Review Request: python-async_timeout - asyncio-compatible timeout context manager

2016-11-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394250 --- Comment #4 from Athmane Madjoudj --- Thanks alot for reviewing, please find below the update. Wrt underscore, IMHO it's only forbidden if it's a separator, in our case it's part of the name, we have python modules and

[Bug 1394250] Review Request: python-async_timeout - asyncio-compatible timeout context manager

2016-11-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394250 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|NEW

[Bug 1394250] Review Request: python-async_timeout - asyncio-compatible timeout context manager

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394250 Athmane Madjoudj changed: What|Removed |Added Blocks||1381750

[Bug 1394250] Review Request: python-async_timeout - asyncio-compatible timeout context manager

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394250 Athmane Madjoudj changed: What|Removed |Added Blocks||1391287

[Bug 1394250] Review Request: python-async_timeout - asyncio-compatible timeout context manager

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394250 --- Comment #2 from Athmane Madjoudj --- Sorry, copy-paste typo: Spec URL: https://athmane.fedorapeople.org/pkgs/python-async_timeout.spec SRPM URL:

[Bug 1394250] Review Request: python-async_timeout - asyncio-compatible timeout context manager

2016-11-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1394250 --- Comment #1 from Athmane Madjoudj --- rpmlint: $ rpmlint SPECS/python-async_timeout.spec SRPMS/python-async_timeout-1.1.0-1.fc25.src.rpm RPMS/noarch/python3-async_timeout-1.1.0-1.fc25.noarch.rpm