[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=1394576 Fedora Update System changed: What|Removed |Added Status|ON_QA

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=1394576 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=1394576 --- Comment #10 from Fedora Update System --- golang-github-PuerkitoBio-purell-1.1.0-5.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4ebaa73819 -- You are

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=1394576 Fedora Update System changed: What|Removed |Added Status|NEW

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=1394576 Bug 1394576 depends on bug 1206883, which changed state. Bug 1206883 Summary: Review Request: golang-github-PuerkitoBio-urlesc - Package urlesc implements query escaping as per RFC 3986. https://bugzilla.redhat.com/show_bug.cgi?id=1206883

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=1394576 --- Comment #9 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-PuerkitoBio-purell -- You are receiving this mail because: You are on the CC list

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=1394576 --- Comment #8 from Athos Ribeiro --- OK! I will do that before building it. Thank you for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=1394576 --- Comment #7 from Fabio Valentini --- One additional nitpick, not a blocker but "nice to have": Please include the %commit and %shortcommit definitions produced by gofed (according to the used git tag) in the ".spec

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=1394576 Fabio Valentini changed: What|Removed |Added Flags|fedora-review? |fedora-review+

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=1394576 --- Comment #5 from Athos Ribeiro --- 1) Fixed 2 and 3 were changes from another version which I forgot to remove. Both are fixed now 4) Fixed Spec URL:

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=1394576 --- Comment #4 from Fabio Valentini --- Initial comments: 1) You can remove the empty %if-%endif block in the -unit-test-devel package section (at lines 77-80). 2) You are simply disabling one of the tests - have you

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=1394576 Fabio Valentini changed: What|Removed |Added CC|

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=1394576 Athos Ribeiro changed: What|Removed |Added Summary|Review Request: |Review