[Bug 1476434] Review Request: bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 Mattia Verga changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks|

[Bug 1476434] Review Request: bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 Mattia Verga changed: What|Removed |Added CC||mattia.ve...@protonmail.com

[Bug 1476434] Review Request: bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com

[Bug 1476434] Review Request: bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 --- Comment #17 from Ye Cheng <18969068...@163.com> --- (In reply to Michael Schwendt from comment #16) Thanks. SONAME changed to libbstr.so.1()(64bit) libbstrc++.so.1()(64bit) libbstrsafe.so.1()(64bit) New spec

[Bug 1476434] Review Request: bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 --- Comment #16 from Michael Schwendt --- > libbstrsafe.so.1.0.0 -> libbstrsafe.so.1.0.0 That is evidence of a wrong and highly problematic SONAME. Let's see: eu-readelf -d libbstrsafe.so.1.0.0 |grep SONAME SONAME

[Bug 1476434] Review Request: bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 --- Comment #15 from Ye Cheng <18969068...@163.com> --- (In reply to Michael Schwendt from comment #14) Thanks. New srpm

[Bug 1476434] Review Request: bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 --- Comment #14 from Michael Schwendt --- > %install > ... > make clean Superfluous and potentially dangerous to clean the build results during %install. > cd ${RPM_BUILD_ROOT}%{_libdir} > ln -sf libbstr.so.%{version}

[Bug 1476434] Review Request: bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added CC|

[Bug 1476434] Review Request: bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 Michael Schwendt changed: What|Removed |Added CC|

[Bug 1476434] Review Request: bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 Jason Tibbitts changed: What|Removed |Added CC||ti...@math.uh.edu

[Bug 1476434] Review Request: bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 --- Comment #10 from Ye Cheng <18969068...@163.com> --- I added pkg-config file, so it could be easier for user to link the file. This should be in devel file list, I will fix this in the next build.

[Bug 1476434] Review Request: bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 Robin Lee changed: What|Removed |Added Summary|Review Request: Bstrlib - |Review Request:

[Bug 1476434] Review Request: Bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 Robin Lee changed: What|Removed |Added Flags|fedora-review? |fedora-review+

[Bug 1476434] Review Request: Bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 --- Comment #8 from Ye Cheng <18969068...@163.com> --- (In reply to Robin Lee from comment #7) Thank you very much for the review. New spec

[Bug 1476434] Review Request: Bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 --- Comment #7 from Robin Lee --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does

[Bug 1476434] Review Request: Bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 Robin Lee changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 1476434] Review Request: Bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 --- Comment #6 from Ye Cheng <18969068...@163.com> --- (In reply to Ye Cheng from comment #0) Sorry, yet another build to make it honour %__global_ldflags Spec URL:

[Bug 1476434] Review Request: Bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 --- Comment #5 from Ye Cheng <18969068...@163.com> --- (In reply to Ye Cheng from comment #0) Spec URL: https://copr-be.cloud.fedoraproject.org/results/yecheng/bstrlib/fedora-rawhide-i386/00585360-bstrlib/bstrlib.spec SRPM URL:

[Bug 1476434] Review Request: Bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 --- Comment #4 from Ye Cheng <18969068...@163.com> --- (In reply to Ye Cheng from comment #0) Sorry for changing URLs again Spec URL:

[Bug 1476434] Review Request: Bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 --- Comment #3 from Ye Cheng <18969068...@163.com> --- (In reply to Ye Cheng from comment #0) Sorry for the inconvenience of switching URLs > Spec URL: No longer valid New Spec URL:

[Bug 1476434] Review Request: Bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 --- Comment #2 from Ye Cheng <18969068...@163.com> --- (In reply to Iwicki Artur from comment #1) > >Release: 0%{?dist} > The Release: tag should start at 1. Fixed as Release: 1%{?dist} in release tag nd changelog > The Group: tag should not

[Bug 1476434] Review Request: Bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 Iwicki Artur changed: What|Removed |Added CC||fed...@svgames.pl

[Bug 1476434] Review Request: Bstrlib - Better String Library

https://bugzilla.redhat.com/show_bug.cgi?id=1476434 Ye Cheng <18969068...@163.com> changed: What|Removed |Added CC||18969068...@163.com