https://bugzilla.redhat.com/show_bug.cgi?id=1712280
Elliott Sales de Andrade changed:
What|Removed |Added
Blocks||177841 (FE-NEEDSPONSOR)
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
Brian (bex) Exelbierd changed:
What|Removed |Added
Status|POST|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #22 from Brian (bex) Exelbierd ---
Built for rawhide https://koji.fedoraproject.org/koji/taskinfo?taskID=35736960
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #21 from Igor Gnatenko ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-hanwen-fuse
--
You are receiving this mail because:
You are on the CC list for the bug.
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #20 from Brian (bex) Exelbierd ---
It seems that I would use it, per
https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_package_metadata
as I only need the devel sub-packages.
WDYT?
--
You are receiving this
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
Elliott Sales de Andrade changed:
What|Removed |Added
Status|ASSIGNED|POST
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #18 from Brian (bex) Exelbierd ---
The use of the %go versions seems to be what the templates now call for ...
does this need to be changed for rawhide?
I've uploaded a new SRPM and spec file.
Spec URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #17 from Elliott Sales de Andrade ---
I'm not sure you need to use the %godevel* versions instead of %go*.
Also, it doesn't appear that you've uploaded new copies of the spec/srpm or
used it in the scratch build.
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #16 from Brian (bex) Exelbierd ---
updated :) https://koji.fedoraproject.org/koji/taskinfo?taskID=35499038
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #15 from Elliott Sales de Andrade ---
You'll need to set those globals earlier to have any effect (not sure exactly
how much earlier, but go2rpm would place them before Name:).
--
You are receiving this mail because:
You are on
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #14 from Brian (bex) Exelbierd ---
I've made changes and run a new scratch build
(https://koji.fedoraproject.org/koji/taskinfo?taskID=35486883)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #13 from Elliott Sales de Andrade ---
Set these
%global golicenses LICENSE
%global godocs README.md
to replace the commented out %files bits and remove extra %license.
I think the rest should work out, though I have not tried
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #12 from Brian (bex) Exelbierd ---
I've now read through the new docs from eclipseo and the email on devel list
and tried this all again in Rawhide. I had to disable all tests as they
require fuse.
Updated:
Spec URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #11 from Elliott Sales de Andrade ---
The new golist (which doesn't crash) and go-compilers should be available in
Rawhide now, so if you run a scratch build, it will fail. You might not get
this with mock though, as I think the
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #10 from Brian (bex) Exelbierd ---
Thanks for the reference.
So I have updated the spec and src rpm, however, it didn't seem to need me to
turn off tests.
Here is a scratch build:
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #9 from Elliott Sales de Andrade ---
You can tell %gochecks to skip files or directories:
https://fedoraproject.org/wiki/More_Go_packaging#Excluding_testing_in_specific_directories
If _all_ tests requires fuse, then switch the
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #8 from Brian (bex) Exelbierd ---
I have had a chance to return to this. There seems to be several ways to skip
the tests, none of which feels right. Your advice is appreciated.
Option 1: Delete the fuse/test subdirectory to
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #7 from Elliott Sales de Andrade ---
It's because this package has a Go.mod and that causes golist to crash and not
run any tests. You can grab a working version from bug 1714090 and test with
that.
--
You are receiving this
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #6 from Brian (bex) Exelbierd ---
I've run koji scratch builds and local builds and the tests don't seem to be
executing. Can you help me see the log where you see them?
--
You are receiving this mail because:
You are on the CC
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #5 from Elliott Sales de Andrade ---
Adding just fuse BRs doesn't work unfortunately, as tests require the fuse
module to be loaded. I don't think you'll ever be able to get that on a koji
builder, so you'll need to disable them
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #4 from Brian (bex) Exelbierd ---
I've uploaded updated files.
I've put it back to making a -devel package. I think I have it, however I am
concerned by not having a %build section. Another reviewer on a different
package seems
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #3 from Elliott Sales de Andrade ---
You've simplified a bit too much; the name of the package must still be
%{goname} with a %{goname}-devel subpackage.
--
You are receiving this mail because:
You are on the CC list for the
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
--- Comment #2 from Brian (bex) Exelbierd ---
Thank you for the feedback - your comments pointed me to read the autogenerated
spec a bit differently. I've updated the files with a new spec that just
generates a -devel package. There really
https://bugzilla.redhat.com/show_bug.cgi?id=1712280
Elliott Sales de Andrade changed:
What|Removed |Added
Status|NEW |ASSIGNED
24 matches
Mail list logo
