[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

2020-08-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 --- Comment #16 from Fedora Update System --- FEDORA-2020-ec0c72eb82 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are

[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

2020-08-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|---

[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

2020-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 --- Comment #14 from Fedora Update System --- FEDORA-2020-ec0c72eb82 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install

[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

2020-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from

[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

2020-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 --- Comment #12 from Fedora Update System --- FEDORA-2020-ec0c72eb82 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-ec0c72eb82 -- You are receiving this mail because: You are on the CC

[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

2020-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #11 from

[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

2020-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/wshowkeys -- You are receiving this mail because: You are on the CC list for the bug. You are always notified

[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

2020-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 --- Comment #9 from Bob Hepple --- All good then - I'll go ahead and request the repo. Thanks again! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and

[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

2020-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 --- Comment #8 from Qiyu Yan --- No need to include the patch, since rpmlint is complaining about this call: setuid(0) != -1 this is just a check and actually won't lead to any security problems. So no need to include the patch, present

[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

2020-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 --- Comment #7 from Bob Hepple --- I'm an idiot! I forgot to re-apply the patch to the spec file in my rush to get out the door. This version silences rpmlint: if (setgid(getgid()) != 0) { fprintf(stderr, "devmgr:

[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

2020-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 Qiyu Yan changed: What|Removed |Added Status|NEW |POST Flags|

[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

2020-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 --- Comment #5 from Bob Hepple --- Cool - that stopped the compiler error. This is now the code: if (setgid(getgid()) != 0) { fprintf(stderr, "devmgr: setgid: %s\n", strerror(errno)); return 1;

[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

2020-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 --- Comment #4 from Qiyu Yan --- (In reply to Bob Hepple from comment #3) > Thanks for the review! > > From the upstream homepage: "wshowkeys must be configured as setuid during > installation. It requires root permissions to read input

[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

2020-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 --- Comment #3 from Bob Hepple --- Thanks for the review! From the upstream homepage: "wshowkeys must be configured as setuid during installation. It requires root permissions to read input events. These permissions are dropped after

[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

2020-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 --- Comment #2 from Qiyu Yan --- Since /usr/bin/wshowkeys has setuid flag, things are getting diffficult (otherwise this will be a security risk) What you should do (I think) is - Suggest: Check if the setuid is needed - Must: set %global

[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

2020-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1860729 Bob Hepple changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment