Product: Fedora
Version: rawhide
Component: Package Review
Package Review has canceled Package
Review 's request for ruki
's needinfo:
Bug 1882871: Review Request: xmake - A cross-platform build utility based on
Lua
https://bugzilla.redhat.com/show_bug.cgi?id=1882871
--- Comment #12 from
https://bugzilla.redhat.com/show_bug.cgi?id=1882871
--- Comment #10 from Robert-André Mauchin ---
- You need to set debug=y to generate the debuginfo. Not sure how you're
supposed to do it properly.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1882871
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
---
https://bugzilla.redhat.com/show_bug.cgi?id=1882871
--- Comment #8 from ruki ---
(In reply to Sheng Mao from comment #7)
> Hi ruki, according to review guidelines [1]:
>
> > MUST: rpmlint must be run on the source rpm and all binary rpms the build
> > produces. The output should be posted in
https://bugzilla.redhat.com/show_bug.cgi?id=1882871
Sheng Mao changed:
What|Removed |Added
CC||shng...@gmail.com
--- Comment #7 from
https://bugzilla.redhat.com/show_bug.cgi?id=1882871
--- Comment #6 from ruki ---
I have completely fixed all the problems, can you help me review this spec
file?
https://github.com/xmake-io/xmake/blob/dev/scripts/rpmbuild/SPECS/xmake.spec
--
You are receiving this mail because:
You are on
https://bugzilla.redhat.com/show_bug.cgi?id=1882871
--- Comment #5 from ruki ---
> When I add it, it will cause the xmake program to crash on the fedora i386
> platform.
I have fixed this problem.
But on opensuse-leap-15.1-*, %set_build_flags still causes some problems.
+ %set_build_flags
https://bugzilla.redhat.com/show_bug.cgi?id=1882871
--- Comment #4 from Artur Frenszek-Iwicki ---
>>1. You need to call the %set_build_flags macro to ensure that Fedora's
>>CXXFLAGS are set properly.
>Is this necessary? I saw that many other rpm packages do not add this. for
>example:
https://bugzilla.redhat.com/show_bug.cgi?id=1882871
--- Comment #3 from ruki ---
I have fixed it. The new spec url:
https://github.com/xmake-io/xmake/blob/spec/scripts/rpmbuild/SPECS/xmake.spec
> 1. You need to call the %set_build_flags macro to ensure that Fedora's
> CXXFLAGS are set
https://bugzilla.redhat.com/show_bug.cgi?id=1882871
Artur Frenszek-Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
https://bugzilla.redhat.com/show_bug.cgi?id=1882871
--- Comment #1 from Fabian Affolter ---
*** Bug 1882872 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and
11 matches
Mail list logo
