[Bug 2272499] Review Request: sqlfluff - Modular SQL linter and auto-formatter

2024-04-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2272499 --- Comment #14 from Arthur Bols --- - Update to 3.0.4 - Added `%bcond_without check` to optionally skip tests as they take 8 mins to run. - Added CHANGELOG.md to %doc Spec URL: https://principis.fedorapeople.org/sqlfluff.spec SRPM URL: https

[Bug 2272499] Review Request: sqlfluff - Modular SQL linter and auto-formatter

2024-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2272499 --- Comment #13 from Arthur Bols --- Thanks for the heads-up. I don't know a better solution, so I'll deal with it when it becomes a problem. :) Thank you for your help. Felix, is there anything else I need to change? Btw, if any of you want

[Bug 2272499] Review Request: sqlfluff - Modular SQL linter and auto-formatter

2024-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2272499 --- Comment #12 from Miro Hrončok --- Note that %py3_build is deprecated as it invoked setup.py build which is deprecated upstream -- but it is unlikely to be removed soon. -- You are receiving this mail because: You are always notified abo

[Bug 2272499] Review Request: sqlfluff - Modular SQL linter and auto-formatter

2024-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2272499 --- Comment #11 from Arthur Bols --- (In reply to Miro Hrončok from comment #10) > > since I couldn't get it to work. > > You should be able to install it to /tmp (e.g. via --root) and use > PYTHONPATH again. Using pip didn't really feel cor

[Bug 2272499] Review Request: sqlfluff - Modular SQL linter and auto-formatter

2024-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2272499 --- Comment #10 from Miro Hrončok --- > Is this safe/allowed? Yes. > since I couldn't get it to work. You should be able to install it to /tmp (e.g. via --root) and use PYTHONPATH again. -- You are receiving this mail because: You are on

[Bug 2272499] Review Request: sqlfluff - Modular SQL linter and auto-formatter

2024-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2272499 --- Comment #9 from Arthur Bols --- Thanks for you help! > Anyway, do you know how much it needs sqlfluff to be installed? Can you point > PYTHONPATH to the build directory, like this? It needs sqlfluff to generate the rules for the documen

[Bug 2272499] Review Request: sqlfluff - Modular SQL linter and auto-formatter

2024-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2272499 --- Comment #8 from Miro Hrončok --- Side note 2: %{python3} -m pip install plugins/sqlfluff-plugin-example --no-deps --no-index --no-warn-script-location This installs the package to the home directory of whoever builds the package. As su

[Bug 2272499] Review Request: sqlfluff - Modular SQL linter and auto-formatter

2024-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2272499 --- Comment #7 from Miro Hrončok --- Side note: %description %_description %py_provides python3-%{name} This puts the Provides lines to the %description. The Provides need to be before %description starts, or else they end up as text i

[Bug 2272499] Review Request: sqlfluff - Modular SQL linter and auto-formatter

2024-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2272499 Miro Hrončok changed: What|Removed |Added Flags|needinfo?(mhroncok@redhat.c | |om)

[Bug 2272499] Review Request: sqlfluff - Modular SQL linter and auto-formatter

2024-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2272499 Felix Wang changed: What|Removed |Added Flags||needinfo?(mhroncok@redhat.c

[Bug 2272499] Review Request: sqlfluff - Modular SQL linter and auto-formatter

2024-04-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2272499 Arthur Bols changed: What|Removed |Added Blocks||2272749 --- Comment #4 from Arthur Bols

[Bug 2272499] Review Request: sqlfluff - Modular SQL linter and auto-formatter

2024-04-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2272499 --- Comment #3 from Arthur Bols --- Thanks for the review! I forgot to mention, I can't build the documentation because it depends on sqlfluff itself... I'm not sure if it's worth the hassle to create a separate -doc source package. Do you ha

[Bug 2272499] Review Request: sqlfluff - Modular SQL linter and auto-formatter

2024-04-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2272499 --- Comment #2 from Felix Wang --- > %package -n python3-%{name} > Summary:%{summary} > > %description -n python3-%{name} %_description It may be replaced by %py_provides python3-sqlfluff. https://docs.fedoraproject.org/en-US/packagi

[Bug 2272499] Review Request: sqlfluff - Modular SQL linter and auto-formatter

2024-04-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2272499 Felix Wang changed: What|Removed |Added Assignee|nob...@fedoraproject.org|topa...@outlook.com CC|