https://bugzilla.redhat.com/show_bug.cgi?id=1476458
--- Comment #2 from Otavio R. Piske ---
Thanks for your review Iwicki.
I have modified all the items you have pointed. Here's some updated links:
Latest COPR build for reference:
https://bugzilla.redhat.com/show_bug.cgi?id=1476085
--- Comment #8 from Michael Cullen ---
I'm guessing you mean
Spec URL: https://jjames.fedorapeople.org/libsemigroups/libsemigroups.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1476014
--- Comment #6 from Michael Cullen ---
> BuildRequires: gzip isn't necessary.
I included it for completeness, and there doesn't seem to really be an explicit
exceptions list now, however since it's practically
https://bugzilla.redhat.com/show_bug.cgi?id=1476085
--- Comment #9 from Michael Cullen ---
Ok, nearly there. A couple of things about that doc subpackage though.
One of the review checklist items is:
* License file installed when any subpackage combination is
https://bugzilla.redhat.com/show_bug.cgi?id=1476458
--- Comment #4 from Otavio R. Piske ---
Thanks for the explanation.
I renamed the package to -doc.
Here's the latest Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=20900568. The link to the
spec
https://bugzilla.redhat.com/show_bug.cgi?id=1476560
Bug ID: 1476560
Summary: Review Request: deepin-desktop-schemas - GSettings
deepin desktop-wide schemas
Product: Fedora
Version: rawhide
Component: Package Review
https://bugzilla.redhat.com/show_bug.cgi?id=1476584
Bug ID: 1476584
Summary: Review Request: deepin-session-ui - Deepin
desktop-environment Session UI module
Product: Fedora
Version: rawhide
Component: Package Review
https://bugzilla.redhat.com/show_bug.cgi?id=1476565
Bug ID: 1476565
Summary: Review Request: deepin-dbus-factory - Golang and QML
DBus factory for DDE
Product: Fedora
Version: rawhide
Component: Package Review
https://bugzilla.redhat.com/show_bug.cgi?id=1120788
--- Comment #16 from Robin Lee ---
> install -d $RPM_BUILD_ROOT%{_datadir}/doc/%{name}/
> install -p ChangeLog CONTRIBUTORS README
> $RPM_BUILD_ROOT%{_datadir}/doc/%{name}/
Theses two lines are not necessary, since
https://bugzilla.redhat.com/show_bug.cgi?id=1476481
--- Comment #4 from Fedora Update System ---
perl-AWS-Signature4-1.02-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ac10151d8e
--
You are receiving this
https://bugzilla.redhat.com/show_bug.cgi?id=1476458
--- Comment #5 from Iwicki Artur ---
Sorry for not pointing this out earlier, but I just consulted the Licensing
Guidelines:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Valid_License_Short_Names
>The
https://bugzilla.redhat.com/show_bug.cgi?id=1476085
--- Comment #10 from Robert-André Mauchin ---
(In reply to Jerry James from comment #6)
> (In reply to Robert-André Mauchin from comment #4)
> > No problem with me. I'm just helping around while hoping for a sponsor.
>
>
https://bugzilla.redhat.com/show_bug.cgi?id=1476458
--- Comment #3 from Iwicki Artur ---
In general, it's best if the docs can be installed without having to pull in
any parts of their parent package.
>Files marked as documentation must not cause the package to pull in more
https://bugzilla.redhat.com/show_bug.cgi?id=1120788
--- Comment #15 from Dominic Hopf ---
The -5 release adds the dependency to perl-AWS-Signature4:
Spec URL: https://dmaphy.fedorapeople.org/Rex/Rex.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1476564
Bug ID: 1476564
Summary: Review Request: deepin-dbus-generator - Convert dbus
interfaces to go-lang or qml wrapper code
Product: Fedora
Version: rawhide
Component: Package
https://bugzilla.redhat.com/show_bug.cgi?id=1476481
Fedora Update System changed:
What|Removed |Added
Status|ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1476558
Bug ID: 1476558
Summary: Review Request: deepin-desktop-base - Base component
for Deepin
Product: Fedora
Version: rawhide
Component: Package Review
Assignee:
https://bugzilla.redhat.com/show_bug.cgi?id=1476573
Bug ID: 1476573
Summary: Review Request: deepin-mutter - Base window manager
for deepin, fork of gnome mutter
Product: Fedora
Version: rawhide
Component: Package Review
https://bugzilla.redhat.com/show_bug.cgi?id=1476583
Bug ID: 1476583
Summary: Review Request: startdde - Starter of deepin desktop
environment
Product: Fedora
Version: rawhide
Component: Package Review
Assignee:
https://bugzilla.redhat.com/show_bug.cgi?id=1476440
--- Comment #8 from Gwyn Ciesla ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/gimp-luminosity-masks
--
You are receiving this mail because:
You are on the CC list for the
https://bugzilla.redhat.com/show_bug.cgi?id=1268742
--- Comment #5 from Roman Joost ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is
https://bugzilla.redhat.com/show_bug.cgi?id=1268742
--- Comment #6 from Roman Joost ---
Diff against the old review:
--- ../1268742-rubygem-bacon-colored_output_old/review.txt 2017-07-28
09:46:15.738517634 +1000
+++ review.txt 2017-07-31 10:37:06.139563839 +1000
@@
https://bugzilla.redhat.com/show_bug.cgi?id=1268742
Roman Joost changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
---
https://bugzilla.redhat.com/show_bug.cgi?id=1432993
srakitnican changed:
What|Removed |Added
Flags|needinfo?(samuel.rakitnican |
https://bugzilla.redhat.com/show_bug.cgi?id=1465885
Bug 1465885 depends on bug 1465884, which changed state.
Bug 1465884 Summary: Review Request: golang-github-cznic-lex - Support for
(f)lex-like tool on .l source files
https://bugzilla.redhat.com/show_bug.cgi?id=1465884
What
https://bugzilla.redhat.com/show_bug.cgi?id=1465884
Fedora Update System changed:
What|Removed |Added
Status|ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=1468768
Fedora Update System changed:
What|Removed |Added
Status|ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=1428202
Bug 1428202 depends on bug 1429090, which changed state.
Bug 1429090 Summary: ecryptfs-simple does not work without proper root
environment (su -l)
https://bugzilla.redhat.com/show_bug.cgi?id=1429090
What|Removed
https://bugzilla.redhat.com/show_bug.cgi?id=1432993
--- Comment #4 from srakitnican ---
I have spotted few things myself that I intend to fix them for the next package
release.
- BuildRequires: gcc
- Try to use macros for make_build and make_install
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1469331
Fedora Update System changed:
What|Removed |Added
Status|MODIFIED|ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=1432993
Iwicki Artur changed:
What|Removed |Added
CC||fed...@svgames.pl
https://bugzilla.redhat.com/show_bug.cgi?id=1432993
Iwicki Artur changed:
What|Removed |Added
Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1465588
--- Comment #12 from Fedora Update System ---
xoreos-tools-0.0.4-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1467322
--- Comment #21 from Fedora Update System ---
manifest-tool-0.6.0-4.gita28af2b.el7 has been pushed to the Fedora EPEL 7
stable repository. If problems still persist, please make note of it in this
bug report.
--
https://bugzilla.redhat.com/show_bug.cgi?id=1476590
Bug ID: 1476590
Summary: Review Request: deepin-daemon - Daemon handling the
DDE session settings
Product: Fedora
Version: rawhide
Component: Package Review
https://bugzilla.redhat.com/show_bug.cgi?id=1476595
Bug ID: 1476595
Summary: Review Request: dtkcore - Deepin tool kit core modules
Product: Fedora
Version: rawhide
Component: Package Review
Assignee: nob...@fedoraproject.org
https://bugzilla.redhat.com/show_bug.cgi?id=1476438
--- Comment #3 from Robert-André Mauchin ---
This looks fine to me. Now you need someone to officially approve it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1476489
Robert-André Mauchin changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1471806
Robert-André Mauchin changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1432993
Randy Barlow changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1476589
Bug ID: 1476589
Summary: Review Request: deepin-api - Go-lang bingding for
dde-daemon
Product: Fedora
Version: rawhide
Component: Package Review
Assignee:
https://bugzilla.redhat.com/show_bug.cgi?id=1476438
--- Comment #2 from Jake Hunsaker ---
(In reply to Robert-André Mauchin from comment #1)
> Hello,
>
> A few points:
> - since you are the developer, a LICENSE file would be nice ofr it to be
> included in the package.
https://bugzilla.redhat.com/show_bug.cgi?id=1476438
Robert-André Mauchin changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1476608
Bug ID: 1476608
Summary: Review Request: ubridge - Bridge for UDP tunnels,
Ethernet, TAP and VMnet interfaces
Product: Fedora
Version: rawhide
Component: Package Review
https://bugzilla.redhat.com/show_bug.cgi?id=1476596
Bug ID: 1476596
Summary: Review Request: dtkwidget - Deepin tool kit widget
modules
Product: Fedora
Version: rawhide
Component: Package Review
Assignee:
https://bugzilla.redhat.com/show_bug.cgi?id=1476608
--- Comment #1 from Athmane Madjoudj ---
NB. This is required by new GNS3.
Rpmlint output:
./SPECS/ubridge.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
./SRPMS/ubridge-0.9.12-1.fc26.src.rpm
1 packages
https://bugzilla.redhat.com/show_bug.cgi?id=1469331
--- Comment #31 from Fedora Update System ---
fedrepo-req-0.3.0-1.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See
https://bugzilla.redhat.com/show_bug.cgi?id=1476014
Jerry James changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1476085
--- Comment #13 from Michael Cullen ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
= MUST items =
https://bugzilla.redhat.com/show_bug.cgi?id=1476085
Michael Cullen changed:
What|Removed |Added
Flags|fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1469331
--- Comment #32 from Fedora Update System ---
fedrepo-req-0.3.0-1.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See
https://bugzilla.redhat.com/show_bug.cgi?id=1476481
Fedora Update System changed:
What|Removed |Added
Status|MODIFIED|ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=1469331
--- Comment #33 from Fedora Update System ---
fedrepo-req-0.3.0-1.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See
https://bugzilla.redhat.com/show_bug.cgi?id=1476481
--- Comment #6 from Fedora Update System ---
perl-AWS-Signature4-1.02-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See
https://bugzilla.redhat.com/show_bug.cgi?id=1476085
--- Comment #12 from Jerry James ---
(In reply to Robert-André Mauchin from comment #10)
> I haven't.
I encourage you to do so. That is a great way to start making connections in
the Fedora community.
> I have made a
https://bugzilla.redhat.com/show_bug.cgi?id=1476085
--- Comment #11 from Jerry James ---
Good heavens. What was that remark you made about not thinking clearly? :-)
Okay, I added the license to the -doc subpackage, and also made -doc be noarch.
These are the actual
56 matches
Mail list logo