[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215



--- Comment #18 from Milan Bouchet-Valat  ---
I've just orphaned llvm3.7 on F28 and rawhide since builds have started to fail
and ghc no longer uses it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553082] New: Review Request: R-webutils - Utility Functions for Developing Web Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553082

Bug ID: 1553082
   Summary: Review Request: R-webutils - Utility Functions for
Developing Web Applications
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: quantum.anal...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: https://qulogic.fedorapeople.org//R-webutils.spec
SRPM URL: https://qulogic.fedorapeople.org//R-webutils-0.6-1.fc27.src.rpm

Description:
High performance in-memory http request parser for application/json,
multipart/form-data, and application/x-www-form-urlencoded. Includes live
demo of hosting and parsing multipart forms with either 'httpuv' or

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #15 from Germano Massullo  ---
Because on 64bit systems the package tries to install files under
/usr/lib/...
instead of
/usr/lib64/...
This can happen only for noarch packages, and this is not a noarch package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548405] Review Request: python-gsd - Read and write hoomd schema gsd files with an easy to use syntax

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548405



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-gsd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553199] Review Request: nodejs-sliced - A faster alternative to [] .slice.call(arguments)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553199

Tom Hughes  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548405] Review Request: python-gsd - Read and write hoomd schema gsd files with an easy to use syntax

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548405

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-03-08 08:57:41



--- Comment #3 from Dominik 'Rathann' Mierzejewski  ---
Imported and build for rawhide for now. Thanks a lot for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553015] Review Request: R-disposables - Create Disposable R Packages for Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553015

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
Package approved


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package have the default element marked as %%doc :DESCRIPTION


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 13 files have unknown license. Detailed
 output of licensecheck in

/home/bob/packaging/review/R-disposables/review-R-disposables/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

R:
[x]: Package contains the mandatory BuildRequires.
[x]: The package has the standard %install section.
[x]: Package requires R-core.

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires 

[Bug 1553049] Review Request: R-gdtools - Utilities for Graphical Rendering

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553049

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
 - Remove this empty file:

R-gdtools-devel.x86_64: E: zero-length
/usr/lib64/R/library/gdtools/include/gdtools_types.cpp


Package otherwise approved. Fix the above error before import.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package have the default element marked as %%doc :DESCRIPTION, NEWS
- Package requires R-core.


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 46 files have unknown license. Detailed
 output of licensecheck in
 /home/bob/packaging/review/R-gdtools/review-R-gdtools/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

R:
[x]: Package contains the mandatory BuildRequires.
[x]: The package has the standard %install section.

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a 

[Bug 1553199] Review Request: nodejs-sliced - A faster alternative to [] .slice.call(arguments)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553199



--- Comment #1 from Tom Hughes  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=25558891

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553199] New: Review Request: nodejs-sliced - A faster alternative to [].slice.call(arguments)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553199

Bug ID: 1553199
   Summary: Review Request: nodejs-sliced - A faster alternative
to [].slice.call(arguments)
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: t...@compton.nu
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://tomh.fedorapeople.org//nodejs-sliced.spec
SRPM URL: http://tomh.fedorapeople.org//nodejs-sliced-1.0.1-1.fc27.src.rpm

Description:
A faster alternative to [].slice.call(arguments).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1189171] Review Request: python-antlr - Python runtime support for ANTLR-generated parsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1189171



--- Comment #21 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-antlr

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552033] Review Request: python-pycryptodomex - A self-contained cryptographic library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552033



--- Comment #16 from Fedora Update System  ---
python-pycryptodomex-3.5.0-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-702bf2655b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552033] Review Request: python-pycryptodomex - A self-contained cryptographic library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552033



--- Comment #17 from Fedora Update System  ---
python-pycryptodomex-3.5.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5dcf74cc38

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215



--- Comment #19 from Jens Petersen  ---
Okay, f27 ghc uses llvm3.7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553053] Review Request: R-fastmatch - Fast match() function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553053

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package have the default element marked as %%doc :DESCRIPTION, NEWS
- Package requires R-core.


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2)", "Unknown or generated". 14 files have unknown
 license. Detailed output of licensecheck in
 /home/bob/packaging/review/R-fastmatch/review-R-fastmatch/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

R:
[x]: Package contains the mandatory BuildRequires.
[x]: The package has the standard %install section.

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package 

[Bug 1553054] Review Request: R-bit - A class for vectors of 1-bit booleans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553054

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #2 from Robert-André Mauchin  ---
 - Fix the line encoding and encoding for these files:

R-bit.x86_64: W: wrong-file-end-of-line-encoding
/usr/lib64/R/library/bit/ANNOUNCEMENT-1.0.txt
R-bit.x86_64: W: file-not-utf8 /usr/lib64/R/library/bit/ANNOUNCEMENT-1.0.txt
R-bit.x86_64: W: wrong-file-end-of-line-encoding
/usr/lib64/R/library/bit/README_devel.txt
R-bit.x86_64: E: wrong-script-end-of-line-encoding
/usr/lib64/R/library/bit/exec/prebuild.sh



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package have the default element marked as %%doc :DESCRIPTION, NEWS
- Package requires R-core.


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 50 files have unknown license. Detailed
 output of licensecheck in
 /home/bob/packaging/review/R-bit/review-R-bit/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
 Note: Macros in: R-bit (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

[Bug 1552988] Review Request: rust-ucd-util - for working with the Unicode character database

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552988

Josh Stone  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-03-08 13:09:49



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551913] Review Request: php-pecl-psr - PSR interfaces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551913



--- Comment #11 from Fedora Update System  ---
php-pecl-psr-0.4.0-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-830a4f8613

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552883] Review Request: python-jinja2-time - Jinja2 Extension for Dates and Times

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552883



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-jinja2-time

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552881] Review Request: python-poyo - A lightweight YAML Parser for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552881



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-poyo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548077] Review Request: libyami - Yet Another Media Infrastructure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548077

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 Blocks||1553377




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1553377
[Bug 1553377] Review Request: libyami-utils - Libyami Utilities
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553377] Review Request: libyami-utils - Libyami Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553377

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 Depends On||1548077




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1548077
[Bug 1548077] Review Request: libyami - Yet Another Media Infrastructure
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553377] New: Review Request: libyami-utils - Libyami Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553377

Bug ID: 1553377
   Summary: Review Request: libyami-utils - Libyami Utilities
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: kwiz...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://dl.kwizart.net/review/libyami-utils.spec
SRPM URL:
http://dl.kwizart.net/review/libyami-utils-1.3.0-1.git9b5a311.fc26.src.rpm
Description: Libyami Utilities
Fedora Account System Username: kwizart

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553391] New: Review Request: nodejs-okay - Bubble errors back up your big ol' nested callback chain

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553391

Bug ID: 1553391
   Summary: Review Request: nodejs-okay - Bubble errors back up
your big ol' nested callback chain
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: t...@compton.nu
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://tomh.fedorapeople.org//nodejs-okay.spec
SRPM URL: http://tomh.fedorapeople.org//nodejs-okay-1.0.0-1.fc27.src.rpm

Description:
Bubble errors back up your big ol' nested callback chain.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553391] Review Request: nodejs-okay - Bubble errors back up your big ol' nested callback chain

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553391



--- Comment #1 from Tom Hughes  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=25563209

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548077] Review Request: libyami - Yet Another Media Infrastructure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548077



--- Comment #5 from Nicolas Chauvet (kwizart)  ---
(In reply to Sergey Avseyev from comment #4)
> Why it does not use https://github.com/intel/libyami as URL?
Indeed, it was where the intel graphic team was previously using. I think the
redirection still works. Fixed locally.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424890



--- Comment #23 from Zbigniew Jędrzejewski-Szmek  ---
Can you post the updated spec and srpm?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552988] Review Request: rust-ucd-util - for working with the Unicode character database

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552988



--- Comment #3 from Josh Stone  ---
Oh, the license files actually are in the crate, I just forgot to add them to
"%files devel".  Will do.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552988] Review Request: rust-ucd-util - for working with the Unicode character database

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552988



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-ucd-util

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553391] Review Request: nodejs-okay - Bubble errors back up your big ol' nested callback chain

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553391

Tom Hughes  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548077] Review Request: libyami - Yet Another Media Infrastructure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548077



--- Comment #3 from Nicolas Chauvet (kwizart)  ---
Spec URL: http://dl.kwizart.net/review/libyami.spec
SRPM URL: http://dl.kwizart.net/review/libyami-1.3.0-2.git40fa32e.fc26.src.rpm

Changelog:
Switch to current git (fix FTBFS in rawhide)
Updated description
Enable more parsers
Enable make check (exept on 32bit and gcc8)

Scratch build succeeded in f29:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25561379
and up to f27 with tests:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25561371

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548077] Review Request: libyami - Yet Another Media Infrastructure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548077

Sergey Avseyev  changed:

   What|Removed |Added

 CC||sergey.avse...@gmail.com



--- Comment #4 from Sergey Avseyev  ---
Why it does not use https://github.com/intel/libyami as URL?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553447] New: Review Request: python-backoff - Python library providing function decorators for configurable backoff and retry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553447

Bug ID: 1553447
   Summary: Review Request: python-backoff - Python library
providing function decorators for configurable backoff
and retry
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rbar...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://bowlofeggs.fedorapeople.org/python-backoff.spec
SRPM URL:
https://bowlofeggs.fedorapeople.org/python-backoff-1.4.3-1.fc28.src.rpm
Description: This module provides function decorators which can be used to wrap
a function such that it will be retried until some condition is met. It is
meant to be of use when accessing unreliable resources with the potential for
intermittent failures i.e. network resources and external APIs. Somewhat more
generally, it may also be of use for dynamically polling resources for
externally generated content.
Fedora Account System Username: bowlofeggs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553054] Review Request: R-bit - A class for vectors of 1-bit booleans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553054

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Robert-André Mauchin  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553447] Review Request: python-backoff - Python library providing function decorators for configurable backoff and retry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553447



--- Comment #1 from Randy Barlow  ---
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25564879

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553049] Review Request: R-gdtools - Utilities for Graphical Rendering

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553049



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/R-gdtools

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542654] Review Request: quentier - Cross-platform desktop Evernote client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542654



--- Comment #2 from Jaroslav Škarvada  ---
(In reply to Matěj Týč from comment #1)
> gtk-update-icon-cache should be invoked in %postun and %posttrans
> 
This is another false positive, it's not required any more:
https://pagure.io/packaging-committee/issue/736

> Please change the versioning metadata so it is in sync with libquentier:
> 
> Version:0
> 
> to
> 
> Version:0.4
> 
> and
> 
> Release:1.%{commitdate}.git%{shortcommit}%{?dist}
> 
> to
> 
> Release:0.1.%{commitdate}.git%{shortcommit}%{?dist}
>
It depends what the upstream version currently is which is not clear, I found:
0.4.0 in: CMakeLists.txt, so if it's what upstream intended, the version tag
should be:
Version: 0.4.0

In https://github.com/d1vanov/quentier/releases it seems the 0.4.0 is still
pre-release, if it's what the upstream intended then the release tag should be:
Release: 0.1.%{commitdate}.git%{shortcommit}%{?dist}


Also I noticed, it seems it's bundling oxygen and tango themes icons, please
unbundle and use icons from the installed themes (which should be added as
dependency to the spec). I.e. regarding oxygen it generates qrc_oxygen.cpp from
the bundled icons, which is cca. 23 MB in size. It's compiled to cca. 4.5 MB
object file qrc_oxygen.cpp.o which is later linked to the final binary.
Similarly for the tango theme. If unbundled the final stripped binary needn't
have cca. 11 MB in size.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542654] Review Request: quentier - Cross-platform desktop Evernote client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542654



--- Comment #3 from Robert-André Mauchin  ---
Thanks both for your reviews. I'll see how I can unbundle the icons.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553082] Review Request: R-webutils - Utility Functions for Developing Web Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553082



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/R-webutils

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553054] Review Request: R-bit - A class for vectors of 1-bit booleans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553054



--- Comment #3 from Elliott Sales de Andrade  ---
Fixed.

Spec URL: https://qulogic.fedorapeople.org/R-bit.spec
SRPM URL: https://qulogic.fedorapeople.org/R-bit-1.1.12-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553015] Review Request: R-disposables - Create Disposable R Packages for Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553015



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/R-disposables

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553596] Review Request: rust-tokio-executor - Future execution primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553596

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1553597
   ||(rust-tokio-reactor)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1553597
[Bug 1553597] Review Request: rust-tokio-reactor - Event loop that drives
Tokio I/O resources
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553597] Review Request: rust-tokio-reactor - Event loop that drives Tokio I/O resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553597

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1553596
   ||(rust-tokio-executor)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1553596
[Bug 1553596] Review Request: rust-tokio-executor - Future execution
primitives
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553560] Review Request: R-pkgconfig - Private Configuration for 'R' Packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553560



--- Comment #1 from Elliott Sales de Andrade  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=25570581

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553601] New: Review Request: rust-tokio-threadpool - Task scheduler backed by a work-stealing thread pool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553601

Bug ID: 1553601
   Summary: Review Request: rust-tokio-threadpool - Task scheduler
backed by a work-stealing thread pool
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-threadpool.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-threadpool-0.1.0-1.fc29.src.rpm
Description:
Task scheduler backed by a work-stealing thread pool.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553601] Review Request: rust-tokio-threadpool - Task scheduler backed by a work-stealing thread pool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553601

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1553596
   ||(rust-tokio-executor)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1553596
[Bug 1553596] Review Request: rust-tokio-executor - Future execution
primitives
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553596] Review Request: rust-tokio-executor - Future execution primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553596

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1553601
   ||(rust-tokio-threadpool)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1553601
[Bug 1553601] Review Request: rust-tokio-threadpool - Task scheduler backed
by a work-stealing thread pool
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553560] New: Review Request: R-pkgconfig - Private Configuration for 'R' Packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553560

Bug ID: 1553560
   Summary: Review Request: R-pkgconfig - Private Configuration
for 'R' Packages
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: quantum.anal...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: https://qulogic.fedorapeople.org//R-pkgconfig.spec
SRPM URL: https://qulogic.fedorapeople.org//R-pkgconfig-2.0.1-1.fc27.src.rpm

Description:
Set configuration options on a per-package basis. Options set by a given
package only apply to that package, other packages are unaffected.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553596] New: Review Request: rust-tokio-executor - Future execution primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553596

Bug ID: 1553596
   Summary: Review Request: rust-tokio-executor - Future execution
primitives
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-executor.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-executor-0.1.0-1.fc29.src.rpm
Description:
Future execution primitives.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553597] New: Review Request: rust-tokio-reactor - Event loop that drives Tokio I/O resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553597

Bug ID: 1553597
   Summary: Review Request: rust-tokio-reactor - Event loop that
drives Tokio I/O resources
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-reactor.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-reactor-0.1.0-1.fc29.src.rpm
Description:
Event loop that drives Tokio I/O resources.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553053] Review Request: R-fastmatch - Fast match() function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553053



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/R-fastmatch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553610] New: Review Request: rust-http - Set of types for representing HTTP requests and responses

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553610

Bug ID: 1553610
   Summary: Review Request: rust-http - Set of types for
representing HTTP requests and responses
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-http.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-http-0.1.5-1.fc29.src.rpm
Description:
Set of types for representing HTTP requests and responses.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553601] Review Request: rust-tokio-threadpool - Task scheduler backed by a work-stealing thread pool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553601

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1553615 (rust-tokio)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1553615
[Bug 1553615] Review Request: rust-tokio - Platform for writing
asynchronous I/O backed applications
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553615] Review Request: rust-tokio - Platform for writing asynchronous I/O backed applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553615

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1553596
   ||(rust-tokio-executor),
   ||1553597
   ||(rust-tokio-reactor),
   ||1553601
   ||(rust-tokio-threadpool),
   ||1553610 (rust-http)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1553596
[Bug 1553596] Review Request: rust-tokio-executor - Future execution
primitives
https://bugzilla.redhat.com/show_bug.cgi?id=1553597
[Bug 1553597] Review Request: rust-tokio-reactor - Event loop that drives
Tokio I/O resources
https://bugzilla.redhat.com/show_bug.cgi?id=1553601
[Bug 1553601] Review Request: rust-tokio-threadpool - Task scheduler backed
by a work-stealing thread pool
https://bugzilla.redhat.com/show_bug.cgi?id=1553610
[Bug 1553610] Review Request: rust-http - Set of types for representing
HTTP requests and responses
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553615] New: Review Request: rust-tokio - Platform for writing asynchronous I/O backed applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553615

Bug ID: 1553615
   Summary: Review Request: rust-tokio - Platform for writing
asynchronous I/O backed applications
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-0.1.2-1.fc29.src.rpm
Description:
Platform for writing asynchronous I/O backed applications.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553597] Review Request: rust-tokio-reactor - Event loop that drives Tokio I/O resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553597

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1553615 (rust-tokio)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1553615
[Bug 1553615] Review Request: rust-tokio - Platform for writing
asynchronous I/O backed applications
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553610] Review Request: rust-http - Set of types for representing HTTP requests and responses

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553610

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1553615 (rust-tokio)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1553615
[Bug 1553615] Review Request: rust-tokio - Platform for writing
asynchronous I/O backed applications
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553596] Review Request: rust-tokio-executor - Future execution primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553596

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1553615 (rust-tokio)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1553615
[Bug 1553615] Review Request: rust-tokio - Platform for writing
asynchronous I/O backed applications
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553049] Review Request: R-gdtools - Utilities for Graphical Rendering

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553049

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553049] Review Request: R-gdtools - Utilities for Graphical Rendering

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553049



--- Comment #4 from Fedora Update System  ---
R-gdtools-0.1.7-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-15ad764a12

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553049] Review Request: R-gdtools - Utilities for Graphical Rendering

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553049



--- Comment #5 from Fedora Update System  ---
R-gdtools-0.1.7-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-804bd01758

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553054] Review Request: R-bit - A class for vectors of 1-bit booleans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553054



--- Comment #8 from Fedora Update System  ---
R-bit-1.1.12-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c8faeba623

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553015] Review Request: R-disposables - Create Disposable R Packages for Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553015

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553015] Review Request: R-disposables - Create Disposable R Packages for Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553015



--- Comment #5 from Fedora Update System  ---
R-disposables-1.0.3-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-4df249966b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553054] Review Request: R-bit - A class for vectors of 1-bit booleans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553054



--- Comment #7 from Fedora Update System  ---
R-bit-1.1.12-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-86ef05248e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553015] Review Request: R-disposables - Create Disposable R Packages for Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553015



--- Comment #4 from Fedora Update System  ---
R-disposables-1.0.3-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-9189340438

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552979] Review Request: sthttpd - Tiny http server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552979



--- Comment #7 from Dan Callaghan  ---
(In reply to Matt Tyson from comment #6)
> Where should I point this to? I'm only aware of the github page.  I have not
> been able to find an official tarball release.  Only a git repo tag.

There are some special guidelines for the case where upstream only publishes
git tags and no tarballs.

https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552979] Review Request: sthttpd - Tiny http server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552979



--- Comment #8 from Matt Tyson  ---
(In reply to Dan Callaghan from comment #7)
> (In reply to Matt Tyson from comment #6)
> > Where should I point this to? I'm only aware of the github page.  I have not
> > been able to find an official tarball release.  Only a git repo tag.
> 
> There are some special guidelines for the case where upstream only publishes
> git tags and no tarballs.
> 
> https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services

Ah, perfect.  Thanks!

Spec file has been updated.

https://github.com/blueness/sthttpd/archive/2845bf5bff2b820d2336c8c8061cbfc5f271e720/sthttpd-2845bf5.tar.gz

or

https://mtyson.fedorapeople.org/sthttpd-2845bf5.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553053] Review Request: R-fastmatch - Fast match() function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553053



--- Comment #6 from Fedora Update System  ---
R-fastmatch-1.1.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-b437e5cc05

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553053] Review Request: R-fastmatch - Fast match() function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553053



--- Comment #4 from Fedora Update System  ---
R-fastmatch-1.1.0-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6485910c93

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553053] Review Request: R-fastmatch - Fast match() function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553053

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553053] Review Request: R-fastmatch - Fast match() function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553053



--- Comment #5 from Fedora Update System  ---
R-fastmatch-1.1.0-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-601f3707b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553054] Review Request: R-bit - A class for vectors of 1-bit booleans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553054

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553049] Review Request: R-gdtools - Utilities for Graphical Rendering

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553049



--- Comment #6 from Fedora Update System  ---
R-gdtools-0.1.7-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-3304815863

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553054] Review Request: R-bit - A class for vectors of 1-bit booleans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553054



--- Comment #6 from Fedora Update System  ---
R-bit-1.1.12-2.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-4a613802ad

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553054] Review Request: R-bit - A class for vectors of 1-bit booleans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553054



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/R-bit

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553496] New: Review Request: libusbauth-configparser, usbauth, usbauth-notifier - USB Firewall including flex/bison parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553496

Bug ID: 1553496
   Summary: Review Request: libusbauth-configparser, usbauth,
usbauth-notifier - USB Firewall including flex/bison
parser
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: stefan.koc...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Fedora Account System Username: kochstefan

### libusbauth-configparser ###
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/kochstefan/usbauth-all/fedora-27-x86_64/00725929-libusbauth-configparser/libusbauth-configparser.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/kochstefan/usbauth-all/fedora-27-x86_64/00725929-libusbauth-configparser/libusbauth-configparser-1.0-0.src.rpm

Description: The library is used to read the usbauth config file into data
structures and is used by usbauth and YaST.

### usbauth ###

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/kochstefan/usbauth-all/fedora-27-x86_64/00725931-usbauth/usbauth.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/kochstefan/usbauth-all/fedora-27-x86_64/00725931-usbauth/usbauth-1.0-0.src.rpm

Description: It is a firewall against BadUSB attacks. A config file descibes in
which way USB interfaces would be accepted or denied.
To the kernel an interface authorization was developed with this firewall.
The firewall sets the authorization mask according to the rules.

### usbauth-notifier ###

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/kochstefan/usbauth-all/fedora-27-x86_64/00725932-usbauth-notifier/usbauth-notifier.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/kochstefan/usbauth-all/fedora-27-x86_64/00725932-usbauth-notifier/usbauth-notifier-1.0-0.src.rpm

Description: A notifier for the usbauth firewall against BadUSB attacks. The
user could manually allow or deny USB devices.
Every user that wants use the notifier must be added to the usbauth group.


Detailed Description:
Hi

I want to add the described packages to Fedora. I need a review and a sponsor
for packaging these packages.

The usbauth packages already part of openSUSE Tumbleweed, Debian Sid and Ubuntu
18.04 (pre).

This work was initially created for SUSE in 2015. Part of it was the USB
interface authorization for the Linux kernel. It's contained in Linux since
kernel version 4.4.
There are the following packages libusbauth-configparser, usbauth,
usbauth-notifier.

GIT Repository: https://github.com/kochstefan/usbauth-all.git

NOTICE aboud usbguard and usbauth:
The usbguard project provides an USB firewall, too. It is already packaged
within debian.
The usbguard development was supported by RedHat and usbauth was 
supported by SUSE. Historical, usbguard was published while the working 
on usbauth has already been started.
The main difference is that usbguard works with USB devices and usbauth works
with USB interfaces.

usbauth could allow/deny usb interfaces using the new usb interface 
authorization mechanism that is part of linux 4.4 and above.
See also: 
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/?h=v4.4.94=grep=interface+auth

Examples:
* allow a storage functionality of a USB device and deny USB Ethernet of 
the same device
* allow audio/video functionality of an USB TV card and deny using the 
remote control functionality
* allow USB printing/scanning and deny USB storage usage of a 
multifunction printer (BTW: the interface mechanism supports denying 
user space triggered actions (using USB claiming) like scanning)

usbguard could allow/deny USB devices using the usb device authorization 
mechanism of the Linux kernel.
It allows to denying a whole device if one interface of it is considered 
as bad (usbauth supports this, too)
usbguard allows creating actions that is not supported by usbauth.

If you can understand German language you could read 
a detailed description: 
https://epub.uni-bayreuth.de/3048/1/koch2017sicherheitsaspekte.pdf

Thank you

Stefan Koch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542654] Review Request: quentier - Cross-platform desktop Evernote client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542654



--- Comment #4 from Robert-André Mauchin  ---
 - Patch dropped: upstream fixed in latest release
 - Owned /usr/share/icons/hicolor/1024x1024/apps, and
/usr/share/icons/hicolor/1024x1024
 - Unbundling themes was trickier than expected because the author included
custom icons with the themes.

Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/6404822/quentier.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/quentier/fedora-rawhide-x86_64/00726001-quentier/quentier-0.4.0-0.1.20180301.git8226e31.fc29.src.rpm


Spec diff:
https://github.com/eclipseo/packaging/commit/640482229acd9cee571e32a25dab74f3fcc215f4#diff-596f9391ff108c3f099c150988abca56

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552979] Review Request: sthttpd - Tiny http server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552979



--- Comment #6 from Matt Tyson  ---
(In reply to Itamar Reis Peixoto from comment #4)
>
> the counterpart thttpd has been removed from Fedora because no one cared
> about it, I think this package will have the same future.

I'm a developer on Beaker ( https://beaker-project.org/ ) and thttpd is used as
part of our automated test suite on the Fedora build machines.  thttpd was
dropped from Fedora before I joined Beaker and it's now a bit of a pain point
in our automated provisioning system.

If there's any issues in this package I will be happy to address them.

> 
> if the intention is only to get in @fedora-packager fas group, I think
> filling a ticket here should be better, 
> 

That was not my intention.


(In reply to Zbigniew Jędrzejewski-Szmek from comment #5)
> Yeah, the sysusers macro shouldn't be used just yet.
> 
> Source0 should be a full URL.

Where should I point this to? I'm only aware of the github page.  I have not
been able to find an official tarball release.  Only a git repo tag.

> 
> Requires: systemd → %?systemd_requires
> [https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd]

Done

> 
> %setup -q + %patch0 -p1 → %autosetup -p1

Done

> 
> %{__perl} → perl [https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
> only suggests macros for directories, there is no reason to obfuscate
> executable names like that]

Changed to /usr/bin/perl

> 
> /var/run → /run [https://fedoraproject.org/wiki/Packaging:Guidelines#.2Frun]

Done

> 
> make %{?_smp_mflags} → %make_build
> 

Done

> You shouldn't use %{SOURCE1} in the scriptlets definitions, because it might
> be a full path. Use just the name of the service.
> %systemd_post %{SOURCE1} → %systemd_post thttpd.service

Done.

Thank you for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553496] Review Request: libusbauth-configparser, usbauth, usbauth-notifier - USB Firewall including flex/bison parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553496

Stefan Koch  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553015] Review Request: R-disposables - Create Disposable R Packages for Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553015



--- Comment #6 from Fedora Update System  ---
R-disposables-1.0.3-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-0c58b6a875

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542654] Review Request: quentier - Cross-platform desktop Evernote client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542654



--- Comment #1 from Matěj Týč  ---
The package is mostly fine, I have suggestions towards:

- the patch,
- versioning
- icon cache handling, and
- minor suggestion towards directory ownership.

The patch is not part of the upstream code, so please comment its usage.

gtk-update-icon-cache should be invoked in %postun and %posttrans

Please change the versioning metadata so it is in sync with libquentier:

Version:0

to

Version:0.4

and

Release:1.%{commitdate}.git%{shortcommit}%{?dist}

to

Release:0.1.%{commitdate}.git%{shortcommit}%{?dist}

Full output of fedora-review:

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- Header files in -devel subpackage, if present.
  Note: quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_AboutQuentierWidget.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_AddAccountDialog.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_AddOrEditNotebookDialog.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_AddOrEditSavedSearchDialog.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_AddOrEditTagDialog.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_EditNoteDialog.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_EnexExportDialog.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_EnexImportDialog.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_FindAndReplaceWidget.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_ListItemWidget.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_LogViewerWidget.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_MainWindow.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_ManageAccountsDialog.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_NewListItemLineEdit.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_NoteEditorWidget.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_NotebookModelItemInfoWidget.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_PreferencesDialog.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_SavedSearchModelItemInfoWidget.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_ShortcutSettingsWidget.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_TableSettingsDialog.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_TagModelItemInfoWidget.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/build/ui_WelcomeToQuentierDialog.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/src/AccountManager.h
  quentier-debugsource :
  /usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/src/ActionsInfo.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/src/AsyncFileWriter.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/src/BasicXMLSyntaxHighlighter.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/src/EditNoteDialogsManager.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/src/EnexExporter.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/src/EnexImporter.h
  quentier-debugsource :
  /usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/src/MainWindow.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/src/NetworkProxySettingsHelpers.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/src/NoteEditorTabsAndWindowsCoordinator.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/src/NoteFiltersManager.h
  quentier-debugsource :
 
/usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/src/SystemTrayIconManager.h
  quentier-debugsource :
  /usr/src/debug/quentier-0-1.20180128.git442947d.fc29.x86_64/src/color-
  picker-tool-button/ColorPickerActionWidget.h quentier-debugsource :
  

[Bug 1551913] Review Request: php-pecl-psr - PSR interfaces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551913



--- Comment #10 from Fedora Update System  ---
php-pecl-psr-0.4.0-2.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1949d5d62d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551306] Review Request: mingw-jsoncpp - JSON library implemented in C++ for MinGW

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551306



--- Comment #7 from Fedora Update System  ---
mingw-jsoncpp-1.8.4-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-a99653897d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552033] Review Request: python-pycryptodomex - A self-contained cryptographic library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552033



--- Comment #19 from Fedora Update System  ---
python-pycryptodomex-3.5.0-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-702bf2655b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551306] Review Request: mingw-jsoncpp - JSON library implemented in C++ for MinGW

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551306



--- Comment #8 from Fedora Update System  ---
mingw-jsoncpp-1.8.4-1.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-43bd84e331

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552033] Review Request: python-pycryptodomex - A self-contained cryptographic library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552033



--- Comment #20 from Fedora Update System  ---
python-pycryptodomex-3.5.0-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5dcf74cc38

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553082] Review Request: R-webutils - Utility Functions for Developing Web Applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553082

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package have the default element marked as %%doc :DESCRIPTION, NEWS
- Package requires R-core.


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 28 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/R-webutils/review-R-webutils/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

R:
[x]: Package contains the mandatory BuildRequires.
[x]: The package has the standard %install section.

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version 

[Bug 1553199] Review Request: nodejs-sliced - A faster alternative to [] .slice.call(arguments)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553199

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 9 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/nodejs-sliced/review-nodejs-
 sliced/licensecheck.txt
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/node_modules
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX 

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163



--- Comment #12 from Fedora Update System  ---
python-sphinx-click-1.0.4-1.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-7f3409174f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551791] Review Request: waylandpp - Wayland C++ bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551791



--- Comment #10 from Fedora Update System  ---
waylandpp-0.2.2-2.fc28 has been pushed to the Fedora 28 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-df618a6936

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551457] Review Request: R-mockery - Mocking Library for R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551457



--- Comment #9 from Fedora Update System  ---
R-mockery-0.4.1-1.fc28 has been pushed to the Fedora 28 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-29e118c7c8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551244] Review Request: golang-github-git-lfs-wildmatch - Pattern matching language for filepaths compatible with Git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551244



--- Comment #9 from Fedora Update System  ---
git-lfs-2.4.0-1.fc28,
golang-github-git-lfs-wildmatch-0-0.1.20180219git8a05186.fc28 has been pushed
to the Fedora 28 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-ff6d88ef10

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542651] Review Request: libquentier - Set of Qt/ C++ APIs for feature rich desktop clients for Evernote service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542651



--- Comment #10 from Fedora Update System  ---
libquentier-0.4.0-0.3.20180301git4ce8e3b.fc28 has been pushed to the Fedora 28
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-7d6da5abdd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551913] Review Request: php-pecl-psr - PSR interfaces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551913

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
php-pecl-psr-0.4.0-2.fc28 has been pushed to the Fedora 28 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-a4af82fbaf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551306] Review Request: mingw-jsoncpp - JSON library implemented in C++ for MinGW

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551306

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
mingw-jsoncpp-1.8.4-1.fc28 has been pushed to the Fedora 28 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f07774fdd9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552450] Review Request: php-samyoul-u2f-php-server - Server side handling class for FIDO U2F registration and authentication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552450



--- Comment #7 from Fedora Update System  ---
php-samyoul-u2f-php-server-1.1.3-1.fc28 has been pushed to the Fedora 28
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6c83c4a134

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551449] Review Request: R-lubridate - Make dealing with dates a little easier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551449



--- Comment #9 from Fedora Update System  ---
R-lubridate-1.7.3-2.fc28 has been pushed to the Fedora 28 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-29ddfd503c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1549686] Review Request: f28-backgrounds - Fedora 28 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1549686

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #13 from Fedora Update System  ---
desktop-backgrounds-28.0.0-1.fc28, f28-backgrounds-28.1.0-1.fc28 has been
pushed to the Fedora 28 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f86f6e9857

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552033] Review Request: python-pycryptodomex - A self-contained cryptographic library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552033

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #18 from Fedora Update System  ---
python-pycryptodomex-3.4.12-3.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f99f8d2fe3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org