[Bug 1562519] Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #3 from Robert-André Mauchin  ---
 - Add a BR to gcc-c++ See
https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B :

BuildRequires:gcc-c++

 - Define ldflags too:

export LDFLAGS="%{__global_ldflags}"

 - Use %make_install to install automatically in the buildroot:

%make_install ENABLE_MAN=yes PREFIX=%{_prefix}

 - Patch the Makefile to use "install -p" instead of "install" to keep
timestamps:

%prep
%autosetup
sed -i "s|^\tinstall -|\t\$(INSTALL) -|" Makefile

 - There's some MIT code too:

MIT/X11 (BSD like)
--
git-crypt-0.6.0/fhstream.cpp
git-crypt-0.6.0/fhstream.hpp
git-crypt-0.6.0/parse_options.cpp
git-crypt-0.6.0/parse_options.hpp

   Add it to the license field and add a commet explaining the license
breakdown.

 - Remove the INSTALL file from %doc:

git-crypt.x86_64: W: install-file-in-docs /usr/share/doc/git-crypt/INSTALL



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "GPL (v3 or later)", "Unknown or
 generated". 17 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/git-crypt/review-git-
 crypt/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source 

[Bug 1562474] Review Request: nodejs-conventional-changelog-core - The conventional-changelog core

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562474

Jared Smith  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #3 from Jared Smith  ---
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/5535.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562526] Review Request: libfullock - A Fast User Level LOCK (FULLOCK ) library for C and C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562526



--- Comment #1 from Hiro Wakabayashi  ---
Here is a link to a successful Copr build.
https://copr.fedorainfracloud.org/coprs/hiwkby/libfullock/build/735310/

Thanks in advance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562526] Review Request: libfullock - A Fast User Level LOCK (FULLOCK ) library for C and C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562526

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #3 from Iwicki Artur  ---
>Source0: %{name}-%{version}.tar.gz
Use the following: "%{URL}/archive/v%{version}/%{name}-%{version}.tar.gz"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1560823] Review Request: erlang-eimp - Erlang Image Manipulation Process

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1560823

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-03-31 20:45:03



--- Comment #9 from Fedora Update System  ---
erlang-eimp-1.0.2-1.fc28 has been pushed to the Fedora 28 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547733] Review Request: nodejs-conventional-recommended-bump - Get a recommended version bump based on conventional commits

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1547733

Jared Smith  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-03-31 16:58:57



--- Comment #9 from Jared Smith  ---
Packaged in Rawhide, closing this issue

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562526] Review Request: libfullock - A Fast User Level LOCK (FULLOCK ) library for C and C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562526

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #2 from Robert-André Mauchin  ---
Hello and welcome,


I can't sponsor, but a couple preliminary remarks:

 - %clean is rot needed

%clean
rm -rf %{buildroot}

 - %defattr(-,root,root) in %files is not needed either as it is the default


Otherwise the rest looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562245] Review Request: python-neo4j-driver - The official Python Neo4j driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562245



--- Comment #2 from Matt Prahl  ---
Thank you for the review! I uploaded a new version and it should fix the issue
you found.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562519] Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519



--- Comment #4 from Christian Kellner  ---
Thanks a lot. Updated:

https://github.com/gicmo/spec/blob/master/git-crypt/git-crypt.spec
https://koji.fedoraproject.org/koji/taskinfo?taskID=26092757

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562245] Review Request: python-neo4j-driver - The official Python Neo4j driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562245

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559699] Review Request: libdasm - Simple x86 disassembly library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559699



--- Comment #7 from Michal Ambroz  ---
bump to tagged version

Spec URL: http://rebus.fedorapeople.org/libdasm.spec
SRPM URL: http://rebus.fedorapeople.org/libdasm-1.6-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552442] Review Request: php-pragmarx-google2fa - Google Two-Factor Authentication for PHP Package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552442

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-03-31 20:42:54



--- Comment #11 from Fedora Update System  ---
php-pragmarx-google2fa-3.0.1-1.fc28 has been pushed to the Fedora 28 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559249] Review Request: langpacks-install - Tool to get auto installed langpacks on GNOME session startup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559249

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-03-31 20:42:57



--- Comment #9 from Fedora Update System  ---
langpacks-install-1.0.0-2.fc28 has been pushed to the Fedora 28 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558892] Review Request: R-callr - Call R from R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558892



--- Comment #12 from Fedora Update System  ---
R-callr-2.0.2-2.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558745] Review Request: R-geepack - Generalized Estimating Equation Package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558745



--- Comment #12 from Fedora Update System  ---
R-geepack-1.2.1-2.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558742] Review Request: R-gee - Generalized Estimation Equation Solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558742



--- Comment #12 from Fedora Update System  ---
R-gee-4.13.19-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558751] Review Request: R-labeling - Axis Labeling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558751



--- Comment #12 from Fedora Update System  ---
R-labeling-0.3-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558748] Review Request: R-gtable - Arrange 'Grobs' in Tables

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558748



--- Comment #12 from Fedora Update System  ---
R-gtable-0.2.0-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558789] Review Request: R-orcutt - Estimate Procedure in Case of First Order Autocorrelation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558789



--- Comment #9 from Fedora Update System  ---
R-orcutt-2.2-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558757] Review Request: R-tkrplot - TK Rplot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558757



--- Comment #12 from Fedora Update System  ---
R-tkrplot-0.0.23-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558874] Review Request: R-R.oo - R Object-Oriented Programming with or without References

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558874



--- Comment #12 from Fedora Update System  ---
R-R.oo-1.21.0-2.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558756] Review Request: R-statnet.common - Common R Scripts and Utilities Used by the Statnet Project Software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558756



--- Comment #12 from Fedora Update System  ---
R-statnet.common-4.0.0-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557748] Review Request: R-openssl - Toolkit for Encryption, Signatures and Certificates Based on OpenSSL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557748



--- Comment #14 from Fedora Update System  ---
R-openssl-1.0.1-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558882] Review Request: R-bindrcpp - An 'Rcpp' Interface to Active Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558882



--- Comment #11 from Fedora Update System  ---
R-bindrcpp-0.2-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558894] Review Request: R-clipr - Read and Write from the System Clipboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558894



--- Comment #12 from Fedora Update System  ---
R-clipr-0.4.0-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558752] Review Request: R-lmodel2 - Model II Regression

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558752



--- Comment #12 from Fedora Update System  ---
R-lmodel2-1.7.3-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558779] Review Request: R-rgdal - Bindings for the 'Geospatial' Data Abstraction Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558779



--- Comment #12 from Fedora Update System  ---
R-rgdal-1.2.18-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558859] Review Request: R-poLCA - Polytomous variable Latent Class Analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558859



--- Comment #13 from Fedora Update System  ---
R-poLCA-1.4.1-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1560834] Review Request: ocaml-sha - Binding to the SHA cryptographic functions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1560834



--- Comment #6 from Fedora Update System  ---
ocaml-sha-1.12-1.fc28 has been pushed to the Fedora 28 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-522d4a1528

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562526] Review Request: libfullock - A Fast User Level LOCK (FULLOCK ) library for C and C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562526



--- Comment #4 from Hiro Wakabayashi  ---
(In reply to Robert-André Mauchin from comment #2)
> Hello and welcome,
> 
> 
> I can't sponsor, but a couple preliminary remarks:
> 
>  - %clean is rot needed
> 
> %clean
> rm -rf %{buildroot}
> 
>  - %defattr(-,root,root) in %files is not needed either as it is the default
> 
> 
> Otherwise the rest looks good.

Good morning, Robert

Thanks you for your kindness! The spec file is simpler and easier to read than
before!

https://github.com/hiwkby/fullock/blob/master/libfullock.spec
https://github.com/hiwkby/fullock/blob/master/libfullock-1.0.24-1.fc27.src.rpm

And here are the links to successfull Koji and Copr build.
https://copr.fedorainfracloud.org/coprs/hiwkby/libfullock/build/735420/
https://koji.fedoraproject.org/koji/taskinfo?taskID=26095901

Thanks in advance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1560834] Review Request: ocaml-sha - Binding to the SHA cryptographic functions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1560834

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
ocaml-sha-1.12-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-b900a0eea6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558779] Review Request: R-rgdal - Bindings for the 'Geospatial' Data Abstraction Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558779



--- Comment #11 from Fedora Update System  ---
R-rgdal-1.2.18-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558859] Review Request: R-poLCA - Polytomous variable Latent Class Analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558859



--- Comment #12 from Fedora Update System  ---
R-poLCA-1.4.1-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557748] Review Request: R-openssl - Toolkit for Encryption, Signatures and Certificates Based on OpenSSL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557748



--- Comment #13 from Fedora Update System  ---
R-openssl-1.0.1-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558892] Review Request: R-callr - Call R from R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558892



--- Comment #11 from Fedora Update System  ---
R-callr-2.0.2-2.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558882] Review Request: R-bindrcpp - An 'Rcpp' Interface to Active Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558882



--- Comment #10 from Fedora Update System  ---
R-bindrcpp-0.2-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558757] Review Request: R-tkrplot - TK Rplot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558757



--- Comment #11 from Fedora Update System  ---
R-tkrplot-0.0.23-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558894] Review Request: R-clipr - Read and Write from the System Clipboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558894



--- Comment #11 from Fedora Update System  ---
R-clipr-0.4.0-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558789] Review Request: R-orcutt - Estimate Procedure in Case of First Order Autocorrelation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558789

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-03-31 23:28:47



--- Comment #8 from Fedora Update System  ---
R-orcutt-2.2-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558784] Review Request: R-rprintf - Adaptive Builder for Formatted Strings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558784



--- Comment #11 from Fedora Update System  ---
R-rprintf-0.2.1-2.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558874] Review Request: R-R.oo - R Object-Oriented Programming with or without References

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558874



--- Comment #11 from Fedora Update System  ---
R-R.oo-1.21.0-2.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558756] Review Request: R-statnet.common - Common R Scripts and Utilities Used by the Statnet Project Software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558756



--- Comment #11 from Fedora Update System  ---
R-statnet.common-4.0.0-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562526] Review Request: libfullock - A Fast User Level LOCK (FULLOCK ) library for C and C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562526



--- Comment #5 from Hiro Wakabayashi  ---
(In reply to Iwicki Artur from comment #3)
> >Source0: %{name}-%{version}.tar.gz
> Use the following: "%{URL}/archive/v%{version}/%{name}-%{version}.tar.gz"

Hello, Iwicki

Thanks you for your quick response!

I can't fix the invalid-url warning by rpmlint, because in my case,
"%{URL}/archive/v%{version}/%{name}-%{version}.tar.gz" does not contain the
".git" directory which is needed to build the source code correctly. So I left
a comment in the spec file to show where the source came from. 

Attached is the following error when I tried building the source code
distributed in the following url.
https://github.com/yahoojapan/fullock/archive/v1.0.24/fullock-1.0.24.tar.gz
```
fatal: Not a git repository (or any of the parent directories): .git
```

The reason of the error message above came from the following code.
https://github.com/yahoojapan/fullock/blob/master/make_release_version_file.sh#L78

Thanks in advance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558784] Review Request: R-rprintf - Adaptive Builder for Formatted Strings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558784



--- Comment #12 from Fedora Update System  ---
R-rprintf-0.2.1-2.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562474] Review Request: nodejs-conventional-changelog-core - The conventional-changelog core

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562474

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562452] Review Request: mypaint-brushes - Brushes to be used with the MyPaint library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562452

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Release should start at 1 if not a dev snapshot:

Release: 1%{?dist}

 - Do not include ChangeLog which is an empty file


Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "*No copyright* CC0", "Unknown or
 generated". 371 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/mypaint-brushes/review-
 mypaint-brushes/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mypaint-
 brushes-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present 

[Bug 1562519] New: Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519

Bug ID: 1562519
   Summary: Review Request: git-crypt - transparent file
encryption in git
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ckell...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://github.com/gicmo/spec/blob/master/git-crypt/git-crypt.spec
SRPM URL: 
https://copr-be.cloud.fedoraproject.org/results/gicmo/git-crypt/fedora-rawhide-x86_64/00735276-git-crypt/git-crypt-0.6.0-1.fc29.src.rpm
https://kojipkgs.fedoraproject.org//work/tasks/3651/26083651/git-crypt-0.6.0-1.fc29.src.rpm
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=26083650
Fedora Account System Username: gicmo
Description (taken from the spec file):
git-crypt enables transparent encryption and decryption of files in a
git repository. Files which you choose to protect are encrypted when
committed, and decrypted when checked out. git-crypt lets you freely
share a repository containing a mix of public and private
content. git-crypt gracefully degrades, so developers without the
secret key can still clone and commit to a repository with encrypted
files. This lets you store your secret material (such as keys or
passwords) in the same repository as your code, without requiring you
to lock down your entire repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562519] Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519



--- Comment #2 from Christian Kellner  ---
Thanks for the review comments!

Hopefully addressed all of them.

New spec:
https://github.com/gicmo/spec/blob/master/git-crypt/git-crypt.spec

New scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=26084103

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562519] Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #1 from Iwicki Artur  ---
>Summary: transparent file encryption in git
This should start with a capital (uppercase) letter.

>URL: https://www.agwa.name/projects/git-crypt/
>Source0: 
>https://www.agwa.name/projects/git-crypt/downloads/%{name}-%{version}.tar.gz
You can replace the beginning of Source0 with %{URL}.

>export DOCBOOK_XSL=/usr/share/sgml/docbook/xsl-stylesheets/manpages/docbook.xsl
I think %{_datadir} would be preferred here, instead of /usr/share.

>make install ENABLE_MAN=yes PREFIX=%{buildroot}/usr
Use %{_prefix} instead of /usr.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562526] New: Review Request: libfullock - A Fast User Level LOCK ( FULLOCK) library for C and C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562526

Bug ID: 1562526
   Summary: Review Request: libfullock - A Fast User Level LOCK
(FULLOCK) library for C and C++
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: hiw...@yahoo.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://github.com/hiwkby/fullock/blob/master/libfullock.spec
SRPM URL:
https://github.com/hiwkby/fullock/blob/master/libfullock-1.0.24-1.fc27.src.rpm

Description: A Fast User Level LOCK (FULLOCK) library for C and C++.
FULLOCK is an open-source software for user level lock library supported by
Yahoo! JAPAN. It runs on user level and provides two types lock that are
faster than fcntl. One is a shared reader/writer lock which has the same
functionality with pthread_rwlock. Another is a shared mutex lock which also
has the same functionality with pthread_mutex.

Fedora Account System Username: hiwkby

This is my first package and I am seeking a sponsor! 
Here is a link to a successful koji build.
https://koji.fedoraproject.org/koji/taskinfo?taskID=26083743

Thanks in advance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562526] Review Request: libfullock - A Fast User Level LOCK (FULLOCK ) library for C and C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562526

Hiro Wakabayashi  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551339] Review Request: shelldap - A shell-like interface for browsing LDAP servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551339



--- Comment #6 from Timothée Floure  ---
Updated Spec URL:
https://fnux.fedorapeople.org/pkg-reviews/shelldap/review-3/shelldap.spec
Updated SRPM URL:
https://fnux.fedorapeople.org/pkg-reviews/shelldap/review-3/shelldap-1.4.0-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org