[Bug 1561613] Review Request: golang-github-shurcool - Common Go code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561613

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-shurcool-0-0.1.20180419git47fa5b7.fc28 has been pushed to the
Fedora 28 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-fa085a1d3e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561678] Review Request: golang-opencensus - A stats collection and distributed tracing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561678

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
golang-opencensus-0.8.0-2.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-89871df882

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561620] Review Request: golang-gopkg-pipe-2 - Unix-like pipelines for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561620

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-gopkg-pipe-2-0-0.1.20180419git3c2ca4d.fc28 has been pushed to the Fedora
28 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-91b183bbf9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508950] Review Request: eccodes - a library for decoding and encoding WMO data formats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508950

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #32 from Fedora Update System  ---
eccodes-2.7.0-2.fc28 has been pushed to the Fedora 28 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-2942160ff6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 662259] Review Request: git-annex - Manage files with git, without checking their contents in

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=662259

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com
  Alias|git-annex   |



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561673] Review Request: golang-honnef-js-dom - GopherJS bindings for the JavaScript DOM APIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561673



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-honnef-js-dom

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1262470] Review Request: python-PyPDF2 - A pure Python library built as a PDF toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262470

Eric Smith  changed:

   What|Removed |Added

 CC||space...@gmail.com



--- Comment #26 from Eric Smith  ---
There are now python34 and python36 in EPEL7, so it may be possible to package
python3-PyPDF2 for EPEL7 now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561613] Review Request: golang-github-shurcool - Common Go code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561613

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561613] Review Request: golang-github-shurcool - Common Go code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561613



--- Comment #3 from Fedora Update System  ---
golang-github-shurcool-0-0.1.20180419git47fa5b7.fc28 has been submitted as an
update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-fa085a1d3e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1512702] Review Request: golang-github-prometheus-node_exporter - Prometheus exporter for hardware and OS metrics exposed by *NIX kernels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512702

Paul Gier  changed:

   What|Removed |Added

  Flags|needinfo?(pg...@redhat.com) |



--- Comment #3 from Paul Gier  ---
Yep, I'm still interested, I should have some time to start working on this
again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561620] Review Request: golang-gopkg-pipe-2 - Unix-like pipelines for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561620



--- Comment #3 from Fedora Update System  ---
golang-gopkg-pipe-2-0-0.1.20180419git3c2ca4d.fc28 has been submitted as an
update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-91b183bbf9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561620] Review Request: golang-gopkg-pipe-2 - Unix-like pipelines for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561620

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561678] Review Request: golang-opencensus - A stats collection and distributed tracing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561678



--- Comment #4 from Fedora Update System  ---
golang-opencensus-0.8.0-2.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-89871df882

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380826] Review Request: pgadmin4 - Management tool for PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Bug 1380826 depends on bug 1550697, which changed state.

Bug 1550697 Summary: python-flask-login-0.4.1 is available (blocking pgadmin4)
https://bugzilla.redhat.com/show_bug.cgi?id=1550697

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561678] Review Request: golang-opencensus - A stats collection and distributed tracing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561678

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561678] Review Request: golang-opencensus - A stats collection and distributed tracing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561678



--- Comment #3 from Fedora Update System  ---
golang-opencensus-0.8.0-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-624a7a0525

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1567202] Review Request: gerbera - UPnP Media Server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567202

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #5 from Robert-André Mauchin  ---
Everything is good, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1567201] Review Request: duktape - Embeddable Javascript engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567201

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Robert-André Mauchin  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536780] Review Request: swift-lang - Apple' s Swift Programming Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536780



--- Comment #27 from Ron Olson  ---
Updated to the 2018-04-16 build:

Spec URL: https://tachoknight.fedorapeople.org/swift-lang/swift-lang.spec

SRPM 4.2-0.5.20180418gitac06163 for Fedora 27:
https://tachoknight.fedorapeople.org/swift-lang/swift-lang-4.2-0.5.20180418gitac06163.fc27.src.rpm

SRPM 4.2-0.5.20180418gitac06163 for Fedora Rawhide:
https://tachoknight.fedorapeople.org/swift-lang/swift-lang-4.2-0.5.20180418gitac06163.fc29.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1567202] Review Request: gerbera - UPnP Media Server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567202



--- Comment #4 from Gwyn Ciesla  ---
Thank you! Updated.

SRPM:
https://fedorapeople.org/~limb/review/gerbera/gerbera-1.1.0-2.20180413git2f6dcb5.fc29.src.rpm
SPEC: https://fedorapeople.org/~limb/review/gerbera/gerbera.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1567201] Review Request: duktape - Embeddable Javascript engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567201



--- Comment #3 from Gwyn Ciesla  ---
Thank you! Updated.

SRPM: https://fedorapeople.org/~limb/review/duktape/duktape-2.2.0-2.src.rpm
SPEC: https://fedorapeople.org/~limb/review/duktape/duktape.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1569590] New: Review Request: php-sebastian-comparator3 - Compare PHP values for equality

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1569590

Bug ID: 1569590
   Summary: Review Request: php-sebastian-comparator3 - Compare
PHP values for equality
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@famillecollet.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://git.remirepo.net/cgit/rpms/php/phpunit/php-sebastian-comparator3.git/plain/php-sebastian-comparator3.spec?id=ab5387f4d7748bf87948598d42e2df02070742d8
SRPM URL:
http://rpms.remirepo.net/SRPMS/php-sebastian-comparator3-3.0.0-1.remi.src.rpm
Description: 
This component provides the functionality to compare PHP values for equality.

Fedora Account System Username: remi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426010] Review Request: modsec-sdbm-util - Utility for inspecting ModSecurity persistent storage files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426010

Robert Bost  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-04-19 09:40:45



--- Comment #2 from Robert Bost  ---
Closing WONTFIX

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1567898] Review Request: tomsfastmath - fast large integer arithmetic library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567898

Jaroslav Škarvada  changed:

   What|Removed |Added

 Status|POST|CLOSED
 CC||jskar...@redhat.com
 Resolution|--- |NEXTRELEASE
Last Closed||2018-04-19 09:23:50



--- Comment #6 from Jaroslav Škarvada  ---
Changing status to NEXTRELEASE according to [1], step 12 (I am not using
RAWHIDE in case it will be build for more versions):

[1]
https://fedoraproject.org/wiki/New_package_process_for_existing_contributors

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508950] Review Request: eccodes - a library for decoding and encoding WMO data formats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508950

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508950] Review Request: eccodes - a library for decoding and encoding WMO data formats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508950



--- Comment #31 from Fedora Update System  ---
eccodes-2.7.0-2.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-2942160ff6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819



--- Comment #8 from Neal Gompa  ---
@Pawel, before I approve this review and sponsor you into the maintainers
group, I'd like you to do five non-binding reviews of other packages in the
review queue[1], to demonstrate your understanding of the Fedora Packaging
Guidelines.

You can find review requests here:
https://fedoraproject.org/PackageReviewStatus/NEW.html

Note that the page is in chronological order, so you'll want to scroll to the
bottom of the page and pick five from there, as those are recent review
requests.

[1]:
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Show_Your_Expertise_by_Commenting_on_other_Review_Requests

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819



--- Comment #7 from Neal Gompa  ---
Review notes:

> [x]: Package must own all directories that it creates.
>  Note: Directories without known owners: /usr/share/gocode/src,
>  /usr/share/gocode, /usr/share/gocode/src/github.com

This is normal for gofed generated packages, so I'm giving a pass on this. And
I expect this to be corrected with 3.0 spec format in the future. Also, at
least a couple of those are owned by the golang stack itself, I believe.

> [x]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "Unknown or generated". 11 files have unknown license. Detailed
>  output of licensecheck in /home/makerpm/1567819-golang-github-
>  pilebones-go-udev/licensecheck.txt

This is caused by none of the golang files actually having license headers.
Sadly, this appears to be the norm in Go libraries (even though it's a bad idea
with how people do vendoring), so I'm going to consider the license file as
sufficient.

> golang-github-pilebones-go-udev.x86_64: E: no-binary

This is not terribly surprising, and I'm okay with ignoring this, since it's a
false positive with how Go libraries are packaged.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819



--- Comment #6 from Neal Gompa  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 11 files have unknown license. Detailed
 output of licensecheck in /home/makerpm/1567819-golang-github-
 pilebones-go-udev/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode, /usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
 github-pilebones-go-udev-devel , golang-github-pilebones-go-udev-unit-
 test-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, 

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819

Neal Gompa  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #5 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561616] Review Request: golang-github-shurcool-flavored-markdown - GitHub Flavored Markdown renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561616

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-shurcool-flavored-markdown-0-0.1.20180418git28433ea.fc28 has been
pushed to the Fedora 28 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-faccd44bf0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561574] Review Request: golang-github-gopherjs - Compiler from Go to JavaScript for running Go code in a browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561574

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-gopherjs-0-0.1.20180418gite14987c.fc28 has been pushed to the
Fedora 28 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f9c1f33fa2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1564683] Review Request: ghc-ghc-syb-utils - Scrap Your Boilerplate utilities for the GHC API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1564683

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
ghc-ghc-syb-utils-0.2.3.3-2.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-b6a06fd1ae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561628] Review Request: golang-github-shurcool-highlight - Syntax highlighter for Go, using go/ scanner

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561628

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-shurcool-highlight-0-0.1.20180418git78fb10f.fc28 has been pushed
to the Fedora 28 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-d69e7c3f35

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561538] Review Request: golang-github-bradfitz-smtpd - SMTP server library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561538

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-bradfitz-smtpd-0-0.1.20180417gitdeb6d62.fc28 has been pushed to
the Fedora 28 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1d133ef29e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561592] Review Request: golang-github-jellevandenhooff-dkim - Pure Go DKIM verification library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561592

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-jellevandenhooff-dkim-0-0.1.20180417gitf50fe3d.fc28 has been
pushed to the Fedora 28 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-e16750f8d6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1549003] Review Request: python-libevdev - Python bindings to the libevdev evdev device wrapper library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1549003

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
python-libevdev-0.4-2.fc28 has been pushed to the Fedora 28 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-7d7e9d3592

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561602] Review Request: golang-github-microcosm-cc-bluemonday - Fast golang HTML sanitizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561602

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-microcosm-cc-bluemonday-0-0.1.20180418git995366f.fc28 has been
pushed to the Fedora 28 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-7a839c0a28

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561575] Review Request: golang-github-neelance-astrewrite - Go tool to write AST

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561575

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-neelance-astrewrite-0-0.1.20180418git9934826.fc28 has been pushed
to the Fedora 28 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-075f0339a6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561629] Review Request: golang-github-shurcool-octiconssvg - GitHub Octicons in SVG format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561629

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-shurcool-octiconssvg-0-0.1.20180418git91d1485.fc28 has been
pushed to the Fedora 28 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-ebec26355a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561582] Review Request: golang-github-shurcool-httpfs - Collection of Go packages for working with the http.FileSystem interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561582

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-shurcool-httpfs-0-0.1.20180418git809bece.fc28 has been pushed to
the Fedora 28 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-2980ea7b34

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1568877] Review Request: perl-File-Copy-Recursive-Reduced - Recursive copying of files and directories within Perl 5 toolchain

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1568877



--- Comment #10 from Fedora Update System  ---
perl-File-Copy-Recursive-Reduced-0.003-1.fc28 has been pushed to the Fedora 28
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-301be36b8c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1564835] Review Request: gmediarender - Resource efficient UPnP/ DLNA renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1564835

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
gmediarender-0-0.8.20180414git4f221e6.fc28 has been pushed to the Fedora 28
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6fde958f35

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561593] Review Request: golang-github-kisielk-gotool - Library of some of the utility functions provided by cmd /go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561593

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-kisielk-gotool-1.0.0-1.fc28 has been pushed to the Fedora 28
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-edb1b14821

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561624] Review Request: golang-github-sourcegraph-annotate - Apply multiple sets of annotations to a region of text

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561624

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-sourcegraph-annotate-0-0.1.20180418gitf4cad6c.fc28 has been
pushed to the Fedora 28 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-e0fa0f0d32

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561518] Review Request: golang-apache-thrift - Thrift Go Software Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561518

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-apache-thrift-0.11.0-0.1.20180417git50bfc56.fc28 has been pushed to the
Fedora 28 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-539906bc40

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561626] Review Request: golang-github-sourcegraph-syntaxhighlight - Syntax highlighting of code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561626

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-sourcegraph-syntaxhighlight-0-0.1.20180418gitbd320f5.fc28 has
been pushed to the Fedora 28 testing repository. If problems still persist,
please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8f7d29aee1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561623] Review Request: golang-github-shurcool-highlight-diff - Syntax highlighter for diff format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561623

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-shurcool-highlight-diff-0-0.1.20180418git09bb405.fc28 has been
pushed to the Fedora 28 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-911b3662e5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1561580] Review Request: golang-github-neelance-sourcemap - JavaScript source map reader & writer for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1561580

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-neelance-sourcemap-0-0.1.20180418git8c68805.fc28 has been pushed
to the Fedora 28 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-ce519c5065

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org