[Bug 1858531] Review Request: partio - Library for reading/writing/manipulating common animation particle
https://bugzilla.redhat.com/show_bug.cgi?id=1858531 --- Comment #2 from Robert-André Mauchin --- Sorry I shouldn't have checked "do not send mail". Please see the comment above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858531] Review Request: partio - Library for reading/writing/manipulating common animation particle
https://bugzilla.redhat.com/show_bug.cgi?id=1858531
--- Comment #4 from Luya Tshimbalanga ---
(In reply to Robert-André Mauchin from comment #1)
> - Please fix the Source0:
>
> Source0:
> https://github.com/wdas/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz
>
> (archives → archive)
Fixed.
> - That should be in the Python subpackage:
>
> %{python3_sitearch}/_%{name}.so
Fixed,
>
> (Probably something like that:
>
> set_target_properties(partio PROPERTIES
> OUTPUT_NAME partio POSITION_INDEPENDENT_CODE ON
> VERSION ${VERSION}
> SOVERSION 1
> )
>
> in src/lib/CMakeLists.txt)
After applying a patch using the above code, the build managed to build as seen
on the scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=47414693
I filed a ticket to upstream about the versioning libraries:
https://github.com/wdas/partio/issues/82
>
> - You should not provide %license LICENSE for all packages, but for all
> packages combination. For ex, -devel depends on the main package which
> already provide the license, so it shouldn't be included another time in the
> -devel subpackage. Same with -doc subpackage.
Fixed.
>
> - Is it useful to package the tests? Are they used by the end-user?
Those tests aren't need so they are removed.
> - Add Version-Release to your changelog entry.
Done.
Here is the updated files:
SPEC:
https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/fedora-rawhide-x86_64/01559730-partio/partio.spec
SRPM:
https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/fedora-rawhide-x86_64/01559730-partio/partio-1.10.1-2.fc33.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1376511] Review Request: nexus - NeXus scientific data file format
https://bugzilla.redhat.com/show_bug.cgi?id=1376511 Andy Mender changed: What|Removed |Added CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503 --- Comment #4 from chedi toueiti --- The same thing happens when building with koji https://koji.fedoraproject.org/koji/taskinfo?taskID=47396069 and https://koji.fedoraproject.org/koji/taskinfo?taskID=47397719 but not from my machine, it seems there is some network issue between the build server and docs.python.org I didn't also have these issues when using copr https://copr.fedorainfracloud.org/coprs/chedi/python-packages/build/1559500/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #35 from Fedora Update System --- FEDORA-EPEL-2020-6e4abc955e has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503
--- Comment #3 from Andy Mender ---
> Thanks for your feedback, I updated the spec file accordingly and linked the
> fonts to the ones from fontsawesome/fontawesome-web packages
> (this is the way the python-sphinx_rtd_theme did it).
Looks good :)
`rpmbuild` complaints about absolute symlinks, but since
python-sphinx_rtd_theme does that, I think it's okay (can't think of a better
way):
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/FontAwesome.otf
-> /usr/share/fonts/fontawesome/FontAwesome.otf
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/fontawesome-webfont.eot
-> /usr/share/fonts/fontawesome/fontawesome-webfont.eot
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/fontawesome-webfont.svg
-> /usr/share/fonts/fontawesome/fontawesome-webfont.svg
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/fontawesome-webfont.ttf
-> /usr/share/fonts/fontawesome/fontawesome-webfont.ttf
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/fontawesome-webfont.woff
-> /usr/share/fonts/fontawesome/fontawesome-webfont.woff
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/fontawesome-webfont.woff2
-> /usr/share/fonts/fontawesome/fontawesome-webfont.woff2
Could you try building the package in COPR or Koji to see if everything goes
well? When running a local mock build I see that the build process is trying to
access the Internet:
+ sphinx-build-3 docs html
Running Sphinx v2.2.2
making output directory... done
loading intersphinx inventory from https://docs.python.org/2/objects.inv...
loading intersphinx inventory from ../python2.inv...
loading intersphinx inventory from https://docs.python.org/3/objects.inv...
WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://docs.python.org/2/objects.inv' not fetchable due
to :
HTTPSConnectionPool(host='docs.python.org', port=443): Max retries exceeded
with url: /2/objects.inv (Caused by
NewConnectionError(': Failed to establish a new connection: [Errno -2] Name or
service not known'))
intersphinx inventory '../python2.inv' not fetchable due to : [Errno 2] No such file or directory:
'/builddir/build/BUILD/sphinx_ansible_theme-0.3.1/docs/../python2.inv'
loading intersphinx inventory from ../python3.inv...
WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://docs.python.org/3/objects.inv' not fetchable due
to :
HTTPSConnectionPool(host='docs.python.org', port=443): Max retries exceeded
with url: /3/objects.inv (Caused by
NewConnectionError(': Failed to establish a new connection: [Errno -2] Name or
service not known'))
intersphinx inventory '../python3.inv' not fetchable due to : [Errno 2] No such file or directory:
'/builddir/build/BUILD/sphinx_ansible_theme-0.3.1/docs/../python3.inv'
loading intersphinx inventory from
http://jinja.palletsprojects.com/objects.inv...
loading intersphinx inventory from ../jinja2.inv...
loading intersphinx inventory from
https://docs.ansible.com/ansible/2.9/objects.inv...
WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'http://jinja.palletsprojects.com/objects.inv' not
fetchable due to :
HTTPConnectionPool(host='jinja.palletsprojects.com', port=80): Max retries
exceeded with url: /objects.inv (Caused by
NewConnectionError(': Failed to establish a new connection: [Errno -2] Name or
service not known'))
intersphinx inventory '../jinja2.inv' not fetchable due to : [Errno 2] No such file or directory:
'/builddir/build/BUILD/sphinx_ansible_theme-0.3.1/docs/../jinja2.inv'
It completes "successfully", but if the package ends up being incomplete,
that's also not good.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839503] Review Request: golang-github-valyala-fasthttp - Fast HTTP package
https://bugzilla.redhat.com/show_bug.cgi?id=1839503 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-07-19 01:09:03 --- Comment #9 from Fedora Update System --- FEDORA-2020-dad23b44a2 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503 --- Comment #5 from chedi toueiti --- @andy, Could you please confirm the review as I think the last point is really not that detrimental to the package core functionality (it's part of the documentation generation process and I cannot really influence it in any way other that signalling the connectivity issue to the infrastructure team) and thanks again for taking the time to help with this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839503] Review Request: golang-github-valyala-fasthttp - Fast HTTP package
https://bugzilla.redhat.com/show_bug.cgi?id=1839503 --- Comment #10 from Fedora Update System --- FEDORA-2020-a2a9eb0cb8 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858531] Review Request: partio - Library for reading/writing/manipulating common animation particle
https://bugzilla.redhat.com/show_bug.cgi?id=1858531 --- Comment #3 from Robert-André Mauchin --- Also the tests contain arch-dependent binaries in /usr/share, which is not good. /usr/share is for arch independent code only: partio-test.x86_64: E: arch-dependent-file-in-usr-share /usr/share/partio/test/makecircle partio-test.x86_64: E: arch-dependent-file-in-usr-share /usr/share/partio/test/makeline partio-test.x86_64: E: arch-dependent-file-in-usr-share /usr/share/partio/test/testcache partio-test.x86_64: E: arch-dependent-file-in-usr-share /usr/share/partio/test/testclonecopy partio-test.x86_64: E: arch-dependent-file-in-usr-share /usr/share/partio/test/testcluster partio-test.x86_64: E: arch-dependent-file-in-usr-share /usr/share/partio/test/testio partio-test.x86_64: E: arch-dependent-file-in-usr-share /usr/share/partio/test/testiterator partio-test.x86_64: E: arch-dependent-file-in-usr-share /usr/share/partio/test/testkdtree partio-test.x86_64: E: arch-dependent-file-in-usr-share /usr/share/partio/test/testmerge partio-test.x86_64: E: arch-dependent-file-in-usr-share /usr/share/partio/test/teststr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1812961] Review Request: openosc - Open Object Size Checking Library to detect buffer overflows with built-in metrics
https://bugzilla.redhat.com/show_bug.cgi?id=1812961 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-07-19 02:19:29 --- Comment #58 from Fedora Update System --- FEDORA-2020-5f1c91eb01 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1856589] Review Request: openshadinglanguage - Advanced shading language for production GI renderers
https://bugzilla.redhat.com/show_bug.cgi?id=1856589 Luya Tshimbalanga changed: What|Removed |Added Depends On||1858531 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1858531 [Bug 1858531] Review Request: partio- Library for reading/writing/manipulating common animation particle -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858531] Review Request: partio- Library for reading/writing/manipulating common animation particle
https://bugzilla.redhat.com/show_bug.cgi?id=1858531 Luya Tshimbalanga changed: What|Removed |Added Blocks||1856589 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1856589 [Bug 1856589] Review Request: openshadinglanguage - Advanced shading language for production GI renderers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858531] New: Review Request: partio- Library for reading/writing/manipulating common animation particle
https://bugzilla.redhat.com/show_bug.cgi?id=1858531 Bug ID: 1858531 Summary: Review Request: partio- Library for reading/writing/manipulating common animation particle Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: luya_...@thefinalzone.net QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/fedora-32-x86_64/01559518-partio/partio.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/fedora-32-x86_64/01559518-partio/partio-1.10.1-1.fc32.src.rpm Description: C++ (with python bindings) library for easily reading/writing/manipulating common animation particle formats such as PDB, BGEO, PTC. Fedora Account System Username: luya -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858449] Review Request: perl-MooX-TypeTiny - Optimized type checks for Moo + Type::Tiny
https://bugzilla.redhat.com/show_bug.cgi?id=1858449 Ralf Corsepius changed: What|Removed |Added Blocks||1858466 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1858466 [Bug 1858466] Review Request: perl-Path-Dispatcher - Flexible and extensible dispatch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858466] Review Request: perl-Path-Dispatcher - Flexible and extensible dispatch
https://bugzilla.redhat.com/show_bug.cgi?id=1858466 Ralf Corsepius changed: What|Removed |Added Depends On||1858449 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1858449 [Bug 1858449] Review Request: perl-MooX-TypeTiny - Optimized type checks for Moo + Type::Tiny -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #30 from Simone Caronni --- Thanks, I've added signature verification which is a bit from all comments above. The packaging guidelines are pretty clear about signatures, so: - Key is downloaded from the keyserver (as also suggested by upstream) and instructions are in the SPEC file. - Key is added to the Fedora SCM (aka it's in git). - Detached signed checksum is in the lookaside cache (aka it's in the sources file). - Since /usr/lib/rpm/redhat/gpgverify (aka %gpgverify) does not support signed sums files I've replaced it with gpgv2/sha256sum commands. I will also add the SHA256UM.asc file in the .gitignore file once approved so there is no chance that the hashed checksum gets into SCM and can only go into the lookaside cache. Spec URL: https://slaanesh.fedorapeople.org/bitcoin.spec SRPM URL: https://slaanesh.fedorapeople.org/bitcoin-0.20.0-3.fc32.src.rpm * Sat Jul 18 2020 Simone Caronni - 0.20.0-3 - Add signature verification. - Trim changelog. - Fix typo in the libs description. I will start working on the SELinux part hopefully soon (terribly busy in real life). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858466] New: Review Request: perl-Path-Dispatcher - Flexible and extensible dispatch
https://bugzilla.redhat.com/show_bug.cgi?id=1858466 Bug ID: 1858466 Summary: Review Request: perl-Path-Dispatcher - Flexible and extensible dispatch Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rc040...@freenet.de QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Path-Dispatcher.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Path-Dispatcher-1.08-1.fc33.src.rpm Description: We really like Jifty::Dispatcher and wanted to use it for Prophet's command line. Fedora Account System Username: corsepiu -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858466] Review Request: perl-Path-Dispatcher - Flexible and extensible dispatch
https://bugzilla.redhat.com/show_bug.cgi?id=1858466 Ralf Corsepius changed: What|Removed |Added Blocks||1858048 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1858048 [Bug 1858048] rt-5.0.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1856589] Review Request: openshadinglanguage - Advanced shading language for production GI renderers
https://bugzilla.redhat.com/show_bug.cgi?id=1856589 --- Comment #3 from Luya Tshimbalanga --- Upated files SPEC: https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/fedora-rawhide-x86_64/01558161-openshadinglanguage/openshadinglanguage.spec SRPM: https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/fedora-rawhide-x86_64/01558161-openshadinglanguage/openshadinglanguage-1.11.6.0-2.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] New: Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503 Bug ID: 1858503 Summary: Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: chedi.toue...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://chedi.fedorapeople.org/python-sphinx_ansible_theme.spec SRPM URL: https://chedi.fedorapeople.org/python-sphinx_ansible_theme-0.3.1-1.fc32.src.rpm Description: A reusable Ansible Sphinx Theme. This theme is building on top of RTD Theme and adds customizations needed for building projects which are part of Ansible ecosystem Fedora Account System Username: chedi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858486] Review Request: rust-zeroize - Securely clear secrets from memory
https://bugzilla.redhat.com/show_bug.cgi?id=1858486 Peter Robinson changed: What|Removed |Added Alias||rust-zeroize Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858486] New: Review Request: rust-zeroize - Securely clear secrets from memory
https://bugzilla.redhat.com/show_bug.cgi?id=1858486 Bug ID: 1858486 Summary: Review Request: rust-zeroize - Securely clear secrets from memory Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: pbrobin...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora SPEC: https://pbrobinson.fedorapeople.org/rust-zeroize.spec SRPM: https://pbrobinson.fedorapeople.org/rust-zeroize-1.1.0-1.fc32.src.rpm Description: Securely clear secrets from memory with a simple trait built on stable Rust primitives which guarantee memory is zeroed using an operation will not be 'optimized away' by the compiler. Uses a portable pure Rust implementation that works everywhere, even WASM!.} FAS: pbrobinson koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=47379345 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858376] Review Request: python-extension-helpers - A build time package to simplify C/Cython extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1858376 Christian Dersch changed: What|Removed |Added Blocks||1720330 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1720330 [Bug 1720330] python-reproject-0.7.1 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858487] New: Review Request: rust-keccak - Keccak-f sponge function
https://bugzilla.redhat.com/show_bug.cgi?id=1858487 Bug ID: 1858487 Summary: Review Request: rust-keccak - Keccak-f sponge function Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: pbrobin...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora SPEC: https://pbrobinson.fedorapeople.org/rust-keccak.spec SRPM: https://pbrobinson.fedorapeople.org/rust-keccak-0.1.0-1.fc32.src.rpm Description: Keccak-f sponge function FAS: pbrobinson koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=47379762 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858487] Review Request: rust-keccak - Keccak-f sponge function
https://bugzilla.redhat.com/show_bug.cgi?id=1858487 Peter Robinson changed: What|Removed |Added Alias||rust-keccak Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503
--- Comment #1 from Andy Mender ---
> %global srcname sphinx_ansible_theme
Is the package not actually called "sphinx-ansible-theme"?
> URL:https://github.com/ansible-community/sphinx_ansible_theme
You can use the %{srcname} macro in the URL block if it matches the name of the
GitHub repo.
> License:MIT
`licensecheck` shows that:
sphinx_ansible_theme/ext/pygments_lexer.py: BSD 2-clause "Simplified" License
You can include that file in a comment above the License block like so:
# Main program: MIT
# ext/pygments_lexer.py: BSD
License: MIT and BSD
> BuildRequires: python3-devel
> BuildRequires: python3-setuptools
> BuildRequires: python-sphinx_rtd_theme
Should be python3-sphinx_rtd_theme, I think.
From the sources I see this package bundles the following font files:
sphinx_ansible_theme/static/fonts/FontAwesome.otf
sphinx_ansible_theme/static/fonts/fontawesome-webfont.eot
sphinx_ansible_theme/static/fonts/fontawesome-webfont.svg
sphinx_ansible_theme/static/fonts/fontawesome-webfont.ttf
sphinx_ansible_theme/static/fonts/fontawesome-webfont.woff
sphinx_ansible_theme/static/fonts/fontawesome-webfont.woff2
Font Awesome seems to have a permissive license
(https://github.com/FortAwesome/Font-Awesome/blob/master/LICENSE.txt), but font
files should not be bundled together with non-font libraries.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
Note: Unversionned Python dependency found.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Python/#_dependencies
- Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
Note: Package contains %{pythonX_site(lib|arch)}/* in %files
See: https://pagure.io/packaging-committee/issue/782
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "BSD 2-clause
"Simplified" License". 51 files have unknown license. Detailed output
of licensecheck in /home/amender/1858503-python-
sphinx_ansible_theme/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[-]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[-]: Package use %makeinstall
[Bug 1856589] Review Request: openshadinglanguage - Advanced shading language for production GI renderers
https://bugzilla.redhat.com/show_bug.cgi?id=1856589 --- Comment #5 from Luya Tshimbalanga --- Thank you Robert-Andre! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858381] Review Request: perl-Web-Machine - Perl port of Webmachine
https://bugzilla.redhat.com/show_bug.cgi?id=1858381
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
Hello Ralf
Could you please update your Perl SPEC to follow the latest Perl-SIG standards,
see these recent SPECs https://bugzilla.redhat.com/show_bug.cgi?id=1856854 or
https://bugzilla.redhat.com/show_bug.cgi?id=1856839
Basically something like this:
BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76
[…]
%prep
%setup -q -n ColorThemeRole-ANSI-%{version}
%build
perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
%{make_build}
%install
%{make_install}
%{_fixperms} $RPM_BUILD_ROOT/*
%check
unset AUTHOR_TESTING
make test
i.e.using NO_PACKLIST=1 NO_PERLLOCAL=1 to use %{make_install} and unset
AUTHOR_TESTING for the tests.
- Add a BR for perl-interpreter: BuildRequires: perl-interpreter
- Do not use %{__perl} but perl directly. Macros starting with __ are reserved
for rpm private use.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503 --- Comment #2 from chedi toueiti --- @Andy Thanks for your feedback, I updated the spec file accordingly and linked the fonts to the ones from fontsawesome/fontawesome-web packages (this is the way the python-sphinx_rtd_theme did it). updated files: (same link different content) Spec URL: https://chedi.fedorapeople.org/python-sphinx_ansible_theme.spec SRPM URL: https://chedi.fedorapeople.org/python-sphinx_ansible_theme-0.3.1-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858256] Review Request: rpm-git-tag-sort - Sorts git annotated tags according to topology and rpm version sorting
https://bugzilla.redhat.com/show_bug.cgi?id=1858256
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Robert-André Mauchin ---
- Please detail how you generated the Sources
Source0:rpm-git-tag-sort-498f832d-dirty.tar.gz
Source1:rpm-git-tag-sort-c-vector-498f832d.tar.gz
- make → %make_build
- You should set Fedora build flags with %set_build_flags, and make sure that
the Makefile respect them (CFLAGS)
- make install root=%{buildroot} → Use DESTDIR instead of root in your
Makefile, and then use %make_install
- Provide a license file and install it with %license in %files. A README.md
as %doc would be nice too.
%files
/usr/bin/rpm-git-tag-sort
- Please provide a changelog entry
- The version is unsortable: 0.0.git.2.498f832d.dirty.0nub0m and the git hash
info should be included in Release not Version. I would use the syntax for a
prerelease and GIT snapshot:
Version: 0
Release: 0.1.20200717git498f832%{?dist}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1856589] Review Request: openshadinglanguage - Advanced shading language for production GI renderers
https://bugzilla.redhat.com/show_bug.cgi?id=1856589 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Robert-André Mauchin --- LGTM, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857740] Review Request: rust-num-bigint-dig - Big integer implementation for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1857740 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #1 from Robert-André Mauchin --- DEBUG util.py:621: Error: DEBUG util.py:621: Problem: nothing provides requested (crate(autocfg/default) >= 0.1.5 with crate(autocfg/default) < 0.2.0) We have autocfg 1.0.0 in Fedora. Either try to bump the dependency in Cargo.toml (recommended) or build a autocfg compat package at version 0.1.5. Jistone actually say that version 1.0.0 of autocfg has no breaking changes so bumping the dep will probably work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857584] Review Request: python-serpent - Serialization based on ast.literal_eval
https://bugzilla.redhat.com/show_bug.cgi?id=1857584
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Expat License", "Unknown or generated". 12 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/python-serpent/review-python-
serpent/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified
[Bug 1723013] Review Request: mne-cpp - A Framework for Electrophysiology
https://bugzilla.redhat.com/show_bug.cgi?id=1723013
--- Comment #10 from Robert-André Mauchin ---
# CentOS/RedHat needs Qt 5.10 to be downloaded and built (no rpm for install)
%if 0%{?rhel}
echo in_setup_for_RedHat
curl -s https://raw.githubusercontent.com/jcfr/qt-easy-build/5.10.0/Build-qt.sh
-o Build-qt.sh
chmod 755 Build-qt.sh
./Build-qt.sh -y -c -j4 -q $HOME/qt
%endif
pwd
If Qt > 5.10 is required then you can't support RHEL < 7. You can target RHEL 8
(not sure of Qt's version here, please check).
- Secondly you need to use nacros:
%build
PATH=/usr/lib64/qt5/bin:$PATH
qmake --version
qmake -makefile -recursive
make
→
%{qmake_qt5}
%make_build
- Do not install in /usr/local, use %{_prefix} macro which is /usr
- No idea what you are trying to do here:
%install
# echo %{buildroot}
# copy over subdirs from build
mkdir -p %{buildroot}/%{_prefix}/mne-cpp
tar cpf - ./bin ./lib ./doc | (cd %{buildroot}/%{_prefix}/mne-cpp; tar xpf -)
- Also
Source0:https://github.com/mne-tools/mne-cpp/archive/master.zip
you can't just pount to master like this, you need to d/l a specific release,
if not are provided, then target a specific commit. It seems 0.1.4 is the
latest release.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858410] Review Request: golang-github-matrix-org-gomatrix - Golang Matrix client
https://bugzilla.redhat.com/show_bug.cgi?id=1858410 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858376] Review Request: python-extension-helpers - A build time package to simplify C/Cython extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1858376
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- Please build the docs/ with Sphinx
- Please see if you can run the tests provided in extension_helpers/tests
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
License". 38 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/python-extension-
helpers/review-python-extension-helpers/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description
[Bug 1857316] Review Request: rust-gptman - GPT manager that allows you to copy partitions from one disk to another
https://bugzilla.redhat.com/show_bug.cgi?id=1857316 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1664161] Review Request: rust-autocfg - Automatic cfg for Rust compiler features
https://bugzilla.redhat.com/show_bug.cgi?id=1664161 Robert-André Mauchin changed: What|Removed |Added Blocks||1269538 (IoT), 1857740 ||(rust-num-bigint-dig) CC||pbrobin...@gmail.com --- Comment #4 from Robert-André Mauchin --- *** Bug 1857737 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora https://bugzilla.redhat.com/show_bug.cgi?id=1857740 [Bug 1857740] Review Request: rust-num-bigint-dig - Big integer implementation for Rust -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857740] Review Request: rust-num-bigint-dig - Big integer implementation for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1857740 Robert-André Mauchin changed: What|Removed |Added Depends On||1664161 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1664161 [Bug 1664161] Review Request: rust-autocfg - Automatic cfg for Rust compiler features -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857737] Review Request: rust-autocfg - Automatic cfg for Rust compiler features
https://bugzilla.redhat.com/show_bug.cgi?id=1857737 Robert-André Mauchin changed: What|Removed |Added Status|NEW |CLOSED CC||zebo...@gmail.com Resolution|--- |DUPLICATE Last Closed||2020-07-18 15:04:44 --- Comment #1 from Robert-André Mauchin --- Package already exists: https://src.fedoraproject.org/rpms/rust-autocfg *** This bug has been marked as a duplicate of bug 1664161 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857740] Review Request: rust-num-bigint-dig - Big integer implementation for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1857740 Bug 1857740 depends on bug 1857737, which changed state. Bug 1857737 Summary: Review Request: rust-autocfg - Automatic cfg for Rust compiler features https://bugzilla.redhat.com/show_bug.cgi?id=1857737 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857747] Review Request: golang-uber-goleak - Goroutine leak detector
https://bugzilla.redhat.com/show_bug.cgi?id=1857747 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Hey thanks for this package - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858193] Review Request: golang-github-tomnomnom-linkheader - Golang HTTP Link header parser
https://bugzilla.redhat.com/show_bug.cgi?id=1858193 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858413] Review Request: mm - File system based matrix client
https://bugzilla.redhat.com/show_bug.cgi?id=1858413 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858486] Review Request: rust-zeroize - Securely clear secrets from memory
https://bugzilla.redhat.com/show_bug.cgi?id=1858486
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- Please include the license with %license in %files:
%files devel
%license LICENSE-MIT
%doc README.md
%{cargo_registry}/%{crate}-%{version_no_tilde}/
- Bother upstream for the LICENSE-APACHE file as well:
https://github.com/iqlusioninc/crates/issues/475
- Package is not installable:
DEBUG util.py:621: Error:
DEBUG util.py:621: Problem: conflicting requests
DEBUG util.py:621:- nothing provides (crate(zeroize_derive/default) >=
1.0.0 with crate(zeroize_derive/default) < 2.0.0) needed by
rust-zeroize+zeroize_derive-devel-1.1.0-1.fc33.noarch
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1350884] Review Request: mspgcc - Rebase of GCC for the MSP430 to TI / Red Hat upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1350884
--- Comment #24 from Andy Mender ---
> Some of the URLs have moved slightly (or were maybe wrong from the
> beginning), those will be fixed in the next revision.
I managed to find the latest sources here:
http://software-dl.ti.com/msp430/msp430_public_sw/mcu/msp430/MSPGCC/9_2_0_0/export/msp430-gcc-9.2.0.50-source-full.tar.bz2
I think one of your %global definitions should be:
%global ti_version_number 9_2_0_0
instead of:
%global ti_version_number 9_2_0_00
And the URL block should be a little different.
> The documentation for packaging cross compilers[0] states "All
> cross-compilers should add --prefix=/usr/arch-os-libc to ./configure when
> building the toolchain. This is according to the cross-compiling guidelines
> in GCC's INSTALL document." I cannot find this guideline in the GCC
> documentation[1]. I can do this of course, but it results in
> /usr/msp430-elf/bin, /usr/msp430-elf/lib, etc... I have experimented with
> this, and with symlinking the resulting binaries into /usr/bin (as noted in
> the Fedora documentation), the compiler works as expected.
I would stick to the official Fedora packaging docs in this case. I'm not sure
why avr-gcc uses `--prefix=%{_prefix}`, but the docs you linked also mention
avr-gcc is a bit of a special case. Unfortunately, I don't have much experience
with packaging compilers.
> So, I count 3 paths forward:
>
> 1: Specify prefix as per Fedora guidelines
> 2: Try to match avr-gcc, with everything going roughly where I would expect,
> binaries in /usr/bin, library files in /usr/lib/gcc/avr, etc...
> 3: The terrible hybrid I've done in all the builds above, with binaries going
> in /usr/bin, libraries and include files mostly going in /usr/msp430-elf/lib,
> but some going in /usr/lib...
I would go with 1. in this case. Putting everything into a prefixed dir inside
`/usr` (`/usr/msp430-elf`, for instance) and then symlinking seems like a
cleaner and better self-contained approach than symlinking some of the files
and directly putting the rest into regular directories.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858487] Review Request: rust-keccak - Keccak-f sponge function
https://bugzilla.redhat.com/show_bug.cgi?id=1858487 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - Bother upstream for a license file. Please not that there is a bug report asking for a license change to MIT/ASL 2.0 - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503 Andy Mender changed: What|Removed |Added CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
