[Bug 1118960] Review Request: perl-Clone-PP - Recursively copy Perl data-types
https://bugzilla.redhat.com/show_bug.cgi?id=1118960 David Dick dd...@cpan.org changed: What|Removed |Added Blocks|182235 (FE-Legal) | --- Comment #6 from David Dick dd...@cpan.org --- Original author of these files has agreed to re-license, and upstream has shipped a new package reflecting the updated license. Many thanks to all involved. Spec URL: http://ddick.fedorapeople.org/packages/perl-Clone-PP.spec SRPM URL: http://ddick.fedorapeople.org/packages/perl-Clone-PP-1.06-1.fc20.src.rpm Ready for review again. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117463] Review Request: imgbased - Tools to work with an image based rootfs
https://bugzilla.redhat.com/show_bug.cgi?id=1117463 Fabian Deutsch fdeut...@redhat.com changed: What|Removed |Added Flags|needinfo?(dougsland@redhat. | |com)| --- Comment #12 from Fabian Deutsch fdeut...@redhat.com --- Move upstream spec into subdir, to prevent review-tools complains. Spec URL: https://raw.githubusercontent.com/fabiand/imgbased-spec/imgbased-0.1-0.7/imgbased.spec SRPM URL: http://fedorapeople.org/~fabiand/imgbased/imgbased-0.1-0.7.git20140721.bb25471.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121302] Review Request: perl-DateTime-Format-RFC3339 - Parse and format RFC3339 datetime strings
https://bugzilla.redhat.com/show_bug.cgi?id=1121302 David Dick dd...@cpan.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from David Dick dd...@cpan.org --- New Package SCM Request === Package Name: perl-DateTime-Format-RFC3339 Short Description: Parse and format RFC3339 datetime strings Upstream URL: http://search.cpan.org/dist/DateTime-Format-RFC3339/ Owners: ddick Branches: el6, epel7, f20, f21 InitialCC: perl-sig Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1118733] Review Request: perl-Retry - Retry Perl module
https://bugzilla.redhat.com/show_bug.cgi?id=1118733 David Dick dd...@cpan.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from David Dick dd...@cpan.org --- New Package SCM Request === Package Name: perl-Retry Short Description: Perl function wrapper providing exponential back-off and callbacks on failure Upstream URL: http://search.cpan.org/dist/Retry/ Owners: ddick Branches: f20, f21 InitialCC: perl-sig Thanks again! Agreed on the summary. Have updated it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055378] Review Request: icinga - Open Source host, service and network monitoring program
https://bugzilla.redhat.com/show_bug.cgi?id=1055378 --- Comment #35 from Michael Scherer m...@zarb.org --- The spec file was not updated ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
https://bugzilla.redhat.com/show_bug.cgi?id=739416 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #18 from Robert Scheck red...@linuxnetz.de --- Package Change Request == Package Name: php-php-gettext New Branches: epel7 Owners: robert -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1114696] Review Request: repo_manager - Manage your RPM repositories easily
https://bugzilla.redhat.com/show_bug.cgi?id=1114696 Pierre-YvesChibon pin...@pingoured.fr changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Pierre-YvesChibon pin...@pingoured.fr --- Thanks a bunch for the review :) New Package SCM Request === Package Name: repo_manager Short Description: Manager your RPM repositories easily Upstream URL: https://github.com/pypingou/repo_manager Owners: pingou Branches: el6, epel7, f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121485] Review Request: adobe-source-han-sans-cn-fonts - An OpenType Pan-CJK Font Family For Simplified Chinese
https://bugzilla.redhat.com/show_bug.cgi?id=1121485 --- Comment #1 from Parag AN(पराग) panem...@gmail.com --- 1)I don't think readme.mkd is need to be installed. Please remove it 2) Summary can be = An OpenType Pan-CJK font family for Simplified Chinese 3) You can remove first line of %description 4) there is no reference to LICENSE.txt, if you want to add it then use upstream source link as https://github.com/adobe-fonts/source-han-sans/blob/master/LICENSE.txt 5) This is A sans-serif font so include only those rules and not to copy again for monospace or serif. Update the fontconfig file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111541] Review Request: ansifilter - ANSI terminal escape code converter
https://bugzilla.redhat.com/show_bug.cgi?id=541 Christopher Meng i...@cicku.me changed: What|Removed |Added Flags||needinfo?(jskarvad@redhat.c ||om) --- Comment #4 from Christopher Meng i...@cicku.me --- Fixed, I'd prepared but forgot to include the desktop file at the first time... NEW SPEC URL: http://us-la.cicku.me/ansifilter.spec NEW SRPM URL: http://us-la.cicku.me/ansifilter-1.8-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 515463] Review Request: cxxtest - A JUnit-like testing framework for C++
https://bugzilla.redhat.com/show_bug.cgi?id=515463 Martin Gieseking martin.giesek...@uos.de changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #15 from Martin Gieseking martin.giesek...@uos.de --- Package Change Request == Package Name: cxxtest New Branches: epel7 Owners: mgieseki InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121485] Review Request: adobe-source-han-sans-cn-fonts - Adobe OpenType Pan-CJK font family for Simplified Chinese
https://bugzilla.redhat.com/show_bug.cgi?id=1121485 Peng Wu p...@redhat.com changed: What|Removed |Added Summary|Review Request: |Review Request: |adobe-source-han-sans-cn-fo |adobe-source-han-sans-cn-fo |nts - An OpenType Pan-CJK |nts - Adobe OpenType |Font Family For Simplified |Pan-CJK font family for |Chinese |Simplified Chinese -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121566] New: Review Request: unidic - Morphological analysis dictionary for mecab
https://bugzilla.redhat.com/show_bug.cgi?id=1121566 Bug ID: 1121566 Summary: Review Request: unidic - Morphological analysis dictionary for mecab Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: i...@cicku.me QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://us-la.cicku.me/unidic.spec SRPM URL: http://us-la.cicku.me/unidic-2.1.2-1.fc22.src.rpm Description: Unidic is a morphological analysis dictionary for mecab. Fedora Account System Username: cicku -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1061801] Review Request: gmic - GREYC's Magic for Image Computing
https://bugzilla.redhat.com/show_bug.cgi?id=1061801 --- Comment #15 from Daniel Berrange berra...@redhat.com --- @Christopher could you approve this package finally. It has all the changes you've requested previously. I really want to get this into Fedora before yet another release comes out we have to waste more time going round in this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1061801] Review Request: gmic - GREYC's Magic for Image Computing
https://bugzilla.redhat.com/show_bug.cgi?id=1061801 Christopher Meng i...@cicku.me changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #16 from Christopher Meng i...@cicku.me --- I still hope you can get an exception from FESCo. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121580] New: Review Request: miniupnpd - UPnP IGD(Internet Gateway Device) daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1121580 Bug ID: 1121580 Summary: Review Request: miniupnpd - UPnP IGD(Internet Gateway Device) daemon Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: i...@cicku.me QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://us-la.cicku.me/miniupnpd.spec SRPM URL: http://us-la.cicku.me/miniupnpd-1.8.20140523-1.fc22.src.rpm Description: MiniUPnP daemon is an UPnP IGD (Internet Gateway Device) which provides NAT traversal services to any UPnP enabled client on the network. Fedora Account System Username: cicku -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117482] Review Request: python-inflect - Correctly generate plurals, singular nouns, ordinals and indefinite articles
https://bugzilla.redhat.com/show_bug.cgi?id=1117482
Julien Enselme juj...@jujens.eu changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||juj...@jujens.eu
Assignee|nob...@fedoraproject.org|juj...@jujens.eu
--- Comment #1 from Julien Enselme juj...@jujens.eu ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v3 or later), Unknown or generated. 26 files have unknown
license. Detailed output of licensecheck in
/run/media/jenselme/Data/1117482-python-inflect/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Requires correct, justified where necessary.
[!]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[X]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 184320 bytes in 6 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[X]: Python eggs must not download any dependencies during the build process.
[X]: A package which is used by another package via an egg interface should
provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[X]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-inflect
[X]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
translations for
[Bug 1119153] Review Request: perl-Dancer-Plugin-Auth-Extensible - Extensible authentication framework for Dancer apps
https://bugzilla.redhat.com/show_bug.cgi?id=1119153 David Dick dd...@cpan.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||dd...@cpan.org Assignee|nob...@fedoraproject.org|dd...@cpan.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847420] Review Request: perl-Date-Holidays-DE - Perl module to determine German holidays
https://bugzilla.redhat.com/show_bug.cgi?id=847420
Petr Pisar ppi...@redhat.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #5 from Petr Pisar ppi...@redhat.com ---
Spec file changes:
--- perl-Date-Holidays-DE.spec.old 2012-08-11 03:16:00.0 +0200
+++ perl-Date-Holidays-DE.spec 2014-07-19 01:28:06.0 +0200
@@ -6,13 +6,14 @@
Summary:Perl module to determine German holidays
Name: perl-Date-Holidays-DE
Version:1.6
-Release:1%{?dist}
+Release:2%{?dist}
License:MIT
Group: Development/Libraries
URL:http://search.cpan.org/dist/%{pkgname}/
Source:
http://search.cpan.org/CPAN/authors/id/M/MS/MSCHMITT/%{pkgname}-%{version}.tar.gz
Requires: perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`; echo
$version))
BuildRequires: perl(ExtUtils::MakeMaker), perl(Date::Calc) = 5.0
+BuildRequires: perl(Exporter), perl(Test), perl(Time::Local)
BuildArch: noarch
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
@@ -37,7 +38,7 @@
find $RPM_BUILD_ROOT \( -name perllocal.pod -o -name .packlist \) -exec rm -f
{} \;
chmod -R u+w $RPM_BUILD_ROOT/*
-# Don't add dependencies for %doc
+# Don't add dependencies for %%doc
chmod -x example/*.pl
%check
@@ -53,6 +54,9 @@
%{perl_vendorlib}/Date/Holidays/
%changelog
+* Sat Jul 19 2014 Robert Scheck rob...@fedoraproject.org 1.6-2
+- Changes to match with Fedora Packaging Guidelines (#847420)
+
* Sat Aug 11 2012 Robert Scheck rob...@fedoraproject.org 1.6-1
- Upgrade to 1.6 (#847420)
- Initial spec file for Fedora and Red Hat Enterprise Linux
TODO: Remove explicit %defattr from %files section.
Will not happen because of Fedora EPEL 5 and 6.
Not addressed.
Were did you get the macro is needed for EPEL5
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions?
TODO: Build-require `perl(Time::Local)' because the package can dual-live in
the future (DE.pm:7, http://search.cpan.org/~drolsky/Time-Local/).
TODO: Build-require `perl(Exporter)' because the package can dual-live in
the future (DE.pm:13, http://search.cpan.org/~toddr/Exporter/).
TODO: Build-require `perl(Test)' because the package can dual-live in the
future (test.pl:8, http://search.cpan.org/~sburke/Test/).
+BuildRequires: perl(Exporter), perl(Test), perl(Time::Local)
Ok.
FIX: Escape %doc in the comment with per-cent to prevent from rpm-evaluation.
-# Don't add dependencies for %doc
+# Don't add dependencies for %%doc
Ok.
TODO: Remove the `PREFIX=$RPM_BUILD_ROOT%{_prefix}' argument from
`perl Makefile.PL' command. It's not necessary.
Not addressed.
$ rpmlint perl-Date-Holidays-DE.spec
../SRPMS/perl-Date-Holidays-DE-1.6-2.fc22.src.rpm
../RPMS/noarch/perl-Date-Holidays-DE-1.6-2.fc22.noarch.rpm
perl-Date-Holidays-DE.spec:32: W: rpm-buildroot-usage %build perl Makefile.PL
PREFIX=$RPM_BUILD_ROOT%{_prefix} INSTALLDIRS=vendor
perl-Date-Holidays-DE.src: W: spelling-error %description -l en_US strftime -
trimmest
perl-Date-Holidays-DE.src:32: W: rpm-buildroot-usage %build perl Makefile.PL
PREFIX=$RPM_BUILD_ROOT%{_prefix} INSTALLDIRS=vendor
perl-Date-Holidays-DE.noarch: W: spelling-error %description -l en_US strftime
- trimmest
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.
Package builds in F22
(http://koji.fedoraproject.org/koji/taskinfo?taskID=7170924). Ok.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111541] Review Request: ansifilter - ANSI terminal escape code converter
https://bugzilla.redhat.com/show_bug.cgi?id=541
Jaroslav Škarvada jskar...@redhat.com changed:
What|Removed |Added
Status|ASSIGNED|MODIFIED
Flags|fedora-review? |fedora-review+
|needinfo?(jskarvad@redhat.c |
|om) |
--- Comment #5 from Jaroslav Škarvada jskar...@redhat.com ---
Giving fedora-review+.
Some other comments (not blocking the review):
I guess there is an typo in the comment:
# CLTR quickfix
should be probably
# CRLF quickfix
Also the conversion could be done by dos2unix tool, e.g.:
dos2unix src/{qt-gui/*,*}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester
https://bugzilla.redhat.com/show_bug.cgi?id=1103927 Christopher Meng i...@cicku.me changed: What|Removed |Added Flags|needinfo?(i...@cicku.me) | --- Comment #10 from Christopher Meng i...@cicku.me --- I want to test it against some real service... As I was sloppy on this review. I will approve tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119148] Review Request: perl-Daemon-Control - Create init scripts in Perl
https://bugzilla.redhat.com/show_bug.cgi?id=1119148 Jitka Plesnikova jples...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jples...@redhat.com QA Contact|extras...@fedoraproject.org |jples...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111541] Review Request: ansifilter - ANSI terminal escape code converter
https://bugzilla.redhat.com/show_bug.cgi?id=541 Christopher Meng i...@cicku.me changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Christopher Meng i...@cicku.me --- I will ask upstream to do that. Thanks! New Package SCM Request === Package Name: ansifilter Short Description: ANSI terminal escape code converter Upstream URL: http://www.andre-simon.de/doku/ansifilter/ansifilter.php Owners: cicku Branches: f19 f20 f21 el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847420] Review Request: perl-Date-Holidays-DE - Perl module to determine German holidays
https://bugzilla.redhat.com/show_bug.cgi?id=847420 --- Comment #6 from Robert Scheck redhat-bugzi...@linuxnetz.de --- (In reply to Petr Pisar from comment #5) TODO: Remove explicit %defattr from %files section. Will not happen because of Fedora EPEL 5 and 6. Not addressed. Were did you get the macro is needed for EPEL5 https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ Guidelines#File_Permissions? You are right. I will remove the macro after the git import (to allow the tracking/verification). Resolution: Package APPROVED. Thank you very much for the package review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847420] Review Request: perl-Date-Holidays-DE - Perl module to determine German holidays
https://bugzilla.redhat.com/show_bug.cgi?id=847420 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Robert Scheck red...@linuxnetz.de --- New Package SCM Request === Package Name: perl-Date-Holidays-DE Short Description: Perl module to determine German holidays Upstream URL: http://search.cpan.org/dist/Date-Holidays-DE/ Owners: robert Branches: f19 f20 f21 el5 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1118960] Review Request: perl-Clone-PP - Recursively copy Perl data-types
https://bugzilla.redhat.com/show_bug.cgi?id=1118960 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Petr Pisar ppi...@redhat.com --- URL and Source0 are usable. Ok. Source archive is original (SHA-256: 4ccf74174a83543787946e5c06a0b3c56f4b3bd29e21632f74d11ade30b9b7e7). Ok. Summary verified from lib/Clone/PP.pm. Ok. Description verified from lib/Clone/PP.pm. Ok. License verified from t/tied.pl, t/dump.pl, t/dclone.t, README, lib/Clone/PP.pm. Ok. No XS code, noarch BuildArch is Ok. All needed build-requires are declared. Ok. All tests pass. Ok. $ rpmlint perl-Clone-PP.spec ../SRPMS/perl-Clone-PP-1.06-1.fc22.src.rpm ../RPMS/noarch/perl-Clone-PP-1.06-1.fc22.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Clone-PP-1.06-1.fc22.noarch.rpm drwxr-xr-x2 rootroot0 Jul 21 12:13 /usr/share/doc/perl-Clone-PP -rw-r--r--1 rootroot 1065 Jul 20 21:06 /usr/share/doc/perl-Clone-PP/Changes -rw-r--r--1 rootroot 3204 Feb 15 11:09 /usr/share/doc/perl-Clone-PP/README -rw-r--r--1 rootroot 3420 Jul 21 12:13 /usr/share/man/man3/Clone::PP.3pm.gz drwxr-xr-x2 rootroot0 Jul 21 12:13 /usr/share/perl5/vendor_perl/Clone -rw-r--r--1 rootroot 6138 Jul 18 23:22 /usr/share/perl5/vendor_perl/Clone/PP.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Clone-PP-1.06-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl = 0:5.006 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Exporter) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) = 3.0.4-1 1 rpmlib(FileDigests) = 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 1 rpmlib(PayloadIsXz) = 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Clone-PP-1.06-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Clone::PP) = 1.06 1 perl-Clone-PP = 1.06-1.fc22 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Clone-PP-1.06-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7171211). Ok. Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121485] Review Request: adobe-source-han-sans-cn-fonts - Adobe OpenType Pan-CJK font family for Simplified Chinese
https://bugzilla.redhat.com/show_bug.cgi?id=1121485 --- Comment #2 from Peng Wu p...@redhat.com --- This new font is a candidate for default Simplified Chinese font, The fontconfig conf file is written as an default Simplified Chinese font. and for Chinese font, not different in sans or serif styles. The rest have been fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121485] Review Request: adobe-source-han-sans-cn-fonts - Adobe OpenType Pan-CJK font family for Simplified Chinese
https://bugzilla.redhat.com/show_bug.cgi?id=1121485 --- Comment #3 from Peng Wu p...@redhat.com --- Spec URL: http://pwu.fedorapeople.org/fonts/adobe-source-han-sans-cn-fonts/adobe-source-han-sans-cn-fonts.spec SRPM URL: http://pwu.fedorapeople.org/fonts/adobe-source-han-sans-cn-fonts/adobe-source-han-sans-cn-fonts-1.000-2.fc20.src.rpm Please review it again, thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119153] Review Request: perl-Dancer-Plugin-Auth-Extensible - Extensible authentication framework for Dancer apps
https://bugzilla.redhat.com/show_bug.cgi?id=1119153 --- Comment #1 from David Dick dd...@cpan.org --- The 'BR perl' can be added if you want Drop the perl(Mock::Quick) BR and RunTime, it does not appear to be used at all The perl(YAML) BR and RunTime can also be dropped BR perl(base) in lib/Dancer/Plugin/Auth/Extensible/Provider/Database.pm at line 4 BR perl(Dancer::Plugin::Database) in lib/Dancer/Plugin/Auth/Extensible/Provider/Database.pm at line 5 BR perl(Dancer::Plugin::Auth::Extensible) in t/lib/TestApp.pm at line 10 BR perl(Unix::Passwd::File) in lib/Dancer/Plugin/Auth/Extensible/Provider/Unix.pm at line 6 BR perl(Authen::Simple::PAM) in lib/Dancer/Plugin/Auth/Extensible/Provider/Unix.pm at line 5 BR perl(Dancer::Plugin) in lib/Dancer/Plugin/Auth/Extensible.pm at line 7 Looks like perl(Authen::Simple::PAM) and perl(Unix::Passwd::File) will need new review requests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1118960] Review Request: perl-Clone-PP - Recursively copy Perl data-types
https://bugzilla.redhat.com/show_bug.cgi?id=1118960 David Dick dd...@cpan.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from David Dick dd...@cpan.org --- New Package SCM Request === Package Name: perl-Clone-PP Short Description: Recursively copy Perl data-types Upstream URL: http://search.cpan.org/dist/Clone-PP/ Owners: ddick Branches: el6, epel7, f20, f21 InitialCC: perl-sig Thanks Petr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121601] New: Review Request: rt - request tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1121601 Bug ID: 1121601 Summary: Review Request: rt - request tracker Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rc040...@freenet.de QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://corsepiu.fedorapeople.org/packages/rt.spec SRPM URL: http://corsepiu.fedorapeople.org/packages/rt-4.0.21-1.fc22.src.rpm Description: RT is an enterprise-grade ticketing system which enables a group of people to intelligently and efficiently manage tasks, issues, and requests submitted by a community of users. Fedora Account System Username: corsepiu Notes: - This package is supposed to replace Fedora's current rt3 package for f21 and f22 (Upstream has abandoned and discontinued rt3). I do not intend to add this package to already released Fedoras (i.e. f19, f20 or epel). - This package's spec is modelled after rt3's spec file. It is more or less a rename and upgrade at once review request. - I am intentionally upgrading to rt-4.0.x and not to rt-4.2.x, because my experiences with rt-4.2 have not been positive, yet. However I intend to eventually upgrade (at least rawhide) to rt-4.2 in hopefully not too distant future. - The motivation to name rt rt3 in Fedora had been to allow parallel installation of packages from different rt-release series. This had worked with earlier rt-releases, but this plan has shown to be non-practical with newer rt-release. This has caused me to dropping this intention and to ship only one set of packages from one release series of rt at a time (Hence rt and not rt4). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119148] Review Request: perl-Daemon-Control - Create init scripts in Perl
https://bugzilla.redhat.com/show_bug.cgi?id=1119148 Jitka Plesnikova jples...@redhat.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|jples...@redhat.com QA Contact|jples...@redhat.com |extras...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119148] Review Request: perl-Daemon-Control - Create init scripts in Perl
https://bugzilla.redhat.com/show_bug.cgi?id=1119148 --- Comment #1 from Jitka Plesnikova jples...@redhat.com --- License is ok URL and Source0 are ok Build-requires are ok Summary and Description are ok Package builds in F22 - http://koji.fedoraproject.org/koji/taskinfo?taskID=7171134 $ rpm -qp --provides perl-Daemon-Control-0.001006-1.fc22.noarch.rpm | sort | uniq -c 1 perl(Daemon::Control) = 0.001006 1 perl-Daemon-Control = 0.001006-1.fc22 Binary provides ok $ rpm -qp --requires perl-Daemon-Control-0.001006-1.fc22.noarch.rpm | sort | uniq -c 1 perl = 0:5.008001 1 perl(:MODULE_COMPAT_5.18.2) 2 perl(Cwd) 1 perl(File::Path) 1 perl(File::Path) = 2.08 2 perl(File::Spec) 1 perl(POSIX) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) = 3.0.4-1 1 rpmlib(FileDigests) = 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 1 rpmlib(PayloadIsXz) = 5.2-1 FIX: remove from Requires perl(Cwd), perl(File::Spec) TODO: Filter unversioned perl(File::Path) from run-requires $ rpmlint ./perl-Daemon-Control* perl-Daemon-Control.noarch: W: spelling-error Summary(en_US) init - unit, int, nit perl-Daemon-Control.noarch: W: spelling-error %description -l en_US init - unit, int, nit perl-Daemon-Control.noarch: W: spelling-error %description -l en_US accessors - accessory, accessorizes, accessorize perl-Daemon-Control.src: W: spelling-error Summary(en_US) init - unit, int, nit perl-Daemon-Control.src: W: spelling-error %description -l en_US init - unit, int, nit perl-Daemon-Control.src: W: spelling-error %description -l en_US accessors - accessory, accessorizes, accessorize 2 packages and 1 specfiles checked; 0 errors, 6 warnings. Rpmlint is ok Otherwise package looks good. Please correct all `FIX' items, consider fixing `TODO' items, and provide new spec file. Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111360] Review Request: python-parse_type - Simplifies to build parse types based on the parse module
https://bugzilla.redhat.com/show_bug.cgi?id=360 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|ASSIGNED|POST CC|package-review@lists.fedora | |project.org | Flags|fedora-review? |fedora-review+ --- Comment #5 from Björn besser82 Esser bjoern.es...@gmail.com --- Bedides the unclarified license, there are no other issues. I watch the licensing issue filed with upstream on github. - Package approved !!! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121627] New: Review Request: perl-Data-Record - split on steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1121627 Bug ID: 1121627 Summary: Review Request: perl-Data-Record - split on steroids Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: dd...@cpan.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://ddick.fedorapeople.org/packages/perl-Data-Record.spec SRPM URL: http://ddick.fedorapeople.org/packages/perl-Data-Record-0.02-1.fc20.src.rpm Description: split on steroids Fedora Account System Username: ddick -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121627] Review Request: perl-Data-Record - split on steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1121627 --- Comment #1 from David Dick dd...@cpan.org --- koji builds rawhide at http://koji.fedoraproject.org/koji/taskinfo?taskID=7171648 el6 at http://koji.fedoraproject.org/koji/taskinfo?taskID=7171646 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111360] Review Request: python-parse_type - Simplifies to build parse types based on the parse module
https://bugzilla.redhat.com/show_bug.cgi?id=360 Matěj Cepl mc...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Matěj Cepl mc...@redhat.com --- New Package SCM Request === Package Name: python-parse_type Short Description: Simplifies to build parse types based on the parse module Upstream URL: http://pypi.python.org/pypi/parse_type Owners: mcepl Branches: f19 f20 f21 el6 epel7 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121627] Review Request: perl-Data-Record - split on steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1121627 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|NEW |ASSIGNED CC||i...@cicku.me Assignee|nob...@fedoraproject.org|i...@cicku.me -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 480859] Review Request: diffuse - graphical diff tool
https://bugzilla.redhat.com/show_bug.cgi?id=480859 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 480859] Review Request: diffuse - graphical diff tool
https://bugzilla.redhat.com/show_bug.cgi?id=480859 --- Comment #20 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 504478] Review Request: rubygem-diff-lcs - Provide a list of changes between two sequenced collections
https://bugzilla.redhat.com/show_bug.cgi?id=504478 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 504478] Review Request: rubygem-diff-lcs - Provide a list of changes between two sequenced collections
https://bugzilla.redhat.com/show_bug.cgi?id=504478 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 515463] Review Request: cxxtest - A JUnit-like testing framework for C++
https://bugzilla.redhat.com/show_bug.cgi?id=515463 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 515463] Review Request: cxxtest - A JUnit-like testing framework for C++
https://bugzilla.redhat.com/show_bug.cgi?id=515463 --- Comment #16 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 544964] Review Request: rubygem-mime-types - Return the MIME Content-Type for a given filename
https://bugzilla.redhat.com/show_bug.cgi?id=544964 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 544964] Review Request: rubygem-mime-types - Return the MIME Content-Type for a given filename
https://bugzilla.redhat.com/show_bug.cgi?id=544964 --- Comment #22 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 559856] Review Request: libbsd - Library providing BSD-compatible functions for portability
https://bugzilla.redhat.com/show_bug.cgi?id=559856 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 559856] Review Request: libbsd - Library providing BSD-compatible functions for portability
https://bugzilla.redhat.com/show_bug.cgi?id=559856 --- Comment #30 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 616779] Review Request: rubygem-json_pure - JSON implementation in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=616779 --- Comment #32 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 616779] Review Request: rubygem-json_pure - JSON implementation in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=616779 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
https://bugzilla.redhat.com/show_bug.cgi?id=739416 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
https://bugzilla.redhat.com/show_bug.cgi?id=739416 --- Comment #19 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719047] Review Request: rubygem-vcr - Record test suite HTTP interactions and replay during future test runs
https://bugzilla.redhat.com/show_bug.cgi?id=719047 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719047] Review Request: rubygem-vcr - Record test suite HTTP interactions and replay during future test runs
https://bugzilla.redhat.com/show_bug.cgi?id=719047 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801439] Review Request: rubygem-netrc - Library to read and write netrc files
https://bugzilla.redhat.com/show_bug.cgi?id=801439 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801439] Review Request: rubygem-netrc - Library to read and write netrc files
https://bugzilla.redhat.com/show_bug.cgi?id=801439 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847420] Review Request: perl-Date-Holidays-DE - Perl module to determine German holidays
https://bugzilla.redhat.com/show_bug.cgi?id=847420 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1116021] Review Request: rubygem-ruby-prof - a fast ruby profiler
https://bugzilla.redhat.com/show_bug.cgi?id=1116021 --- Comment #3 from Steve Traylen steve.tray...@cern.ch --- Thanks for taking a look. Spec URL: http://cern.ch/straylen/rpms/rubygem-ruby-prof/rubygem-ruby-prof.spec SRPM URL: http://cern.ch/straylen/rpms/rubygem-ruby-prof/rubygem-ruby-prof-0.15.1-2.fc20.src.rpm addresses all your comments above with the exception of adding man pages. The commands have --help support which is enough I would say. As for the licensing it's clearly meant to be BSD indeed , I've added a comment highlighting the discrepancy with rubygems.org which should hopefully fix at some time. Only other change was I deleted a duplicate copy of arch depedendent .so file incorrectly in /usr/share. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847420] Review Request: perl-Date-Holidays-DE - Perl module to determine German holidays
https://bugzilla.redhat.com/show_bug.cgi?id=847420 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1086447] Review Request: kf5 - Filesystem ownership and RPM macros for KF5 packages
https://bugzilla.redhat.com/show_bug.cgi?id=1086447 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1086447] Review Request: kf5 - Filesystem ownership and RPM macros for KF5 packages
https://bugzilla.redhat.com/show_bug.cgi?id=1086447 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1105015] Review Request: lua-ldap - LDAP client library for Lua
https://bugzilla.redhat.com/show_bug.cgi?id=1105015 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1105015] Review Request: lua-ldap - LDAP client library for Lua
https://bugzilla.redhat.com/show_bug.cgi?id=1105015 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111360] Review Request: python-parse_type - Simplifies to build parse types based on the parse module
https://bugzilla.redhat.com/show_bug.cgi?id=360 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111360] Review Request: python-parse_type - Simplifies to build parse types based on the parse module
https://bugzilla.redhat.com/show_bug.cgi?id=360 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111541] Review Request: ansifilter - ANSI terminal escape code converter
https://bugzilla.redhat.com/show_bug.cgi?id=541 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111541] Review Request: ansifilter - ANSI terminal escape code converter
https://bugzilla.redhat.com/show_bug.cgi?id=541 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1095895] Review Request: rubygem-rubyntlm - Ruby NTLM Authentication Library
https://bugzilla.redhat.com/show_bug.cgi?id=1095895 Steve Traylen steve.tray...@cern.ch changed: What|Removed |Added Status|NEW |ASSIGNED CC||steve.tray...@cern.ch Assignee|nob...@fedoraproject.org|steve.tray...@cern.ch Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1114696] Review Request: repo_manager - Manage your RPM repositories easily
https://bugzilla.redhat.com/show_bug.cgi?id=1114696 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1114696] Review Request: repo_manager - Manage your RPM repositories easily
https://bugzilla.redhat.com/show_bug.cgi?id=1114696 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111673] Review Request: kdelibs-webkit - KDE WebKit support library
https://bugzilla.redhat.com/show_bug.cgi?id=673 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111673] Review Request: kdelibs-webkit - KDE WebKit support library
https://bugzilla.redhat.com/show_bug.cgi?id=673 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1118733] Review Request: perl-Retry - Retry Perl module
https://bugzilla.redhat.com/show_bug.cgi?id=1118733 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1118960] Review Request: perl-Clone-PP - Recursively copy Perl data-types
https://bugzilla.redhat.com/show_bug.cgi?id=1118960 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1118960] Review Request: perl-Clone-PP - Recursively copy Perl data-types
https://bugzilla.redhat.com/show_bug.cgi?id=1118960 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120543] Review Request: php-ocramius-lazy-map - Lazy instantiation logic for a map of objects
https://bugzilla.redhat.com/show_bug.cgi?id=1120543 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120543] Review Request: php-ocramius-lazy-map - Lazy instantiation logic for a map of objects
https://bugzilla.redhat.com/show_bug.cgi?id=1120543 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120563] Review Request: php-ocramius-instantiator - Instantiate objects in PHP without invoking their constructors
https://bugzilla.redhat.com/show_bug.cgi?id=1120563 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120563] Review Request: php-ocramius-instantiator - Instantiate objects in PHP without invoking their constructors
https://bugzilla.redhat.com/show_bug.cgi?id=1120563 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1095895] Review Request: rubygem-rubyntlm - Ruby NTLM Authentication Library
https://bugzilla.redhat.com/show_bug.cgi?id=1095895
--- Comment #1 from Steve Traylen steve.tray...@cern.ch ---
Hi,
##
Could you update to latest guidelines.
In particualar the
Requires: ruby(release)
Requires: ruby(rubygems)
Provides: rubygem(%{gem_name}) = %{version}
is not needed for fc21
##
rubygem(simplecov) is now available so maybe add this
back into the tests.
##
$ rpmlint ../SRPMS/rubygem-rubyntlm-0.4.0-1.fc20.src.rpm
rubygem-rubyntlm.src: W: strange-permission rubyntlm-0.4.0.gem 0444L
easy enough to clean up.
#
$ rpmlint ../RPMS/noarch/rubygem-rubyntlm-*
rubygem-rubyntlm-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/gems/gems/rubyntlm-0.4.0/examples/smtp.rb
rubygem-rubyntlm-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/gems/gems/rubyntlm-0.4.0/examples/http.rb
rubygem-rubyntlm-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/gems/gems/rubyntlm-0.4.0/examples/imap.rb
rubygem-rubyntlm-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/gems/gems/rubyntlm-0.4.0/README.md
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
#
Other than that all seems good, the licensing is good and clear.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121302] Review Request: perl-DateTime-Format-RFC3339 - Parse and format RFC3339 datetime strings
https://bugzilla.redhat.com/show_bug.cgi?id=1121302 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121302] Review Request: perl-DateTime-Format-RFC3339 - Parse and format RFC3339 datetime strings
https://bugzilla.redhat.com/show_bug.cgi?id=1121302 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121358] Review Request: xmlrpc-epi - An implementation of the XML-RPC protocol in C
https://bugzilla.redhat.com/show_bug.cgi?id=1121358 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121358] Review Request: xmlrpc-epi - An implementation of the XML-RPC protocol in C
https://bugzilla.redhat.com/show_bug.cgi?id=1121358 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055378] Review Request: icinga - Open Source host, service and network monitoring program
https://bugzilla.redhat.com/show_bug.cgi?id=1055378 --- Comment #36 from Shawn Starr shawn.st...@rogers.com --- Sure is? its 1.11.5-2 now, check %changelog info -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117463] Review Request: imgbased - Tools to work with an image based rootfs
https://bugzilla.redhat.com/show_bug.cgi?id=1117463 --- Comment #13 from Fabian Deutsch fdeut...@redhat.com --- Another respin to pickup a sane sourcefile (passing travis again) Spec URL: https://raw.githubusercontent.com/fabiand/imgbased-spec/imgbased-0.1-0.8/imgbased.spec SRPM URL: http://fedorapeople.org/~fabiand/imgbased/imgbased-0.1-0.8.git20140721.71b82f3.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855780] Review Request: apacheds-daemon - Reusable Daemon Framework
https://bugzilla.redhat.com/show_bug.cgi?id=855780 Christopher Meng i...@cicku.me changed: What|Removed |Added Flags||needinfo?(mizdebsk@redhat.c ||om) -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121601] Review Request: rt - request tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1121601
David Nichols da...@qore.org changed:
What|Removed |Added
CC||da...@qore.org
--- Comment #1 from David Nichols da...@qore.org ---
HI, this is an informal review
fedora-review was not able to find the following files:
INFO: No upstream for (Source3): rt.conf.in
INFO: No upstream for (Source1): README.tests
INFO: No upstream for (Source4): README.fedora.in
INFO: No upstream for (Source5): rt.logrotate.in
so I was not able to check them with the build (note that there is no Source2).
and here is the annotated output of fedora-review:
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 202 files have unknown license. Detailed output
of licensecheck in /export/home/dnichols/fr/review-rt/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
the rt-tests and perl-RT-Test packages don't contain the license file, but they
are test packages, and since this is based on the already-approved rt3 package,
I assume that this is OK.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/logrotate.d,
/usr/libexec/perl5-tests
these are OK:
https://fedoraproject.org/wiki/User:Johannbg/Packaging/LogFiles
also the perl5-tests directory is a shared directory designed using macros in
the spec file
[ ]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/perl5/vendor_perl/RT/Interface/Web(rt3),
/usr/share/perl5/vendor_perl/RT/Shredder/Plugin/Base(rt3),
/usr/share/perl5/vendor_perl/RT/Interface/Web/QueryBuilder(rt3),
/usr/share/perl5/vendor_perl/RT/Condition(rt3),
/usr/share/perl5/vendor_perl/RT/Crypt(rt3),
/usr/share/perl5/vendor_perl/RT/Interface/Email(perl-RT-Extension-
CommandByMail, rt3), /usr/share/perl5/vendor_perl/RT/Approval/Rule(rt3),
/usr/share/perl5/vendor_perl/RT/Graph(rt3),
/usr/share/perl5/vendor_perl/RT/Interface(perl-RT-Extension-
CommandByMail, rt3), /usr/share/perl5/vendor_perl/RT/Approval(rt3),
/usr/share/perl5/vendor_perl/RT/Interface/Email/Auth(rt3),
/usr/share/perl5/vendor_perl/RT/Shredder/Plugin(rt3),
/usr/share/perl5/vendor_perl/RT/Search(rt3),
/usr/share/perl5/vendor_perl/RT/I18N(rt3),
/usr/share/perl5/vendor_perl/RT/Shredder(rt3),
/usr/share/perl5/vendor_perl/RT/CustomFieldValues(rt3),
/usr/share/perl5/vendor_perl/RT/Report(rt3),
/usr/share/perl5/vendor_perl/RT/URI(rt3),
/usr/share/perl5/vendor_perl/RT/Report/Tickets(rt3),
/usr/share/perl5/vendor_perl/RT/Action(rt3),
/usr/share/perl5/vendor_perl/RT(perl-RT-Client-REST, perl-RT-Test, perl-
RT-Extension-CommandByMail, perl-RT-Authen-ExternalAuth, rt3)
rt replaces rt3, so these are OK
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
rt.spec:
Obsoletes: rt3 %{version}-%{release}
I understand that it's better to hardcode the version in the Obsoletes line -
to quote a more experienced fedora reviewer (Michael Schwendt): typically one
hardcodes a specific maximum version-release in the Obsoletes tag to be really
accurate and not obsolete more than necessary (e.g. if %version increments, the
Obsoletes tag would adjust and also obsolete newer versions than what had been
specified originally).
Therefore maybe this should be
Obsoletes: rt3 4.0.21
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 931840 bytes in 39 files.
[x]:
[Bug 1111691] Review Request: qore - multithreaded programming/scripting language
https://bugzilla.redhat.com/show_bug.cgi?id=691 --- Comment #32 from David Nichols da...@qore.org --- another informal review: https://bugzilla.redhat.com/show_bug.cgi?id=1121601#c1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985129] Review Request: text2nato - text converter to nato phonetic alphabet
https://bugzilla.redhat.com/show_bug.cgi?id=985129 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|NEW |CLOSED Blocks||201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Flags|needinfo?(mind...@gmail.com | |) | Last Closed||2014-07-21 09:33:19 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119117] Review Request: perl-Algorithm-Cron - Abstract implementation of the cron(8) scheduling algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1119117 Jitka Plesnikova jples...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jples...@redhat.com Assignee|nob...@fedoraproject.org|jples...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 --- Comment #4 from Marcel Wysocki m...@satgnu.net --- Update: * Mon Jul 21 2014 maci m...@satgnu.net - 2.0.0-3 - Fix homepage URL Spec URL: https://rawgit.com/maci0/rpmbuild/master/SPECS/mingw-SDL2_mixer.spec SRPM URL: https://rawgit.com/maci0/rpmbuild/master/SRPMS/mingw-SDL2_mixer-2.0.0-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096807] Review Request: mingw-SDL2_image - MinGW Windows port of the Image loading library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1096807 --- Comment #5 from Marcel Wysocki m...@satgnu.net --- Update: * Mon Jul 21 2014 maci m...@satgnu.net - 2.0.0-3 - Fix homepage URL Spec URL: https://rawgit.com/maci0/rpmbuild/master/SPECS/mingw-SDL2_image.spec SRPM URL: https://rawgit.com/maci0/rpmbuild/master/SRPMS/mingw-SDL2_image-2.0.0-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117482] Review Request: python-inflect - Correctly generate plurals, singular nouns, ordinals and indefinite articles
https://bugzilla.redhat.com/show_bug.cgi?id=1117482 --- Comment #2 from David Shea ds...@redhat.com --- I guess that'll teach me to copy and paste a description without looking at it. Spec URL: http://dshea.fedorapeople.org/python-inflect/0.2.4-3/python-inflect.spec SRPM URL: http://dshea.fedorapeople.org/python-inflect/0.2.4-3/python-inflect-0.2.4-3.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120543] Review Request: php-ocramius-lazy-map - Lazy instantiation logic for a map of objects
https://bugzilla.redhat.com/show_bug.cgi?id=1120543 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- php-ocramius-lazy-map-1.0.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-ocramius-lazy-map-1.0.0-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120543] Review Request: php-ocramius-lazy-map - Lazy instantiation logic for a map of objects
https://bugzilla.redhat.com/show_bug.cgi?id=1120543 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120543] Review Request: php-ocramius-lazy-map - Lazy instantiation logic for a map of objects
https://bugzilla.redhat.com/show_bug.cgi?id=1120543 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- php-ocramius-lazy-map-1.0.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/php-ocramius-lazy-map-1.0.0-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120543] Review Request: php-ocramius-lazy-map - Lazy instantiation logic for a map of objects
https://bugzilla.redhat.com/show_bug.cgi?id=1120543 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- php-ocramius-lazy-map-1.0.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-ocramius-lazy-map-1.0.0-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 David King amigad...@amigadave.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from David King amigad...@amigadave.com --- The updated spec seems fine to me. The SRPM has not been updated, however (it is still the -2), but that seems like a typo, as using a -3 in the URL instead works fine. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117438] Review Request: php-horde-Horde-CssMinify - CSS Minification
https://bugzilla.redhat.com/show_bug.cgi?id=1117438
Haïkel Guémar karlthe...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||karlthe...@gmail.com
Assignee|nob...@fedoraproject.org|karlthe...@gmail.com
Flags||fedora-review+
--- Comment #3 from Haïkel Guémar karlthe...@gmail.com ---
Since this package complies with Fedora general and PHP specific guidelines, I
hereby approve it into Fedora Packages Collection. Please go forward with the
scm request.
I took packager comments into account, I have full confidence that Remi will
cleanup thel EL-5 after import
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 3 files have unknown license. Detailed output of
licensecheck in /home/haikel/1117438-php-horde-Horde-
CssMinify/licensecheck.txt
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[ ]: Sources contain only permissible code or content.
[ ]: Each %files section contains %defattr if rpm 4.4
Note: %defattr present but not needed
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: Buildroot is not present
Note: Buildroot: present but not needed
[ ]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|i...@cicku.me -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
