[Bug 1149390] New: Review Request: dnfdaemon - Dbus daemon for dnf package actions
https://bugzilla.redhat.com/show_bug.cgi?id=1149390 Bug ID: 1149390 Summary: Review Request: dnfdaemon - Dbus daemon for dnf package actions Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: t...@rasmil.dk QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: spec info here SRPM URL: https://github.com/timlau/dnf-daemon/releases/download/dnfdaemon-0.3.1-1/dnfdaemon-0.3.1-1.fc21.src.rpm Description: Dbus daemon for dnf package actions Fedora Account System Username: timlau -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149390] Review Request: dnfdaemon - Dbus daemon for dnf package actions
https://bugzilla.redhat.com/show_bug.cgi?id=1149390 --- Comment #1 from Tim Lauridsen t...@rasmil.dk --- Spec URL: https://github.com/timlau/dnf-daemon/blob/master/dnfdaemon.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149391] New: Review Request: vdr-skindesigner - A VDR skinning engine that displays XML based Skins
https://bugzilla.redhat.com/show_bug.cgi?id=1149391 Bug ID: 1149391 Summary: Review Request: vdr-skindesigner - A VDR skinning engine that displays XML based Skins Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mgans...@alice.de QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vdr-skindesigner.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vdr-skindesigner-0.0.1-1.20141004git688ad96.fc20.src.rpm Description: SkinDesigner is a powerfull tool to create VDR Skins based on Skindesigner specific XML Code. The following documentation shows the SkinDesigner internals so that new Skinners get easily an overview how Skindesigner works. Hopefully all your open questions are answerd, if not, feel free to ask in VDR Portal. Fedora Account System Username: martinkg # rpmlint vdr-skindesigner-0.0.1-1.20141004git688ad96.fc20.x86_64.rpm vdr-skindesigner.x86_64: W: spelling-error %description -l en_US powerfull - powerful, powerfully, power full vdr-skindesigner.x86_64: W: spelling-error %description -l en_US answerd - answers, answer, answered 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # rpmlint vdr-skindesigner-debuginfo-0.0.1-1.20141004git688ad96.fc20.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # rpmlint vdr-skindesigner-0.0.1-1.20141004git688ad96.fc20.src.rpm vdr-skindesigner.src: W: spelling-error %description -l en_US powerfull - powerful, powerfully, power full vdr-skindesigner.src: W: spelling-error %description -l en_US answerd - answers, answer, answered 1 packages and 0 specfiles checked; 0 errors, 2 warnings. %changelog * Sat Oct 04 2014 Martin Gansser marti...@fedoraproject.org - 0.0.1-1.20141004git688ad96 - Initial build -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149390] Review Request: dnfdaemon - Dbus daemon for dnf package actions
https://bugzilla.redhat.com/show_bug.cgi?id=1149390 Tim Lauridsen t...@rasmil.dk changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149390] Review Request: dnfdaemon - Dbus daemon for dnf package actions
https://bugzilla.redhat.com/show_bug.cgi?id=1149390 Tim Lauridsen t...@rasmil.dk changed: What|Removed |Added Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149390] Review Request: dnfdaemon - Dbus daemon for dnf package actions
https://bugzilla.redhat.com/show_bug.cgi?id=1149390 Denis Fateyev de...@fateyev.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||de...@fateyev.com Assignee|nob...@fedoraproject.org|de...@fateyev.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149391] Review Request: vdr-skindesigner - A VDR skinning engine that displays XML based Skins
https://bugzilla.redhat.com/show_bug.cgi?id=1149391 MartinKG mgans...@alice.de changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2014-10-04 08:38:25 --- Comment #1 from MartinKG mgans...@alice.de --- closed ticket, because package belongs to rpmfusion, due vdr-softhddevice dependencies. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 582864] Review Request: qtlockedfile - QFile extension with advisory locking functions
https://bugzilla.redhat.com/show_bug.cgi?id=582864 Fabio Alessandro Locati fabioloc...@gmail.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #20 from Fabio Alessandro Locati fabioloc...@gmail.com --- epel7 is already done. sorry for the wrong copypaste -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581220] Review Request: qtsingleapplication - Qt library to start applications only once per user
https://bugzilla.redhat.com/show_bug.cgi?id=581220 Fabio Alessandro Locati fabioloc...@gmail.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #32 from Fabio Alessandro Locati fabioloc...@gmail.com --- epel7 is already done. sorry for the wrong copypaste -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577601] Review Request: libqxt - Qt extension library
https://bugzilla.redhat.com/show_bug.cgi?id=577601 Fabio Alessandro Locati fabioloc...@gmail.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #21 from Fabio Alessandro Locati fabioloc...@gmail.com --- Sorry for the comment #19, copypaste error :( -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1147269] Review Request: GeographicLib - Library for geographic coordinate transformations
https://bugzilla.redhat.com/show_bug.cgi?id=1147269 --- Comment #2 from Rich Mattes richmat...@gmail.com --- Thanks for taking a look. I've updated the spec based on the issues you pointed out, and did a little more cleanup for rpmlint purposes. You can find the new version here: Spec URL: https://rmattes.fedorapeople.org/RPMS/GeographicLib/GeographicLib.spec SRPM URL: https://rmattes.fedorapeople.org/RPMS/GeographicLib/GeographicLib-1.38-1.fc21.src.rpm scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7763309 rpmlint: $ rpmlint ../RPMS/x86_64/GeographicLib-* ../RPMS/noarch/*GeographicLib* ./GeographicLib.spec GeographicLib.x86_64: W: spelling-error %description -l en_US geoid - gelid, geode GeographicLib.x86_64: W: spelling-error %description -l en_US nanometers - manometers, anemometers, galvanometers GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-gravity.8.gz 11: warning: macro `Vb' not defined GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-gravity.8.gz 13: warning: macro `Ve' not defined GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-gravity.8.gz 16: warning: macro `C`' not defined GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-gravity.8.gz 16: warning: macro `C'' not defined GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-geoids.8.gz 11: warning: macro `Vb' not defined GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-geoids.8.gz 13: warning: macro `Ve' not defined GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-geoids.8.gz 16: warning: macro `C`' not defined GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-geoids.8.gz 16: warning: macro `C'' not defined GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-magnetic.8.gz 11: warning: macro `Vb' not defined GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-magnetic.8.gz 13: warning: macro `Ve' not defined GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-magnetic.8.gz 16: warning: macro `C`' not defined GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-magnetic.8.gz 16: warning: macro `C'' not defined GeographicLib-devel.x86_64: W: only-non-binary-in-usr-lib GeographicLib-devel.x86_64: W: no-documentation GeographicLib-doc.noarch: W: spelling-error %description -l en_US doxygen - oxygen, d oxygen 5 packages and 1 specfiles checked; 0 errors, 17 warnings. This version of the package adds 3 generated manpages (the three missing manpages from the rpmlint output in the original release.) It looks like the generator script includes a few macros that aren't defined, I'm not sure I know enough about what the author was trying to do to fix them. The rest of the warnings are false positives as far as I can see. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1147269] Review Request: GeographicLib - Library for geographic coordinate transformations
https://bugzilla.redhat.com/show_bug.cgi?id=1147269
Florian der-flo Lehner d...@der-flo.net changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from Florian der-flo Lehner d...@der-flo.net ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later), Unknown or generated.
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/cmake(cmake),
/usr/share/cmake/Modules(cmake)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires:
[Bug 1149407] New: Review Request: rOCCI-server - Ruby OCCI Server
https://bugzilla.redhat.com/show_bug.cgi?id=1149407 Bug ID: 1149407 Summary: Review Request: rOCCI-server - Ruby OCCI Server Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: val...@civ.zcu.cz QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://scientific.zcu.cz/fedora/rOCCI-server-1.0.5-1/rOCCI-server.spec SRPM URL: http://scientific.zcu.cz/fedora/rOCCI-server-1.0.5-1/rOCCI-server-1.0.5-1.fc22.src.rpm Description: OCCI (the Open Cloud Computing Interface) is a standard by the Open Grid Forum, specifying a protocol and API to perform various remote management tasks in clouds. The rOCCI-server extends cloud managers, which are not OCCI-compliant natively, with its own OCCI interface. It is based on the rOCCI (Ruby OCCI) Framework. Fedora Account System Username: valtri koji build: http://scientific.zcu.cz/fedora/rOCCI-server-1.0.5-1/koji.txt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1132008] Review Request: rubygem-openssl_cms - OpenSSL with CMS functions
https://bugzilla.redhat.com/show_bug.cgi?id=1132008 František Dvořák val...@civ.zcu.cz changed: What|Removed |Added Blocks||1149407 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1149407 [Bug 1149407] Review Request: rOCCI-server - Ruby OCCI Server -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149407] Review Request: rOCCI-server - Ruby OCCI Server
https://bugzilla.redhat.com/show_bug.cgi?id=1149407 František Dvořák val...@civ.zcu.cz changed: What|Removed |Added Depends On||1142497, 1138455, 1135502, ||1132008 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1132008 [Bug 1132008] Review Request: rubygem-openssl_cms - OpenSSL with CMS functions https://bugzilla.redhat.com/show_bug.cgi?id=1135502 [Bug 1135502] Review Request: rubygem-rack-cors - Middleware for enabling Cross-Origin Resource Sharing in Rack apps https://bugzilla.redhat.com/show_bug.cgi?id=1138455 [Bug 1138455] Review Request: rubygem-occi-core - OCCI toolkit https://bugzilla.redhat.com/show_bug.cgi?id=1142497 [Bug 1142497] Review Request: rubygem-opennebula - OpenNebula Client API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142497] Review Request: rubygem-opennebula - OpenNebula Client API
https://bugzilla.redhat.com/show_bug.cgi?id=1142497 František Dvořák val...@civ.zcu.cz changed: What|Removed |Added Blocks||1149407 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1149407 [Bug 1149407] Review Request: rOCCI-server - Ruby OCCI Server -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138455] Review Request: rubygem-occi-core - OCCI toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1138455 František Dvořák val...@civ.zcu.cz changed: What|Removed |Added Blocks||1149407 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1149407 [Bug 1149407] Review Request: rOCCI-server - Ruby OCCI Server -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135502] Review Request: rubygem-rack-cors - Middleware for enabling Cross-Origin Resource Sharing in Rack apps
https://bugzilla.redhat.com/show_bug.cgi?id=1135502 František Dvořák val...@civ.zcu.cz changed: What|Removed |Added Blocks||1149407 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1149407 [Bug 1149407] Review Request: rOCCI-server - Ruby OCCI Server -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149410] New: Review Request: rubygem-aws-sdk-core - AWS SDK for Ruby - Core
https://bugzilla.redhat.com/show_bug.cgi?id=1149410 Bug ID: 1149410 Summary: Review Request: rubygem-aws-sdk-core - AWS SDK for Ruby - Core Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: val...@civ.zcu.cz QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://scientific.zcu.cz/fedora/rubygem-aws-sdk-core-2.0.1-1/rubygem-aws-sdk-core.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-aws-sdk-core-2.0.1-1/rubygem-aws-sdk-core-2.0.1-1.fc22.src.rpm Description: Provides API clients for AWS. Fedora Account System Username: valtri koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7764147 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1143021] Review Request: rubygem-jamespath - JMESpath declarative object searching
https://bugzilla.redhat.com/show_bug.cgi?id=1143021 František Dvořák val...@civ.zcu.cz changed: What|Removed |Added Blocks||1149410 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1149410 [Bug 1149410] Review Request: rubygem-aws-sdk-core - AWS SDK for Ruby - Core -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149410] Review Request: rubygem-aws-sdk-core - AWS SDK for Ruby - Core
https://bugzilla.redhat.com/show_bug.cgi?id=1149410 František Dvořák val...@civ.zcu.cz changed: What|Removed |Added Depends On||1143021 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1143021 [Bug 1143021] Review Request: rubygem-jamespath - JMESpath declarative object searching -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1147269] Review Request: GeographicLib - Library for geographic coordinate transformations
https://bugzilla.redhat.com/show_bug.cgi?id=1147269 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Rich Mattes richmat...@gmail.com --- Thanks for the review! New Package SCM Request === Package Name: GeographicLib Short Description: Library for geographic coordinate transformations Upstream URL: http://geographiclib.sourceforge.net/ Owners: rmattes Branches: f19 f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1145443] Review Request: python-pdfkit - Python 2 wrapper for wkhtmltopdf utility to convert HTML to PDF
https://bugzilla.redhat.com/show_bug.cgi?id=1145443 --- Comment #7 from William Moreno williamjmore...@gmail.com --- 0.4.1-3 Subpackage for Python3 and conditionals for Epel6 Updated .spec: https://williamjmorenor.fedorapeople.org/rpmdev/python-pdfkit.spec Updater .src.rpm: https://williamjmorenor.fedorapeople.org/rpmdev/python-pdfkit-0.4.1-3.fc20.src.rpm Koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=7765543 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1147922] Review Request: XTandem - X!TANDEM Spectrum Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=1147922 MartinKG mgans...@alice.de changed: What|Removed |Added CC||mgans...@alice.de Fixed In Version||mgans...@alice.de -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1147922] Review Request: XTandem - X!TANDEM Spectrum Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=1147922 MartinKG mgans...@alice.de changed: What|Removed |Added Status|NEW |ASSIGNED Fixed In Version|mgans...@alice.de | Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1147922] Review Request: XTandem - X!TANDEM Spectrum Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=1147922 MartinKG mgans...@alice.de changed: What|Removed |Added Assignee|nob...@fedoraproject.org|mgans...@alice.de -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1147922] Review Request: XTandem - X!TANDEM Spectrum Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=1147922
MartinKG mgans...@alice.de changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from MartinKG mgans...@alice.de ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 84 files have unknown license. Detailed output of
licensecheck in
/home/martin/rpmbuild/SPECS/1147922-XTandem/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI
[Bug 1120788] Review Request: Rex - Tool for Automation, Remote Execution and Configuration Deployment
https://bugzilla.redhat.com/show_bug.cgi?id=1120788 --- Comment #3 from Dominic Hopf dma...@fedoraproject.org --- Updated the package to latest release 0.54.3 and fixed some rpmlint warnings in the meanwhile: Spec URL: https://dmaphy.fedorapeople.org/Rex/Rex.spec SRPM URL: https://dmaphy.fedorapeople.org/Rex/Rex-0.54.3-1.fc20.src.rpm Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7767299 You still have this Review on your plan? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1146935] Review Request: nodejs-filed - Simplified file library
https://bugzilla.redhat.com/show_bug.cgi?id=1146935 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- nodejs-filed-0.1.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1146930] Review Request: python-cpuinfo - Getting CPU info
https://bugzilla.redhat.com/show_bug.cgi?id=1146930 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-cpuinfo-0.1.2-2.el7 has been pushed to the Fedora EPEL 7 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148365] Review Request: perl-URI-Encode - Simple percent Encoding/Decoding
https://bugzilla.redhat.com/show_bug.cgi?id=1148365 Denis Fateyev de...@fateyev.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Denis Fateyev de...@fateyev.com --- The URL and Source0 are usable. Ok. The source archive is original (SHA-256: 532a09f04da80b28d420f3ff52eb4e489f10656e527a967ca131ce683b83bcc3). Ok. Summary and description are basically Ok - but I would improve them to be more informative for search, especially, the description. License verified from lib/URI/Encode.pm. GPL+ or Artistic. License is Ok. XS code not present, BuildArch is noarch: Ok. Build log used for check (Koji rawhide build): https://kojipkgs.fedoraproject.org/work/tasks/8107/7768107/build.log Build-time dependencies are Ok. All tests passed. Ok. $ rpmlint perl-URI-Encode-0.09-1.fc22.noarch.rpm perl-URI-Encode-0.09-1.fc22.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint is Ok. $ rpm -q -lv -p perl-URI-Encode-0.09-1.fc22.noarch.rpm drwxr-xr-x2 root root 0 Oct 5 02:10 /usr/share/doc/perl-URI-Encode -rw-r--r--1 root root 1042 Mar 5 2013 /usr/share/doc/perl-URI-Encode/Changes -rw-r--r--1 root root 18407 Mar 5 2013 /usr/share/doc/perl-URI-Encode/LICENSE -rw-r--r--1 root root 3793 Mar 5 2013 /usr/share/doc/perl-URI-Encode/README -rw-r--r--1 root root 3635 Oct 5 02:10 /usr/share/man/man3/URI::Encode.3pm.gz drwxr-xr-x2 root root 0 Oct 5 02:10 /usr/share/perl5/vendor_perl/URI -rw-r--r--1 root root 8158 Oct 5 02:10 /usr/share/perl5/vendor_perl/URI/Encode.pm File permissions and layout are Ok. $ rpm -q --requires -p perl-URI-Encode-0.09-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl = 0:5.008001 1 perl(:MODULE_COMPAT_5.20.1) 1 perl(base) 1 perl(Carp) 1 perl(Encode) = 2.12 1 perl(Exporter) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) = 3.0.4-1 1 rpmlib(FileDigests) = 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 1 rpmlib(PayloadIsXz) = 5.2-1 Requires are Ok. rpm -q --provides -p perl-URI-Encode-0.09-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(URI::Encode) = 0.09 1 perl-URI-Encode = 0.09-1.fc22 Provides are Ok. Package can be built successfully in Rawhide and EPEL7: https://koji.fedoraproject.org/koji/taskinfo?taskID=7768106 https://koji.fedoraproject.org/koji/taskinfo?taskID=7768288 Build is Ok. Package is in line with Fedora and Perl packaging guidelines. Review result: package is APPROVED. The recommendation is only to improve package's summary and description. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148415] Review Request: classads - Condor's classified advertisement language
https://bugzilla.redhat.com/show_bug.cgi?id=1148415 František Dvořák val...@civ.zcu.cz changed: What|Removed |Added Component|Package Review |Package Review Version|rawhide |el5 Product|Fedora |Fedora EPEL -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149423] New: Review Request: gnurobbo - short summary here
https://bugzilla.redhat.com/show_bug.cgi?id=1149423 Bug ID: 1149423 Summary: Review Request: gnurobbo - short summary here Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: projects...@smart.ms QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raphgro.fedorapeople.org/review/gnurobbo/gnurobbo.spec SRPM URL: https://raphgro.fedorapeople.org/review/gnurobbo/gnurobbo-0.66svn412-1.fc20.src.rpm Description: Port of the once famous ATARI game Robbo Fedora Account System Username: raphgro rpmlint does not show any true issues, all warnings are false positives. koji rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=7768469 koji f21: https://koji.fedoraproject.org/koji/taskinfo?taskID=7768479 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149423] Review Request: gnurobbo - Port of the once famous ATARI game Robbo
https://bugzilla.redhat.com/show_bug.cgi?id=1149423 Raphael Groner projects...@smart.ms changed: What|Removed |Added Summary|Review Request: gnurobbo - |Review Request: gnurobbo - |short summary here|Port of the once famous ||ATARI game Robbo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 --- Comment #2 from Denis Fateyev de...@fateyev.com --- I skipped Pod::Readme and Pod::Markdown dependencies intentionally because they didn't affect the build or core functionality, - and the first was missing in epel7 [1], the second was missing both in el5 and el6 [2]. $ rpmlint perl-DBIx-RunSQL-0.12-1.fc22.src.rpm perl-DBIx-RunSQL-0.12-1.fc22.noarch.rpm perl-DBIx-RunSQL.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-DBIx-RunSQL/README 2 packages and 0 specfiles checked; 0 errors, 1 warnings. I think they can be omitted but if it's important I can either add a conditional for el5,el6 or exclude them from build entirely (actually, I wouldn't do that.) [1] http://pkgs.fedoraproject.org/cgit/perl-Pod-Readme.git I've recently posted the update: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-2808/perl-Pod-Readme-0.110-11.el7 but it hasn't reached stable repo yet. [2] http://pkgs.fedoraproject.org/cgit/perl-Pod-Markdown.git -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1147356] Review Request: python-tilestache - A stylish alternative for caching your map tiles
https://bugzilla.redhat.com/show_bug.cgi?id=1147356 --- Comment #4 from Scott K Logan log...@cottsay.net --- * version constraint: removed * macros: removed (will target epel7, though) * patches: renamed * python3: package source is incompatible * timestamp: not restored * typo: fixed * cflags: removed Spec URL: https://cottsay.fedorapeople.org/python-tilestache/python-tilestache.spec Thanks for your feedback! --scott -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047497] Review Request: otcl - MIT Object Tcl
https://bugzilla.redhat.com/show_bug.cgi?id=1047497 --- Comment #17 from Mosaab Alzoubi moc...@hotmail.com --- - Tweaks Spec: http://ojuba.org/test/otcl.spec Srpm: http://ojuba.org/test/otcl-1.14-7.oj35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047702] Review Request: tclcl - Tcl/C++ interface
https://bugzilla.redhat.com/show_bug.cgi?id=1047702 --- Comment #8 from Mosaab Alzoubi moc...@hotmail.com --- - Tweaks: Spec: http://ojuba.org/test/tclcl.spec Srpm: http://ojuba.org/test/tclcl-1.20-6.oj35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049116] Review Request: ns2 - The Network Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1049116 --- Comment #5 from Mosaab Alzoubi moc...@hotmail.com --- - Support 64Bit by Seng Jea. - Fix configure lines. - General tweaks. Spec: http://ojuba.org/test/ns2.spec Srpm: http://ojuba.org/test/ns2-2.35-2.oj35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879740] Review Request: python-evdev - bindings for the linux input handling subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=879740 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Flags||needinfo?(georgi.t.valkov@g ||mail.com) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 --- Comment #3 from David Dick dd...@cpan.org --- Those modules are required in Makefile.PL, so BuildRequires should be put in place for them. Having Pod::Readme available allows the regeneration of the README file, which fixes the end-of-line issue noted by rpmlint. I think that BR can be added without causing you to miss out on anything? Pod-Markdown can be skipped as the resulting README.mkdn is not included in the RPM (correctly, as it is an exact copy of the README file) Is that ok? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
