[Bug 1336255] Review Request: vimwiki - A personal wiki For Vim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336255



--- Comment #6 from Josef Ridky  ---
No, it is not about length of %description, but about structure of this
section. Description should be breathe paragraph or a few sentences, but no
"checklist".

If you change this list into paragraph or sentence, it will be better than
using list.

(e.g. With Vimwiki you will be able to organize your notes and ideas, manage
your TODO lists, write documentation, maintain your diary and many more.)

But finally its up to you. This is just my recommendation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372938] Review Request: xorg-x11-drv-amdgpu - X.Org X11 amdgpu video driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372938



--- Comment #31 from Fedora Update System  ---
libXfont2-2.0.1-2.fc25, tigervnc-1.7.0-3.fc25, xorg-x11-drivers-7.7-18.fc25,
xorg-x11-drv-amdgpu-1.1.2-3.20160929git97d7386c.fc25,
xorg-x11-drv-armsoc-1.4.0-3.20160929.fc25,
xorg-x11-drv-ati-7.7.1-1.20160928git3fc839ff.fc25,
xorg-x11-drv-dummy-0.3.6-26.fc25, xorg-x11-drv-evdev-2.10.4-1.fc25,
xorg-x11-drv-fbdev-0.4.3-25.fc25, xorg-x11-drv-fbturbo-0.5.1-0.8.20150221.fc25,
xorg-x11-drv-freedreno-1.4.0-3.20160929.fc25,
xorg-x11-drv-geode-2.11.18-2.fc25,
xorg-x11-drv-intel-2.99.917-26.20160929.fc25,
xorg-x11-drv-ivtv-1.2.0-0.22.fc25,
xorg-x11-drv-libinput-0.19.1-3.20160929.fc25,
xorg-x11-drv-nouveau-1.0.13-1.fc25, xorg-x11-drv-omap-0.4.4-3.fc25,
xorg-x11-drv-openchrome-0.5.0-2.fc25, xorg-x11-drv-opentegra-0.7.0-8.fc25,
xorg-x11-drv-qxl-0.1.4-10.20160929gite13d28ee.fc25,
xorg-x11-drv-sisusb-0.9.6-24.fc25, xorg-x11-drv-synaptics-1.8.99.2-2.fc25,
xorg-x11-drv-v4l-0.2.0-47.fc25, xorg-x11-drv-vesa-2.3.2-25.fc25,
xorg-x11-drv-vmware-13.0.2-12.20150211git8f0cf7c.fc25,
xorg-x11-drv-voodoo-1.2.5-25.fc25,
xorg-x11-drv-wacom-0.33.0-2.20160929gitb61d1711.fc25,
xorg-x11-font-utils-7.5-32.fc25, xorg-x11-proto-devel-7.7-20.fc25,
xorg-x11-server-1.19.0-0.2.20160929.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a5c3ebe67a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357064] Review Request: lumina-desktop - A lightweight, portable desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357064

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #39 from Fedora Update System  ---
lumina-desktop-1.0.0-5.p2.Lbc08e90.fc23 has been pushed to the Fedora 23
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f700d53a6a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1352972] Review Request: python-twine - Collection of utilities for interacting with PyPI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352972

Jeremy Cline  changed:

   What|Removed |Added

  Flags|needinfo?(jer...@jcline.org |
   |)   |



--- Comment #22 from Jeremy Cline  ---
(In reply to William Moreno from comment #21)
> This package was imported?

I'm not sure I understand what you mean by imported. If you're asking if this
package is built, it's currently available in F23-Rawhide and EPEL7:
https://apps.fedoraproject.org/packages/python-twine

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336255] Review Request: vimwiki - A personal wiki For Vim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336255



--- Comment #5 from Brad Hubbard  ---
1) I have no tests so I think %check is unneeded.

2) Are you saying %description is still too long since I removed the
"Features:" section?

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343977] Review Request: asciidoctor-mallard - A Project Mallard converter for AsciiDoc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343977

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
  Flags||needinfo?(dhanvicse@gmail.c
   ||om)



--- Comment #4 from William Moreno  ---
Hi dhanvi, there is a lot of time since last update, do you want to continue
with this review? If not I can take care of it.

Please remenber than acording to the Stalle Package Review process(0) if you do
not reponse in one week I can close this review a open a new one.

Regards

0: https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372888] Review Request: python-toro - Synchronization primitives for Tornado coroutines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372888

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372889] Review Request: python-thriftpy - Pure Python implementation of Apache Thrift

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372889

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372893] Review Request: python-parquet - Python implementation of the Parquet file format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372893

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378160] Review Request: jitterentropy-rngd - RNGD based on CPU Jitter RNG

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378160



--- Comment #7 from Fedora Update System  ---
jitterentropy-rngd-1.0.3-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-theme-bootstrap - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #31 from Stuart Campbell  ---
Hi, no problem I know how things are.

Spec URL:
https://github.com/stuartcampbell/rpm-packages/blob/master/sphinx-theme-bootstrap/sphinx-theme-bootstrap.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sic/packages/fedora-rawhide-x86_64/00443690-python-sphinx-theme-bootstrap/python-sphinx-theme-bootstrap-0.4.5-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376511] Review Request: nexus - NeXus scientific data file format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376511



--- Comment #3 from Stuart Campbell  ---
SPEC URL:
https://github.com/stuartcampbell/rpm-packages/blob/master/nexus/nexus.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sic/science/fedora-rawhide-x86_64/00453425-nexus/nexus-4.4.3-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358739] Review Request: python-msrest - AutoRest swagger generator Python client runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358739



--- Comment #4 from William Moreno  ---
This package is licensed under the MIT License, the MIT License is visible in
setup.py and pypi page, and all source files have the full license text in
header, it is fine to accept this package without a separate LICENSE file?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358739] Review Request: python-msrest - AutoRest swagger generator Python client runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358739

William Moreno  changed:

   What|Removed |Added

 Blocks||182235 (FE-Legal)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358739] Review Request: python-msrest - AutoRest swagger generator Python client runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358739



--- Comment #3 from William Moreno  ---
Please ask upstream to add a LICENSE file in the project directory, files have
the MIT License text in header but it is prefered to add a LICENSE text.

https://github.com/xingwu1/autorest/blob/master/ClientRuntimes/Python/msrest/msrest/__init__.py

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358741] Review Request: python-msrestazure - AutoRest swagger generator Python client runtime ( Azure-specific module)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358741

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1291877] Review Request: python-nilearn - Python module for fast and easy statistical learning on NeuroImaging data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291877

William Moreno  changed:

   What|Removed |Added

 CC|williamjmore...@gmail.com   |
   Assignee|williamjmore...@gmail.com   |nob...@fedoraproject.org
  Flags|fedora-review?  |
   |needinfo?(ignatenko@redhat. |
   |com)|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358739] Review Request: python-msrest - AutoRest swagger generator Python client runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358739

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1260845] Review Request: sshguard - Protect hosts from brute-force attacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260845

William Moreno  changed:

   What|Removed |Added

 CC|williamjmore...@gmail.com   |
   Assignee|williamjmore...@gmail.com   |nob...@fedoraproject.org
  Flags|fedora-review?  |
   |needinfo?(kon...@tylerc.org |
   |)   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268380] Review Request: python-sphinx-theme-bootstrap - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #30 from William Moreno  ---
Hi, sorry for the last feedback, but can you please update links using the
format:

Spec URL: 
SRPM URL:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1279104] Review Request: python-pbkdf2 - password-based key derivation in pure Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279104

William Moreno  changed:

   What|Removed |Added

 CC|williamjmore...@gmail.com   |
   Assignee|williamjmore...@gmail.com   |nob...@fedoraproject.org
  Flags|fedora-review?  |
   |needinfo?(gy...@fsfe.org)   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1352972] Review Request: python-twine - Collection of utilities for interacting with PyPI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352972

William Moreno  changed:

   What|Removed |Added

 CC||jer...@jcline.org
  Flags||needinfo?(jer...@jcline.org
   ||)



--- Comment #21 from William Moreno  ---
This package was imported?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382989] Review Request: mirrormanager2 - Mirror management application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382989



--- Comment #12 from Patrick Uiterwijk  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/mirrormanager2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383474] Review Request: perl-DateTime-Calendar-Julian - Julian Calendar support for DateTime.pm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383474

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Neal Gompa  ---
Okay, then. I have no other issues with it.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383474] Review Request: perl-DateTime-Calendar-Julian - Julian Calendar support for DateTime.pm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383474



--- Comment #8 from Tom "spot" Callaway  ---
It's common in perl packages. Because it uses this structure:

/usr/share/perl5/vendor_perl/DateTime/Calendar/Julian.pm

Any perl-DateTime-Calendar module will put a pm file in there. This one doesn't
depend on any other DateTime-Calendar modules, so there is unclear ownership,
and when ownership is unclear. it is permissible for multiple packages to share
ownership.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383474] Review Request: perl-DateTime-Calendar-Julian - Julian Calendar support for DateTime.pm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383474



--- Comment #7 from Neal Gompa  ---
Is the file/folder ownership conflict intentional?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383474] Review Request: perl-DateTime-Calendar-Julian - Julian Calendar support for DateTime.pm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383474



--- Comment #6 from Neal Gompa  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "Perl". 7 files have unknown license.
 Detailed output of licensecheck in /home/makerpm/1383474-perl-
 DateTime-Calendar-Julian/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/perl5/vendor_perl/DateTime(perl-DateTime-Format-IBeat,
 perl-DateTime-Format-DB2, perl-DateTime-Format-Builder, perl-DateTime-
 Event-Recurrence, perl-DateTime-Format-Pg, perl-DateTime-Format-ICal,
 perl-DateTime-TimeZone-SystemV, perl-DateTime-Tiny, perl-DateTime-
 Format-Duration, perl-DateTime-Precise, perl-DateTime-Format-
 DateManip, perl-DateTime-Format-Natural, perl-DateTime-Calendar-Mayan,
 perl-DateTime-TimeZone, perl-DateTime-Format-MySQL, perl-DateTime-
 Format-Excel, perl-DateTime-Format-Oracle, perl-DateTime-Set, perl-
 DateTime-Event-ICal, perl-DateTime-Locale, perl-DateTime-Format-
 DateParse, perl-DateTime-Format-Flexible, perl-DateTime-Incomplete,
 perl-DateTime-TimeZone-Tzfile, perl-DateTime-Format-Epoch, perl-
 DateTime-Format-HTTP, perl-DateTime-Format-W3CDTF, perl-DateTime-
 Format-ISO8601, perl-DateTime-Format-SQLite, perl-DateTime-Format-XSD,
 perl-DateTime-Format-Mail, perl-DateTime-Format-Atom, perl-DateTime-
 Format-Strptime, perl-DateTime-Format-DBI, perl-DateTime-Format-
 RFC3339), /usr/share/perl5/vendor_perl/DateTime/Calendar(perl-
 DateTime-Calendar-Mayan)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.

= SHOULD items =

Generic:

[Bug 1382989] Review Request: mirrormanager2 - Mirror management application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382989

Kevin Fenzi  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #11 from Kevin Fenzi  ---
Thanks. The only issue I see left is that you should likely move the license
files to the -filesystem subpackge. That way they always get installed no
matter what subset of the packages you install. ;) 

If you could fix that before import that would be great. 

This package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383474] Review Request: perl-DateTime-Calendar-Julian - Julian Calendar support for DateTime.pm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383474

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #3 from Neal Gompa  ---
Taking the review...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383474] Review Request: perl-DateTime-Calendar-Julian - Julian Calendar support for DateTime.pm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383474



--- Comment #5 from Tom "spot" Callaway  ---
Add BR: perl-generators

Spec URL: https://spot.fedorapeople.org/perl-DateTime-Calendar-Julian.spec
SRPM URL:
https://spot.fedorapeople.org/perl-DateTime-Calendar-Julian-0.04-3.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383474] Review Request: perl-DateTime-Calendar-Julian - Julian Calendar support for DateTime.pm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383474



--- Comment #4 from Neal Gompa  ---
Something I noticed right off the bat: perl-generators is missing as a
BuildRequires. perl-generators is no longer in the buildroot by default, so
dependencies will not be generated automatically.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1279087] Review Request: sharpfont - Cross-platform FreeType bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279087



--- Comment #16 from Raphael Groner  ---
Pravin,
thanks again. Approved in PkgDB.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383488] Review Request: php-asm89-stack-cors - Cross-origin resource sharing library and stack middleware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383488

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1383483
  Alias||php-asm89-stack-cors




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1383483
[Bug 1383483] drupal8-8.2.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1197517] Review Request: elmon - Performance monitoring tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1197517



--- Comment #10 from Raphael Groner  ---
Thanks for the reminder. Could you take a look into bug #1380942?

As I'm busy with other things during the weeks, don't expect anything from me
for this review here earlier than on one of the next weekends.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383487] Review Request: php-akamai-open-edgegrid-auth - Implements the Akamai {OPEN} EdgeGrid Authentication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383487

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1382986
  Alias||php-akamai-open-edgegrid-au
   ||th




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1382986
[Bug 1382986] php-akamai-open-edgegrid-client-0.6.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383488] New: Review Request: php-asm89-stack-cors - Cross-origin resource sharing library and stack middleware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383488

Bug ID: 1383488
   Summary: Review Request: php-asm89-stack-cors - Cross-origin
resource sharing library and stack middleware
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/afeaa339a8338c80035a142408f5c1b1dce40574/php-asm89-stack-cors/php-asm89-stack-cors.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-asm89-stack-cors-1.0.0-1.fc24.src.rpm

Description:
Library and middleware enabling cross-origin resource sharing for your
http-{foundation,kernel} using application. It attempts to implement the
W3C Candidate Recommendation [1] for cross-origin resource sharing.

Autoloader: /usr/share/php/Asm89/Stack/autoload-cors.php

[1] http://www.w3.org/TR/cors/


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383487] New: Review Request: php-akamai-open-edgegrid-auth - Implements the Akamai {OPEN} EdgeGrid Authentication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383487

Bug ID: 1383487
   Summary: Review Request: php-akamai-open-edgegrid-auth -
Implements the Akamai {OPEN} EdgeGrid Authentication
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/e93dfff5c2fa5f1e09bc8a317ff78d7a7a00f8d6/php-akamai-open-edgegrid-auth/php-akamai-open-edgegrid-auth.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-akamai-open-edgegrid-auth-0.6.0-1.fc24.src.rpm

Description:
This library implements the Akamai {OPEN} EdgeGrid Authentication scheme.

For more information visit the Akamai {OPEN} Developer Community [1].

Autoloader: /usr/share/php/Akamai/Open/EdgeGrid/autoload-auth.php

[1] https://developer.akamai.com/

NOTE: Broken out from client as of version 0.6.0


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383474] Review Request: perl-DateTime-Calendar-Julian - Julian Calendar support for DateTime.pm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383474



--- Comment #2 from Tom "spot" Callaway  ---
Since it is no longer 2005, I have removed the rm -rf %{buildroot} line from
%install.

Spec URL: https://spot.fedorapeople.org/perl-DateTime-Calendar-Julian.spec
SRPM URL:
https://spot.fedorapeople.org/perl-DateTime-Calendar-Julian-0.04-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382989] Review Request: mirrormanager2 - Mirror management application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382989



--- Comment #10 from Patrick Uiterwijk  ---
Regarding client, crawler or list needing -lib: no.
-lib is only for things that directly communicate with the database, meaning
the backend and the frontend.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383474] Review Request: perl-DateTime-Calendar-Julian - Julian Calendar support for DateTime.pm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383474



--- Comment #1 from Tom "spot" Callaway  ---
Koji Rawhide scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16032959

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1197517] Review Request: elmon - Performance monitoring tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1197517



--- Comment #9 from Pavel Alexeev  ---
Raphael?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382989] Review Request: mirrormanager2 - Mirror management application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382989



--- Comment #9 from Patrick Uiterwijk  ---
Fixed your remarks.

new Spec URL: https://puiterwijk.fedorapeople.org/mirrormanager2.spec
new SRPM URL:
https://puiterwijk.fedorapeople.org/mirrormanager2-0.7.3-3.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383474] New: Review Request: perl-DateTime-Calendar-Julian - Julian Calendar support for DateTime.pm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383474

Bug ID: 1383474
   Summary: Review Request: perl-DateTime-Calendar-Julian - Julian
Calendar support for DateTime.pm
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: tcall...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://spot.fedorapeople.org/perl-DateTime-Calendar-Julian.spec
SRPM URL:
https://spot.fedorapeople.org/perl-DateTime-Calendar-Julian-0.04-1.fc24.src.rpm
Description: DateTime object in the Julian calendar.
Fedora Account System Username: spot

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378160] Review Request: jitterentropy-rngd - RNGD based on CPU Jitter RNG

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378160

Fedora Update System  changed:

   What|Removed |Added

 Resolution|CURRENTRELEASE  |ERRATA



--- Comment #6 from Fedora Update System  ---
jitterentropy-rngd-1.0.3-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373782] Review Request: mingw-cmocka - MinGW Lightweight library to simplify and generalize unit tests for C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373782

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-10 13:45:27



--- Comment #12 from Fedora Update System  ---
mingw-cmocka-1.1.0-2.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381892] Review Request: osgi-core - OSGi Core API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381892

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-10 13:42:35



--- Comment #10 from Fedora Update System  ---
osgi-compendium-6.0.0-1.fc25, osgi-core-6.0.0-2.fc25 has been pushed to the
Fedora 25 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375735] Review Request: python-asciitree - Draws ASCII trees

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375735

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-10 13:43:08



--- Comment #8 from Fedora Update System  ---
python-asciitree-0.3.3-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1271193] Review Request: osgi-compendium - Interfaces and Classes for use in compiling OSGi bundles

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1271193

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-06-02 10:13:08 |2016-10-10 13:42:41



--- Comment #17 from Fedora Update System  ---
osgi-compendium-6.0.0-1.fc25, osgi-core-6.0.0-2.fc25 has been pushed to the
Fedora 25 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1271193] Review Request: osgi-compendium - Interfaces and Classes for use in compiling OSGi bundles

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1271193
Bug 1271193 depends on bug 1381892, which changed state.

Bug 1381892 Summary: Review Request: osgi-core - OSGi Core API
https://bugzilla.redhat.com/show_bug.cgi?id=1381892

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382989] Review Request: mirrormanager2 - Mirror management application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382989



--- Comment #8 from Kevin Fenzi  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

ignore, it's because python-admin-flask wasn't back in at the time of review.

- Package uses either %{buildroot} or $RPM_BUILD_ROOT
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros

Pick the one you prefer? :) 

- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

Mark COPYING as %license

- Note: No known owner of /usr/share/mirrormanager2
  Note: Directories without known owners: /etc/httpd, /etc/logrotate.d,
 /etc/httpd/conf.d, /usr/share/mirrormanager2, /usr/lib/python2.7/site-
 packages/mirrormanager2, /usr/lib/tmpfiles.d

Fix ownership

[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /etc/mirrormanager-client
 (mirrormanager-client), /etc/mirrormanager(mirrormanager),
 /var/log/mirrormanager/crawler(mirrormanager),
 /var/lock/mirrormanager(mirrormanager),
 /var/lib/mirrormanager(mirrormanager),
 /var/run/mirrormanager(mirrormanager),
 /var/log/mirrormanager(mirrormanager)

We need to remember to retire mirrormanager.

- [!]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 mirrormanager2-lib , mirrormanager2-mirrorlist ,
 mirrormanager2-crawler , mirrormanager2-backend ,
 mirrormanager2-client , mirrormanager2-statistics

Should mirrorlist/crawler/client at least require lib?

- Theres a number of rpmlint issues, might be nice to clean some up.
Nothing particularly blocking in there however.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "*No copyright* GPL (v2)", "Unknown or
 generated". 304 files have unknown license. Detailed output of
 licensecheck in
 /home/fedora/kevin/1382989-mirrormanager2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/mirrormanager2
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/httpd, /etc/logrotate.d,
 /etc/httpd/conf.d, /usr/share/mirrormanager2, /usr/lib/python2.7/site-
 packages/mirrormanager2, /usr/lib/tmpfiles.d
[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /etc/mirrormanager-client
 (mirrormanager-client), /etc/mirrormanager(mirrormanager),
 /var/log/mirrormanager/crawler(mirrormanager),
 /var/lock/mirrormanager(mirrormanager),
 /var/lib/mirrormanager(mirrormanager),
 /var/run/mirrormanager(mirrormanager),
 /var/log/mirrormanager(mirrormanager)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 307200 bytes in 15 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint 

[Bug 1383445] Review Request: python-requests_ntlm - HTTP NTLM authentication using the requests library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383445

James Hogarth  changed:

   What|Removed |Added

 Blocks||1383447




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1383447
[Bug 1383447] Review Request: python-winrm - Python library for Windows
Remote Management
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383447] Review Request: python-winrm - Python library for Windows Remote Management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383447

James Hogarth  changed:

   What|Removed |Added

 CC||ke...@scrye.com
 Depends On||1383445




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1383445
[Bug 1383445] Review Request: python-requests_ntlm - HTTP NTLM
authentication using the requests library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383447] New: Review Request: python-winrm - Python library for Windows Remote Management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383447

Bug ID: 1383447
   Summary: Review Request: python-winrm - Python library for
Windows Remote Management
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: james.hoga...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://jhogarth.fedorapeople.org/python-winrm/python-winrm.spec
SRPM URL:
https://jhogarth.fedorapeople.org/python-winrm/python-winrm-0.2.1-1.fc25.src.rpm

Description: python-winrm is a Python client for the Windows Remote Management
(WinRM) service. It allows you to invoke commands on target Windows machines
from any machine that can run Python.

WinRM allows you to perform various management tasks remotely. These include,
but are not limited to: running batch scripts, powershell scripts, and fetching
WMI variables.

Fedora Account System Username: jhogarth

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383434] Review Request: python-ntlm3 - Python 3 compatible NTLM library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383434

James Hogarth  changed:

   What|Removed |Added

 Blocks||1383445




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1383445
[Bug 1383445] Review Request: python-requests_ntlm - HTTP NTLM
authentication using the requests library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383445] Review Request: python-requests_ntlm - HTTP NTLM authentication using the requests library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383445

James Hogarth  changed:

   What|Removed |Added

 CC||ke...@scrye.com
 Depends On||1383434




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1383434
[Bug 1383434] Review Request: python-ntlm3 - Python 3 compatible NTLM
library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383445] New: Review Request: python-requests_ntlm - HTTP NTLM authentication using the requests library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383445

Bug ID: 1383445
   Summary: Review Request: python-requests_ntlm - HTTP NTLM
authentication using the requests library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: james.hoga...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jhogarth.fedorapeople.org/python-requests_ntlm/python-requests_ntlm.spec
SRPM URL:
https://jhogarth.fedorapeople.org/python-requests_ntlm/python-requests_ntlm-0.3.0-1.fc25.src.rpm

Description: This package allows for HTTP NTLM authentication using the
requests library.

Fedora Account System Username: jhogarth

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1193730] Review Request: apache-jena - Java framework for building Semantic Web and Linked Data applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193730

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1193730] Review Request: apache-jena - Java framework for building Semantic Web and Linked Data applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193730

Donald Pellegrino  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |CANTFIX
  Flags|needinfo?(dapellegrino@dow. |
   |com)|
Last Closed||2016-10-10 11:25:31



--- Comment #13 from Donald Pellegrino  ---
Thanks for the information. Rather than chase down the dependencies, I have
opted to mark the bug as closed, cantfix. The "Java Packaging HOWTO"
(https://fedora-java.github.io/howto/latest/) has been updated recently and may
describe a path forward for keeping up with Java dependencies. The approach I
used does not seem maintainable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1155058] Review Request: jenkins-translation-plugin - Jenkins Translation Assistance Plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155058

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383434] New: Review Request: python-ntlm3 - Python 3 compatible NTLM library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383434

Bug ID: 1383434
   Summary: Review Request: python-ntlm3 - Python 3 compatible
NTLM library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: james.hoga...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://jhogarth.fedorapeople.org/python-ntlm3/python-ntlm3.spec
SRPM URL:
https://jhogarth.fedorapeople.org/python-ntlm3/python-ntlm3-1.0.2-1.fc25.src.rpm

Description: This package allows Python clients running on any operating
system to provide NTLM authentication to a supporting server.

Fedora Account System Username: jhogarth

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382989] Review Request: mirrormanager2 - Mirror management application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382989



--- Comment #7 from Patrick Uiterwijk  ---
URL and source updated

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1193730] Review Request: apache-jena - Java framework for building Semantic Web and Linked Data applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193730



--- Comment #12 from gil cattaneo  ---
(In reply to Donald Pellegrino from comment #11)
> I received the needinfo alert but I have not played with this build in a
> bit. I had given up due to the extent of the dependencies necessary. What
> next step might I take to help out here?

The only missing dependencies are:
BuildRequires: mvn(org.apache.lucene:lucene-analyzers-common:4.6.1)
BuildRequires: mvn(org.apache.lucene:lucene-core:4.6.1)
BuildRequires: mvn(org.apache.lucene:lucene-queryparser:4.6.1)
BuildRequires: mvn(org.apache.lucene:lucene-spatial:4.6.1)
BuildRequires: mvn(org.apache.solr:solr-solrj:4.6.1)
BuildRequires: mvn(org.apache.httpcomponents:httpclient-osgi)
BuildRequires: mvn(org.apache.httpcomponents:httpcore-osgi)
BuildRequires: mvn(com.github.rvesse:airline:0.9.1)


Test deps
BuildRequires: mvn(org.apache.mrunit:mrunit)
BuildRequires: mvn(org.xenei:junit-contracts)

if you think is not possible continue. please close this bug
regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350257] Review Request: petsc - Portable Extensible Toolkit for Scientific Computation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350257



--- Comment #38 from Orion Poplawski  ---
(In reply to Dave Love from comment #37)
> (In reply to Antonio Trande from comment #36)
> > PETSc needs fftw-mpi libraries; it does not work with fftw actually
> > available on Fedora/EPEL.
> 
> OK, so we should get rid of that (and chase the change for fftw mpi
> support...).

fftw with mpi support:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ae8fc16aac

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350257] Review Request: petsc - Portable Extensible Toolkit for Scientific Computation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350257



--- Comment #37 from Dave Love  ---
(In reply to Antonio Trande from comment #36)
> PETSc needs fftw-mpi libraries; it does not work with fftw actually
> available on Fedora/EPEL.

OK, so we should get rid of that (and chase the change for fftw mpi
support...).

> > Also, I still don't understand the module file.  The tests run (locally, for
> > me) 
> > without it, so why is it needed?
> 
> Sorry, which modules?

The environment modules file.  It seems useless.

Well done on debugging the test failures.  Perhaps the -64 packages should be
omitted pending a fix -- up to you how long to wait.

Also the discussion with the PETSc folks suggests cleaning up the stuff that
isn't used, or probably isn't useful, like papi.

I'm happier now those issues are understood, thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383416] New: Review Request: python-inlfuxdb - InfluxDB Python client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383416

Bug ID: 1383416
   Summary: Review Request: python-inlfuxdb -  InfluxDB Python
client
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: david.hanneq...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://hvad.fedorapeople.org/fedora/python-influxdb/python-influxdb.spec
SRPM URL:
https://hvad.fedorapeople.org/fedora/python-influxdb/python-influxdb-3.0.0-1.fc24.src.rpm

Description: InfluxDB Python is a client for interacting with InfluxDB.
Fedora Account System Username: hvad

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382755] Review Request: legion - A data-centric parallel programming system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382755



--- Comment #5 from Christoph Junghans  ---
Re-added gcc-c++

Spec URL: http://junghans.github.io/fedora-review/legion/legion.spec
SRPM URL:
http://junghans.github.io/fedora-review/legion/legion-16.10.0-1.fc26.src.rpm
Review.txt: http://junghans.github.io/fedora-review/legion/review.txt
Build log: https://travis-ci.org/junghans/fedora-review/builds/166436975
Raw Build log:
https://s3.amazonaws.com/archive.travis-ci.org/jobs/166436976/log.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336255] Review Request: vimwiki - A personal wiki For Vim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336255



--- Comment #4 from Josef Ridky  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =

Generic:
[x]: Rpmlint is run on all installed packages.
 Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
---
Checking: vim-wiki-2.3-1.fc24.noarch.rpm
  vim-wiki-2.3-1.fc24.src.rpm
vim-wiki.noarch: W: spelling-error %description -l en_US Vimwiki -> Vim wiki,
Vim-wiki, Viking
vim-wiki.src: W: spelling-error %description -l en_US Vimwiki -> Vim wiki,
Vim-wiki, Viking
2 packages and 0 specfiles checked; 0 errors, 2 warnings.




Rpmlint (installed 

[Bug 1193730] Review Request: apache-jena - Java framework for building Semantic Web and Linked Data applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193730



--- Comment #11 from Donald Pellegrino  ---
I received the needinfo alert but I have not played with this build in a bit. I
had given up due to the extent of the dependencies necessary. What next step
might I take to help out here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1269964] Rebase clufter component [RHEL 6.8]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269964

Jan Pokorný  changed:

   What|Removed |Added

 Depends On||1270740




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1270740
[Bug 1270740] Clone declaration missing from cib2pcscmd result
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1269964] Rebase clufter component [RHEL 6.8]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269964

Jan Pokorný  changed:

   What|Removed |Added

 Depends On||1272570




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1272570
[Bug 1272570] clufter does not add resource operations (monitor, start) to
converted resource into cib.xml
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343661] Rebase clufter component [RHEL 7.3]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343661

Igor Gnatenko  changed:

   What|Removed |Added

 CC|package-review@lists.fedora |
   |project.org |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1269964] Rebase clufter component [RHEL 6.8]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269964

Jan Pokorný  changed:

   What|Removed |Added

 Depends On||1272592




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1272592
[Bug 1272592] clufter add extra internal attribute into resulting cib.xml
when converting vm resource
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382755] Review Request: legion - A data-centric parallel programming system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382755



--- Comment #4 from Igor Gnatenko  ---
> Undid adding gcc-c++
By guidelines you must include all dependencies which you are using.

Don't rely completely on fedora-review.
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRequires_2

It is important that your package list all necessary build dependencies using
the BuildRequires: tag. You may assume that enough of an environment exists for
RPM to function and execute basic shell scripts, but you should not assume any
other packages are present as RPM dependencies and anything brought into the
buildroot by the build system may change over time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343661] Rebase clufter component [RHEL 7.3]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343661

Jan Pokorný  changed:

   What|Removed |Added

 Depends On||1272592




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1272592
[Bug 1272592] clufter add extra internal attribute into resulting cib.xml
when converting vm resource
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343661] Rebase clufter component [RHEL 7.3]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343661

Jan Pokorný  changed:

   What|Removed |Added

 Depends On||1300014




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1300014
[Bug 1300014] validation failure in pcs2pcscmd due to newer schema of the
CIB
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1269964] Rebase clufter component [RHEL 6.8]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269964

Jan Pokorný  changed:

   What|Removed |Added

Summary|Rebase clufter component|Rebase clufter component
   ||[RHEL 6.8]



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343661] Rebase clufter component [RHEL 7.3]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343661

Jan Pokorný  changed:

   What|Removed |Added

Summary|Rebase clufter component|Rebase clufter component
   ||[RHEL 7.3]



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367536] Rebase clufter component [RHEL 6.9]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367536

Jan Pokorný  changed:

   What|Removed |Added

Summary|Rebase clufter component|Rebase clufter component
   ||[RHEL 6.9]



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343661] Rebase clufter component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343661

Jan Pokorný  changed:

   What|Removed |Added

 Depends On||1300050




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1300050
[Bug 1300050] clufter: validation failure in ccs2pcs ([64:0] Type ID
doesn't allow value '-OP-monitor')
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382989] Review Request: mirrormanager2 - Mirror management application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382989



--- Comment #6 from Neal Gompa  ---
The URL and Source0 are wrong for this package.

From what I can tell, this would be valid for this package:

URL: https://github.com/fedora-infra/mirrormanager2
Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz

Please fix to valid paths where the sources can be retrieved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1269964] Rebase clufter component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269964

Jan Pokorný  changed:

   What|Removed |Added

 Depends On||1300050




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1300050
[Bug 1300050] clufter: validation failure in ccs2pcs ([64:0] Type ID
doesn't allow value '-OP-monitor')
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367536] Rebase clufter component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367536

Jan Pokorný  changed:

   What|Removed |Added

 Blocks|1328078 |
 Depends On||1328078




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1328078
[Bug 1328078] *2pcscmd commands ought not to suggest "pcs cluster cib
 --config" that doesn't currently work for subsequent
local-modification pcs commands
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343661] Rebase clufter component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343661

Jan Pokorný  changed:

   What|Removed |Added

 Depends On||1328078




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1328078
[Bug 1328078] *2pcscmd commands ought not to suggest "pcs cluster cib
 --config" that doesn't currently work for subsequent
local-modification pcs commands
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1147817] Review Request: php53-getid3 - The PHP media file parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1147817

Remi Collet  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2016-10-10 08:49:05



--- Comment #5 from Remi Collet  ---
No worth to be fixed.
Give up.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382755] Review Request: legion - A data-centric parallel programming system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382755



--- Comment #3 from Christoph Junghans  ---
Undid adding gcc-c++ and added as-needed to LDFLAGS:

Spec URL: http://junghans.github.io/fedora-review/legion/legion.spec
SRPM URL:
http://junghans.github.io/fedora-review/legion/legion-16.10.0-1.fc26.src.rpm
Review.txt: http://junghans.github.io/fedora-review/legion/review.txt
Build log: https://travis-ci.org/junghans/fedora-review/builds/166379013
Raw Build log:
https://s3.amazonaws.com/archive.travis-ci.org/jobs/166379014/log.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324784] Review Request: pseudo - Advanced tool for simulating superuser privileges

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324784



--- Comment #19 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Igor Gnatenko from comment #18)
> (In reply to Dominik 'Rathann' Mierzejewski from comment #17)
> > (In reply to Igor Gnatenko from comment #16)
> > > Just checked all bits. On thing MUST be fixed:
> > > %{_libdir}/pseudo/libpseudo.so -> %{_libdir}/%{name}/
> >  
> > Why? %{name} is not shorter than "pseudo" and I'd argue that readability is
> > better with the actual name instead of a macro.
> Point was about owning /usr/lib64/pseudo/. But you was owning file without
> dir.

Ah! Of course. I'll fix that.

And I'll keep BR: attr, because getfattr is required for tests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324784] Review Request: pseudo - Advanced tool for simulating superuser privileges

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324784



--- Comment #18 from Igor Gnatenko  ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #17)
> (In reply to Igor Gnatenko from comment #15)
> > if getfattr --help >/dev/null 2>&1; then
> > xattr_runs=true
> > 
> > 
> > hmm, then don't drop it.
> 
> As I said, it's only a warning.
> 
> (In reply to Igor Gnatenko from comment #16)
> > Just checked all bits. On thing MUST be fixed:
> > %{_libdir}/pseudo/libpseudo.so -> %{_libdir}/%{name}/
>  
> Why? %{name} is not shorter than "pseudo" and I'd argue that readability is
> better with the actual name instead of a macro.
Point was about owning /usr/lib64/pseudo/. But you was owning file without dir.
> 
> > APPROVED.
> 
> Is it still approved if I don't make the above change?
Sure!
> 
> > Dominik, can you add me as co-maintainer in PkgDB when you will request
> > package? I would be happy to help with it (as it could potentially become
> > replacement for fakechroot for RPM test suide).
> 
> Yes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324784] Review Request: pseudo - Advanced tool for simulating superuser privileges

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324784



--- Comment #17 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Igor Gnatenko from comment #15)
> if getfattr --help >/dev/null 2>&1; then
> xattr_runs=true
> 
> 
> hmm, then don't drop it.

As I said, it's only a warning.

(In reply to Igor Gnatenko from comment #16)
> Just checked all bits. On thing MUST be fixed:
> %{_libdir}/pseudo/libpseudo.so -> %{_libdir}/%{name}/

Why? %{name} is not shorter than "pseudo" and I'd argue that readability is
better with the actual name instead of a macro.

> APPROVED.

Is it still approved if I don't make the above change?

> Dominik, can you add me as co-maintainer in PkgDB when you will request
> package? I would be happy to help with it (as it could potentially become
> replacement for fakechroot for RPM test suide).

Yes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324784] Review Request: pseudo - Advanced tool for simulating superuser privileges

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324784



--- Comment #15 from Igor Gnatenko  ---
if getfattr --help >/dev/null 2>&1; then
xattr_runs=true


hmm, then don't drop it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324784] Review Request: pseudo - Advanced tool for simulating superuser privileges

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324784

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #16 from Igor Gnatenko  ---
Just checked all bits. On thing MUST be fixed: %{_libdir}/pseudo/libpseudo.so
-> %{_libdir}/%{name}/


APPROVED.

Dominik, can you add me as co-maintainer in PkgDB when you will request
package? I would be happy to help with it (as it could potentially become
replacement for fakechroot for RPM test suide).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324784] Review Request: pseudo - Advanced tool for simulating superuser privileges

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324784



--- Comment #14 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Igor Gnatenko from comment #13)
> As I can see, not all bits were applied from patch which I attached...
> 
> > BuildRequires:   attr
> not removed, it's useless BR

configure checks for getfattr availability at build time and prints a warning
if it's not present. Failure to run getfattr doesn't disable any features
though, so I'll drop this BR and patch out the warning instead.

> > sed -i -e "/s,@ARCH_FLAGS@/s|,|!|g" configure
> I don't see this, but build was failing because we have commas in CFLAGS.

I know. I fixed it another way. See the new patch.

> > link=$(readlink -e "%{_bindir}/fakeroot")
> IMO we have fakeroot with alternatives support for long time, so this part
> can be skipped.

The fakeroot in RHEL5 doesn't support alternatives. Neither does the one in
RHEL6.

> Now I'm not around laptop, once I will have it - I will check that it
> builds, some trivial stuff and approve.

I checked that it builds across all primary arches via koji scratch build.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1258542] Review Request: hack-fonts - A typeface designed for source code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1258542



--- Comment #21 from Shawn Starr  ---
Well, if it's acceptable to Debian surely this should be acceptable to Fedora,
if not something seems wrong with our policy...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382989] Review Request: mirrormanager2 - Mirror management application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382989



--- Comment #5 from Patrick Uiterwijk  ---
Fixed those remarks except for %{buildroot} vs $RPM_BUILD_ROOT, as that's
personal preference.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1120788] Review Request: Rex - Tool for Automation, Remote Execution and Configuration Deployment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1120788

Robin Lee  changed:

   What|Removed |Added

 CC||robinlee.s...@gmail.com
   Assignee|i...@cicku.me  |robinlee.s...@gmail.com
  Flags|needinfo?(i...@cicku.me)   |



--- Comment #6 from Robin Lee  ---
I would like to take the review.
Please update to the latest version 1.4.1.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381935] Review Request: python-distro - Linux Distribution - a Linux OS platform information API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381935



--- Comment #9 from Miroslav Suchý  ---
Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374947] Review Request: vpcs - Virtual PC Simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374947

Michal Ruprich  changed:

   What|Removed |Added

  Flags||needinfo?(athma...@gmail.co
   ||m)



--- Comment #6 from Michal Ruprich  ---
Thank you for fixing those small issues. Unfortunately the link is still not
working for me.

$ wget 
http://sourceforge.net/code-snapshots/svn/v/vp/vpcs/code/vpcs-code-126-trunk.zip
--2016-10-10 08:41:50-- 
http://sourceforge.net/code-snapshots/svn/v/vp/vpcs/code/vpcs-code-126-trunk.zip
Resolving sourceforge.net (sourceforge.net)... 216.34.181.60
Connecting to sourceforge.net (sourceforge.net)|216.34.181.60|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2016-10-10 08:41:50 ERROR 404: Not Found.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1258542] Review Request: hack-fonts - A typeface designed for source code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1258542



--- Comment #20 from Helio Chissini de Castro  ---
Debian is using same approach as me, using the precompiled ttf/otf
The only thing is that we're deploying only ttf and debian both ones.

And i personally don't know if worth pack the web fonts.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324784] Review Request: pseudo - Advanced tool for simulating superuser privileges

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324784



--- Comment #13 from Igor Gnatenko  ---
As I can see, not all bits were applied from patch which I attached...

> BuildRequires:   attr
not removed, it's useless BR

> sed -i -e "/s,@ARCH_FLAGS@/s|,|!|g" configure
I don't see this, but build was failing because we have commas in CFLAGS.

> link=$(readlink -e "%{_bindir}/fakeroot")
IMO we have fakeroot with alternatives support for long time, so this part can
be skipped.

Now I'm not around laptop, once I will have it - I will check that it builds,
some trivial stuff and approve.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1155058] Review Request: jenkins-translation-plugin - Jenkins Translation Assistance Plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155058

Michal Srb  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
  Flags|needinfo?(m...@redhat.com)  |
Last Closed||2016-10-10 02:08:43



--- Comment #2 from Michal Srb  ---
I didn't know this one is still open. Closing ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org