[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Germano Massullo  changed:

   What|Removed |Added

  Flags||needinfo?(sanjay.ankur@gmai
   ||l.com)



--- Comment #11 from Germano Massullo  ---
spec file:
https://germano.fedorapeople.org/package_reviews/python-django-jsonfield/python-django-jsonfield.spec
srpm file:
https://germano.fedorapeople.org/package_reviews/python-django-jsonfield/python-django-jsonfield-1.0.3-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385441] Review Request: rpmdeplint - Tool to find errors in RPM packages in the context of their dependency graph

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385441



--- Comment #8 from Dan Callaghan  ---
I just remembered why this is never going to run in Python 3 on EPEL7: it
requires rpm Python 3 bindings, which don't exist in EPEL7 because the rpm
package comes from RHEL.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386735] Review Request: php-fedora-autoloader - Fedora Autoloader

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386735

Remi Collet  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Remi Collet  ---
-%global github_version   0.1.0
-%global github_commitf88fc9430954d86250495eb945ac736bef1dd9ba
+%global github_version   0.1.1
+%global github_commit816e4e59061c592f7480a00c6cd9c16067811c1e

-sed 's#__PHPDIR__#%{phpdir}#' res/phpab/fedora.php.tpl
+sed "s#___AUTOLOAD_PATH___#'%{phpdir}/Fedora/Autoloader'#" \
+-i res/phpab/fedora.php.tpl

-%doc *.md
-%doc composer.json

+%doc *.md
+%doc composer.json

+* Wed Oct 19 2016 Shawn Iwinski  - 0.1.1-1
+- Update to 0.1.1
+- Fix phpab template
+- Move docs to devel subpackage

[x]: Package functions as described.

This Package complies to the Packaging Guidelines.

=== APPROVED ===

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385441] Review Request: rpmdeplint - Tool to find errors in RPM packages in the context of their dependency graph

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385441



--- Comment #7 from Dan Callaghan  ---
Oh I see, so rpmdeplint package provides the CLI, and python2-rpmdeplint and
python3-rpmdeplint provide the Python API? Makes sense. I will post a new
version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376511] Review Request: nexus - NeXus scientific data file format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376511



--- Comment #4 from Michael Schwendt  ---
Drive-by comments. Not easy to review, not a full review. Needs some more work:


> Name:   nexus
> Summary:NeXus scientific data file format

This %summary could be improved, because so far it is for insiders only and
doesn't give a hint what is included in this package. Judging on the %files
section contents, this is a library-only package. No program, not tools, and
the %summary could mention that. Such as:

  Summary: Library for handling NeXus scientific data files

It's written in C++ and offers shared library APIs for C, C++ and Fortran it
seems. Offering all of them in a single package could be drawback because of
what is pulled in via implicit dependencies.

Also visit
  https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries
and:
 
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries


> License:LGPL

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

Further, the -tools subpackage contains a GPLv2 license text as one of the
files in a %doc folder. This needs to be reflected in the "License" tag of that
package, and the %license macro ought to be used.

There is another "LICENSE" file included. Consider pointing the fedora-review
tool at this bugzilla ticket, since it automates many checks related to
licensing.


> Requires:   libgfortran
> Requires:   hdf5
> Requires:   hdf
> Requires:   mxml

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> %packagedevel
> Summary:Development files for %{name}
> Requires:   %{name} = %{version}-%{release}

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> %packagetools
> Requires:   %{name} = %{version}-%{release}
> Requires:   libxml2
> Requires:   readline

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> %install
> rm -rf $RPM_BUILD_ROOT
> %make_install

https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections


> %files
> %doc %{_datadir}/doc/NeXus/README.doc
> %{_libdir}/libNeXus*
> %{_libdir}/nexus/

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership

Particularly
  https://fedoraproject.org/wiki/Packaging:UnownedDirectories
since directory /usr/share/doc/NeXus/ would not be included. Similar problem
for the -tools subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386735] Review Request: php-fedora-autoloader - Fedora Autoloader

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386735



--- Comment #6 from Shawn Iwinski  ---
Modified:
- Update to 0.1.1
- Fix phpab template
- Move docs to devel subpackage



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/ec4823df4fd2f3b7c03608fd194a9ca107c06cef/php-fedora-autoloader/php-fedora-autoloader.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-fedora-autoloader-0.1.1-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373641] Review Request: setBfree - A DSP Tonewheel Organ emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373641



--- Comment #7 from Michael Schwendt  ---
> 3.

Glad you've mentioned that. It's really odd to create a tiny subpackage (plus
explicit dependencies!) for those few files only. Also note that this would
inherit paths from the subpackage %name and store the %license file in
/usr/share/licenses/setBfree-common/ instead of /usr/share/licenses/setBfree/
(and something similar for %doc).


> Requires:   lv2 >= 1.8.1

Preferably, that one would be arch-specific due to the lv2 base package being
multilib.

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386938] Review Request: libprelude - Prelude Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386938



--- Comment #1 from Thomas Andrejak  ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=16127586

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386938] New: Review Request: libprelude - Prelude Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386938

Bug ID: 1386938
   Summary: Review Request: libprelude - Prelude Library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: thomas.andre...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://pastebin.com/4zbE5cKX

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/totol/Prelude/fedora-rawhide-x86_64/00467104-libprelude/libprelude-3.1.0-24.fc26.src.rpm

Description: Prelude is a Universal "Security Information & Event Management"
(SIEM) system. Prelude collects, normalizes, sorts, aggregates, correlates and
reports all security-related events independently of the product brand or
license giving rise to such events; Prelude is "agentless".

Fedora Account System Username: totol

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383447] Review Request: python-winrm - Python library for Windows Remote Management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383447



--- Comment #4 from James Hogarth  ---
It's an interesting question for sure...

Attempting to use the winrm connector will show the error that python-winrm
isn't installed just like when trying to use certain modules so it'll be
obvious what needs installing.

Also ansible is primarily used on *nix systems via SSH (or direct execution)
and the windows stuff is only just starting to grow, and far less common... As
such it'll be a pointless install for most people and a superfluous dependency.

It would probably be a good candidate for a suggests rather than requires or
recommends.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383447] Review Request: python-winrm - Python library for Windows Remote Management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383447



--- Comment #3 from Kevin Fenzi  ---
Do you think we should add some deps on ansible for this stack? 

Or will people doing windows management see the error(s) and install these?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1370449] Review Request: rtv - A simple terminal viewer for Reddit ( Reddit Terminal Viewer)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370449



--- Comment #6 from Fedora Update System  ---
rtv-1.12.1-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8369bf29d4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385728] Review Request: perl-Specio-Library-Path-Tiny - Path:: Tiny types and coercions for Specio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385728

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
perl-Specio-Library-Path-Tiny-0.04-1.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-38ba77b5a1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383434] Review Request: python-ntlm3 - Python 3 compatible NTLM library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383434



--- Comment #5 from Fedora Update System  ---
python-ntlm3-1.0.2-1.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ecb32376b7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385534] Review Request: python-ruamel-ordereddict - Ordered dictionary with Key Insertion Order

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385534



--- Comment #4 from Fedora Update System  ---
python-ruamel-ordereddict-0.4.9-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d89c5fa874

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383445] Review Request: python-requests_ntlm - HTTP NTLM authentication using the requests library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383445



--- Comment #4 from Fedora Update System  ---
python-requests_ntlm-0.3.0-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ece513d041

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383447] Review Request: python-winrm - Python library for Windows Remote Management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383447



--- Comment #2 from James Hogarth  ---
Don't know how I managed to miss a changelog in that somehow...

Thanks Kevin I'll get that fixed up and import tomorrow... And then we get
winrm in Fedora for ansible to manage windows systems :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1370449] Review Request: rtv - A simple terminal viewer for Reddit ( Reddit Terminal Viewer)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370449

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |ON_QA



--- Comment #5 from Fedora Update System  ---
rtv-1.12.1-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c30d57ac6c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383445] Review Request: python-requests_ntlm - HTTP NTLM authentication using the requests library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383445

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #3 from Fedora Update System  ---
python-requests_ntlm-0.3.0-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a9fdec7773

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385534] Review Request: python-ruamel-ordereddict - Ordered dictionary with Key Insertion Order

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385534

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #3 from Fedora Update System  ---
python-ruamel-ordereddict-0.4.9-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b848089218

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383434] Review Request: python-ntlm3 - Python 3 compatible NTLM library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383434

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #4 from Fedora Update System  ---
python-ntlm3-1.0.2-1.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a5e250cd6c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383445] Review Request: python-requests_ntlm - HTTP NTLM authentication using the requests library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383445
Bug 1383445 depends on bug 1383434, which changed state.

Bug 1383434 Summary: Review Request: python-ntlm3 - Python 3 compatible NTLM 
library
https://bugzilla.redhat.com/show_bug.cgi?id=1383434

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383447] Review Request: python-winrm - Python library for Windows Remote Management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383447
Bug 1383447 depends on bug 1383445, which changed state.

Bug 1383445 Summary: Review Request: python-requests_ntlm - HTTP NTLM 
authentication using the requests library
https://bugzilla.redhat.com/show_bug.cgi?id=1383445

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222



--- Comment #10 from Germano Massullo  ---
(In reply to Miro Hrončok from comment #7)
> Just a note: You are doing Python 3 conditionals, but still use python2-
> prefix for Python 2 subpackage, that's not being used in (RH|EP)EL.

I am sorry but I have not found any packaging rule that concerns python2 prefix
not being used on EPEL7
https://fedoraproject.org/wiki/Packaging:Python
https://fedoraproject.org/wiki/EPEL:Packaging

I will make a new package in 48 hours

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Germano Massullo  changed:

   What|Removed |Added

   Priority|unspecified |urgent



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372938] Review Request: xorg-x11-drv-amdgpu - X.Org X11 amdgpu video driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372938

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-10-05 02:22:51 |2016-10-19 13:28:10



--- Comment #32 from Fedora Update System  ---
libXfont2-2.0.1-2.fc25, tigervnc-1.7.0-3.fc25, xorg-x11-drivers-7.7-18.fc25,
xorg-x11-drv-amdgpu-1.1.2-3.20160929git97d7386c.fc25,
xorg-x11-drv-armsoc-1.4.0-3.20160929.fc25,
xorg-x11-drv-ati-7.7.1-1.20160928git3fc839ff.fc25,
xorg-x11-drv-dummy-0.3.6-26.fc25, xorg-x11-drv-evdev-2.10.4-1.fc25,
xorg-x11-drv-fbdev-0.4.3-25.fc25, xorg-x11-drv-fbturbo-0.5.1-0.8.20150221.fc25,
xorg-x11-drv-freedreno-1.4.0-3.20160929.fc25,
xorg-x11-drv-geode-2.11.18-2.fc25,
xorg-x11-drv-intel-2.99.917-26.20160929.fc25,
xorg-x11-drv-ivtv-1.2.0-0.22.fc25,
xorg-x11-drv-libinput-0.19.1-3.20160929.fc25,
xorg-x11-drv-nouveau-1.0.13-1.fc25, xorg-x11-drv-omap-0.4.4-3.fc25,
xorg-x11-drv-openchrome-0.5.0-2.fc25, xorg-x11-drv-opentegra-0.7.0-8.fc25,
xorg-x11-drv-qxl-0.1.4-10.20160929gite13d28ee.fc25,
xorg-x11-drv-sisusb-0.9.6-24.fc25, xorg-x11-drv-synaptics-1.8.99.2-2.fc25,
xorg-x11-drv-v4l-0.2.0-47.fc25, xorg-x11-drv-vesa-2.3.2-25.fc25,
xorg-x11-drv-vmware-13.0.2-12.20150211git8f0cf7c.fc25,
xorg-x11-drv-voodoo-1.2.5-25.fc25,
xorg-x11-drv-wacom-0.33.0-2.20160929gitb61d1711.fc25,
xorg-x11-font-utils-7.5-32.fc25, xorg-x11-proto-devel-7.7-20.fc25,
xorg-x11-server-1.19.0-0.2.20160929.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324784] Review Request: pseudo - Advanced tool for simulating superuser privileges

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324784

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-19 13:27:43



--- Comment #23 from Fedora Update System  ---
pseudo-1.8.1-3.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350257] Review Request: petsc - Portable Extensible Toolkit for Scientific Computation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350257



--- Comment #44 from Antonio Trande  ---
(In reply to Dave Love from comment #43).
> 
> I'm still interested in the optimization, though.  I'd at least expect
> vectorization to be worthwhile, even if it only uses sse2 in this case, but
> I don't have time to do any benchmarking.  Do you have any numbers?

No, honestly.

SPEC:
http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/petsc/petsc.git/plain/petsc.spec?id=fea4ae21425e6d3bd973f1e7fda507edcde60317

SRPM:
https://copr-be.cloud.fedoraproject.org/results/sagitter/petsc/fedora-rawhide-i386/00467031-petsc/petsc-3.7.4-6.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386774] Review Request: kf5-libktorrent - Library providing torrent downloading code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386774



--- Comment #2 from Rex Dieter  ---
Better scratch:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16125503

(need patch_fuzz for rawhide apparently... even though all the patches used are
directly from upstream git)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357064] Review Request: lumina-desktop - A lightweight, portable desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357064

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-10-08 22:52:06 |2016-10-19 13:21:15



--- Comment #40 from Fedora Update System  ---
lumina-desktop-1.0.0-5.p2.Lbc08e90.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381935] Review Request: python-distro - Linux Distribution - a Linux OS platform information API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381935



--- Comment #18 from Fedora Update System  ---
python-distro-1.0.0-6.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350257] Review Request: petsc - Portable Extensible Toolkit for Scientific Computation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350257



--- Comment #43 from Dave Love  ---
(In reply to Antonio Trande from comment #42)
> (In reply to Dave Love from comment #41)
> > I still don't understand why the environment module is needed.
> 
> And i still don't understand of what env module you are talking.. :)

I beg your pardon -- I don't know why I thought it was still there...

I guess it's about OK now, though I still find the spec hard to follow.

I'm still interested in the optimization, though.  I'd at least expect
vectorization to be worthwhile, even if it only uses sse2 in this case, but
I don't have time to do any benchmarking.  Do you have any numbers?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350257] Review Request: petsc - Portable Extensible Toolkit for Scientific Computation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350257



--- Comment #42 from Antonio Trande  ---
(In reply to Dave Love from comment #41)
> I still don't understand why the environment module is needed.

And i still don't understand of what env module you are talking.. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386774] Review Request: kf5-libktorrent - Library providing torrent downloading code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386774



--- Comment #1 from Rex Dieter  ---
Spec URL: https://rdieter.fedorapeople.org/rpms/ktorrent/kf5-libktorrent.spec
SRPM URL:
https://rdieter.fedorapeople.org/rpms/ktorrent/kf5-libktorrent-2.0.1-4.fc24.src.rpm

%changelog
* Wed Oct 19 2016 Rex Dieter  - 2.0.1-4
- use upstreamable gmp fix/workaround

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16125181

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350257] Review Request: petsc - Portable Extensible Toolkit for Scientific Computation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350257



--- Comment #41 from Dave Love  ---
I still don't understand why the environment module is needed.

Why has it reverted to using -O2?

gmp is linked, but apparently never referenced, so presumably it can be
dropped.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373641] Review Request: setBfree - A DSP Tonewheel Organ emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373641



--- Comment #6 from Fabio Alessandro Locati  ---
Hi Guido,

Looking at this SPEC file, there are few things that should be improved in my
opinion before do a "proper" review.

1. Please send upstream all patches and file addition that can be sent
upstream. Fedora policy is to stay close to upstream. Examples of patches that
should be definitely sent upstream are the one to fix the FSF address as well
as fix version number (probably they forgot to change it during the release
process). Also, adding the desktop/appdata files to upstream will probably be
welcome as well.

2. the lv2-setBfree-plugins package does not depend on setBfree, which seems
odd to me.

3. The setBfree-common package only contains license and doc. Probably is
better to put those files in the setBfree package and drop the setBfree-common
package. If the lv2-setBfree-plugins package does not depend on the setBfree
package, it will need to carry it's own license file, otherwise the setBfree
one will be enough

If you have any doubts, please do contact me here, via email, or via irc :).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365839] Review Request: python-django-notifications-hq - GitHub notifications alike app for Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365839

Sundeep Anand  changed:

   What|Removed |Added

 Depends On||1375222




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1375222
[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django
field that allows you to store validated JSON in your model
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386774] Review Request: kf5-libktorrent - Library providing torrent downloading code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386774

Rex Dieter  changed:

   What|Removed |Added

 Blocks||656997 (kde-reviews)
  Alias||kf5-libktorrent




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=656997
[Bug 656997] kde-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386774] New: Review Request: kf5-libktorrent - Library providing torrent downloading code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386774

Bug ID: 1386774
   Summary: Review Request: kf5-libktorrent - Library providing
torrent downloading code
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rdie...@math.unl.edu
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://rdieter.fedorapeople.org/rpms/ktorrent/kf5-libktorrent.spec
SRPM URL:
https://rdieter.fedorapeople.org/rpms/ktorrent/kf5-libktorrent-2.0.1-3.fc24.src.rpm
Description: Library providing torrent downloading code
Fedora Account System Username: rdieter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Sundeep Anand  changed:

   What|Removed |Added

 Blocks||1365839




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1365839
[Bug 1365839] Review Request: python-django-notifications-hq - GitHub
notifications alike app for Django
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Sundeep Anand  changed:

   What|Removed |Added

 CC||suan...@redhat.com



--- Comment #9 from Sundeep Anand  ---
*** Bug 1386760 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386760] Review Request: python-django-jsonfield - A reusable Django field that allows to store validated JSON in model.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386760

Sundeep Anand  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2016-10-19 11:22:17



--- Comment #2 from Sundeep Anand  ---


*** This bug has been marked as a duplicate of bug 1375222 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386760] Review Request: python-django-jsonfield - A reusable Django field that allows to store validated JSON in model.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386760



--- Comment #1 from Sundeep Anand  ---
Builds:
https://koji.fedoraproject.org/koji/taskinfo?taskID=16122598
https://koji.fedoraproject.org/koji/taskinfo?taskID=16122653

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386760] New: Review Request: python-django-jsonfield - A reusable Django field that allows to store validated JSON in model.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386760

Bug ID: 1386760
   Summary: Review Request: python-django-jsonfield - A reusable
Django field that allows to store validated JSON in
model.
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: suan...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://bitbucket.org/sundeep_co_in/python-pkgs/downloads/python-django-jsonfield.spec
SRPM URL:
https://bitbucket.org/sundeep_co_in/python-pkgs/downloads/python-django-jsonfield-1.0.3-1.fc24.src.rpm
Description: django-jsonfield is a reusable Django field that allows you to
store validated JSON in your model.
Fedora Account System Username:suanand

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386735] Review Request: php-fedora-autoloader - Fedora Autoloader

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386735



--- Comment #3 from Remi Collet  ---
Created attachment 1212185
  --> https://bugzilla.redhat.com/attachment.cgi?id=1212185=edit
review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1386735
Buildroot used: fedora-rawhide-x86_64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386735] Review Request: php-fedora-autoloader - Fedora Autoloader

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386735

Remi Collet  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #4 from Remi Collet  ---
[!]: Package functions as described.
phpab template is not functional.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386735] Review Request: php-fedora-autoloader - Fedora Autoloader

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386735



--- Comment #5 from Remi Collet  ---
As README contains mostly dev instructions, perhaps can be moved in -devel
subpackage (and probably also composer.json)

Which will make the "runtime" package really small.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386735] Review Request: php-fedora-autoloader - Fedora Autoloader

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386735

Remi Collet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|fed...@famillecollet.com



--- Comment #2 from Remi Collet  ---
Created attachment 1212183
  --> https://bugzilla.redhat.com/attachment.cgi?id=1212183=edit
phpci.log

phpCompatInfo version 5.0.1 DB version 1.14.0 built Oct 15 2016 18:25:18 CEST
static analyze results

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386735] Review Request: php-fedora-autoloader - Fedora Autoloader

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386735

Remi Collet  changed:

   What|Removed |Added

 CC||fed...@famillecollet.com



--- Comment #1 from Remi Collet  ---
Please ;)


-sed 's#__PHPDIR__#%{phpdir}#' res/phpab/fedora.php.tpl
+sed -e 's#__PHPDIR__#%{phpdir}/Fedora/Autoloader#' -i res/phpab/fedora.php.tpl

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386735] New: Review Request: php-fedora-autoloader - Fedora Autoloader

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386735

Bug ID: 1386735
   Summary: Review Request: php-fedora-autoloader - Fedora
Autoloader
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/9648c70d5c63b6816f4739bdf347fbe00dd35361/php-fedora-autoloader/php-fedora-autoloader.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-fedora-autoloader-0.1.0-1.fc24.src.rpm

Description:
Static PSR-4 [1], PSR-0 [2], and classmap autoloader.  Includes loader for
required and optional dependencies.

[1] http://www.php-fig.org/psr/psr-4/
[2] http://www.php-fig.org/psr/psr-0/


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375962] Review Request: python-sphinx-intl - Sphinx utility that make it easy to translate and to apply translation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375962



--- Comment #11 from Fedora Update System  ---
python-sphinx-intl-0.9.9-3.gitbf6edc2.fc24 has been pushed to the Fedora 24
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381935] Review Request: python-distro - Linux Distribution - a Linux OS platform information API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381935



--- Comment #17 from Fedora Update System  ---
python-distro-1.0.0-6.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382875] Review Request: psad - Port Scan Attack Detector (psad) watches for suspect traffic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382875



--- Comment #10 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Jens Lody from comment #3)
> - Permissions on files are set properly.
>   Note: See rpmlint output
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
> 
> The cause for the 0700 file-permissions should be documented in spec-file.

Fixed.

[...]
> =
> 
> [ ]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "GPL (v2 or later) (with incorrect FSF address)", "BSD (3
>  clause)", "Unknown or generated". 63 files have unknown license.
>  Detailed output of licensecheck in
>  /home/jens/reviews/rawhide/1382875-psad/licensecheck.txt
> 
> Not sure about the two strl*.c files with BSD3 license, but I guess they
> should be mentioned in license-tag

GPLv2+ and BSD is effectively GPLv2+, as mentioned in comment #5.

> 
> =
> 
> [ ]: Package does not own files or directories owned by other packages.
>  Note: Dirs in package are owned also by: /etc/logrotate.d(samba-
>  common, logrotate, ppp, sssd-common)
> 
> Is "%dir /etc/logrotate.d" really needed ?

Yes. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

> =
> 
> [!]: Patches link to upstream bugs/comments/lists or are otherwise
>  justified.
> A comment is missing in spec/and patch-file.

Fixed.

> =
> 
> [?]: Package should compile and build into binary rpms on all supported
>  architectures.
> Not tested/testable.

Actually this is testable using koji.

> psad.x86_64: E: incorrect-fsf-address /usr/share/licenses/psad/LICENSE
> psad-debuginfo.x86_64: E: incorrect-fsf-address
> /usr/src/debug/psad-2.4.3/psad.h
> psad-debuginfo.x86_64: E: incorrect-fsf-address
> /usr/src/debug/psad-2.4.3/psad_funcs.c
> psad-debuginfo.x86_64: E: incorrect-fsf-address
> /usr/src/debug/psad-2.4.3/kmsgsd.c
> 
> Upstream should be informed, the source/header-files can be patched, but
> there is no need to.
> The LICENSE-file should not be changed.

I'll inform upstream.

Spec URL: https://rathann.fedorapeople.org/review/psad/psad.spec
SRPM URL:
https://rathann.fedorapeople.org/review/psad/psad-2.4.3-2.fc24.src.rpm

* Sun Oct 09 2016 Dominik Mierzejewski  - 2.4.3-2
- fix SELinux policy temporarily (#1040425)
- document patch purpose and file/dir permissions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386625] Review Request: gotun - Tool to run tests on OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386625



--- Comment #3 from kushal...@gmail.com  ---
Updated spec, and SRPM.

Spec URL: https://kushal.fedorapeople.org/packages/gotun.spec
SRPM URL:
https://kushal.fedorapeople.org/packages/gotun-0-0.1.git839a210.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386563] Review Request: python-ruamel-yaml - YAML 1.2 loader/ dumper package for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386563

Parag AN(पराग)  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

==> This is expected as required dependency python-ruamel-ordereddict not in
configured/rawhide repository yet.

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* MIT/X11 (BSD like)", "Unknown or generated". 46
 files have unknown license. Detailed output of licensecheck in
 /home/parag/1386563-python-ruamel-yaml/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in 

[Bug 1386638] Review Request: eclipse-usage - Usage reporting plug-ins for Eclipse

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386638

Alexander Kurtakov  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386638] Review Request: eclipse-usage - Usage reporting plug-ins for Eclipse

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386638

Alexander Kurtakov  changed:

   What|Removed |Added

 CC||akurt...@redhat.com
   Assignee|nob...@fedoraproject.org|akurt...@redhat.com
  Flags||fedora-review?



--- Comment #1 from Alexander Kurtakov  ---
I'll do this one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386625] Review Request: gotun - Tool to run tests on OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386625



--- Comment #2 from kushal...@gmail.com  ---
Updated spec, and SRPM.

Spec URL: https://kushal.fedorapeople.org/packages/gotun.spec
SRPM URL:
https://kushal.fedorapeople.org/packages/gotun-0.1.0-0.1.git839a210.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385331] Review Request: hot-tux - Graphical CPU utilization monitoring utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385331



--- Comment #2 from jiri vanek  ---
Thanx! I will fix it with other issues flowing from review.

As for scratches - I built it on all architectures, but scracthbuilds have very
short live, so it do not have sense to put them here, as they usually disapear
before anybody pick the bug up.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1318969] Review Request: perl-B-Hooks-OP-Check-EntersubForCV - Invoke callbacks on construction of entersub OPs for certain CVs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318969

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-10-19 07:01:30



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386638] New: Review Request: eclipse-usage - Usage reporting plug-ins for Eclipse

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386638

Bug ID: 1386638
   Summary: Review Request: eclipse-usage - Usage reporting
plug-ins for Eclipse
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mat.bo...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://fedorapeople.org/~mbooth/reviews/eclipse-usage.spec
SRPM URL:
https://fedorapeople.org/~mbooth/reviews/eclipse-usage-4.4.1-1.fc26.src.rpm
Description: Usage reporting plug-ins for Eclipse
Fedora Account System Username: mbooth

See also, koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16123417

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386625] Review Request: gotun - Tool to run tests on OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386625

Jan Chaloupka  changed:

   What|Removed |Added

 CC||jchal...@redhat.com



--- Comment #1 from Jan Chaloupka  ---
Running dependency check on the last commit from upstream repository
(b65f2d15d928a82a5a310ddba83de46dd89e27e2):

$ gofed check-deps --godeps Godeps.json
ERROR:root:Unable to get mapping for gopkg.in/yaml.v2
ERROR:root:Unable to get mapping for github.com/pkg/sftp
ERROR:root:Unable to get mapping for github.com/spf13/afero/sftp
ERROR:root:Unable to get mapping for github.com/spf13/jwalterweatherman
ERROR:root:Unable to get mapping for github.com/spf13/afero
ERROR:root:Unable to get mapping for github.com/fsnotify/fsnotify
ERROR:root:Unable to get mapping for github.com/pelletier/go-buffruneio
ERROR:root:Unable to get mapping for github.com/pelletier/go-toml
ERROR:root:Unable to get mapping for github.com/spf13/afero/mem
ERROR:root:Unable to get mapping for github.com/pkg/errors
github.com/hashicorp/hcl is outdated in distribution
github.com/urfave/cli is outdated in distribution
Unable to find ipprefix2rpm mapping 'github.com/pkg/sftp' ipprefix
Unable to find ipprefix2rpm mapping 'gopkg.in/yaml.v2' ipprefix
github.com/rackspace/gophercloud is outdated in distribution: not covered:
[u'github.com/rackspace/gophercloud/openstack/imageservice/v2/images']
Unable to find ipprefix2rpm mapping 'github.com/pelletier/go-buffruneio'
ipprefix
golang.org/x/sys is outdated in distribution
golang.org/x/crypto is outdated in distribution: not covered:
[u'golang.org/x/crypto/ed25519',
u'golang.org/x/crypto/ed25519/internal/edwards25519']
github.com/magiconair/properties is outdated in distribution
Unable to find ipprefix2rpm mapping 'github.com/spf13/afero' ipprefix
golang.org/x/text is outdated in distribution
github.com/spf13/cast is outdated in distribution
github.com/mitchellh/mapstructure is outdated in distribution
Unable to find ipprefix2rpm mapping 'github.com/pelletier/go-toml' ipprefix
Unable to find ipprefix2rpm mapping 'github.com/pkg/errors' ipprefix
Unable to find ipprefix2rpm mapping 'github.com/spf13/jwalterweatherman'
ipprefix
github.com/kr/fs is up-to-date
Unable to find ipprefix2rpm mapping 'github.com/fsnotify/fsnotify' ipprefix
github.com/spf13/viper is outdated in distribution
github.com/spf13/pflag is outdated in distribution

Summary:
- 11 package outdated
- 5 packages missing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386625] New: Review Request: gotun - Tool to run tests on OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386625

Bug ID: 1386625
   Summary: Review Request: gotun - Tool to run tests on OpenStack
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: m...@kushaldas.in
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://kushal.fedorapeople.org/packages/gotun.spec
SRPM URL:
https://kushal.fedorapeople.org/packages/gotun-0.1.0-0.1.gite6546c3.fc24.src.rpm
Description: Tool to run tests on OpenStack or remote system.
Fedora Account System Username: kushal


Note: The RPM is still broken.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310368] review request: rubygem-jekyll - A simple, blog aware, static site generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310368



--- Comment #10 from Vít Ondruch  ---
(In reply to John Heidemann from comment #9)
> It's not clear that the packages at
> https://bugzilla.redhat.com/show_bug.cgi?id=1368851
> 
> include all of the extensions listed above (in particular:
> rubygem-jekyll-scholar and its dependencies).
> 
> I guess that is a new ticket?

You are right, rubygem-jekyll-scholar is not yet in Fedora. If you want to get
it in, please open new ticket. If it has some missing dependencies, then please
open separate ticket for each of the dependencies.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

Zuzana Svetlikova  changed:

   What|Removed |Added

  Flags|needinfo?(zsvetlik@redhat.c |
   |om) |



--- Comment #10 from Zuzana Svetlikova  ---
Sources:

Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx.spec
SRPM URL:
https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx-0.5.1-1.f26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381087] Review Request: python-pandas-datareader - Data readers from the pandas codebase

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381087

Sergio Pascual  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-10-19 06:00:32



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381548] Review Request: mariadb-connector-odbc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381548



--- Comment #4 from Michal Schorm  ---
Third review request:

* %{_libdir}/mariadb/ added as into %files section of package
mariadb-connector-c-devel and RPATH was fixed. New release (2.3.1-2.fc26) is on
its way to rawhide repo by now.

Reason:
You can install mariadb-connector-c as a part of mariadb (so mariadb owns the
libdir/mariadb directory).
But the goal of mariadb-connector-c, which can be used as a standalone package
in various use-cases, is to offer its functionality without whole mariadb. (For
example if mariadb-server is remote) 
That's why mariadb-connector-c-devel (which place library in libdir/mariadb)
must own libdir/mariadb directory.

* libmaodbc.so should stay directly in %{_libdir}

Reason:
mariadb-connector-odbc is NOT mariadb plugin. To be exact, it is unix-odbc
plugin. To preserve consistency, it should reside, where all other unixODBC
plugins are - directly in %{_libdir} directory.

Note:
In order to Packaging guidelines, (1) plugins libraries don't need to be
versioned and (2) NONE unversioned libraries should be directly in libdir.
The only right solution would be to move ALL unix-odbc plugins from all
associated packages to their new libdir/unixodbc directory at once.  

_

SPEC and url did not change, the now point to updated version.
SRPM url update to:
https://raw.githubusercontent.com/FaramosCZ/Fedora-maintain/master/mariadb/mariadb-connector-odbc/SRPMS/mariadb-connector-odbc-2.0.12-1.fc26.src.rpm
Old version can be found on GitHub in "Version 1" and "Version 2" branches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386563] Review Request: python-ruamel-yaml - YAML 1.2 loader/ dumper package for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386563

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386563] New: Review Request: python-ruamel-yaml - YAML 1.2 loader/ dumper package for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386563

Bug ID: 1386563
   Summary: Review Request: python-ruamel-yaml - YAML 1.2
loader/dumper package for Python
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: chku...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://chandankumar.fedorapeople.org/python-ruamel-yaml.spec
SRPM URL:
https://chandankumar.fedorapeople.org/python-ruamel-yaml-0.12.14-1.fc24.src.rpm


Description: ruamel.yaml is a YAML 1.2 loader/dumper package for Python.
It is a derivative of Kirill Simonov’s PyYAML 3.11

Fedora Account System Username: chandankumar

Successful Koji Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16122587

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/ YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917



--- Comment #6 from Fedora Update System  ---
python-pykwalify-1.5.1-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-186d414a86

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385180] Review Request: purple-facebook - Facebook protocol plugin for purple2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385180



--- Comment #8 from Fedora Update System  ---
purple-facebook-0.0.0.20160409-0.4.git66ee773.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-fd02294bfb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385180] Review Request: purple-facebook - Facebook protocol plugin for purple2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385180



--- Comment #7 from Fedora Update System  ---
purple-facebook-0.0.0.20160409-0.4.git66ee773.fc23 has been pushed to the
Fedora 23 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1fee03e1a8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385331] Review Request: hot-tux - Graphical CPU utilization monitoring utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385331

Link Dupont  changed:

   What|Removed |Added

 CC||l...@sub-pop.net



--- Comment #1 from Link Dupont  ---
Incorrect version in %changelog.

> hot-tux.x86_64: W: incoherent-version-in-changelog 0.3.0-1 ['0.3.1-1.fc24', 
> '0.3.1-1']
> 2 packages and 0 specfiles checked; 0 errors, 1 warnings.

Try submitting a scratch build to koji to build on all the supported
architectures.

*Note I am not yet an approved packager*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org