[Bug 1391216] Review Request: python3-pygments - Syntax highlighting engine written in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391216

Tim Orling  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ticot...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336555] Review Request: python3-pytz - World Timezone Definitions for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336555



--- Comment #2 from Tim Orling  ---
WARNING: Cannot download url:
http://pypi.python.org/packages/source/p/pytz/pytz-2016.4.tar.gz

Latest:
https://pypi.python.org/pypi/pytz/2016.7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376932] Review Request: python3-markupsafe - Implements a XML/HTML/ XHTML Markup safe string for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376932



--- Comment #2 from Tim Orling  ---
ERROR: 'Error 404 downloading
http://www.cora.nwra.com/~orion/fedora/python3-markupsafe-0.23-1.el7.src.rpm'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384130] Review Request: python3-sqlalchemy - Modular and flexible ORM library for python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384130



--- Comment #1 from Tim Orling  ---
Koji EPEL7 build: https://koji.fedoraproject.org/koji/taskinfo?taskID=16345936
Koji EL6 build: https://koji.fedoraproject.org/koji/taskinfo?taskID=16345941

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- Package contains BR: python2-devel or python3-devel
  => This is ok, as %{python3_pkgversion}-devel is used and this is EPEL only.
- Latest version is 1.1.3, provided version is 1.1.1
  => To be fair, upstream has bumped twice in 20 days.
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 17274880 bytes in 278 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 255 files have
 unknown license. Detailed output of licensecheck in
 /home/parallels/1384130-python3-sqlalchemy/licensecheck.txt
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/licenses
 => In EPEL there is no owner of /usr/share/licenses
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/licenses
 => In EPEL there is no owner of /usr/share/licenses
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
 Note: Macros in: python34-sqlalchemy (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 

[Bug 1384130] Review Request: python3-sqlalchemy - Modular and flexible ORM library for python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384130

Tim Orling  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ticot...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384249] Review Request: python3-ply - Python Lex-Yacc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384249

Tim Orling  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #1 from Tim Orling  ---
Koji build EPEL7: http://koji.fedoraproject.org/koji/taskinfo?taskID=16345664
Koji build EL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=16345670

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- Package contains BR: python2-devel or python3-devel
  => This is ok, as %{python3_pkgversion}-devel is used and this is EPEL only.
- Latest version is 3.9, provided version is 3.8

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "Unknown or generated". 141 files have
 unknown license. Detailed output of licensecheck in
 /home/parallels/1384249-python3-ply/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
 Note: Macros in: python34-ply (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[!]: Latest version is packaged.
 => ply 3.9 is latest
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package 

[Bug 1384249] Review Request: python3-ply - Python Lex-Yacc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384249

Tim Orling  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ticot...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636

Tim Orling  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Tim Orling  ---
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16344573

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- Package contains BR: python2-devel or python3-devel
  => This is ok, as %{python3_pkgversion}-devel is used and this is EPEL only.
- Package should not use obsolete m4 macros
 Note: Some obsoleted macros found, see the attachment.
 See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
  => This is ok, as 'autoupdate' is used in spec file to replace obsolete
macros


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
 => expected behavior for python extensions, *.so -> site-packages
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 10 files have
 unknown license. Detailed output of licensecheck in
 /home/parallels/1324636-python3-dbus/licensecheck.txt
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/licenses
 => EPEL7 has no owner of /usr/share/licenses
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/licenses
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
 Note: Macros in: python34-dbus (summary), python34-dbus (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: 

[Bug 1392227] Review Request: pidgin-groupchat-typing-notifications - Adds typing notifications for group chats in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392227



--- Comment #11 from Fedora Update System  ---
pidgin-groupchat-typing-notifications-0-2.git33a75f9.fc23 has been pushed to
the Fedora 23 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f0639c407b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392227] Review Request: pidgin-groupchat-typing-notifications - Adds typing notifications for group chats in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392227



--- Comment #10 from Fedora Update System  ---
pidgin-groupchat-typing-notifications-0-2.git33a75f9.fc24 has been pushed to
the Fedora 24 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-844bebd440

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1279104] Review Request: python-pbkdf2 - password-based key derivation in pure Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279104

Jonny Heggheim  changed:

   What|Removed |Added

 CC||jonnyheggh...@sigaint.org
  Flags||needinfo?(gy...@fsfe.org)



--- Comment #8 from Jonny Heggheim  ---
Just to not step on anyone toes:

Any updates? Anyone want to maintain this package? This package is a dependency
on Electrum, which I want to include in Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392649] Review Request: tacacs+- Cisco AAA server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392649



--- Comment #1 from Philip Prindeville  ---
Grrr... Copy issues w/ my VM.  Let's try it again:

Spec URL: http://fedorapeople.org/~philipp/tacacs+.spec
SRPM URL: http://fedorapeople.org/~philipp/tacacs+-F4.0.4.29a-2.fc24.src.rpm
Description: Tacacs+ authentication/authorization/accounting daaemon
Fedora Account System Username: philipp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392649] New: Review Request: tacacs+- Cisco AAA server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392649

Bug ID: 1392649
   Summary: Review Request: tacacs+- Cisco AAA server
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: phil...@redfish-solutions.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://fedorapeople.org/~philipp/tacacs+-F4.0.4.29a-2.fc24.src.rpm
SRPM URL:
https://fedorapeople.org/~philipp/tacacs+-F4.0.4.29a-2.fc24.x86_64.rpm
Description: Tacacs+ authentication/authorization/accounting daaemon
Fedora Account System Username: philipp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187082] Review Request: python-slowaes - An Implementation of AES in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187082

Jonny Heggheim  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187082] Review Request: python-slowaes - An Implementation of AES in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187082



--- Comment #16 from Jonny Heggheim  ---
I am not sure if I should create a new ticket or re-use this, anyway just let
me know if I should create a new ticket.

Here is an updated version based on the work of Samuel Gyger:

Spec URL: https://jonny.fedorapeople.org/python-slowaes/python-slowaes.spec
SRPM URL:
https://jonny.fedorapeople.org/python-slowaes/python-slowaes-0.1a1-6.fc25.src.rpm
Description: A pure Python AES implementation
Fedora Account System Username: jonny


Anyone that would like to do a formal review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382928] Review Request: perl-HTTP-Entity-Parser - PSGI compliant HTTP Entity Parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382928
Bug 1382928 depends on bug 1382926, which changed state.

Bug 1382926 Summary: Review Request: perl-HTTP-MultiPartParser - HTTP MultiPart 
Parser
https://bugzilla.redhat.com/show_bug.cgi?id=1382926

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382926] Review Request: perl-HTTP-MultiPartParser - HTTP MultiPart Parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382926

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-11-03 14:22:24 |2016-11-07 18:24:41



--- Comment #9 from Fedora Update System  ---
perl-HTTP-MultiPartParser-0.01-2.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387837] Review Request: python-hidapi - Interface to the hidapi library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387837



--- Comment #10 from Fedora Update System  ---
python-binstruct-1.0.1-1.fc24, python-bitstruct-3.3.1-1.fc24,
python-evic-0.1-0.4.git20160814.f916017.fc24,
python-hidapi-0.7.99.post20-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387835] Review Request: python-binstruct - Library for read/ write access of binary data via structures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387835



--- Comment #14 from Fedora Update System  ---
python-binstruct-1.0.1-1.fc24, python-bitstruct-3.3.1-1.fc24,
python-evic-0.1-0.4.git20160814.f916017.fc24,
python-hidapi-0.7.99.post20-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387834] Review Request: python-evic - USB programmer for devices based on the Joyetech Evic VTC Mini

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387834



--- Comment #12 from Fedora Update System  ---
python-binstruct-1.0.1-1.fc24, python-bitstruct-3.3.1-1.fc24,
python-evic-0.1-0.4.git20160814.f916017.fc24,
python-hidapi-0.7.99.post20-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387836] Review Request: python-bitstruct - Interpret strings as packed binary data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387836



--- Comment #10 from Fedora Update System  ---
python-binstruct-1.0.1-1.fc24, python-bitstruct-3.3.1-1.fc24,
python-evic-0.1-0.4.git20160814.f916017.fc24,
python-hidapi-0.7.99.post20-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386735] Review Request: php-fedora-autoloader - Fedora Autoloader

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386735



--- Comment #30 from Fedora Update System  ---
php-fedora-autoloader-0.2.1-2.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215



--- Comment #15 from Orion Poplawski  ---
Hmm, maybe hold of a bit.  I'm trying to use it to compile pocl, but not having
luck yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215



--- Comment #14 from Orion Poplawski  ---
Milan - could you build this for EPEL7 too?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187082] Review Request: python-slowaes - An Implementation of AES in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187082



--- Comment #15 from Jonny Heggheim  ---
Ok, thanks for your feedback

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187082] Review Request: python-slowaes - An Implementation of AES in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187082

Samuel Gyger  changed:

   What|Removed |Added

  Flags|needinfo?(gy...@fsfe.org)   |



--- Comment #14 from Samuel Gyger  ---
Hey Jonny,
I didn't find the time. Feel free to take over, you can use all the Files I
have Provided here. They are free to use under what ever license you want to
use them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1157299] Review Request: "jonathan-jeremie" - Distributed Object Platform (DOP) written entirely in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157299

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it,
   ||wei.d.c...@intel.com
  Flags||needinfo?(wei.d.chen@intel.
   ||com)



--- Comment #1 from gil cattaneo  ---
hi, can you close this bug?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1157299] Review Request: "jonathan-jeremie" - Distributed Object Platform (DOP) written entirely in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157299

gil cattaneo  changed:

   What|Removed |Added

 Blocks||201449 (FE-DEADREVIEW)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1157299] Review Request: "jonathan-jeremie" - Distributed Object Platform (DOP) written entirely in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157299

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1086608] Review Request: jna-posix - Java library for accessing common POSIX functions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1086608

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187082] Review Request: python-slowaes - An Implementation of AES in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187082

Jonny Heggheim  changed:

   What|Removed |Added

 CC||jonnyheggh...@sigaint.org
  Flags||needinfo?(gy...@fsfe.org)



--- Comment #13 from Jonny Heggheim  ---
What is the update? Do you have done informal reviews? I am interested in
getting Electrum and slowaes into Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392606] New: Review Request: perl-Encode-IMAPUTF7 - Process the special UTF-7 variant required by IMAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392606

Bug ID: 1392606
   Summary: Review Request: perl-Encode-IMAPUTF7 - Process the
special UTF-7 variant required by IMAP
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ti...@math.uh.edu
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://www.math.uh.edu/~tibbs/review/perl-Encode-IMAPUTF7/perl-Encode-IMAPUTF7.spec
SRPM URL:
https://www.math.uh.edu/~tibbs/review/perl-Encode-IMAPUTF7/perl-Encode-IMAPUTF7-1.05-1.fc24.src.rpm
Description:
This module is able to encode and decode IMAP mailbox names using the UTF-7
modification specified in RFC2060 section 5.1.3.

Fedora Account System Username: tibbs

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16340823

Fedora-review output (note that any strange-permissions errors are due to
rpmlint not being able to cope with my umask):

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[ ]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
[ ]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[ ]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/perl5/vendor_perl/Encode(perl-Encode-Locale)
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
 names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.

ἐπιθυμία:..perl-Encode-IMAPUTF7/review-perl-Encode-IMAPUTF7> cat review.txt

This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[ ]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
[ ]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[ ]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/perl5/vendor_perl/Encode(perl-Encode-Locale)
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ 

[Bug 1392599] Review Request: mcrcon - Console based rcon client for minecraft servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392599



--- Comment #1 from srakitnican  ---
Sorry, wrong SRPM URL.

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/srakitnican/minecraft/fedora-rawhide-x86_64/00474083-mcrcon/mcrcon-0.0.5-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392599] Review Request: mcrcon - Console based rcon client for minecraft servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392599

srakitnican  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392599] New: Review Request: mcrcon - Console based rcon client for minecraft servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392599

Bug ID: 1392599
   Summary: Review Request: mcrcon - Console based rcon client for
minecraft servers
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: samuel.rakitni...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/srakitnican/minecraft/mcrcon.git/tree/mcrcon.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/srakitnican/minecraft/fedora-rawhide-x86_64/00474083-mcrcon/mcrcon-0.0.5-2.fc26.x86_64.rpm


Description:

Mcrcon is powerful IPv6 compliant minecraft rcon client with bukkit coloring
support.
It is well suited for remote administration and to be used as part of automated
server maintenance scripts.
Does not cause "IO: Broken pipe" or "IO: Connection reset" spam in server
console.

Features:
 - Interacive terminal mode. Keeps the connection alive.
 - Send multiple commands in one command line.
 - Silent mode. Does not print rcon output.
 - Support for bukkit coloring on Windows and Linux (sh compatible shells).
 - Multiplatform code. Compiles on many platforms with only minor changes.

Fedora Account System Username: srakitnican


This is my first package, thus I am seeking for a sponsor!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376867] Review Request: python3-pycurl - Python interface to libcurl for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376867
Bug 1376867 depends on bug 1376864, which changed state.

Bug 1376864 Summary: Ship python34-pyflakes
https://bugzilla.redhat.com/show_bug.cgi?id=1376864

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383487] Review Request: php-akamai-open-edgegrid-auth - Implements the Akamai {OPEN} EdgeGrid Authentication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383487



--- Comment #13 from Fedora Update System  ---
php-akamai-open-edgegrid-auth-0.6.0-1.el7 has been pushed to the Fedora EPEL 7
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1370239] Review Request: python-ansible-tower-cli - A CLI tool for Ansible Tower

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370239



--- Comment #19 from Fedora Update System  ---
python-ansible-tower-cli-3.0.1-1.el7 has been pushed to the Fedora EPEL 7
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383488] Review Request: php-asm89-stack-cors - Cross-origin resource sharing library and stack middleware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383488



--- Comment #15 from Fedora Update System  ---
php-asm89-stack-cors-1.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383488] Review Request: php-asm89-stack-cors - Cross-origin resource sharing library and stack middleware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383488



--- Comment #14 from Fedora Update System  ---
php-asm89-stack-cors-1.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390156

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
jsonassert-1.4.0-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-15dbccbf42

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392227] Review Request: pidgin-groupchat-typing-notifications - Adds typing notifications for group chats in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392227

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
pidgin-groupchat-typing-notifications-0-1.git33a75f9.fc25 has been pushed to
the Fedora 25 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e11a1fd11d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392553] New: webalizer package for EPEL7

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392553

Bug ID: 1392553
   Summary: webalizer package for EPEL7
   Product: Fedora EPEL
   Version: epel7
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: watte...@watters.ws
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



The webalizer package is not available in epel7.  Can you please build this
package for CentOS 7?  There is an SRPM available for CentOS 6.8 which builds
properly after patching the spec file as shown below.

[root@example-srv1 SPECS]# diff -u webalizer.spec.orig webalizer.spec
--- webalizer.spec.orig2016-11-07 11:59:46.550527719 -0500
+++ webalizer.spec2016-11-07 11:59:53.844621850 -0500
@@ -18,7 +18,7 @@
 Patch6: webalizer-2.01_10-confuser.patch
 Patch9: webalizer-2.01-10-groupvisit.patch
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-BuildRequires: gd-devel, db4-devel, bzip2-devel
+BuildRequires: gd-devel, db4-devel, bzip2-devel, libdb-devel
 Requires(pre): /usr/sbin/useradd
 Requires: httpd, crontabs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636

Orion Poplawski  changed:

   What|Removed |Added

  Flags|needinfo?(or...@cora.nwra.c |
   |om) |



--- Comment #4 from Orion Poplawski  ---
Thanks for the review.

Spec URL: http://www.cora.nwra.com/~orion/fedora/python3-dbus.spec
SRPM URL:
http://www.cora.nwra.com/~orion/fedora/python3-dbus-1.2.4-2.el7.src.rpm

* Mon Nov 7 2016 Orion Poplawski  - 1.2.4-2
- Run autoupdate to remove obsolete macros such as AC_PROG_LIBTOOL

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392227] Review Request: pidgin-groupchat-typing-notifications - Adds typing notifications for group chats in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392227



--- Comment #8 from Fedora Update System  ---
pidgin-groupchat-typing-notifications-0-2.git33a75f9.fc24 has been submitted as
an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-844bebd440

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392227] Review Request: pidgin-groupchat-typing-notifications - Adds typing notifications for group chats in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392227



--- Comment #7 from Fedora Update System  ---
pidgin-groupchat-typing-notifications-0-2.git33a75f9.fc23 has been submitted as
an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f0639c407b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Yaniv Bronhaim  changed:

   What|Removed |Added

  Flags|needinfo?(ybronhei@redhat.c |
   |om) |



--- Comment #30 from Yaniv Bronhaim  ---
currently nobody works on it. we plan to re-visit it and finish the review in
later versions. please update the bug status if needed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1315495] Review Request: ibus-table-coptic - Unicode Ibus keyboard input for Sahidic Coptic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315495



--- Comment #9 from Mike FABIAN  ---
Created attachment 1218128
  --> https://bugzilla.redhat.com/attachment.cgi?id=1218128=edit
cop-greek-kbd.mim

For use with ibus-m17n, the attached file can be used.

You will need to install

ibus-m17n
Any suitable Unicode font

Installation

$ mkdir -p ~/.m17n.d/
$ cp cop-greek-kbd.mim ~/.m17n.d/
$ ibus restart

Now ibus should list the newly added input method:

$ ibus  list-engine | grep  -i cop
  m17n:cop:greek-kbd - greek-kbd (m17n)

Now add the input method  using the gnome-control-center
or, on non-Gnome desktops, ibus-setup.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392434] Review Request: perl-XML-LibXML-Devel-SetLineNumber - Set the line number for an XML:: LibXML::Node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392434



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-XML-LibXML-Devel-SetLineNumber

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392388] Review Request: perl-Geo-Distance - Calculate distances and closest locations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392388

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Geo-Distance-0.20-1.fc
   ||26
 Resolution|--- |RAWHIDE
Last Closed||2016-11-07 11:02:45



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392434] Review Request: perl-XML-LibXML-Devel-SetLineNumber - Set the line number for an XML:: LibXML::Node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392434

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires
perl-XML-LibXML-Devel-SetLineNumber-0.002-1.fc26.x86_64.rpm | sort | uniq -c
  1 libc.so.6()(64bit)
  1 libc.so.6(GLIBC_2.2.5)(64bit)
  1 libdl.so.2()(64bit)
  1 libm.so.6()(64bit)
  1 libperl.so.5.24()(64bit)
  1 libxml2.so.2()(64bit)
  1 libxml2.so.2(LIBXML2_2.4.30)(64bit)
  1 libz.so.1()(64bit)
  1 perl(:MODULE_COMPAT_5.24.0)
  1 perl(:VERSION) >= 5.8.3
  1 perl(Exporter)
  1 perl(XML::LibXML) >= 1.90
  1 perl(XML::LibXML::Devel)
  1 perl(XSLoader)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
  1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides
perl-XML-LibXML-Devel-SetLineNumber-0.002-1.fc26.x86_64.rpm | sort | uniq -c
  1 perl(XML::LibXML::Devel::SetLineNumber) = 0.002
  1 perl-XML-LibXML-Devel-SetLineNumber = 0.002-1.fc26
  1 perl-XML-LibXML-Devel-SetLineNumber(x86-64) = 0.002-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-XML-LibXML-Devel-SetLineNumber*
perl-XML-LibXML-Devel-SetLineNumber.src: W: invalid-license (GPL+
perl-XML-LibXML-Devel-SetLineNumber.src: W: invalid-license Artistic
perl-XML-LibXML-Devel-SetLineNumber.src: W: invalid-license CC-BY-SA)
perl-XML-LibXML-Devel-SetLineNumber.x86_64: W: invalid-license (GPL+
perl-XML-LibXML-Devel-SetLineNumber.x86_64: W: invalid-license Artistic
perl-XML-LibXML-Devel-SetLineNumber.x86_64: W: invalid-license CC-BY-SA)
2 packages and 1 specfiles checked; 0 errors, 6 warnings.

The license is valid. It seems that rpmlint did not properly process '((GPL+ or
Artistic) or CC-BY-SA)'.
Rpmlint is ok

The package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383781



--- Comment #17 from Michal Vala  ---
fixed, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343977] Review Request: asciidoctor-mallard - A Project Mallard converter for AsciiDoc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343977

Tummala Dhanvi (c0mrad3)  changed:

   What|Removed |Added

 Depends On||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390063] Package Review: classloader-leak-test-framework - Detection and verification of Java ClassLoader leaks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390063



--- Comment #9 from Tomas Repik  ---
Spec URL:
https://trepik.fedorapeople.org/classloader-leak-test-framework/v1/classloader-leak-test-framework.spec
SRPM URL:
https://trepik.fedorapeople.org/classloader-leak-test-framework/v1/classloader-leak-test-framework-1.1.1-1.fc24.src.rpm
Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16336757

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392388] Review Request: perl-Geo-Distance - Calculate distances and closest locations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392388



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Geo-Distance

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392227] Review Request: pidgin-groupchat-typing-notifications - Adds typing notifications for group chats in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392227



--- Comment #6 from Fedora Update System  ---
pidgin-groupchat-typing-notifications-0-1.git33a75f9.fc23 has been submitted as
an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-49e258e3cc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392227] Review Request: pidgin-groupchat-typing-notifications - Adds typing notifications for group chats in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392227



--- Comment #4 from Fedora Update System  ---
pidgin-groupchat-typing-notifications-0-1.git33a75f9.el7 has been submitted as
an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-17a788c064

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392227] Review Request: pidgin-groupchat-typing-notifications - Adds typing notifications for group chats in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392227



--- Comment #5 from Fedora Update System  ---
pidgin-groupchat-typing-notifications-0-1.git33a75f9.fc24 has been submitted as
an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ee53cd72dc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392227] Review Request: pidgin-groupchat-typing-notifications - Adds typing notifications for group chats in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392227

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392227] Review Request: pidgin-groupchat-typing-notifications - Adds typing notifications for group chats in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392227



--- Comment #3 from Fedora Update System  ---
pidgin-groupchat-typing-notifications-0-1.git33a75f9.fc25 has been submitted as
an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e11a1fd11d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392457] Re-review Request for renaming python package to python2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

Charalampos Stratakis  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|mhron...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392457] New: Re-review Request for renaming python package to python2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

Bug ID: 1392457
   Summary: Re-review Request for renaming python package to
python2
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: cstra...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://github.com/fedora-python/python2-spec/blob/py2rename/python.spec

Diff from master branch:
https://github.com/fedora-python/python2-spec/compare/py2rename

SRPM URL: https://cstratak.fedorapeople.org/python2-2.7.12-9.fc26.src.rpm

Fedora Account System Username: cstratak

With Python 2 reaching end of life at 2020 and also having by default in Fedora
the Python 3 version of the language it only makes sense to explicitly reflect
in the name of the package, the respective major version. Also in the future,
there is a high possibility that python will refer only to python3.

Thus I would like to rename python to python2.

The package still virtually provide the python name. All the changes in the
SPEC file are in the posted github link. The change is intended only for
rawhide.

This can be tested by using a rawhide machine and enabling my copr repo [0]
where I have a build with the renamed python: dnf copr enable cstratak/Python2

Then by invoking "dnf update" or "dnf update python" the python2 package will
be installed, replacing the python package with no conflicts.

[0] https://copr.fedorainfracloud.org/coprs/cstratak/Python2/build/473988/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372836] Review Request: python-hug - A Python framework that makes developing APIs simple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372836

Iryna Shcherbina  changed:

   What|Removed |Added

 CC||ishch...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392434] Review Request: perl-XML-LibXML-Devel-SetLineNumber - Set the line number for an XML:: LibXML::Node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392434

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1392451




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1392451
[Bug 1392451] Review Request: perl-HTML-HTML5-Parser - Parse HTML reliably
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392451] Review Request: perl-HTML-HTML5-Parser - Parse HTML reliably

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392451

Petr Pisar  changed:

   What|Removed |Added

 Depends On||1392434




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1392434
[Bug 1392434] Review Request: perl-XML-LibXML-Devel-SetLineNumber - Set the
line number for an XML::LibXML::Node
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392451] New: Review Request: perl-HTML-HTML5-Parser - Parse HTML reliably

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392451

Bug ID: 1392451
   Summary: Review Request: perl-HTML-HTML5-Parser - Parse HTML
reliably
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-HTML-HTML5-Parser/perl-HTML-HTML5-Parser.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-HTML-HTML5-Parser/perl-HTML-HTML5-Parser-0.301-1.fc26.src.rpm
Description:
HTML parser with XML::LibXML-like DOM interface.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391487] Review Request: nextcloud-client - The Nextcloud Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391487

Nick Bebout  changed:

   What|Removed |Added

 CC||germano.massu...@gmail.com
  Flags||needinfo?(germano.massullo@
   ||gmail.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1086608] Review Request: jna-posix - Java library for accessing common POSIX functions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1086608

Michal Srb  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
  Flags|needinfo?(m...@redhat.com)  |
Last Closed||2016-11-07 09:13:12



--- Comment #6 from Michal Srb  ---
Oops, sorry. This should have been closed long time age. Closing now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392434] Review Request: perl-XML-LibXML-Devel-SetLineNumber - Set the line number for an XML:: LibXML::Node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392434

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390156



--- Comment #9 from Fedora Update System  ---
jsonassert-1.4.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-15dbccbf42

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390156

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267340] Review Request: rubygem-minitest-around - Around block for minitest

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267340

Vít Ondruch  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Vít Ondruch  ---
(In reply to Ilya Gradina from comment #3)
> - updated to version 0.4.0

Thx

> - removed from BuildRequires rubygem-cucumber(with cucumber not pass the
> tests).

Actually you can run the cucumber test suite. This is the diff I tested:

```
--- rubygem-minitest-around.spec2016-11-07 14:50:38.050724282 +0100
+++ rubygem-minitest-around.spec.back2016-11-07 14:49:26.946770370 +0100
@@ -11,6 +11,7 @@
 BuildRequires: ruby(release)
 BuildRequires: rubygems-devel
 BuildRequires: rubygem(minitest)
+BuildRequires: rubygem(cucumber)
 BuildArch: noarch

 %description
@@ -54,6 +55,8 @@
 pushd .%{gem_instdir}
   sed -i "/require 'bundler/ s/^/#/" test/helper.rb
   ruby -Ilib -e 'Dir.glob "./test/*_test.rb", (:require)'
+
+  RUBYOPT=-Ilib cucumber --tag ~@todo --tag ~@rspec
 popd

 %files
```

There are excluded some parts, but these corresponds to the Rakefile [1].

And actually, there are also test/*_spec.rb files which could be executed, so
the final patch according to my testing should be:

```
--- rubygem-minitest-around.spec.orig2016-11-07 15:05:01.312144585 +0100
+++ rubygem-minitest-around.spec2016-11-07 15:04:43.281157338 +0100
@@ -11,6 +11,7 @@
 BuildRequires: ruby(release)
 BuildRequires: rubygems-devel
 BuildRequires: rubygem(minitest)
+BuildRequires: rubygem(cucumber)
 BuildArch: noarch

 %description
@@ -53,7 +54,9 @@
 %check
 pushd .%{gem_instdir}
   sed -i "/require 'bundler/ s/^/#/" test/helper.rb
-  ruby -Ilib -e 'Dir.glob "./test/*_test.rb", (:require)'
+  RUBYOPT=-Ilib ruby -e 'Dir.glob "./test/*_{test,spec}.rb",
(:require)'
+
+  RUBYOPT=-Ilib cucumber --tag ~@todo --tag ~@rspec
 popd

 %files
```

The RUBYOPT export is required, -Ilib is not enough, since there are spawned
some testing sub processes. In upstream, Bundler takes care about it, but
without Bundler, we have to workaround it.


Otherwise the package looks sane => APPROVED but please make sure to enable as
much tests as possible.


[1] https://github.com/splattael/minitest-around/blob/master/Rakefile#L37

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392434] New: Review Request: perl-XML-LibXML-Devel-SetLineNumber - Set the line number for an XML:: LibXML::Node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392434

Bug ID: 1392434
   Summary: Review Request: perl-XML-LibXML-Devel-SetLineNumber -
Set the line number for an XML::LibXML::Node
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-XML-LibXML-Devel-SetLineNumber/perl-XML-LibXML-Devel-SetLineNumber.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-XML-LibXML-Devel-SetLineNumber/perl-XML-LibXML-Devel-SetLineNumber-0.002-1.fc26.src.rpm
Description:
If you are, say, writing a parser for a non-XML format that happens to have an
XML-like data model, then you might wish to parse your format into an
XML::LibXML document with elements, attributes and so on. And you might want
all those nodes to return the correct line numbers when the "line_number"
method is called on them. This Perl module allows you to set the line number.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376035] Review Request: modulemd - Module metadata manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376035



--- Comment #7 from Petr Šabata  ---
Just released the first stable release.
https://pypi.python.org/pypi/modulemd/1.0.0

Note this is incompatible with the development releases that COPR probably
relies on.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346060] Review Request: python-pintail-asciidoc - Use AsciiDoc pages in Pintail sites

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346060

Tummala Dhanvi (c0mrad3)  changed:

   What|Removed |Added

  Flags||needinfo?(juj...@jujens.eu)



--- Comment #8 from Tummala Dhanvi (c0mrad3)  ---
- Changed %{sum} to %{summary}
- Removed the %check 
- I am packaging the dependency
(https://bugzilla.redhat.com/show_bug.cgi?id=1343977)
- Removed macro from change log 
- Updated the files as you have mentioned


https://dhanvi.fedorapeople.org/packages/pintail-asciidoc/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343977] Review Request: asciidoctor-mallard - A Project Mallard converter for AsciiDoc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343977



--- Comment #8 from Tummala Dhanvi (c0mrad3)  ---
I have added the testing part by adding this line 

ruby -Ilib -e 'Dir.glob "./test/*.rb"' 

Hope it should do it. 


Updated packages here
https://dhanvi.fedorapeople.org/packages/asciidoctor-mallard/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392309] Review Request: python-os-faults - OpenStack fault-injection library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392309

Javier Peña  changed:

   What|Removed |Added

 Target Release|--- |trunk
  Component|Package Review  |Package Review
Version|rawhide |trunk
Product|Fedora  |RDO
 QA Contact|extras...@fedoraproject.org |jp...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392388] Review Request: perl-Geo-Distance - Calculate distances and closest locations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392388

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Geo-Distance-0.20-1.fc26.noarch.rpm | sort | uniq -c
  1 perl(:MODULE_COMPAT_5.24.0)
  1 perl(Carp)
  1 perl(Math::Trig)
  1 perl(constant)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Geo-Distance-0.20-1.fc26.noarch.rpm | sort | uniq -c
  1 perl(Geo::Distance) = 0.20
  1 perl-Geo-Distance = 0.20-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Geo-Distance*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390063] Package Review: classloader-leak-test-framework - Detection and verification of Java ClassLoader leaks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390063



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/classloader-leak-test-framework

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367819] Review Request: znc-clientbuffer - ZNC module for client specific buffers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367819



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/znc-clientbuffer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392227] Review Request: pidgin-groupchat-typing-notifications - Adds typing notifications for group chats in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392227



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/pidgin-groupchat-typing-notifications

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374781] Review Request: python-sphinxcontrib-autoprogram - Sphinx extension for documenting CLI programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374781



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-sphinxcontrib-autoprogram

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390156



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/jsonassert

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392309] Review Request: python-os-faults - OpenStack fault-injection library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392309



--- Comment #5 from Chandan Kumar  ---
Here is the updated
SPEC file: https://chandankumar.fedorapeople.org/python-os-faults.spec
SRPM:
https://chandankumar.fedorapeople.org/python-os-faults-0.1.5-4.fc24.src.rpm
and successful Koji Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16334626

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392388] Review Request: perl-Geo-Distance - Calculate distances and closest locations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392388

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392388] New: Review Request: perl-Geo-Distance - Calculate distances and closest locations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392388

Bug ID: 1392388
   Summary: Review Request: perl-Geo-Distance - Calculate
distances and closest locations
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-Geo-Distance/perl-Geo-Distance.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-Geo-Distance/perl-Geo-Distance-0.20-1.fc26.src.rpm
Description:
This Perl library aims to provide as many tools to make it as simple as
possible to calculate distances between geographic points, and anything
that can be derived from that. Currently there is support for finding the
closest locations within a specified distance, to find the closest number
of points to a specified point, and to do basic point-to-point distance
calculations.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390063] Package Review: classloader-leak-test-framework - Detection and verification of Java ClassLoader leaks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390063

Tomas Repik  changed:

   What|Removed |Added

   Assignee|prais...@redhat.com |tre...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390063] Package Review: classloader-leak-test-framework - Detection and verification of Java ClassLoader leaks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390063



--- Comment #7 from Pavel Raiskup  ---
FTR, another two nice errors:
Review not approved by the assignee of the ticket tre...@redhat.com
Review not approved by the assignee of the ticket tre...@redhat.com

Tomáš, can you please "take" the bug, too?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390063] Package Review: classloader-leak-test-framework - Detection and verification of Java ClassLoader leaks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390063

Tomas Repik  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392309] Review Request: python-os-faults - OpenStack fault-injection library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392309



--- Comment #4 from Javier Peña  ---
We still have two issues (see rpmlint section below):

- The libvirt compiled files end up in the wrong subpackage. You just need to
change the following:

%exclude %{python2_sitelib}/%{pypi_name}/drivers/libvirt_driver.py*

%files -n python2-%{sname}-libvirt
%license LICENSE
%{python2_sitelib}/%{pypi_name}/drivers/libvirt_driver.py*

And the same applies to the python3 subpackage.

- Also, the generated rpms fail to install because they require a newer version
of python-pyghmi (>= 1.0.3) than available in the repo (0.8.0). We'll need to
get a newer dependency or remove the version from the requirement, although I'm
afraid the latter will cause issues down the road.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
 (v2.0)". 9 files have unknown license. Detailed output of licensecheck
 in /tmp/1392309-python-os-faults/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see 

[Bug 1390063] Package Review: classloader-leak-test-framework - Detection and verification of Java ClassLoader leaks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390063

Pavel Raiskup  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?



--- Comment #6 from Pavel Raiskup  ---
Pkgdb says:
"Review approved by the person creating the ticket prais...@redhat.com"
Let's hope the check makes sense elsewhere, Tomáš, can you approve?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380179] Review Request: webvirtmgr - panel for manage virtual machine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380179

Matthias Runge  changed:

   What|Removed |Added

 CC||mru...@redhat.com



--- Comment #4 from Matthias Runge  ---
Hey, I'm currently the django maintainer in Fedora (and EPEL). I'd be trying to
get rid of (unmaintained by upstream) Django-1.6 in EPEL7 ASAP. Django releases
roughly every 9 months, latest LTS version is Django-1.8. 

That means, you should wait for a new release of webvirtmgr, if possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390156

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383781

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392309] Review Request: python-os-faults - OpenStack fault-injection library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392309



--- Comment #3 from Chandan Kumar  ---
Here is the updated
SPEC file: https://chandankumar.fedorapeople.org/python-os-faults.spec
SRPM:
https://chandankumar.fedorapeople.org/python-os-faults-0.1.5-3.fc24.src.rpm
and successful Koji Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16333720

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383781

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #16 from gil cattaneo  ---
NON blocking issues:
[!]: Changelog in prescribed format.

sunflow.noarch: W: incoherent-version-in-changelog 0.07.3.8097f6d
['0.07.3-8097f6d.fc26', '0.07.3-8097f6d']

Please, fix before import
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383781

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #15 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "*No copyright* GPL (v2 or later) (with
 incorrect FSF address)", "GPL (v2 or later)", "Unknown or generated",
 "BSD (3 clause)". 22 files have unknown license. Detailed output of
 licensecheck in /home/gil/1383781-sunflow/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/icons/hicolor,
 /usr/share/icons/hicolor/128x128/apps,
 /usr/share/icons/hicolor/128x128
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[?]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in sunflow
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should 

[Bug 1389286] Review Request: perl-Module-Install-DOAP - Generate META.yml data from DOAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389286

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-11-07 05:11:04



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392309] Review Request: python-os-faults - OpenStack fault-injection library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392309



--- Comment #2 from Chandan Kumar  ---
Hello Jpena,

Thanks for the review.
All the above comments are fixed.
Here is the updated
SPEC file: https://chandankumar.fedorapeople.org/python-os-faults.spec
SRPM:
https://chandankumar.fedorapeople.org/python-os-faults-0.1.5-2.fc24.src.rpm
and successful Koji Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1691

Thanks,

Chandan Kumar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380179] Review Request: webvirtmgr - panel for manage virtual machine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380179

jiri vanek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jva...@redhat.com
   Assignee|nob...@fedoraproject.org|jva...@redhat.com



--- Comment #3 from jiri vanek  ---
Hello! I'm wiling to review, however whats the point of bringing it in, if the
application do not work in Fedora?

Maybe django1.6-compact package is the way to go in fedora (and keep python2)?

I do not have precedense for epel7 only pkg, although I do not have issues with
epel7 pkg only...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org