[Bug 1344276] Review Request: gdeploy - Tool to deploy GlusterFS clusters and other utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344276



--- Comment #7 from Sachidananda Urs  ---
Hi I've made changes to the spec file and can be found at: 

https://github.com/gluster/gdeploy/blob/master/gdeploy.spec

I'll request to upload the srpm to a publicly accessible location.
The change I'm not confident in the spec file is the define:

%global _rpmfilename noarch/%{name}-%{version}-%{release}%{?dist}.rpm

I hope this is fine. I need it this way so that I can have a generic
tar.gz source file and build dist specific rpm from that.

Parag I will work on reviewing packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393129] Review Request: aexpect - a python library to control interactive applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393129

Stephen Gallagher  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sgall...@redhat.com
   Assignee|nob...@fedoraproject.org|sgall...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365319] Review Request: EPEL vcftools - newest version 0.1.14

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365319

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
vcftools-0.1.14-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-aade6f515d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1157299] Review Request: "jonathan-jeremie" - Distributed Object Platform (DOP) written entirely in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157299

Dave Chen  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(wei.d.chen@intel. |
   |com)|
Last Closed||2016-11-08 20:50:15



--- Comment #2 from Dave Chen  ---
sure, I missed this one, will close it since I don't have any balance to
continue the work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393021] Review Request: pulledpork - Pulled Pork for Snort and Suricata rule management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393021



--- Comment #3 from marcindulak  ---
Spec URL:
http://marcindulak.fedorapeople.org/packages/pulledpork/r02/pulledpork.spec
SRPM URL:
http://marcindulak.fedorapeople.org/packages/pulledpork/r02/pulledpork-0.7.2-1.fc23.src.rpm

Changes:

1. %license macro is used LICENSE

2. asked for clarification at https://github.com/shirkdog/pulledpork/issues/234

3. fixed ownership of /etc/pulledpork

4. fixed ownership of /usr/share/pulledpork

5. added according to perl packaging guide:

BuildRequires:  perl-generators
BuildRequires:  perl

Requires:   perl(LWP::Protocol::https)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720

Janet Morgan  changed:

   What|Removed |Added

 Blocks||1275029



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369708

Janet Morgan  changed:

   What|Removed |Added

 Blocks||1275027



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393021] Review Request: pulledpork - Pulled Pork for Snort and Suricata rule management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393021

Jason Taylor  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #2 from Jason Taylor  ---
Hi Marcin,

A couple of items:

1. LICENSE should be tagged as %license under %files. It is currently listed as
%doc in the spec

2. It might be worth getting licensing clarification on contrib/oink-conv.pl.
Either include a GPL2 header as pulledpork.pl does or similar indicator.

3. The spec as written does not define ownership of the /etc/pulledpork
directory

4. The spec as written does not define ownership of /usr/share/pulledpork

5. Take a look at https://fedoraproject.org/wiki/Packaging:Perl for additional
items related to packaging perl.

Thanks!

JT

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386735] Review Request: php-fedora-autoloader - Fedora Autoloader

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386735



--- Comment #31 from Fedora Update System  ---
php-fedora-autoloader-0.2.1-2.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382926] Review Request: perl-HTTP-MultiPartParser - HTTP MultiPart Parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382926



--- Comment #10 from Fedora Update System  ---
perl-HTTP-MultiPartParser-0.01-2.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393021] Review Request: pulledpork - Pulled Pork for Snort and Suricata rule management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393021

Jason Taylor  changed:

   What|Removed |Added

 CC||jtfa...@gmail.com
   Assignee|nob...@fedoraproject.org|jtfa...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393129] New: Review Request: aexpect - a python library to control interactive applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393129

Bug ID: 1393129
   Summary: Review Request: aexpect - a python library to control
interactive applications
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mmath...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://merlinm.fedorapeople.org/aexpect.spec
SRPM URL: https://merlinm.fedorapeople.org/aexpect-1.2.0-1.fc24.src.rpm
Koji scratch build URL:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16341439
Description:

Aexpect is a python library used to control interactive applications, very
similar to pexpect. You can use it to control applications such as ssh, scp
sftp, telnet, among others.

Fedora Account System Username: merlinm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392649] Review Request: tacacs+- Cisco AAA server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392649



--- Comment #2 from Philip Prindeville  ---
Here's the output from rpmlint on both files:

tacacs+.src: W: invalid-url Source0: tacacs-F4.0.4.29a.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

tacacs+.x86_64: W: no-manual-page-for-binary tac_convert
Each executable in standard binary directories should have a man page.

tacacs+.x86_64: W: service-default-enabled /etc/rc.d/init.d/tac_plus
The service is enabled by default after "chkconfig --add"; for security
reasons, most services should not be. Use "-" as the default runlevel in the
init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword
to fix this if appropriate for this service.

tacacs+.x86_64: W: incoherent-init-script-name tac_plus ('tacacs+', 'tacacs+d')
The init script name should be the same as the package name in lower case, or
one with 'd' appended if it invokes a process by that name.

2 packages and 0 specfiles checked; 0 errors, 4 warnings.


Yes, the Source: value will need to be updated.  When the reviews are done and
I commit a final version of the .spec file to github, I will tag and publish a
tarball which agrees with what's in the final .spec file.

There is no man page for tac_convert, but tac_convert is a Perl script.  Use
the source, Luke!

Regarding the init.d file... not sure if I should mangle it with a sed script
to replace "chkconfig: 2345" with "chkconfig: -" or leave it as is but
explicitly disable it with "chkconfig tac_plus off" in the %post.

Incoherent script name... again, trying to preserve the sources wherever
possible.  This is what it was called upstream.  Don't want to diverge too much
from that.  Plus it will likely have a ripple effect: the daemon name will
change to agree with the init.d script name, then the config file for the
daemon will need to change too, then the man page for the config file needs to
change...  It snowballs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393021] Review Request: pulledpork - Pulled Pork for Snort and Suricata rule management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393021



--- Comment #1 from marcindulak  ---
Update

Spec URL:
http://marcindulak.fedorapeople.org/packages/pulledpork/r01/pulledpork.spec
SRPM URL:
http://marcindulak.fedorapeople.org/packages/pulledpork/r01/pulledpork-0.7.2-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1279104] Review Request: python-pbkdf2 - password-based key derivation in pure Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279104

Jonny Heggheim  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1279104] Review Request: python-pbkdf2 - password-based key derivation in pure Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279104



--- Comment #11 from Jonny Heggheim  ---
Spec URL: https://jonny.fedorapeople.org/python-pbkdf2/python-pbkdf2.spec
SRPM URL:
https://jonny.fedorapeople.org/python-pbkdf2/python-pbkdf2-1.3-5.fc25.src.rpm
Description: A pure Python Implementation of the password-based key derivation
function, PBKDF2, specified in RSA PKCS#5 v2.0.
Fedora Account System Username: jonny
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16357933

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1279104] Review Request: python-pbkdf2 - password-based key derivation in pure Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279104



--- Comment #10 from Jonny Heggheim  ---
(In reply to Samuel Gyger from comment #9)
> From my side, feel free to take over. I'm looking forward to see electrum
> finally in fedora. :)

Ok, I take over this package. I will continue to use this ticket since my SPEC
file is the same as your with some small changes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187082] Review Request: python-slowaes - An Implementation of AES in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187082



--- Comment #17 from Jonny Heggheim  ---
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16357891

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393086] Review Request: golang-github-Microsoft-winio - Utilities for efficiently performing Win32 IO operations in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393086

Lokesh Mandvekar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Depends On||1393077
   Assignee|nob...@fedoraproject.org|jchal...@redhat.com




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1393077
[Bug 1393077] rebase needed for golang-github-Microsoft-winio
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393086] New: Review Request: golang-github-Microsoft-winio - Utilities for efficiently performing Win32 IO operations in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393086

Bug ID: 1393086
   Summary: Review Request: golang-github-Microsoft-winio -
Utilities for efficiently performing Win32 IO
operations in Go
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: l...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://lsm5/fedorapeople.org/golang-github-Microsoft-winio/golang-github-Microsoft-winio
SRPM URL: not yet

Description:  
Utilities for efficiently performing Win32 IO operations in Go

Fedora Account System Username: lsm5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336555] Review Request: python3-pytz - World Timezone Definitions for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336555



--- Comment #6 from Fedora Update System  ---
python3-pytz-2016.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-326692eac8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336555] Review Request: python3-pytz - World Timezone Definitions for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336555



--- Comment #7 from Fedora Update System  ---
python3-pytz-2016.7-1.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-f1ffcf0ecd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336555] Review Request: python3-pytz - World Timezone Definitions for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336555

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #21 from Orion Poplawski  ---
Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376867] Review Request: python3-pycurl - Python interface to libcurl for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376867



--- Comment #2 from Orion Poplawski  ---
Spec URL: http://www.cora.nwra.com/~orion/fedora/python3-pycurl.spec
SRPM URL:
http://www.cora.nwra.com/~orion/fedora/python3-pycurl-7.43.0-4.el7.src.rpm

* Tue Nov 8 2016 Orion Poplawski  - 7.43.0-4
- Add patch to build with python3 pyflakes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #20 from Fedora Update System  ---
gasnet-1.28.0-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b706f067d3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373019] Review Request: python-fuse - Python module that provides a simple interface to FUSE and MacFUSE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373019

Juan Orti  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2016-11-08 13:42:00



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336555] Review Request: python3-pytz - World Timezone Definitions for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336555



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python3-pytz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384249] Review Request: python3-ply - Python Lex-Yacc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384249



--- Comment #2 from Orion Poplawski  ---
Spec URL: https://www.cora.nwra.com/~orion/fedora/python3-ply.spec
SRPM URL: https://www.cora.nwra.com/~orion/fedora/python3-ply-3.9-1.el7.src.rpm

* Tue Nov 8 2016 Orion Poplawski  - 3.9-1
- Update to 3.9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384130] Review Request: python3-sqlalchemy - Modular and flexible ORM library for python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384130



--- Comment #2 from Orion Poplawski  ---
Spec URL: https://www.cora.nwra.com/~orion/fedora/python3-sqlalchemy.spec
SRPM URL:
https://www.cora.nwra.com/~orion/fedora/python3-sqlalchemy-1.1.3-1.el7.src.rpm

* Tue Nov 8 2016 Orion Poplawski  - 1.1.3-1
- Update to 1.1.3
- Move docs to sub-package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336555] Review Request: python3-pytz - World Timezone Definitions for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336555

Tim Orling  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Tim Orling  ---
Koji EPEL7 build: https://koji.fedoraproject.org/koji/taskinfo?taskID=16356008
Koji EL6 build: https://koji.fedoraproject.org/koji/taskinfo?taskID=16356010


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- Package contains BR: python2-devel or python3-devel
  => This is ok, as %{python3_pkgversion}-devel is used and this is EPEL only.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 10 files have unknown license.
 => Ok. Normal python behavior.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/licenses
 => EPEL7 has no owner of /usr/share/licenses
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/licenses
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported 

[Bug 1393044] New: Review Request: su-exec - switch user and group id, setgroups and exec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393044

Bug ID: 1393044
   Summary: Review Request: su-exec - switch user and group id,
setgroups and exec
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: acmat...@hotmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://mativi.fedorapeople.org/su-exec.spec
SRPM URL: https://mativi.fedorapeople.org/su-exec-0.2-1.fc25.src.rpm
Description: This is a simple tool that will simply execute a program with
different privileges. The program will not run as a child, like su and sudo, so
we work around TTY and signal issues.
Fedora Account System Username: mativi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393044] Review Request: su-exec - switch user and group id, setgroups and exec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393044

Ana Mativi  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)



--- Comment #1 from Ana Mativi  ---
Adding the block FE-NEEDSPONSOR


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336555] Review Request: python3-pytz - World Timezone Definitions for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336555

Tim Orling  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ticot...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389016] Review Request: libxsmm - Library for small matrix-matrix multiplications on Intel x86_64 (e.g. for cp2k)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389016

Antonio Trande  changed:

   What|Removed |Added

  Flags|needinfo?(anto.trande@gmail |
   |.com)   |



--- Comment #25 from Antonio Trande  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
>I need to know what to do about the samples,

If you want provide those files under %doc, executable permissions must be
removed.
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 60 files have unknown
 license. Detailed output of licensecheck in
 /home/sagitter/1389016-libxsmm/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libxsmm-
 doc , libxsmm-debuginfo
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license 

[Bug 1393021] New: Review Request: pulledpork - Pulled Pork for Snort and Suricata rule management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393021

Bug ID: 1393021
   Summary: Review Request: pulledpork - Pulled Pork for Snort and
Suricata rule management
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: marcin.du...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://marcindulak.fedorapeople.org/packages/pulledpork/r01/pulledpork.spec
SRPM URL:
http://marcindulak.fedorapeople.org/packages/pulledpork/r01/pulledpork-0.7.3-1.fc23.src.rpm
Description: Pulled Pork for Snort and Suricata rule management (from Google
code).
Fedora Account System Username: marcindulak

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393002] New: Review Request: perl-HTML-HTML5-Writer - Output a DOM as HTML5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393002

Bug ID: 1393002
   Summary: Review Request: perl-HTML-HTML5-Writer - Output a DOM
as HTML5
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-HTML-HTML5-Writer/perl-HTML-HTML5-Writer.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-HTML-HTML5-Writer/perl-HTML-HTML5-Writer-0.201-1.fc26.src.rpm
Description:
This Perl module outputs XML::LibXML::Node objects as HTML5 strings. It works
well on DOM trees that represent valid HTML/XHTML documents; less well on
other DOM trees.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365319] Review Request: EPEL vcftools - newest version 0.1.14

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365319



--- Comment #5 from Fedora Update System  ---
vcftools-0.1.14-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-879804ba99

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365319] Review Request: EPEL vcftools - newest version 0.1.14

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365319



--- Comment #3 from Fedora Update System  ---
vcftools-0.1.14-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-aade6f515d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365319] Review Request: EPEL vcftools - newest version 0.1.14

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365319



--- Comment #4 from Fedora Update System  ---
vcftools-0.1.14-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d2bfa75d27

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365319] Review Request: EPEL vcftools - newest version 0.1.14

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365319

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376932] Review Request: python3-markupsafe - Implements a XML/HTML/ XHTML Markup safe string for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376932



--- Comment #3 from Orion Poplawski  ---
Whoops, There now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365319] Review Request: EPEL vcftools - newest version 0.1.14

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365319

Filipe Rosset  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||rosset.fil...@gmail.com



--- Comment #2 from Filipe Rosset  ---
I'll push 0.1.14 to epel-7 soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336555] Review Request: python3-pytz - World Timezone Definitions for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336555



--- Comment #3 from Orion Poplawski  ---
Spec URL: http://www.cora.nwra.com/~orion/fedora/python3-pytz.spec
SRPM URL:
http://www.cora.nwra.com/~orion/fedora/python3-pytz-2016.7-1.el7.src.rpm

* Tue Nov 8 2016 Orion Poplawski  - 2016.7-1
- Update to 2016.7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391254] Review Request: python3-doctutils - System for processing plaintext documentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391254

Tim Orling  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ticot...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #19 from Christoph Junghans  ---
(In reply to Orion Poplawski from comment #17)
> Could you build this for EPEL7?  It mostly builds fine - though I see static
> libs installed when I build locally.
I have no access to the epel7 branch.

This is the error:
+ g++ -shared -Wl,-soname=libammpi-1.28.0.so -Wl,--as-needed -Wl,-z,defs
-Wl,-z,relro -Wl,--rpath-link=. -Wl,--whole-archive
/builddir/build/BUILDROOT/gasnet-1.28.0-1.el7.ppc64le//usr/lib64/mpich/lib/libammpi.a
-Wl,--no-whole-archive -L//usr/lib64/mpich/lib -lmpi -o
/builddir/build/BUILDROOT/gasnet-1.28.0-1.el7.ppc64le//usr/lib64/mpich/lib/libammpi-1.28.0.so
/usr/bin/ld: cannot find -lmpi
collect2: error: ld returned 1 exit status

No idea why that would fail, as MPI_LIB=/usr/lib64/mpich/lib, is there not
libmpi in /usr/lib64/mpich/lib on ppc64le?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267340] Review Request: rubygem-minitest-around - Around block for minitest

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267340



--- Comment #6 from Vít Ondruch  ---
(In reply to Ilya Gradina from comment #5)
> - added run rdoc

Would you mind to elaborate the purpose of this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392606] Review Request: perl-Encode-IMAPUTF7 - Process the special UTF-7 variant required by IMAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392606



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Encode-IMAPUTF7-1.05-1.fc26.noarch.rpm | sort | uniq
-c
  1 perl(:MODULE_COMPAT_5.24.0)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Most of binary requires are missing, because perl-generators was not
installed.

$ rpm -qp --provides perl-Encode-IMAPUTF7-1.05-1.fc26.noarch.rpm | sort | uniq
-c
  1 perl-Encode-IMAPUTF7 = 1.05-1.fc26
FIX: Provides 'erl(Encode::IMAPUTF7) = 1.05 is not listed due to missing
perl-generators

$ rpmlint ./perl-Encode-IMAPUTF7*
perl-Encode-IMAPUTF7.src: W: strange-permission Encode-IMAPUTF7-1.05.tar.gz 660
perl-Encode-IMAPUTF7.src: W: strange-permission perl-Encode-IMAPUTF7.spec 660
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok

BuildRequires:
FIX: Please add following build-requires:
coreutils - because 'tr', 'mv', 'touch',... are used in spec file
findutils - 'find' is used in spec file
perl - it is used in spec file
perl-generators - is necessary for generating of package provides and
  requires. The package is not part of default
  buildroot
Encode-IMAPUTF7-1.05/Makefile.PL
perl(base) - lib/Encode/IMAPUTF7.pm:7
perl(Encode::Encoding) - lib/Encode/IMAPUTF7.pm:7
perl(File::Basename) - t/0-test.t:12
perl(File::Spec) - t/0-test.t:13
perl(MIME::Base64) - lib/Encode/IMAPUTF7.pm:10
perl(strict) - lib/Encode/IMAPUTF7.pm:5
perl(Test::More) - t/0-test.t:12
perl(warnings) - lib/Encode/IMAPUTF7.pm:7

TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR.

If you want to add the package to EPEL, please ignore these two TODO 
TODO: The easier way to remove .packlist is used NO_PACKLIST option,
  which is part of perl(ExtUtils::MakeMaker) >= 6.76. It can be 
  used in all Fedoras. The command is 
  %{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1

TODO: Remove the deleting empty directories in %install section. This is
  default behavior for Fedoras.


Please correct all 'FIX' issues and consider fixing 'TODO' items and
provide new spec file.

The package is not approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383781

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383781



--- Comment #20 from Fedora Update System  ---
sunflow-0.07.3-8097f6d.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e4985bc6c0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392977] Review Request: ocid - OCI-based implementation of Kubernetes Container Runtime Interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392977



--- Comment #1 from Lokesh Mandvekar  ---
$ sudo dnf builddep ocid.spec
Last metadata expiration check: 0:12:17 ago on Tue Nov  8 09:51:53 2016.
No matching package to install: 'golang(github.com/Microsoft/go-winio)'
No matching package to install:
'golang(github.com/containernetworking/cni/libcni)'
No matching package to install:
'golang(github.com/containernetworking/cni/pkg/invoke)'
No matching package to install:
'golang(github.com/containernetworking/cni/pkg/types)'
No matching package to install:
'golang(github.com/containernetworking/cni/pkg/version)'
No matching package to install: 'golang(github.com/containers/image/directory)'
No matching package to install:
'golang(github.com/containers/image/directory/explicitfilepath)'
No matching package to install: 'golang(github.com/containers/image/docker)'
No matching package to install:
'golang(github.com/containers/image/docker/policyconfiguration)'
No matching package to install: 'golang(github.com/containers/image/image)'
No matching package to install: 'golang(github.com/containers/image/manifest)'
No matching package to install:
'golang(github.com/containers/image/oci/layout)'
No matching package to install: 'golang(github.com/containers/image/openshift)'
No matching package to install:
'golang(github.com/containers/image/transports)'
No matching package to install: 'golang(github.com/containers/image/types)'
No matching package to install: 'golang(github.com/containers/image/version)'
No matching package to install:
'golang(github.com/docker/docker/api/types/blkiodev)'
No matching package to install:
'golang(github.com/docker/docker/api/types/container)'
No matching package to install:
'golang(github.com/docker/docker/api/types/mount)'
No matching package to install:
'golang(github.com/docker/docker/api/types/strslice)'
No matching package to install:
'golang(github.com/docker/docker/api/types/versions)'
No matching package to install:
'golang(github.com/docker/docker/plugin/getter)'
No matching package to install:
'golang(github.com/opencontainers/image-spec/specs-go)'
No matching package to install:
'golang(github.com/opencontainers/image-spec/specs-go/v1)'
No matching package to install:
'golang(github.com/opencontainers/runtime-tools/generate)'
No matching package to install: 'golang(github.com/rajatchopra/ocicni)'
No matching package to install: 'golang(golang.org/x/net/internal/timeseries)'
No matching package to install: 'golang(google.golang.org/grpc/internal)'
No matching package to install:
'golang(k8s.io/kubernetes/pkg/kubelet/api/v1alpha1/runtime)'
No matching package to install: 'golang(k8s.io/kubernetes/pkg/selection)'
No matching package to install: 'golang(k8s.io/kubernetes/pkg/util/homedir)'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392977] Review Request: ocid - OCI-based implementation of Kubernetes Container Runtime Interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392977

Lokesh Mandvekar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|jchal...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392977] New: Review Request: ocid - OCI-based implementation of Kubernetes Container Runtime Interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392977

Bug ID: 1392977
   Summary: Review Request: ocid - OCI-based implementation of
Kubernetes Container Runtime Interface
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: l...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://lsm5.fedorapeople.org/ocid/ocid.spec
SRPM URL: WIP, not yet :)

Description:
OCI-based implementation of Kubernetes Container Runtime Interface

Fedora Account System Username: lsm5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389016] Review Request: libxsmm - Library for small matrix-matrix multiplications on Intel x86_64 (e.g. for cp2k)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389016

Orion Poplawski  changed:

   What|Removed |Added

 CC||or...@cora.nwra.com



--- Comment #24 from Orion Poplawski  ---
FWIW - samples in -doc seems entirely appropriate to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636



--- Comment #7 from Fedora Update System  ---
python3-dbus-1.2.4-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-3606e79612

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #18 from Orion Poplawski  ---
scratch build - https://koji.fedoraproject.org/koji/taskinfo?taskID=16353531

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376035] Review Request: modulemd - Module metadata manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376035



--- Comment #9 from Miroslav Suchý  ---
Updated:
Spec URL: http://miroslav.suchy.cz/fedora/modulemd.spec
SRPM URL: http://miroslav.suchy.cz/fedora/modulemd-1.0.2-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392451] Review Request: perl-HTML-HTML5-Parser - Parse HTML reliably

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392451

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-HTML-HTML5-Parser-0.30
   ||1-1.fc26
 Resolution|--- |RAWHIDE
Last Closed||2016-11-08 09:37:59



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository. I forgot on the double-defined
module. Thanks for pointing at it. I removed the unversioned symbol.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392606] Review Request: perl-Encode-IMAPUTF7 - Process the special UTF-7 variant required by IMAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392606

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392451] Review Request: perl-HTML-HTML5-Parser - Parse HTML reliably

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392451



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-HTML-HTML5-Parser

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392838] Review Request: python-mlpy - Python module for Machine Learning

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392838



--- Comment #4 from Dhanesh Sabane  ---
Sorry for the mix up. Linked wrong SRPM. 

* Updated SRPM URL:
https://pagure.io/rpm-packaging/blob/master/f/SRPMS/python-mlpy-3.5.0-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372836] Review Request: python-hug - A Python framework that makes developing APIs simple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372836



--- Comment #6 from Iryna Shcherbina  ---
(In reply to Haïkel Guémar from comment #5)
> 2. I'll shorten it.
> 3. fixed.
> 4. ack

Hi Haïkel,

are you going to push the updates for the above changes? I do not see the
changes in the linked files.
Let me know if any help needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392950] New: Review Request: qclib - Provides a C API for extraction of system information for Linux on z Systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392950

Bug ID: 1392950
   Summary: Review Request: qclib - Provides a C API for
extraction of system information for Linux on z
Systems
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rdoss...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://people.redhat.com/~rdossant/qclib.spec
SRPM URL: http://people.redhat.com/~rdossant/qclib-1.2.0-1.fc24.src.rpm
Description: qclib provides a C API for extraction of system information for
Linux on z
Systems.
For instance, it will provide the number of CPUs 
 * on the machine (CEC, Central Electronic Complex) layer
 * on the PR/SM (Processor Resource/Systems Manager) layer, i.e. visible to
   LPARs, including LPAR groups in z/VM hosts, guests and CPU pools
 * in KVM hosts and guests

This allows calculating the upper limit of CPU resources a highest level guest
can use. For example: If an LPAR on a z13 provides 4 CPUs to a z/VM
hyper-visor,
and the hyper-visor provides 8 virtual CPUs to a guest, qclib can be used to
retrieve all of these numbers, and it can be concluded that not more capacity
than 4 CPUs can be used by the software running in the guest.

Fedora Account System Username: rdossant

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392838] Review Request: python-mlpy - Python module for Machine Learning

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392838



--- Comment #3 from Dhanesh Sabane  ---
Bumped up spec. Removed unnecessary BRs. 

Spec URL: https://pagure.io/rpm-packaging/raw/master/f/SPECS/python-mlpy.spec

SRPM URL:
https://pagure.io/rpm-packaging/blob/master/f/SRPMS/python-mlpy-3.5.0-1.fc24.src.rpm

Koji build status:

*For F24: http://koji.fedoraproject.org/koji/taskinfo?taskID=16353282
*For F25: http://koji.fedoraproject.org/koji/taskinfo?taskID=16353354
*For rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=16353398

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744

Orion Poplawski  changed:

   What|Removed |Added

 CC||or...@cora.nwra.com



--- Comment #17 from Orion Poplawski  ---
Could you build this for EPEL7?  It mostly builds fine - though I see static
libs installed when I build locally.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python3-dbus

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392451] Review Request: perl-HTML-HTML5-Parser - Parse HTML reliably

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392451

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-HTML-HTML5-Parser-0.301-1.fc26.noarch.rpm | sort |
uniq -c
  1 /usr/bin/perl
  1 perl(:MODULE_COMPAT_5.24.0)
  1 perl(:VERSION) >= 5.10.0
  1 perl(:VERSION) >= 5.8.1
  1 perl(Carp)
  1 perl(Data::Dumper)
  1 perl(Encode)
  1 perl(Encode::Encoding)
  1 perl(Exporter)
  1 perl(Getopt::Long)
  1 perl(HTML::HTML5::Entities) >= 0.002
  1 perl(HTML::HTML5::Parser)
  1 perl(HTML::HTML5::Parser::Charset::Info)
  1 perl(HTML::HTML5::Parser::Error)
  1 perl(HTML::HTML5::Parser::TagSoupParser)
  1 perl(HTML::HTML5::Parser::Tokenizer)
  1 perl(HTTP::Tiny)
  1 perl(IO::HTML)
  1 perl(IO::Handle)
  1 perl(Scalar::Util)
  1 perl(Try::Tiny)
  1 perl(URI::file)
  1 perl(XML::LibXML) >= 1.94
  1 perl(XML::LibXML::Devel)
  1 perl(overload)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-HTML-HTML5-Parser-0.301-1.fc26.noarch.rpm | sort |
uniq -c
  1 perl(HTML::HTML5::Parser) = 0.301
  1 perl(HTML::HTML5::Parser::Charset::DecodeHandle) = 0.301
  1 perl(HTML::HTML5::Parser::Charset::DecodeHandle::ByteBuffer)
  1 perl(HTML::HTML5::Parser::Charset::DecodeHandle::CharString)
  1 perl(HTML::HTML5::Parser::Charset::DecodeHandle::Encode)
  1 perl(HTML::HTML5::Parser::Charset::DecodeHandle::ISO2022JP)
  1 perl(HTML::HTML5::Parser::Charset::Info) = 0.301
  1 perl(HTML::HTML5::Parser::Charset::USASCII)
  1 perl(HTML::HTML5::Parser::Charset::UnicodeChecker) = 0.301
  1 perl(HTML::HTML5::Parser::Charset::UniversalCharDet) = 0.301
  1 perl(HTML::HTML5::Parser::Charset::WebLatin1) = 0.301
  1 perl(HTML::HTML5::Parser::Charset::WebLatin5)
  1 perl(HTML::HTML5::Parser::Charset::WebThai) = 0.301
  1 perl(HTML::HTML5::Parser::Charset::WebThai::WebTIS620)
  1 perl(HTML::HTML5::Parser::Error) = 0.301
  1 perl(HTML::HTML5::Parser::TagSoupParser)
  1 perl(HTML::HTML5::Parser::TagSoupParser) = 0.301
  1 perl(HTML::HTML5::Parser::TagSoupParser::RestartParser)
  1 perl(HTML::HTML5::Parser::Tokenizer) = 0.301
  1 perl(HTML::HTML5::Parser::UA) = 0.301
  1 perl-HTML-HTML5-Parser = 0.301-1.fc26
Binary provides are Ok.

TODO: Unversioned provide perl(HTML::HTML5::Parser::TagSoupParser) can be
filtered.

$ rpmlint ./perl-HTML-HTML5-Parser*
perl-HTML-HTML5-Parser.noarch: W: spelling-error %description -l en_US LibXML
-> Lib XML, Lib-XML, Librium
perl-HTML-HTML5-Parser.noarch: E: useless-provides
perl(HTML::HTML5::Parser::TagSoupParser)
perl-HTML-HTML5-Parser.noarch: W: no-manual-page-for-binary html2xhtml
perl-HTML-HTML5-Parser.noarch: W: no-manual-page-for-binary html5debug
perl-HTML-HTML5-Parser.src: W: spelling-error %description -l en_US LibXML ->
Lib XML, Lib-XML, Librium
2 packages and 1 specfiles checked; 1 errors, 4 warnings.

perl(HTML::HTML5::Parser::TagSoupParser) is declare in these two files
HTML-HTML5-Parser-0.301/lib/HTML/HTML5/Parser/Tokenizer.pm
HTML-HTML5-Parser-0.301/lib/HTML/HTML5/Parser/TagSoupParser.pm
It should be provided only once. 

Otherwise, rpmlint is ok

Please consider fixing 'TODO' item.

The package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392838] Review Request: python-mlpy - Python module for Machine Learning

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392838

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
Please link to the raw file, so that fedora-review works:
Spec URL: https://pagure.io/rpm-packaging/raw/master/f/SPECS/python-mlpy.spec
SRPM URL:
https://pagure.io/rpm-packaging/blob/master/f/SRPMS/python-mlpy-3.5.0-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383781



--- Comment #19 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/sunflow

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392917] Review Request: libvdpau-va-gl - VDPAU driver with OpenGL/ VAAPI back-end

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392917



--- Comment #1 from Nicolas Chauvet (kwizart)  ---
koji scratch build for f26:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16352969

rpmlint is clean

This package was previously in a 3rd part repository, but since it has dropped
a dependency on a component not allowed in Fedora, it can now be submitted
here.

This package is a bridge between a vdpau player and vaapi backend driver.
There are currently several native vaapi backend:
- radeonsi_drv_video , r600_drv_video, nouveau_drv_video (which last requires
an external firmware). Thoses are from the mesa-dri-drivers package. But theses
also have a native vdpau backend.
- libva-intel-driver which is not in fedora because it may implement forbidden
items in software.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392917] New: Review Request: libvdpau-va-gl - VDPAU driver with OpenGL/VAAPI back-end

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392917

Bug ID: 1392917
   Summary: Review Request: libvdpau-va-gl - VDPAU driver with
OpenGL/VAAPI back-end
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: kwiz...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://dl.kwizart.net/review/libvdpau-va.spec
SRPM URL: http://dl.kwizart.net/review/libvdpau-va-gl-0.4.2-2.fc26.src.rpm
Description: VDPAU driver with OpenGL/VAAPI back-end
Fedora Account System Username: kwizart

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389016] Review Request: libxsmm - Library for small matrix-matrix multiplications on Intel x86_64 (e.g. for cp2k)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389016

Dave Love  changed:

   What|Removed |Added

 CC||anto.tra...@gmail.com
  Flags||needinfo?(anto.trande@gmail
   ||.com)



--- Comment #23 from Dave Love  ---
I need to know what to do about the samples, but here's an update to the
current version anyway.

SRPM URL: https://loveshack.fedorapeople.org/review/libxsmm-1.5.2-1.el6.src.rpm
Spec URL: https://loveshack.fedorapeople.org/review/libxsmm.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376035] Review Request: modulemd - Module metadata manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376035



--- Comment #8 from Petr Šabata  ---
1.0.1 released :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267340] Review Request: rubygem-minitest-around - Around block for minitest

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267340



--- Comment #5 from Ilya Gradina  ---
Hi Vit,

Thx!

new spec:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-minitest-around.spec
new srpm:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-minitest-around-0.4.0-2.fc25.src.rpm

- added your fix of the tests
- added run rdoc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392838] Review Request: python-mlpy - Python module for Machine Learning

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392838



--- Comment #1 from Dhanesh Sabane  ---
Koji build status:

*For F25 - http://koji.fedoraproject.org/koji/taskinfo?taskID=16351147
*For rawhide - http://koji.fedoraproject.org/koji/taskinfo?taskID=16351456

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389695] Review Request: python-wcsaxes - A Python framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389695

Iryna Shcherbina  changed:

   What|Removed |Added

 CC||ishch...@redhat.com



--- Comment #1 from Iryna Shcherbina  ---
Hi Sergio,

the spec file looks good, but I have a couple of suggestions you might
consider:

* Please use the %{srcname} macro you have defined in the `SourceO` tag:

> Source0: https://pypi.io/packages/source/w/wcsaxes/wcsaxes-%{version}.tar.gz

change to

`Source0:
https://pypi.io/packages/source/w/%{srcname}/%{srcname}-%{version}.tar.gz`


* To improve readability please use multiple lines for `BuildRequires` tag:

> BuildRequires: python2-devel python3-devel xorg-x11-server-Xvfb


* You can use macro %{summary}, which will contain content of the Summary tag
(it's generated automatically, you do not have to define it). Just keep the
first Summary tag as it is and in python2/3- subpackages you can use `Summary: 
 %{summary}`.


* It is better to avoid using wildcards in the %files section to have an idea
what is installed with the package. Doing the following change would make it
more safe (same for python3- subpackage):

> %{python2_sitelib}/*

change to

%{python2_sitelib}/%{srcname}
%{python2_sitelib}/%{srcname}-%{version}-py?.?.egg-info


* Due to the above, the following file gets to the generated RPMs. It is
generated during tests and does not belong in the package:

/usr/lib/python3.5/site-packages/test.png
/usr/lib/python2.7/site-packages/test.png


Another issue is that I believe you are running tests in %{buildroot} to avoid
the problem with pytest-mpl dependency
(https://github.com/astrofrog/wcsaxes/commit/83fec6e82bbae751f0241da6933ae425c0e9664b#diff-8b1c3fd0d4a6765c16dfd18509182f9dR8)
and ignore wcsaxes/setup.cfg settings. However, when installing the package and
running tests with wcsaxes.test() (as it is stated in the documentation), I am
running into multiple errors:

import file mismatch:
imported module 'wcsaxes.tests.test_coordinate_helpers' has this __file__
attribute:
 
/builddir/build/BUILDROOT/python-wcsaxes-0.9-1.fc24.x86_64/usr/lib/python3.5/site-packages/wcsaxes/tests/test_coordinate_helpers.py
  which is not the same as the test file we want to collect:
/usr/lib/python3.5/site-packages/wcsaxes/tests/test_coordinate_helpers.py
HINT: remove __pycache__ / .pyc files and/or use a unique basename for your
test file modules

That happens because running tests in the %{buildroot} generates files, e.g.
/usr/lib/python3.5/site-packages/test.png (mentioned above).
Instead of changing the directory, try specifying another config when running
tests (with a -c option) or ignoring it, to fix the above issues. Another
option would be to clean up after tests.

Apart from a couple of small suggestions above, everything looks fine.
Note, that it is an informal package review, as I am not sponsored yet, but I
can do a formal one once I am.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392451] Review Request: perl-HTML-HTML5-Parser - Parse HTML reliably

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392451

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392838] Review Request: python-mlpy - Python module for Machine Learning

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392838

Dhanesh Sabane  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392838] New: Review Request: python-mlpy - Python module for Machine Learning

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392838

Bug ID: 1392838
   Summary: Review Request: python-mlpy - Python module for
Machine Learning
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: dhaneshsaban...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://pagure.io/rpm-packaging/blob/master/f/SPECS/python-mlpy.spec

SRPM URL: https://pagure.io/rpm-packaging/blob/master/f/SRPMS

Description: 
*python-mlpy provides machine learning methods for supervised and unsupervised
problems.  

*I would appreciate a review so that I can get it into Fedora.  This is my
first package and so I would also appreciate getting sponsored.  I'm currently
active in the Fedora Project as a CommOps and Marketing contributor.

*With this package I'm hoping to be a member of Python SIG and Machine Learning
SIG. 

Fedora Account System Username: dhanesh95

Koji build status: http://koji.fedoraproject.org/koji/taskinfo?taskID=16346771

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343977] Review Request: rubygem-asciidoctor-mallard - A Project Mallard converter for AsciiDoc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343977

Vít Ondruch  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |asciidoctor-mallard - A |rubygem-asciidoctor-mallard
   |Project Mallard converter   |- A Project Mallard
   |for AsciiDoc|converter for AsciiDoc



--- Comment #9 from Vít Ondruch  ---
* Source of the gem?
  - Where did you get the source gem? It is not available on rubygems.org as
far
as I can tell, neither you documented anywhere how you obtained it.

* Package naming
  - Please rename the .spec file to rubygem-asciidoctor-mallar.spec to be in
line with the guidelines [1].

* Package version
  - Please use proper version scheme. The package version should be probably
just "0.1.0" while the release should be "0.1.dev".
  - The versioning is documented in detail here [2].

* Duplicated license
  - You should not include the "%license LICENSE.adoc". Please keep just "%doc
%{gem_instdir}/LICENSE.adoc" in the main package (and change the %doc to
%license of course).

* Unneeded requires
  - You probably don't need to include "Requires: rubygem-thread_safe". Runtime
requires should be autogenerated during build process.
  - Not sure what is the "pintail" good for. Some explaining hint above would
come handy.

* Doc subpackage
  - It is good habit to keep the documentation in -doc subpackage.

* Test suite
  - Well, the line you used is just part of the story. You can see that there
is nothing which would indicated, that the test suite was executed. You
should use following line:

```
ruby -Ilib -e 'Dir.glob "./test/*_test.rb", (:require)'
```

  - Unfortunately, there seems to be dependency on asciidoctor-doctest, which
is not in Fedora yet. Since it has quite lot of dependencies, it is
probably not worth of packaging ATM, but all this should be documented.
  - Instead of execution of test suite, you should consider to provide at least
some sanity test, e.g. try to convert some document from AsciiDoc to
Mallard using the %{gem_instdir}/bin/asciidoctor-mallard

* Bump release between review iteration
  - It is good habit to bump the package release each review iteration.



[1] https://fedoraproject.org/wiki/Packaging:Ruby#Naming_Guidelines
[2] https://fedoraproject.org/wiki/Packaging:Versioning#Pre-Release_packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1279104] Review Request: python-pbkdf2 - password-based key derivation in pure Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279104

Samuel Gyger  changed:

   What|Removed |Added

  Flags|needinfo?(gy...@fsfe.org)   |



--- Comment #9 from Samuel Gyger  ---
From my side, feel free to take over. I'm looking forward to see electrum
finally in fedora. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383781

jiri vanek  changed:

   What|Removed |Added

 CC||jva...@redhat.com



--- Comment #18 from jiri vanek  ---
Michal is being sponsored.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392434] Review Request: perl-XML-LibXML-Devel-SetLineNumber - Set the line number for an XML:: LibXML::Node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392434

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-XML-LibXML-Devel-SetLi
   ||neNumber-0.002-1.fc26
 Resolution|--- |RAWHIDE
Last Closed||2016-11-08 04:17:16



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392451] Review Request: perl-HTML-HTML5-Parser - Parse HTML reliably

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392451
Bug 1392451 depends on bug 1392434, which changed state.

Bug 1392434 Summary: Review Request: perl-XML-LibXML-Devel-SetLineNumber - Set 
the line number for an XML::LibXML::Node
https://bugzilla.redhat.com/show_bug.cgi?id=1392434

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374138] Review Request: vim-syntastic - A vim plugins to check syntax for programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374138

Pavel Raiskup  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-11-08 03:12:55



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org