[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack

https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #63 from Yunying Sun --- > > Questions left: > > 1. > N/A*%check is present and all tests pass. > > Is the %check section a MUST? > > it's a SHOULD >

[Bug 1382850] Review Request: libtoml - Fast C parser using Ragel to generate the state machine

https://bugzilla.redhat.com/show_bug.cgi?id=1382850 --- Comment #4 from Igor Gnatenko --- https://ignatenkobrain.fedorapeople.org/for-review/libtoml.spec https://ignatenkobrain.fedorapeople.org/for-review/libtoml-0-1.20161213git03e8a3a.fc26.src.rpm -- You are receiving

[Bug 1402540] Review Request: git-fame - Pretty-print git repository collaborators sorted by contributions

https://bugzilla.redhat.com/show_bug.cgi?id=1402540 --- Comment #12 from Fedora Update System --- git-fame-1.2.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See

[Bug 1402540] Review Request: git-fame - Pretty-print git repository collaborators sorted by contributions

https://bugzilla.redhat.com/show_bug.cgi?id=1402540 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA

[Bug 1402164] Review Request: pydf - Fully colorized df clone written in python

https://bugzilla.redhat.com/show_bug.cgi?id=1402164 --- Comment #4 from Devin Henderson --- Thank you Dhanesh and Michael! I will read through your notes and links and see if I can come up with a better spec file. -- You are receiving this mail because: You are on the CC

[Bug 1393947] Review Request: cinch - A tool for provisioning Jenkins components for CI

https://bugzilla.redhat.com/show_bug.cgi?id=1393947 --- Comment #5 from greg.helli...@gmail.com --- New SRPM: https://fedorapeople.org/~greghellings/cinch/cinch-0.2.1-2.fc25.src.rpm I added the %license line I switched python-devel to python2-devel instead I'm guessing that's what you were

[Bug 1403417] Review Request: gsequencer - audio processing engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403417 --- Comment #7 from Joël Krähemann --- Hi Just updated gsequencer.spec and have taken a look at the review. About certain points I'm unsure. This is a review *template*. Besides handling the [ ]-marked tests you are

[Bug 1402164] Review Request: pydf - Fully colorized df clone written in python

https://bugzilla.redhat.com/show_bug.cgi?id=1402164 --- Comment #3 from Michael Schwendt --- > I have made as little changes to the original rpms as possible. Why that? What changes would you have liked to make? > Summary:Fully colorized df clone written in

[Bug 1382850] Review Request: libtoml - Fast C parser using Ragel to generate the state machine

https://bugzilla.redhat.com/show_bug.cgi?id=1382850 --- Comment #3 from Michael Schwendt --- > Release:1git%{shortcommit}%{?dist} Does not follow the versioning guidelines: https://fedoraproject.org/wiki/Packaging:Versioning#Snapshot_packages > %package devel

[Bug 1404044] Review Request: brooklyn - model, deploy, manage application

https://bugzilla.redhat.com/show_bug.cgi?id=1404044 Michael Schwendt changed: What|Removed |Added Blocks||177841

[Bug 1401302] Review Request: libarcus - Communication library between internal components for Ultimaker software

https://bugzilla.redhat.com/show_bug.cgi?id=1401302 --- Comment #3 from Michael Schwendt --- > %description > Arcus library contains C++ code and Python 3 bindings Then you will need "BuildRequires: gcc-c++" as per this year's changes to the buildroots to make them

[Bug 1397051] Review Request: caffeine - High performance java 8 caching library

https://bugzilla.redhat.com/show_bug.cgi?id=1397051 --- Comment #21 from Fedora Update System --- caffeine-2.3.5-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving

[Bug 1401276] Review Request: python-grako - Python grammer compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1401276 --- Comment #4 from Eric Smith --- Spec URL: https://fedorapeople.org/~brouhaha/python-grako/python-grako.spec SRPM URL: https://fedorapeople.org/~brouhaha/python-grako/python-grako-3.18.0-2.fc24.src.rpm Good catch! I've

[Bug 1404044] New: Review Request: brooklyn - model, deploy, manage application

https://bugzilla.redhat.com/show_bug.cgi?id=1404044 Bug ID: 1404044 Summary: Review Request: brooklyn - model, deploy, manage application Product: Fedora Version: rawhide Component: Package Review Severity: medium

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

https://bugzilla.redhat.com/show_bug.cgi?id=1404043 --- Comment #1 from Jarod Wilson --- There isn't an upstream rdma-core release just yet, so the tarball was generated using: $ git archive --prefix rdma-core-12/ --output ~/rpmbuild/SOURCES/rdma-core-12.tgz HEAD A release

[Bug 1404043] New: Review Request: rdma-core - RDMA core userspace libraries and daemons

https://bugzilla.redhat.com/show_bug.cgi?id=1404043 Bug ID: 1404043 Summary: Review Request: rdma-core - RDMA core userspace libraries and daemons Product: Fedora Version: rawhide Component: Package Review

[Bug 1396232] Review Request: libkeepalive - Enable TCP keepalive in dynamic binaries

https://bugzilla.redhat.com/show_bug.cgi?id=1396232 Igor Gnatenko changed: What|Removed |Added CC|

[Bug 1374899] Review Request: quassel-irssi - An irssi plugin to connect to quassel core

https://bugzilla.redhat.com/show_bug.cgi?id=1374899 --- Comment #16 from Fedora Update System --- quassel-irssi-0-2.20161120gitcbd9bd7.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

[Bug 1402456] Review Request: python3-idna - Internationalized Domain Names in Applications (IDNA)

https://bugzilla.redhat.com/show_bug.cgi?id=1402456 Fedora Update System changed: What|Removed |Added Status|ASSIGNED

[Bug 1402456] Review Request: python3-idna - Internationalized Domain Names in Applications (IDNA)

https://bugzilla.redhat.com/show_bug.cgi?id=1402456 --- Comment #4 from Fedora Update System --- python3-idna-2.1-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-940fb9734f -- You are receiving this

[Bug 1402456] Review Request: python3-idna - Internationalized Domain Names in Applications (IDNA)

https://bugzilla.redhat.com/show_bug.cgi?id=1402456 --- Comment #3 from Fedora Update System --- python3-idna-2.1-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-3faec4c6db -- You are receiving this

[Bug 1398949] Review Request: bear - Game engine and editors dedicated to creating great 2D games

https://bugzilla.redhat.com/show_bug.cgi?id=1398949 --- Comment #20 from Jeremy Newton --- (In reply to Tom "spot" Callaway from comment #19) > (In reply to Jeremy Newton from comment #18) > > > Well any libraries needed for run-time should be placed into the main > >

[Bug 1404012] New: Review Request: module-build-service - The Module Build Service for Modularity

https://bugzilla.redhat.com/show_bug.cgi?id=1404012 Bug ID: 1404012 Summary: Review Request: module-build-service - The Module Build Service for Modularity Product: Fedora Version: rawhide Component: Package Review

[Bug 1404012] Review Request: module-build-service - The Module Build Service for Modularity

https://bugzilla.redhat.com/show_bug.cgi?id=1404012 --- Comment #1 from Ralph Bean --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=16857938 -- You are receiving this mail because: You are on the CC list for the bug. You are always

[Bug 1397842] Review Request: python-cccolutils - Python Kerberos Credential Cache Collection Utilities

https://bugzilla.redhat.com/show_bug.cgi?id=1397842 --- Comment #21 from Fedora Update System --- python-cccolutils-1.5-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0137e43188 -- You are receiving

[Bug 1402540] Review Request: git-fame - Pretty-print git repository collaborators sorted by contributions

https://bugzilla.redhat.com/show_bug.cgi?id=1402540 --- Comment #10 from Fedora Update System --- git-fame-1.2.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a20a6ee060 -- You are receiving this mail

[Bug 1402540] Review Request: git-fame - Pretty-print git repository collaborators sorted by contributions

https://bugzilla.redhat.com/show_bug.cgi?id=1402540 --- Comment #9 from Fedora Update System --- git-fame-1.2.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8fd51877c2 -- You are receiving this mail

[Bug 1402540] Review Request: git-fame - Pretty-print git repository collaborators sorted by contributions

https://bugzilla.redhat.com/show_bug.cgi?id=1402540 Fedora Update System changed: What|Removed |Added Status|POST

[Bug 1402540] Review Request: git-fame - Pretty-print git repository collaborators sorted by contributions

https://bugzilla.redhat.com/show_bug.cgi?id=1402540 --- Comment #8 from Raphael Groner --- Please fix (again) while importing: - Please use License: MPLv2.0 - Remove unneeded Requires: python3-setuptools - I think also the package has to explicitly 'Require: git' as

[Bug 1398949] Review Request: bear - Game engine and editors dedicated to creating great 2D games

https://bugzilla.redhat.com/show_bug.cgi?id=1398949 --- Comment #19 from Tom "spot" Callaway --- (In reply to Jeremy Newton from comment #18) > Well any libraries needed for run-time should be placed into the main > package, and any libraries or header/source files needed

[Bug 1387669] Review Request: kio-gdrive - KDE Dolphin Google Drive access

https://bugzilla.redhat.com/show_bug.cgi?id=1387669 --- Comment #9 from Vasiliy Glazov --- Oh, sorry, I am not able to be a sponsor. I have not enough experience for it. May be Rex will sponsor. But I make review of your package. Package Review == Legend: [x]

[Bug 1382755] Review Request: legion - A data-centric parallel programming system

https://bugzilla.redhat.com/show_bug.cgi?id=1382755 Antonio Trande changed: What|Removed |Added CC|

[Bug 1398949] Review Request: bear - Game engine and editors dedicated to creating great 2D games

https://bugzilla.redhat.com/show_bug.cgi?id=1398949 --- Comment #18 from Jeremy Newton --- (In reply to Tom "spot" Callaway from comment #17) > (In reply to Tom "spot" Callaway from comment #16) > > Do you have another package (besides plee-the-bear) that depends on the

[Bug 1398949] Review Request: bear - Game engine and editors dedicated to creating great 2D games

https://bugzilla.redhat.com/show_bug.cgi?id=1398949 --- Comment #17 from Tom "spot" Callaway --- (In reply to Tom "spot" Callaway from comment #16) > Do you have another package (besides plee-the-bear) that depends on the bear > library? Replying to myself, I see that

[Bug 1398949] Review Request: bear - Game engine and editors dedicated to creating great 2D games

https://bugzilla.redhat.com/show_bug.cgi?id=1398949 Tom "spot" Callaway changed: What|Removed |Added CC|

[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities

https://bugzilla.redhat.com/show_bug.cgi?id=1401334 Randy Barlow changed: What|Removed |Added Flags|fedora-review?

[Bug 1312303] Review Request: perl-Net-LDAP-Server-Test - Test Net:: LDAP code

https://bugzilla.redhat.com/show_bug.cgi?id=1312303 --- Comment #5 from Ralf Corsepius --- Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Net-LDAP-Server-Test.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Net-LDAP-Server-Test-0.21-2.fc26.src.rpm

[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities

https://bugzilla.redhat.com/show_bug.cgi?id=1401334 --- Comment #7 from Randy Barlow --- Miro, it looks like upstream made a 2.0.1 release that has the license file. You might want to package that one instead. -- You are receiving this mail because: You are on

[Bug 1401276] Review Request: python-grako - Python grammer compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1401276 --- Comment #3 from Iryna Shcherbina --- Thank you for the changes. (In reply to Eric Smith from comment #2) > The reason for the for loop that changes the shebang and perms for only one > file: > 1) copied from another

[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities

https://bugzilla.redhat.com/show_bug.cgi?id=1401334 --- Comment #6 from Randy Barlow --- Thanks Miro, upstream responded quickly! Also I hadn't noticed the BSD in the setup.py. Since that is there, I think we can proceed and you can add the license file whenever

[Bug 1387669] Review Request: kio-gdrive - KDE Dolphin Google Drive access

https://bugzilla.redhat.com/show_bug.cgi?id=1387669 --- Comment #8 from Wolnei Junior --- Full review attach to https://bugzilla.redhat.com/show_bug.cgi?id=1037427 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1403381] Review Request: microdnf - Micro DNF

https://bugzilla.redhat.com/show_bug.cgi?id=1403381 --- Comment #6 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/microdnf -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1037427] Review Request: kdeneur - KDE frontend for X Neural Switcher (xneur)

https://bugzilla.redhat.com/show_bug.cgi?id=1037427 --- Comment #5 from Wolnei Junior --- After run fedora-review tool: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://launchpad.net/~andrew-crew-

[Bug 1403381] Review Request: microdnf - Micro DNF

https://bugzilla.redhat.com/show_bug.cgi?id=1403381 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ ---

[Bug 1403381] Review Request: microdnf - Micro DNF

https://bugzilla.redhat.com/show_bug.cgi?id=1403381 --- Comment #4 from Igor Gnatenko --- Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/microdnf.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/microdnf-1-1.fc26.src.rpm Jason, Neal, * IMO

[Bug 1403417] Review Request: gsequencer - audio processing engine

https://bugzilla.redhat.com/show_bug.cgi?id=1403417 Michael Schwendt changed: What|Removed |Added CC|

[Bug 1386774] Review Request: kf5-libktorrent - Library providing torrent downloading code

https://bugzilla.redhat.com/show_bug.cgi?id=1386774 Rex Dieter changed: What|Removed |Added Flags|needinfo?(rdie...@math.unl. |

[Bug 1398949] Review Request: bear - Game engine and editors dedicated to creating great 2D games

https://bugzilla.redhat.com/show_bug.cgi?id=1398949 --- Comment #15 from MartinKG --- (In reply to Jeremy Newton from comment #14) > Package Review > == > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed

[Bug 1403734] Review Request: perl-Sub-Quote - Efficient generation of subroutines via string eval

https://bugzilla.redhat.com/show_bug.cgi?id=1403734 Jitka Plesnikova changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed

[Bug 1403734] Review Request: perl-Sub-Quote - Efficient generation of subroutines via string eval

https://bugzilla.redhat.com/show_bug.cgi?id=1403734 --- Comment #2 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Sub-Quote -- You are receiving this mail because: You are on the CC list for the bug. You

[Bug 1402540] Review Request: git-fame - Pretty-print git repository collaborators sorted by contributions

https://bugzilla.redhat.com/show_bug.cgi?id=1402540 --- Comment #7 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/git-fame -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1359914] Review Request: lollypop - Music player for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=1359914 --- Comment #33 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/lollypop -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1402456] Review Request: python3-idna - Internationalized Domain Names in Applications (IDNA)

https://bugzilla.redhat.com/show_bug.cgi?id=1402456 --- Comment #2 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python3-idna -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1401337] Review Request: python-zeroconf - Pure Python Multicast DNS Service Discovery Library

https://bugzilla.redhat.com/show_bug.cgi?id=1401337 --- Comment #4 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-zeroconf -- You are receiving this mail because: You are on the CC list for the bug. You

[Bug 1393796] Review Request: golang-github-go-errors-error - Package errors provides errors that have stack-traces

https://bugzilla.redhat.com/show_bug.cgi?id=1393796 --- Comment #7 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-go-errors-error -- You are receiving this mail because: You are on the CC list for

[Bug 1375765] Review Request: yosys - Yosys Open SYnthesis Suite, including Verilog synthesizer

https://bugzilla.redhat.com/show_bug.cgi?id=1375765 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA

[Bug 1403734] Review Request: perl-Sub-Quote - Efficient generation of subroutines via string eval

https://bugzilla.redhat.com/show_bug.cgi?id=1403734 Petr Pisar changed: What|Removed |Added Flags|fedora-review? |fedora-review+ ---

[Bug 1395244] Review Request: python3-zope-event - Zope Event Publication

https://bugzilla.redhat.com/show_bug.cgi?id=1395244 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA

[Bug 1403734] Review Request: perl-Sub-Quote - Efficient generation of subroutines via string eval

https://bugzilla.redhat.com/show_bug.cgi?id=1403734 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

https://bugzilla.redhat.com/show_bug.cgi?id=1302744 --- Comment #6 from Mathieu Bridon --- Port is now randomized in the latest upstream release, here's the new package. Spec URL: https://bochecha.fedorapeople.org/packages/python-resumable-urlretrieve.spec SRPM URL:

[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack

https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #62 from Dan Horák --- (In reply to Yunying Sun from comment #61) > (In reply to Dan Horák from comment #60) > > formal review is here, see the notes explaining OK* and BAD statuses below: > > ... > > So almost

[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack

https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #61 from Yunying Sun --- (In reply to Dan Horák from comment #60) > formal review is here, see the notes explaining OK* and BAD statuses below: > ... > So almost good, but please answer my question (and/or

[Bug 1403734] New: Review Request: perl-Sub-Quote - Efficient generation of subroutines via string eval

https://bugzilla.redhat.com/show_bug.cgi?id=1403734 Bug ID: 1403734 Summary: Review Request: perl-Sub-Quote - Efficient generation of subroutines via string eval Product: Fedora Version: rawhide Component: Package Review

[Bug 1403724] New: Review Request: php-justinrainbow-json-schema4 - A library to validate a json schema

https://bugzilla.redhat.com/show_bug.cgi?id=1403724 Bug ID: 1403724 Summary: Review Request: php-justinrainbow-json-schema4 - A library to validate a json schema Product: Fedora Version: rawhide Component: Package Review

[Bug 1312303] Review Request: perl-Net-LDAP-Server-Test - Test Net:: LDAP code

https://bugzilla.redhat.com/show_bug.cgi?id=1312303 --- Comment #4 from Jitka Plesnikova --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed $ rpm -qp --requires perl-Net-LDAP-Server-Test-0.21-1.fc26.noarch.rpm |

[Bug 1387669] Review Request: kio-gdrive - KDE Dolphin Google Drive access

https://bugzilla.redhat.com/show_bug.cgi?id=1387669 --- Comment #7 from Vasiliy Glazov --- I am think that "make review request" mean that you need make full review (with run and check fedora-review) with actual package and responsive packager. And if you update SPEC and