[Bug 1386774] Review Request: kf5-libktorrent - Library providing torrent downloading code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386774



--- Comment #14 from Fedora Update System  ---
kf5-libktorrent-2.0.1-5.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1d2a0ef47f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386774] Review Request: kf5-libktorrent - Library providing torrent downloading code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386774

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
kf5-libktorrent-2.0.1-5.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab746d8a0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1259002] Review Request: rudiments - C++ class library for developing systems and applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1259002

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-24 22:20:52



--- Comment #20 from Fedora Update System  ---
rudiments-0.53-5.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1408552] Review Request: python-pyzo - The Interactive editor for scientific Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1408552

Scott K Logan  changed:

   What|Removed |Added

 Blocks||1382158, 1393063




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1393063
[Bug 1393063] Python console is super slow
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1408552] New: Review Request: python-pyzo - The Interactive editor for scientific Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1408552

Bug ID: 1408552
   Summary: Review Request: python-pyzo - The Interactive editor
for scientific Python
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: log...@cottsay.net
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://cottsay.fedorapeople.org/python-pyzo/python-pyzo.spec
SRPM URL:
https://cottsay.fedorapeople.org/python-pyzo/python-pyzo-4.3.1-1.fc26.src.rpm

Description:
Pyzo is a cross-platform Python IDE focused on interactivity and
introspection, which makes it very suitable for scientific computing.
Its practical design is aimed at simplicity and efficiency.

It consists of two main components, the editor and the shell, and uses
a set of pluggable tools to help the programmer in various ways. Some
example tools are source structure, project manager, interactive help,
workspace ...

Fedora Account System Username: cottsay

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17057889

rpmlint output:
python-pyzo.src: W: spelling-error %description -l en_US pluggable -> plug
gable, plug-gable, plugged
python-pyzo.src: W: spelling-error %description -l en_US workspace -> work
space, work-space, works pace
python3-pyzo.noarch: W: spelling-error %description -l en_US pluggable -> plug
gable, plug-gable, plugged
python3-pyzo.noarch: W: spelling-error %description -l en_US workspace -> work
space, work-space, works pace
python3-pyzo.noarch: W: obsolete-not-provided python3-iep
python3-pyzo.noarch: W: obsolete-not-provided python3-pyzolib
2 packages and 1 specfiles checked; 0 errors, 6 warnings.

**IMPORTANT NOTE**
This is a package rename/obsolete review. The python-pyzolib and python-iep
packages should be merged into this one following the merger of the upstream
projects. More information on the merger is available here:
http://www.pyzo.org/iep.html

Per packaging spec, the python-pyzolib and python-iep packages will be retired
when this package (python-pyzo) has been pushed.

I am aware that the desktop post-scriptlets shouldn't be used in f25+. I'll
make sure those entries aren't in the f25 or rawhide branches, but they should
exist in the f24 branch, so I thought it best to include them in the review.

Relevant packaging specs:
-
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Icon_Cache
-
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#desktop-database
-
https://fedoraproject.org/wiki/Packaging:FontsPolicy#Install-time_dependencies
- https://fedoraproject.org/wiki/Package_Renaming_Process
- https://fedoraproject.org/wiki/Packaging:Python
-
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags

Thanks,

--scott

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #3 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1405298] Review Request: php-geos - PHP module for GEOS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1405298



--- Comment #1 from Remi Collet  ---
Updated to 1.0.0 final

Spec:
https://raw.githubusercontent.com/remicollet/remirepo/2c5ca0a5c2f11ff9a65f6e51e6fc0461ff47a5df/php/php-geos/php-geos.spec
Srpm: http://rpms.remirepo.net/SRPMS/php-geos-1.0.0-1.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401335] Review Request: python-numpy-stl - Library for reading, writing and modifying STL files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401335

Athos Ribeiro  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||athoscribe...@gmail.com
   Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1360482] Review Request: nextcloud - a private, secure way to share and access files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360482

Germano Massullo  changed:

   What|Removed |Added

 CC||james.hoga...@gmail.com
  Flags||needinfo?(james.hogarth@gma
   ||il.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1408428] Review Request: log4cxx - A port to C++ of the Log4j project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1408428

Antonio Trande  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Antonio Trande  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1408428] Review Request: log4cxx - A port to C++ of the Log4j project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1408428



--- Comment #3 from Till Hofmann  ---
Spec URL: https://thofmann.fedorapeople.org/log4cxx/log4cxx.spec
SRPM URL:
https://thofmann.fedorapeople.org/log4cxx/log4cxx-0.10.0-22.fc23.src.rpm

Thank you for reviewing!

(In reply to Antonio Trande from comment #2)
> Package Review
> ==
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
> 
> 
> Issues:
> ===
> - Package does not use a name that already exists.
>   Note: A package with this name already exists. Please check
>   https://admin.fedoraproject.org/pkgdb/package/log4cxx
>   See:
>  
> https://fedoraproject.org/wiki/Packaging/
> NamingGuidelines#Conflicting_Package_Names
> 
> - No Requires: %{name}%{?_isa} = %{version}-%{release} in log4cxx-devel
> 
> Use Requires: '%{name}%{?_isa} = %{version}-%{release}'

Fixed.

> 
> - Use '--enable-static=no' as configure's option to not build static files
> (*.a)

Fixed.

> 
> - make -k %{?_smp_mflags}
> 
> Why that -k option?

Oversight. I replaced it with %make_build.

> 
> - Please, fix 'unused-direct-shlib-dependency' warnings

Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1262515] Review Request: qbs - Qt Build Suite

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262515



--- Comment #12 from Michael Schwendt  ---
(!) 404 not found for the src.rpm


> # Required for running the tests
> BuildRequires:  pkgconfig(Qt5Quick)
> BuildRequires:  glibc-static
> BuildRequires:  libstdc++-static

Hmmm. Does the comment above that also refer to the two -static packages?

Why would tests require linking statically?

Since BuildRequires apply to the entire package, the availability of the static
libs in the buildroot can be problematic due to linking other executables
statically (either accidentally, unknowingly or because of build defaults
changing eventually). That would be something to avoid by adding guards or
finding ways to eliminate static linking in those tests.

https://fedoraproject.org/wiki/Packaging:Guidelines#Statically_Linking_Executables

[...]

Has "fedora-review -b 1262515" been run for this ticket yet?

[...]

> %package doc
> %package examples

If these shall stay completely separate subpackages, consider fixing the
directory ownership and %license usage for these packages.

* https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
*
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #3 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 61 files have unknown
 license. Detailed output of licensecheck in /home/gil/1406958-python-
 ipykernel/licensecheck.txt

The following source files are without license headers:

ipykernel-4.5.2/ipykernel/__init__.py
ipykernel-4.5.2/ipykernel/_main.py
ipykernel-4.5.2/ipykernel/_version.py
ipykernel-4.5.2/ipykernel/datapub.py
ipykernel-4.5.2/ipykernel/embed.py
ipykernel-4.5.2/ipykernel/ipkernel.py
ipykernel-4.5.2/ipykernel/log.py
ipykernel-4.5.2/ipykernel/comm/__init__.py
ipykernel-4.5.2/ipykernel/inprocess/__init__.py
ipykernel-4.5.2/ipykernel/inprocess/constants.py
ipykernel-4.5.2/ipykernel/inprocess/tests/__init__.py
ipykernel-4.5.2/ipykernel/pylab/__init__.py
ipykernel-4.5.2/ipykernel/tests/test_pickleutil.py
ipykernel-4.5.2/ipykernel/tests/test_start_kernel.py

ipykernel-4.5.2/docs/conf.py
ipykernel-4.5.2/examples/embedding/inprocess_qtconsole.py
ipykernel-4.5.2/examples/embedding/inprocess_terminal.py
ipykernel-4.5.2/examples/embedding/internal_ipkernel.py
ipykernel-4.5.2/examples/embedding/ipkernel_qtapp.py
ipykernel-4.5.2/examples/embedding/ipkernel_wxapp.py

Please, ask to upstream to confirm the licensing of code and/or content/s, and
add license headers
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

[x]: License file installed when any subpackage combination is installed.
[?]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/doc/python-ipykernel,
 /usr/lib/python3.6/site-packages, /usr/lib/python3.6
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/doc/python-
 ipykernel, /usr/lib/python3.6/site-packages, /usr/lib/python3.6

  /usr/share/doc/python-ipykernel

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 6 files.
[?]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: 

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958



--- Comment #4 from gil cattaneo  ---
Issues:

[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 61 files have unknown
 license. Detailed output of licensecheck in /home/gil/1406958-python-
 ipykernel/licensecheck.txt

The following source files are without license headers:

ipykernel-4.5.2/ipykernel/__init__.py
ipykernel-4.5.2/ipykernel/_main.py
ipykernel-4.5.2/ipykernel/_version.py
ipykernel-4.5.2/ipykernel/datapub.py
ipykernel-4.5.2/ipykernel/embed.py
ipykernel-4.5.2/ipykernel/ipkernel.py
ipykernel-4.5.2/ipykernel/log.py
ipykernel-4.5.2/ipykernel/comm/__init__.py
ipykernel-4.5.2/ipykernel/inprocess/__init__.py
ipykernel-4.5.2/ipykernel/inprocess/constants.py
ipykernel-4.5.2/ipykernel/inprocess/tests/__init__.py
ipykernel-4.5.2/ipykernel/pylab/__init__.py
ipykernel-4.5.2/ipykernel/tests/test_pickleutil.py
ipykernel-4.5.2/ipykernel/tests/test_start_kernel.py

ipykernel-4.5.2/docs/conf.py
ipykernel-4.5.2/examples/embedding/inprocess_qtconsole.py
ipykernel-4.5.2/examples/embedding/inprocess_terminal.py
ipykernel-4.5.2/examples/embedding/internal_ipkernel.py
ipykernel-4.5.2/examples/embedding/ipkernel_qtapp.py
ipykernel-4.5.2/examples/embedding/ipkernel_wxapp.py

Please, ask to upstream to confirm the licensing of code and/or content/s, and
add license headers
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

[?]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/doc/python-ipykernel,
 /usr/lib/python3.6/site-packages, /usr/lib/python3.6
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/doc/python-
 ipykernel, /usr/lib/python3.6/site-packages, /usr/lib/python3.6

  /usr/share/doc/python-ipykernel


[!]: Uses parallel make %{?_smp_mflags} macro.

 make html >> make %{?_smp_mflags} html


[!]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
 files.
 cp -favr docs/_build/html %{buildroot}%{_docdir}/%{name}

Please; use:
Source0:   
https://github.com/ipython/%{modname}/archive/%{version}/%{modname}-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958



--- Comment #5 from gil cattaneo  ---
(In reply to gil cattaneo from comment #4)
> Issues:
> 
> [!]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "BSD (3 clause)", "Unknown or generated". 61 files have unknown
>  license. Detailed output of licensecheck in /home/gil/1406958-python-
>  ipykernel/licensecheck.txt
> 
> The following source files are without license headers:
> 
> ipykernel-4.5.2/ipykernel/__init__.py
> ipykernel-4.5.2/ipykernel/_main.py
> ipykernel-4.5.2/ipykernel/_version.py
> ipykernel-4.5.2/ipykernel/datapub.py
> ipykernel-4.5.2/ipykernel/embed.py
> ipykernel-4.5.2/ipykernel/ipkernel.py
> ipykernel-4.5.2/ipykernel/log.py
> ipykernel-4.5.2/ipykernel/comm/__init__.py
> ipykernel-4.5.2/ipykernel/inprocess/__init__.py
> ipykernel-4.5.2/ipykernel/inprocess/constants.py
> ipykernel-4.5.2/ipykernel/inprocess/tests/__init__.py
> ipykernel-4.5.2/ipykernel/pylab/__init__.py
> ipykernel-4.5.2/ipykernel/tests/test_pickleutil.py
> ipykernel-4.5.2/ipykernel/tests/test_start_kernel.py
> 
> ipykernel-4.5.2/docs/conf.py
> ipykernel-4.5.2/examples/embedding/inprocess_qtconsole.py
> ipykernel-4.5.2/examples/embedding/inprocess_terminal.py
> ipykernel-4.5.2/examples/embedding/internal_ipkernel.py
> ipykernel-4.5.2/examples/embedding/ipkernel_qtapp.py
> ipykernel-4.5.2/examples/embedding/ipkernel_wxapp.py
> 
> Please, ask to upstream to confirm the licensing of code and/or content/s,
> and add license headers
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/
> LicensingGuidelines#License_Clarification

Most of the code use this license header:
# Copyright (c) IPython Development Team.
# Distributed under the terms of the Modified BSD License.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958

gil cattaneo  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org