[Bug 915791] Review Request: perl-MogileFS-Server - Server part of the MogileFS distributed file system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=915791

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-MogileFS-Server-2.72-1
   ||.fc27
 Resolution|--- |RAWHIDE
Last Closed|2014-05-26 06:00:29 |2017-04-28 01:54:45



--- Comment #23 from Petr Pisar  ---
Thank you for the review and the repository. I added the version constraint.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1446459] Review Request: nodejs-corser - CORS middleware for Node.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1446459



--- Comment #1 from Parag Nemade  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=19262728

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1446459] New: Review Request: nodejs-corser - CORS middleware for Node.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1446459

Bug ID: 1446459
   Summary: Review Request: nodejs-corser - CORS middleware for
Node.js
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pnem...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-corser.spec
SRPM URL:
http://pnemade.fedorapeople.org/fedora-work/nodejs-corser-2.0.1-1.fc26.src.rpm

Description:
A highly configurable, middleware compatible implementation of CORS for Node.js

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445719] Review Request: perl-Net-LibIDN2 - Perl binding for GNU Libidn2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445719

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Net-LibIDN2-0.03-1.fc2
   ||7
 Resolution|--- |RAWHIDE
Last Closed||2017-04-28 01:47:58



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445822] Review Request: python-nose_fixes - Plugin to make nose behave better

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445822



--- Comment #8 from Fedora Update System  ---
python-nose_fixes-1.3-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-502374f79d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440406] Review Request: thermald - Thermal Management daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440406



--- Comment #19 from Fedora Update System  ---
thermald-1.6-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445822] Review Request: python-nose_fixes - Plugin to make nose behave better

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445822



--- Comment #7 from Fedora Update System  ---
python-nose_fixes-1.3-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9673db0113

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
python-testfixtures-4.13.5-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3e52596821

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442469] Review Request: php-psr-simple-cache - Common interfaces for simple caching (PSR-16)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442469



--- Comment #4 from Shawn Iwinski  ---
THANKS for the review.  Pkg request submitted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442470] Review Request: php-cache-tag-interop - Framework interoperable interfaces for tags

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442470



--- Comment #4 from Shawn Iwinski  ---
THANKS for the review.  Pkg request submitted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445822] Review Request: python-nose_fixes - Plugin to make nose behave better

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445822



--- Comment #6 from Fedora Update System  ---
python-nose_fixes-1.3-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-cba9e74b7b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445822] Review Request: python-nose_fixes - Plugin to make nose behave better

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445822

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
python-nose_fixes-1.3-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-44df7bb4ab

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444093] Review Request: python-pymoc - Multi-Order Coverage map module for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444093

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-27 16:53:47



--- Comment #8 from Fedora Update System  ---
python-pymoc-0.4.2-1.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441729] Review Request: lizardfs - Distributed, fault tolerant file system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441729

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-27 16:53:03



--- Comment #17 from Fedora Update System  ---
lizardfs-3.10.6-5.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-27 16:53:07



--- Comment #14 from Fedora Update System  ---
guile22-2.2.1-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #93 from Fedora Update System  ---
gsequencer-0.7.135-1.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #92 from Fedora Update System  ---
gsequencer-0.7.135-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419366] Review Request: pybind11 - Seamless operability between C++11 and Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419366



--- Comment #25 from Fedora Update System  ---
psi4-1.0-2.2118f2fgit.fc24, pybind11-2.0.1-5.fc24 has been pushed to the Fedora
24 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-04-18 15:59:37 |2017-04-27 15:52:45



--- Comment #91 from Fedora Update System  ---
gsequencer-0.7.135-1.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444666] Review Request: python-XStatic-Patternfly - Patternfly CSS/ JS framework (XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444666



--- Comment #7 from Fedora Update System  ---
python-XStatic-Patternfly-3.21.0.1-1.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-30ae2db6ea

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444666] Review Request: python-XStatic-Patternfly - Patternfly CSS/ JS framework (XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444666



--- Comment #6 from Fedora Update System  ---
python-XStatic-Patternfly-3.21.0.1-1.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9ad6eaf8d5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444666] Review Request: python-XStatic-Patternfly - Patternfly CSS/ JS framework (XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444666



--- Comment #5 from Fedora Update System  ---
python-XStatic-Patternfly-3.21.0.1-1.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-58f639c765

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444666] Review Request: python-XStatic-Patternfly - Patternfly CSS/ JS framework (XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444666



--- Comment #4 from Fedora Update System  ---
python-XStatic-Patternfly-3.21.0.1-1.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ad1f7077ac

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444666] Review Request: python-XStatic-Patternfly - Patternfly CSS/ JS framework (XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444666

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444682] Review Request: python-XStatic-DataTables - DataTables jquery javascript framework ( XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444682



--- Comment #6 from Fedora Update System  ---
python-XStatic-DataTables-1.10.15.1-1.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-f038c836a5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444682] Review Request: python-XStatic-DataTables - DataTables jquery javascript framework ( XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444682



--- Comment #5 from Fedora Update System  ---
python-XStatic-DataTables-1.10.15.1-1.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f5c5a12935

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444682] Review Request: python-XStatic-DataTables - DataTables jquery javascript framework ( XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444682



--- Comment #4 from Fedora Update System  ---
python-XStatic-DataTables-1.10.15.1-1.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-df8b0ad77c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444682] Review Request: python-XStatic-DataTables - DataTables jquery javascript framework ( XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444682



--- Comment #3 from Fedora Update System  ---
python-XStatic-DataTables-1.10.15.1-1.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d01a9438f8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444682] Review Request: python-XStatic-DataTables - DataTables jquery javascript framework ( XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444682

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321

Oliver Gutiérrez  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



--- Comment #3 from Oliver Gutiérrez  ---
Spec URL:
https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00543607-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-1.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445412] Review Request: python-fpylll - A Python wrapper for fplll

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445412



--- Comment #1 from Paulo Andrade  ---
Spec URL: https://pcpa.fedorapeople.org/python-fpylll.spec
SRPM URL: https://pcpa.fedorapeople.org/python-fpylll-0.2.3dev-2.fc27.src.rpm

  Update to a very higher quality initial package (based on
python-cysignals review), and to match dependencies in the
current state of the python-cysignals review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431740] Review Request: golang-github-cznic-internal - Shared dependencies for other cznic Go libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431740



--- Comment #1 from Fabio Valentini  ---
koji scratch build for rawhide, now all dependencies are available:
https://koji.fedoraproject.org/koji/taskinfo?taskID=19239126

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435914] Review Request: python-uranium - A Python framework for building desktop applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435914



--- Comment #4 from Martin Kolman  ---
Just a couple of issues:
- the docs should probably go to a separate package as they are rather big
- the locale folder ownership should be fixed
- might be good to use parallel make flags (well, not that it would matter
much...)
- there are some RPMLint issue, but they are probably related to the local
folder issue above or false positives (zero length file)



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 7024640 bytes in 829 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "AGPL (v3)", "Unknown or generated". 374 files
 have unknown license. Detailed output of licensecheck in
 /home/mkolman/devel/misc/review/1435914-python-
 uranium/licensecheck.txt
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/locale/ptbr,
 /usr/share/locale/ptbr/LC_MESSAGES
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/locale/ptbr,
 /usr/lib/python3.6/site-packages, /usr/lib/python3.6,
 /usr/share/locale/ptbr/LC_MESSAGES
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as 

[Bug 1444157] Review Request: purple-discord - discord plugin for libpurple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444157



--- Comment #6 from Fedora Update System  ---
purple-discord-0-3.20170427gitd879f18.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2ed250cd9e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444157] Review Request: purple-discord - discord plugin for libpurple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444157



--- Comment #5 from Fedora Update System  ---
purple-discord-0-3.20170427gitd879f18.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4d10266b91

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444157] Review Request: purple-discord - discord plugin for libpurple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444157



--- Comment #4 from Fedora Update System  ---
purple-discord-0-3.20170427gitd879f18.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-dfe1382766

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444157] Review Request: purple-discord - discord plugin for libpurple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444157

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444157] Review Request: purple-discord - discord plugin for libpurple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444157



--- Comment #3 from Fedora Update System  ---
purple-discord-0-3.20170427gitd879f18.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7bb80277c6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427634] Review Request: syncthing - Continuous File Synchronization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427634
Bug 1427634 depends on bug 1437403, which changed state.

Bug 1437403 Summary: Review Request: golang-github-xtaci-smux - Simple Stream 
Multiplexing for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1437403

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437403] Review Request: golang-github-xtaci-smux - Simple Stream Multiplexing for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437403

Fabio Valentini  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-04-27 11:01:43



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437403] Review Request: golang-github-xtaci-smux - Simple Stream Multiplexing for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437403



--- Comment #6 from Fedora Update System  ---
golang-github-xtaci-smux-1.0.5-1.20170422.git2de5471.fc24 has been submitted as
an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-440c271a62

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437403] Review Request: golang-github-xtaci-smux - Simple Stream Multiplexing for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437403



--- Comment #5 from Fedora Update System  ---
golang-github-xtaci-smux-1.0.5-1.20170422.git2de5471.fc25 has been submitted as
an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d0b6264962

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437403] Review Request: golang-github-xtaci-smux - Simple Stream Multiplexing for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437403



--- Comment #4 from Fedora Update System  ---
golang-github-xtaci-smux-1.0.5-1.20170422.git2de5471.fc26 has been submitted as
an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-33bed24e51

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437403] Review Request: golang-github-xtaci-smux - Simple Stream Multiplexing for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437403

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431740] Review Request: golang-github-cznic-internal - Shared dependencies for other cznic Go libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431740
Bug 1431740 depends on bug 1431568, which changed state.

Bug 1431568 Summary: Review Request: golang-github-edsrzf-mmap-go - Portable 
mmap package for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1431568

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431568] Review Request: golang-github-edsrzf-mmap-go - Portable mmap package for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431568

Fabio Valentini  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed|2017-03-14 06:58:53 |2017-04-27 10:57:13



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444618] Review Request: buildah - A command line tool to facilitate working with containers and using them to build images.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444618



--- Comment #6 from Lokesh Mandvekar  ---
C/C++:
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.



Generic:
[-]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/bash-completion,
 /usr/share/bash-completion/completions

Dan, could you add /usr/share/bash-completion to %files?


[ ]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/.build-id(nss-pem,
 libuser, vim-common, oci-systemd-hook, python3-hawkey, dhcp-libs,
 openssh-clients, iproute, nss-tools, gc, libgpg-error,
 policycoreutils-python-utils, gdbm, gpgme, python3-cryptography, rpm-
 plugin-selinux, libsolv, gdb-headless, krb5-workstation, perl-libs,
 gmp, policycoreutils, python3-gpg, iproute-tc, kpartx, libselinux-
 python3, gnutls, pcre2, python3, cyrus-sasl-lib, hardlink, nspr, rpm-
 build, dbus, fuse-libs, polkit-libs, krb5-libs, runc, rpm-build-libs,
 libnghttp2, device-mapper-persistent-data, pkgconf, shared-mime-info,
 rpm-plugin-systemd-inhibit, pcre-cpp, rhash, audit-libs, nss-sysinit,
 libgcc, libxslt, cryptsetup-libs, perl-threads-shared, gettext-libs,
 libpkgconf, golang-github-cpuguy83-go-md2man, keyutils-libs, perl-
 Encode, python2-cryptography, sqlite-libs, btrfs-progs, system-python,
 bind99-libs, dbus-libs, nss-softokn, audit-libs-python3, GeoIP, git,
 bash, vim-enhanced, polkit, openssh, libselinux-utils, libkadm5, perl-
 Unicode-UTF8, python2-rpm, docker-v1.10-migrator, system-python-libs,
 glib2, binutils, rkt, docker-rhel-push-plugin, libstdc++, file-libs,
 gnupg2-smime, gettext-devel, nss, rpm, pcre, vim-minimal, syslinux,
 gnupg2, perl-IO, gpgme-devel, dracut, git-core, python3-cffi,
 libcroco, python3-psutil, openssh-server, ocid, libdnf, perl-version,
 drpm, info, glib2-devel, pcre-utf16, nss-util, libsemanage,
 libselinux, libtomcrypt, docker-unit-test, sqlite, sudo, golang, dhcp-
 client, file, curl, libarchive, gcc, chkconfig, cmake, libcurl,
 libsemanage-python3, gettext, coreutils, pam, nss-softokn-freebl,
 libgomp, python2-cffi, libidn2, openldap, perl-Net-SSLeay, libtool-
 ltdl, audit, rpm-libs, pcre-utf32, chrony, python3-rpm, docker),
 /usr/lib/.build-id/73(coreutils, gettext)

- Not quite sure why the /usr/lib/.build-id gets generated. rpmbuild doesn't
complain but fedora-review gives me this:

$ cat files.dir 
buildah
===
/usr/lib/.build-id
/usr/lib/.build-id/73
/usr/share/doc/buildah
/usr/share/licenses/buildah

/usr/bin/buildah
/usr/lib/.build-id/73/4dd08b2524e8a7c20ef92dce19dee0e93bccc8
/usr/share/bash-completion/completions/buildah
/usr/share/doc/buildah/README.md
/usr/share/licenses/buildah/LICENSE
/usr/share/man/man1/buildah-add.1.gz
/usr/share/man/man1/buildah-bud.1.gz
/usr/share/man/man1/buildah-commit.1.gz
/usr/share/man/man1/buildah-config.1.gz
/usr/share/man/man1/buildah-containers.1.gz
/usr/share/man/man1/buildah-copy.1.gz
/usr/share/man/man1/buildah-from.1.gz
/usr/share/man/man1/buildah-images.1.gz
/usr/share/man/man1/buildah-mount.1.gz
/usr/share/man/man1/buildah-rm.1.gz
/usr/share/man/man1/buildah-rmi.1.gz
/usr/share/man/man1/buildah-run.1.gz
/usr/share/man/man1/buildah-umount.1.gz
/usr/share/man/man1/buildah.1.gz


[x]: Package contains no bundled libraries without FPC exception.

- github.com/docker/docker is vendored so it's ok to build this with bundled
libraries.


[-]: Development files must be in a -devel package


[!]: Useful -debuginfo package or justification otherwise.

with_debug on line 3 should be set to 1 and rebuilt so we can have a debuginfo
package, unless we need to skip debuginfo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431568] Review Request: golang-github-edsrzf-mmap-go - Portable mmap package for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431568



--- Comment #10 from Fedora Update System  ---
golang-github-edsrzf-mmap-go-0-0.1.20170318.git0bce6a6.fc24 has been submitted
as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6ceb4e060c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431568] Review Request: golang-github-edsrzf-mmap-go - Portable mmap package for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431568



--- Comment #9 from Fedora Update System  ---
golang-github-edsrzf-mmap-go-0-0.1.20170318.git0bce6a6.fc25 has been submitted
as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-72ec07bb4a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431568] Review Request: golang-github-edsrzf-mmap-go - Portable mmap package for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431568

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431568] Review Request: golang-github-edsrzf-mmap-go - Portable mmap package for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431568



--- Comment #8 from Fedora Update System  ---
golang-github-edsrzf-mmap-go-0-0.1.20170318.git0bce6a6.fc26 has been submitted
as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0aede52b82

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441588] Review Request: copr-builder - build package from copr dist-git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441588



--- Comment #3 from Pavel Raiskup  ---
Spec URL:
https://pagure.io/copr/copr/raw/bf1d7b1f3c61b5f2ca6573d8f4bb09b8478fc32f/f/builder/copr-builder.spec
SRPM URL: http://praiskup.fedorapeople.org/copr-builder-0-13.fc25.src.rpm

Thanks for the review.

(In reply to Miroslav Suchý from comment #2)
> You are using /var/lib/copr-builder/{pid,results,live-log}. You should
> own that directories.  And lock file as %ghost.

This is the only thing I'm not sure about, the ownership of the files is
not defined "in advance" (basically any user can create files under
/var/lib/copr-builder, if in 'mock' group); so I had to use %verify
macro && and thus %ghost doesn't give us a lot of added value.  Also, other
files under /var/lib/copr-builder are automatically created, without
pre-defined filenames.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444666] Review Request: python-XStatic-Patternfly - Patternfly CSS/ JS framework (XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444666



--- Comment #3 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-XStatic-Patternfly

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444682] Review Request: python-XStatic-DataTables - DataTables jquery javascript framework ( XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444682



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-XStatic-DataTables

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444666] Review Request: python-XStatic-Patternfly - Patternfly CSS/ JS framework (XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444666

Haïkel Guémar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444666] Review Request: python-XStatic-Patternfly - Patternfly CSS/ JS framework (XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444666

Haïkel Guémar  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



--- Comment #2 from Haïkel Guémar  ---
I hereby approve this package. Please proceed with pkgdb request.
It does bundle Google OpenSans (ASL 2.0) fonts but webfonts are not packaged in
open-sans-fonts package.
I suggest to see if it's fixable.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated". 285 files have unknown
 license. Detailed output of licensecheck in /home/haikel/1444666
 -python-XStatic-Patternfly/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python3.6/site-packages/xstatic/pkg,
 /usr/lib/python3.6/site-packages/xstatic
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.6/site-
 packages, /usr/lib/python3.6/site-packages/xstatic,
 /usr/lib/python3.6, /usr/lib/python3.6/site-packages/xstatic/pkg
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.

[Bug 1444618] Review Request: buildah - A command line tool to facilitate working with containers and using them to build images.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444618



--- Comment #5 from Lokesh Mandvekar  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated", "MIT/X11 (BSD like)",
 "MIT/X11 (BSD like) BSD (3 clause)", "*No copyright* MPL (v2.0)", "BSD
 (3 clause)", "BSD (2 clause)", "*No copyright* Apache (v2.0)". 1261
 files have unknown license. Detailed output of licensecheck in
 /home/lsm5/repositories/pkgs/reviews/1444618-buildah/licensecheck.txt
[ ]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/bash-completion,
 /usr/share/bash-completion/completions
[ ]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/.build-id(nss-pem,
 libuser, vim-common, oci-systemd-hook, python3-hawkey, dhcp-libs,
 openssh-clients, iproute, nss-tools, gc, libgpg-error,
 policycoreutils-python-utils, gdbm, gpgme, python3-cryptography, rpm-
 plugin-selinux, libsolv, gdb-headless, krb5-workstation, perl-libs,
 gmp, policycoreutils, python3-gpg, iproute-tc, kpartx, libselinux-
 python3, gnutls, pcre2, python3, cyrus-sasl-lib, hardlink, nspr, rpm-
 build, dbus, fuse-libs, polkit-libs, krb5-libs, runc, rpm-build-libs,
 libnghttp2, device-mapper-persistent-data, pkgconf, shared-mime-info,
 rpm-plugin-systemd-inhibit, pcre-cpp, rhash, audit-libs, nss-sysinit,
 libgcc, libxslt, cryptsetup-libs, perl-threads-shared, gettext-libs,
 libpkgconf, golang-github-cpuguy83-go-md2man, keyutils-libs, perl-
 Encode, python2-cryptography, sqlite-libs, btrfs-progs, system-python,
 bind99-libs, dbus-libs, nss-softokn, audit-libs-python3, GeoIP, git,
 bash, vim-enhanced, polkit, openssh, libselinux-utils, libkadm5, perl-
 Unicode-UTF8, python2-rpm, docker-v1.10-migrator, system-python-libs,
 glib2, binutils, rkt, docker-rhel-push-plugin, libstdc++, file-libs,
 gnupg2-smime, gettext-devel, nss, rpm, pcre, vim-minimal, syslinux,
 gnupg2, perl-IO, gpgme-devel, dracut, git-core, python3-cffi,
 libcroco, python3-psutil, openssh-server, ocid, libdnf, perl-version,
 drpm, info, glib2-devel, pcre-utf16, nss-util, libsemanage,
 libselinux, libtomcrypt, docker-unit-test, sqlite, sudo, golang, dhcp-
 client, file, curl, libarchive, gcc, chkconfig, cmake, libcurl,
 libsemanage-python3, gettext, coreutils, pam, nss-softokn-freebl,
 libgomp, python2-cffi, libidn2, openldap, perl-Net-SSLeay, libtool-
 ltdl, audit, rpm-libs, pcre-utf32, chrony, python3-rpm, docker),
 /usr/lib/.build-id/73(coreutils, gettext)
[x]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the 

[Bug 1445887] Review Request: standard-test-roles - Standard Test Interface Ansible roles

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445887



--- Comment #1 from Merlin Mathesius  ---
Thank you for accepting the review of this package.

Please note that I am aware that /etc (specifically, /etc/ansible/roles) is not
the ideal location to deliver the shared Ansible roles, but that is where
Ansible can currently find them. This package will be updated to change the
delivery location to /usr/share/ansible/roles after Ansible PR
https://github.com/ansible/ansible/pull/23038 becomes available in Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444666] Review Request: python-XStatic-Patternfly - Patternfly CSS/ JS framework (XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444666

Haïkel Guémar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|karlthe...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444682] Review Request: python-XStatic-DataTables - DataTables jquery javascript framework ( XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444682

Haïkel Guémar  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Haïkel Guémar  ---
I hereby approve this package as it complies with Fedora Packaging guidelines.
Please proceed with a pkgdb request.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 55 files have unknown license. Detailed
 output of licensecheck in /home/haikel/1444682-python-XStatic-
 DataTables/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python3.6/site-packages/xstatic,
 /usr/lib/python3.6/site-packages/xstatic/pkg
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.6/site-
 packages, /usr/lib/python3.6/site-packages/xstatic,
 /usr/lib/python3.6, /usr/lib/python3.6/site-packages/xstatic/pkg
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[=]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: 

[Bug 1444618] Review Request: buildah - A command line tool to facilitate working with containers and using them to build images.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444618



--- Comment #4 from Daniel Walsh  ---
Fixed and Updated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441588] Review Request: copr-builder - build package from copr dist-git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441588

Pavel Raiskup  changed:

   What|Removed |Added

 Depends On||1400592




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1400592
[Bug 1400592] Rename subpackage pyrpkg to python2-rpkg
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441588] Review Request: copr-builder - build package from copr dist-git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441588
Bug 1441588 depends on bug 1400592, which changed state.

Bug 1400592 Summary: Rename subpackage pyrpkg to python2-rpkg
https://bugzilla.redhat.com/show_bug.cgi?id=1400592

   What|Removed |Added

 Status|CLOSED  |NEW
 Resolution|ERRATA  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421183] Review Request: ntetris - simple cli tetris game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421183



--- Comment #17 from jiri vanek  ---
(In reply to Tom "spot" Callaway from comment #16)
> No. That has the exact same issue as the original name. You're relying on
> the confusion caused by the "etris" relationship plus the game design, and
> that's textbook infringement.
> 
> Pick a name that is unique, please.

Thanx. I was afraid you will reply like this.

So Michal, you really are doomed to MyTerribleCmdBricksWithDisapearingRows ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824



--- Comment #5 from Fedora Update System  ---
python-testfixtures-4.13.5-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3e52596821

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444925] Review Request: python-rpm-generators - The RPM python dependency generators

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444925



--- Comment #6 from Petr Šabata  ---
(In reply to Neal Gompa from comment #5)
> (In reply to Petr Šabata from comment #4)
> > (In reply to Neal Gompa from comment #3)
> > > For what it's worth, this is an awful idea, but since the Modularity guys
> > > clearly can't separate base runtime from build root, I guess we're faking
> > > multibuild packages now...
> > > 
> > > If you're going to do this instead of doing it the right way, you might as
> > > well add "Supplements: (python3-devel and rpm-build and 
> > > redhat-rpm-config)"
> > > so that people don't have to notice you did a bad thing and made this.
> > 
> > I might be missing quite a lot here.  Your comment was fairly vague.
> > 
> > Faking multibuild packages?  What do you mean by that?
> > 
> 
> multibuild is a concept that SUSE has with their OBS where you can have
> multiple spec files associated with a single set of sources, which build
> multiple source and binary packages[1]. Combined with source services, it's
> not completely terrible, though it can make it harder to build outside of
> OBS, depending on how it's done. This is a poor man's version of that, but
> it's too decoupled to be useful, since they must be manually updated
> independently, but in lockstep with each other.
> 
> [1]:
> http://openbuildservice.org/help/manuals/obs-reference-guide/cha.obs.
> multibuild.html

Associating sources with packages is done via the sources files in dist-git;
multiple packages and branches can use the same sources.  I'm not familiar with
SUSE so perhaps I'm misunderstanding; I'll read the link.  Thanks.

> > What's wrong about separating language-specific dependency generators from a
> > generic package build tool?  What's the right away in your book?  Or are you
> > commenting on the transitive hard dependency on the generators, which is
> > different from how it was done with Perl, for example?
> > 
> 
> This particular dependency generator is part of RPM itself, and I as the
> upstream developer of it, prefer it to be maintained with RPM.
> 
> Additionally, The *only* reason this is being separated is because the
> modularity guys want base runtime = buildroot, which is a completely wrong
> characterization to begin with. They freaked out because python3-setuptools
> is a requirement for the new dependency generator, because otherwise there's
> no way to reliably parse the Python metadata.
> 
> I don't even agree with how we handled Perl, either. Perl dependency
> generators are still part of RPM, just like my Python one, and splitting
> them like this just promotes people monkey-patching and not upstreaming
> fixes.

Ah, a clash of opinions :) I believe such generators should be maintained
separately, in both downstream and upstream.  I supported the Perl change and I
welcome this one as well.

I happen to be one of "the modularity guys" and while I definitely dislike the
Python generators currently being part of rpm-build and depending on the full
Python installation and yes, it was what, at least partially, ignited a brief
discussion about this change, it's not the only reason here.  I dare to say the
reason is that some people actually think it's a Good Thing going forward. 
Again, I do, for instance.

> > While a reverse soft dependency wouldn't hurt anything, why would you want
> > it?
> 
> Because then when normal humans want to build Python packages, they don't
> have to care that this split happened. We probably have to edit all the
> Fedora packages anyway, because weak deps are disabled in mock builds.
> Either that, or python3-devel gains a Requires on python3-rpm-generators,
> which would allow us to not have to mass edit the spec files. I'd probably
> go for the latter, personally, because then it's a "nothing changes"
> scenario everywhere.

I see.

Yes, there are two main ways to do this.  One is to add the generators build
dependency to every Python package (or more precisely, every Python package
whose maintainer wishes to use this feature), which I think is more flexible
and is what was done for Perl but would be a massive undertaking.  Another is
to add that dependency to python*-devel which is what the Python team plans to
do, from what I heard.  So it should be relatively painless.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445411] Review Request: python-cysignals - Interrupt and signal handling for Cython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445411



--- Comment #6 from Paulo Andrade  ---
Spec URL: https://pcpa.fedorapeople.org/python-cysignals.spec
SRPM URL: https://pcpa.fedorapeople.org/python-cysignals-1.3.2-2.fc27.src.rpm

  Changed to install .h, .pxi and .pxd files in a -devel package.
This should require changes to the spec of python-fpylll review
request, I will confirm.

  Sorry for the cut and not properly noticing the spaces only
in some BuildRequires. Fixed now.

  The Popen calls are on doctests of .pyx files. For safety I changed
the files before every build; no changes in %install because it
pass --skip-build in eval of %py{2,3}_install.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445822] Review Request: python-nose_fixes - Plugin to make nose behave better

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445822



--- Comment #4 from Fedora Update System  ---
python-nose_fixes-1.3-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9673db0113

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445822] Review Request: python-nose_fixes - Plugin to make nose behave better

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445822

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 915791] Review Request: perl-MogileFS-Server - Server part of the MogileFS distributed file system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=915791



--- Comment #22 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-MogileFS-Server

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445719] Review Request: perl-Net-LibIDN2 - Perl binding for GNU Libidn2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445719



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Net-LibIDN2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437403] Review Request: golang-github-xtaci-smux - Simple Stream Multiplexing for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437403



--- Comment #3 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-xtaci-smux

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431568] Review Request: golang-github-edsrzf-mmap-go - Portable mmap package for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431568



--- Comment #7 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-edsrzf-mmap-go

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824



--- Comment #4 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-testfixtures

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445822] Review Request: python-nose_fixes - Plugin to make nose behave better

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445822



--- Comment #3 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-nose_fixes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444157] Review Request: purple-discord - discord plugin for libpurple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444157



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/purple-discord

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421183] Review Request: ntetris - simple cli tetris game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421183



--- Comment #16 from Tom "spot" Callaway  ---
No. That has the exact same issue as the original name. You're relying on the
confusion caused by the "etris" relationship plus the game design, and that's
textbook infringement.

Pick a name that is unique, please.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421183] Review Request: ntetris - simple cli tetris game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421183



--- Comment #15 from jiri vanek  ---
+1 from me!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421183] Review Request: ntetris - simple cli tetris game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421183



--- Comment #14 from Michal Vala  ---
Thinking about new name. Is "retris" ok?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444925] Review Request: python-rpm-generators - The RPM python dependency generators

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444925



--- Comment #5 from Neal Gompa  ---
(In reply to Petr Šabata from comment #4)
> (In reply to Neal Gompa from comment #3)
> > For what it's worth, this is an awful idea, but since the Modularity guys
> > clearly can't separate base runtime from build root, I guess we're faking
> > multibuild packages now...
> > 
> > If you're going to do this instead of doing it the right way, you might as
> > well add "Supplements: (python3-devel and rpm-build and redhat-rpm-config)"
> > so that people don't have to notice you did a bad thing and made this.
> 
> I might be missing quite a lot here.  Your comment was fairly vague.
> 
> Faking multibuild packages?  What do you mean by that?
> 

multibuild is a concept that SUSE has with their OBS where you can have
multiple spec files associated with a single set of sources, which build
multiple source and binary packages[1]. Combined with source services, it's not
completely terrible, though it can make it harder to build outside of OBS,
depending on how it's done. This is a poor man's version of that, but it's too
decoupled to be useful, since they must be manually updated independently, but
in lockstep with each other.

[1]:
http://openbuildservice.org/help/manuals/obs-reference-guide/cha.obs.multibuild.html

> What's wrong about separating language-specific dependency generators from a
> generic package build tool?  What's the right away in your book?  Or are you
> commenting on the transitive hard dependency on the generators, which is
> different from how it was done with Perl, for example?
> 

This particular dependency generator is part of RPM itself, and I as the
upstream developer of it, prefer it to be maintained with RPM.

Additionally, The *only* reason this is being separated is because the
modularity guys want base runtime = buildroot, which is a completely wrong
characterization to begin with. They freaked out because python3-setuptools is
a requirement for the new dependency generator, because otherwise there's no
way to reliably parse the Python metadata.

I don't even agree with how we handled Perl, either. Perl dependency generators
are still part of RPM, just like my Python one, and splitting them like this
just promotes people monkey-patching and not upstreaming fixes.

> While a reverse soft dependency wouldn't hurt anything, why would you want
> it?

Because then when normal humans want to build Python packages, they don't have
to care that this split happened. We probably have to edit all the Fedora
packages anyway, because weak deps are disabled in mock builds. Either that, or
python3-devel gains a Requires on python3-rpm-generators, which would allow us
to not have to mass edit the spec files. I'd probably go for the latter,
personally, because then it's a "nothing changes" scenario everywhere.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445887] Review Request: standard-test-roles - Standard Test Interface Ansible roles

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445887

Petr Šabata  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||psab...@redhat.com
   Assignee|nob...@fedoraproject.org|psab...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 915791] Review Request: perl-MogileFS-Server - Server part of the MogileFS distributed file system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=915791

Petr Šabata  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #21 from Petr Šabata  ---
(In reply to Petr Pisar from comment #19)
> (In reply to Petr Šabata from comment #18)
> > * Several of the listed build dependencies don't appear to be used at build
> >   time, including:
> >   - perl(DBD::SQLite)
> This is used when running t/store-sqlite.t.

Ok, I thought you weren't running the test, probably due to the comment
in %check.

> >   - perl(Fcntl)
> Removed.
> 
> >   - perl(Perlbal)
> Removed.
> 
> >   - perl(Perlbal::Socket)
> Removed.
> 
> >   - perl(Perlbal::TCPListener)
> Removed.
> 
> >   - net-tools
> Removed.

Ack.

> > * You could use the NO_PACKLIST feature.
> >
> Done.

You should also update the EE::MM dependency to require >= 6.76, which is
the version which introduced this feature.

> > * mogstored is missing some runtime dependencies, namely:
> >   - perl(Mogstored::ChildProcess::DiskUsage)
> Added.
> 
> >   - perl(Mogstored::ChildProcess::IOStat)
> Added.
> 
> >   - perl(Pod::Usage)
> Added.

Ack.

> > * Does it make sense to have the None backend in a separate subpackage?
> > 
> For the symmetry.

Ok.

> > * To me, "Same terms as Perl itself.  Artistic/GPLv2, at your choosing"
> >   doesn't read as "(GPL+ or Artistic) and (GPLv2 or Artistic)" but more like
> >   "GPL+ or GPLv2 or Artistic".
> > 
> I can see your point. My reading of the second sentence is this is an
> explanation (a wrong one) of the first sentence.
> 
> Your reading can be simplified to "GPL+ or Artistic".
> My reading can be simplified to "GPLv2 or Artistic".
> 
> I will use stricter "GPLv2 or Artistic" that conform to both readings and I
> will try to ask the author.

Clarified with the next update.

> Spec URL:
> https://ppisar.fedorapeople.org/perl-MogileFS-Server/perl-MogileFS-Server.
> spec
> SRPM URL:
> https://ppisar.fedorapeople.org/perl-MogileFS-Server/perl-MogileFS-Server-2.
> 72-1.fc27.src.rpm

No blockers here.  Approving.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444925] Review Request: python-rpm-generators - The RPM python dependency generators

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444925



--- Comment #4 from Petr Šabata  ---
(In reply to Neal Gompa from comment #3)
> For what it's worth, this is an awful idea, but since the Modularity guys
> clearly can't separate base runtime from build root, I guess we're faking
> multibuild packages now...
> 
> If you're going to do this instead of doing it the right way, you might as
> well add "Supplements: (python3-devel and rpm-build and redhat-rpm-config)"
> so that people don't have to notice you did a bad thing and made this.

I might be missing quite a lot here.  Your comment was fairly vague.

Faking multibuild packages?  What do you mean by that?

What's wrong about separating language-specific dependency generators from a
generic package build tool?  What's the right away in your book?  Or are you
commenting on the transitive hard dependency on the generators, which is
different from how it was done with Perl, for example?

While a reverse soft dependency wouldn't hurt anything, why would you want it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1295115] Review Request: swift-lang - Swift Programming Language by Apple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295115

Gilles Dubreuil  changed:

   What|Removed |Added

 CC||gdubr...@redhat.com



--- Comment #32 from Gilles Dubreuil  ---
A more recent and also *great* work is available with [1]

Using patch [2], I generated a Swift 3.1 RPM for Fedora 25.
It provides REPL, LLDB, Package and Foundation:

--
$ swift --version
Swift version 3.1 (swift-3.1-RELEASE)
Target: x86_64-unknown-linux-gnu
--

--
$ swift
Welcome to Swift version 3.1 (swift-3.1-RELEASE). Type :help for assistance.
  1> 
--

--
$ lldb --version
lldb version 4.0.0
  Swift-3.1 (revision 6309a8a39f499549676a1ac889f01d04ac823d8f)
--


[1] https://github.com/corinnekrych/swift-rpm
[2] https://github.com/corinnekrych/swift-rpm/pull/6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1408939] Review Request: libreoffice-grammalecte - French grammar corrector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1408939

Remi Collet  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2017-04-27 02:56:35



--- Comment #5 from Remi Collet  ---
Nobody seems interested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442743] Review Request: python-bz2file - Read and write bzip2-compressed files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442743



--- Comment #9 from Fedora Update System  ---
python-bz2file-0.98-2.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9bbadddc13

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1443932] Review Request: switchboard-plug-about - Switchboard System Information plug

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1443932

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
switchboard-plug-about-0.2.2-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b2e4037c9f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441024] Review Request: waiverdb - Companion service to ResultsDB, for recording waivers against test results

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441024



--- Comment #7 from matt jia  ---
Spec URL: https://mjia.fedorapeople.org/waiverdb.spec
SRPM URL: https://mjia.fedorapeople.org/waiverdb-0.1.1-1.fc24.src.rpm
Description: WaiverDB is a companion service to ResultsDB, for recording
waivers against test results.
Fedora Account System Username: mjia

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org