[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421413

Marek Cermak  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421413

Marek Cermak  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #21 from Marek Cermak  ---
(In reply to Frank Crawford from comment #20)
> (In reply to Marek Cermak from comment #19)
> > Thanks Frank, 
> > 
> > If I am not mistaken, you've forgotten to update the changelog to the newest
> > release. Could you correct that, please?
> 
> Whoops, sorry, I've updated the changelog in the spec file and regenerated
> the SRPM.  I haven't updated the version number, so the links in Comment 18
> will get the correct version.

Great, thanks, Frank.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1464225] Review Request: purple-matrix - Matrix plugin for libpurple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1464225



--- Comment #12 from Fedora Update System  ---
purple-matrix-0-3.20170530gitbe53d53.el7 has been pushed to the Fedora EPEL 7
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465291] Review Request: php-myclabs-php-enum - PHP Enum implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465291



--- Comment #13 from Fedora Update System  ---
php-myclabs-php-enum-1.5.2-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465313] Review Request: php-bacon-qr-code - QR code generator for PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465313



--- Comment #15 from Fedora Update System  ---
php-bacon-qr-code-1.0.1-4.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465443] Review Request: php-endroid-qrcode - Endroid QR Code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465443



--- Comment #13 from Fedora Update System  ---
php-endroid-qrcode-1.9.3-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470447] Review Request: php-robrichards-xmlseclibs3 - A PHP library for XML Security (version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470447

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
php-robrichards-xmlseclibs3-3.0.0-1.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-afb5bfeaf1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460917] Review Request: rpkg - Command-line client tool to DistGit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460917



--- Comment #21 from Fedora Update System  ---
rpkg-client-0.6-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-52327d89db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460917] Review Request: rpkg - Command-line client tool to DistGit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460917

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #20 from Fedora Update System  ---
rpkg-client-0.6-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6796b3ccfe

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421413



--- Comment #20 from Frank Crawford  ---
(In reply to Marek Cermak from comment #19)
> Thanks Frank, 
> 
> If I am not mistaken, you've forgotten to update the changelog to the newest
> release. Could you correct that, please?

Whoops, sorry, I've updated the changelog in the spec file and regenerated the
SRPM.  I haven't updated the version number, so the links in Comment 18 will
get the correct version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 494238] Review Request: pyrrd - A Pure Python Wrapper for RRDTool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=494238

Bill Nottingham  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed|2009-04-24 15:55:21 |2017-07-18 22:39:39



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468768] Review Request: domoticz - Open source Home Automation System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468768

Ben Rosser  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Ben Rosser  ---
Great; the package now looks good. APPROVED.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "ISC BSD (2 clause)", "GPL (v2 or later)",
 "Unknown or generated", "*No copyright* EPL (v1.0)", "EPL (v1.0)",
 "MIT/X11 (BSD like)", "BSL (v1.0)", "CC by", "GPL (v3.0 or later)",
 "zlib/libpng", "BSD (3 clause)", "*No copyright* zlib/libpng", "LGPL
 (v3 or later)", "*No copyright* BSL (v1.0)", "BSD (2 clause)", "BSD
 (unspecified)", "GPL (v2) (with incorrect FSF address)", "*No
 copyright* MIT/X11 (BSD like)", "GPL (v3 or later)". 1775 files have
 unknown license. Detailed output of licensecheck in
 /home/bjr/Programming/fedora/reviews/1468768-domoticz/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 92160 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages 

[Bug 1341662] Review Request: fedora-developer-portal - Offline Fedora Developer Portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341662



--- Comment #13 from František Zatloukal  ---
I've updated SPEC with your changes:
https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-26-x86_64/00581156-fedora-developer-portal/fedora-developer-portal.spec


Regarding the URL - upstream never really did a release, so the only option
would be to use master.zip link provided by Github. There is problem that we
wouldn't know shortcommit till archive unzip in %prep (and we need it for
Release: which is above %prep).

I can try to contact repo maintainer to do a "release for us".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468971] Review Request: freshmaker - A service scheduling rebuilds of artifacts as new content becomes available

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468971

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags||fedora-review+



--- Comment #9 from Igor Gnatenko  ---
apart from broken SourceURL and useless systemd requires/buildrequires, I can't
complain about anything ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419330] Review Request: deepin-menu - deepin menu service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419330

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421063] Review Request: deepin-gir-generator - Generate static golang bindings for GObject

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421063

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421048] Review Request: deepin-sound-theme - Deepin sound theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421048

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421066] Review Request: deepin-wm-switcher - Window manager switcher for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421066

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421046] Review Request: deepin-go-lib - Go bindings for DDE development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421046

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419332] Review Request: deepin-shortcut-viewer - deepin shortcut viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419332

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/ Qt Developer work on Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421047

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421044] Review Request: deepin-qml-widgets - Deepin QML widgets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421044

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421051] Review Request: deepin-nautilus-properties - Provide file property dialog for DDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421051

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419317] Review Request: deepin-terminal - terminal emulation application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419317

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421055

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421065

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419317] Review Request: deepin-terminal - terminal emulation application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419317



--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
Errr, Requires: %{name}-data = %{version}-%{release} of course.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421041] Review Request: deepin-gettext-tools - Deepin Gettext Tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421041

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
 Blocks|177841 (FE-NEEDSPONSOR) |
  Flags||fedora-review+



--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
So now the requires are:
/usr/bin/perl
/usr/bin/python3
gettext
perl(Config::Tiny)
perl(Exporter::Tiny)
perl(XML::LibXML)
perl(XML::LibXML::PrettyPrint)
qt5-linguist
Looks good.

> /bin/perl desktop_ts/src/desktop_ts_convert.pl --help
> /bin/python3 src/generate_mo.py --help
> /bin/python3 src/update_pot.py --help

No need to use the full path. We assume that the tools like perl and python3
are in $PATH.

rpmlint:
deepin-gettext-tools.noarch: W: spelling-error %description -l en_US msgid ->
MSG
deepin-gettext-tools.noarch: W: spelling-error %description -l en_US ini ->
uni, in, ii
deepin-gettext-tools.noarch: W: spelling-error %description -l en_US po -> PO,
pew, op
deepin-gettext-tools.src: W: spelling-error %description -l en_US msgid -> MSG
deepin-gettext-tools.src: W: spelling-error %description -l en_US ini -> uni,
in, ii
deepin-gettext-tools.src: W: spelling-error %description -l en_US po -> PO,
pew, op
Bogus warnings.

deepin-gettext-tools.noarch: W: no-manual-page-for-binary
deepin-desktop-ts-convert
deepin-gettext-tools.noarch: W: no-manual-page-for-binary deepin-generate-mo
deepin-gettext-tools.noarch: W: no-manual-page-for-binary
deepin-policy-ts-convert
deepin-gettext-tools.noarch: W: no-manual-page-for-binary deepin-update-pot
That's OK. It's nice to have man pages, but it's certainly not required.

2 packages and 0 specfiles checked; 0 errors, 10 warnings.

+ package name is OK
+ latest version
+ license is acceptable for Fedora (GPLv3)
+ license is specified correctly
+ builds and installs OOK
+ Provides/Requires/BuildRequires appear correct
+ no scriptlets are needed
+ %check is present and passes.

Package is APPROVED.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419317] Review Request: deepin-terminal - terminal emulation application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419317

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
For reviewer convenience, whenever you make another version of package under
review, please add the "Spec:" and "SRPM:" lines again, so it's easy to go to
the latest sources.

rpmlint:
> deepin-terminal.src: W: invalid-license GPL3
The list of allowed license is at
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Software_License_List.
In this case, it should be "GPLv3".

> deepin-terminal.x86_64: E: incorrect-locale-subdir 
> /usr/share/locale/es_419/LC_MESSAGES/deepin-terminal.mo
> deepin-terminal.x86_64: E: invalid-lc-messages-dir 
> /usr/share/locale/es_419/LC_MESSAGES/deepin-terminal.mo
It's probably harmless, but indeed seems strange.

> deepin-terminal.x86_64: E: invalid-desktopfile 
> /usr/share/applications/deepin-terminal.desktop file contains group 
> "NewWindow Shortcut Group", but groups extending the format should start with 
> "X-"
> deepin-terminal.x86_64: E: invalid-desktopfile 
> /usr/share/applications/deepin-terminal.desktop file contains group "Quake 
> Shortcut Group", but groups extending the format should start with "X-"

Is this a Deepin thing? If so, you can ignore this warning.

> 3 packages and 0 specfiles checked; 5 errors, 8 warnings.
There's a bunch of other warnings, but I think they are all harmless.

It looks almost OK. We can revisit the appdata question later.

The package has a ~600kB binary, and ~5MB of data. Please split out the data
into a noarch subpackage. Everything under /usr/share can go that that
subpackage. And then the main package should have Requires = %{name}-data =
%{version}-%{release}.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421041] Review Request: deepin-gettext-tools - Deepin Gettext Tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421041

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Depends On||1469951




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1469951
[Bug 1469951] Review Request: perl-XML-LibXML-PrettyPrint - Add pleasant
white space to an XML tree
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469951] Review Request: perl-XML-LibXML-PrettyPrint - Add pleasant white space to an XML tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469951

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl
 Blocks||1421041



--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
Any chance you could build this for F26 too? It'll simplify testing of the
Deepin packages.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1421041
[Bug 1421041] Review Request: deepin-gettext-tools - Deepin Gettext Tools
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468768] Review Request: domoticz - Open source Home Automation System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468768



--- Comment #6 from Michael Cronenworth  ---
(In reply to Ben Rosser from comment #2)
> Apologies for not getting to this sooner.

No problem at all. Thanks for looking!

> * rpmlint complains that you are shipping a PEM certificate. However looking
> at the domoticz documentation, it explicitly references that domoticz will
> use this cert if a separate one is not provided, so this is probably fine.

Yes, the cert is just shipped by the source tarball and it is up to the user to
create their own and place it in /var/lib/domoticz, which is what the systemd
unit file expects.

> * As per
> https://fedoraproject.org/wiki/Packaging:UsersAndGroups?rd=Packaging/
> UsersAndGroups#Dynamic_allocation, please add "Requires(pre): shadow-utils"
> since this package creates a user and a group.

Fixed.

> They look compiled to me. :) I would include the BRs just to be safe.

That's rpmbuild helping too much. I'll include it anyway.

> * fedora-review also complains about the perl scripts, but I think this one
> is safe to ignore, assuming the Perl scripts are also not used for anything.
> 
>  Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`";
>  echo $version)) missing?"

Correct.

> * I'm dubious about the licensing being okay-- there are a lot of different
> licenses listed in the full licensecheck output [1]. Are you sure that, for
> example, the Boost-licensed files (marked by fedora-review as "BSL") in the
> "webserver" directory aren't being compiled? If they are, the license must
> be annotated accordingly.
> 
> To be explicit about this, I would recommend removing the bits that are
> bundled in %prep and cross-checking with the licensecheck output.
> 
> Further complicating things, there is a large amount of content in
> /usr/share/domoticz/www, including a number of gzip-compressed JS libraries
> in /usr/share/domoticz/www/js, and a variety of fonts scattered throughout
> the directory as well. Please:
> 
> - Investigate unbundling the fonts. Hopefully this is possible, but if not
> please confirm that the fonts are appropriately licensed via "ttname" as per
> the fonts policy [2].
> 
> - Go through the bundled JS libs, identify their licenses, add bundled
> provides, and amend the License: tag of the package accordingly. (I would
> bet most are MIT licensed). Having had to do this myself before, I know it's
> mostly frustrating busywork; I'm sorry to have to ask for it, but the
> guidelines are clear. :(

These issues should be corrected.

Spec: http://michael.cronenworth.com/RPMS/domoticz.spec
SRPM: http://michael.cronenworth.com/RPMS/domoticz-3.5877-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433003] Review Request: openboardview - Software for viewing .brd files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433003

srakitnican  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #2 from srakitnican  ---
Also seems like I have a sponsor now, removing FE-NEEDSPONSOR.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433003] Review Request: openboardview - Software for viewing .brd files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433003



--- Comment #1 from srakitnican  ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/srakitnican/openboardview/fedora-26-x86_64/00581077-openboardview/openboardview.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/srakitnican/openboardview/fedora-26-x86_64/00581077-openboardview/openboardview-7.3-3.fc26.src.rpm

New release 7.3-3:

* Enabled debug build and made sure not to use stripped binaries
* Added mesa-dri-drivers install requirement
* Added tarball of Khronos spec for Glad to allow offline build
* Switched to official GH sources and added git submodules
* AppStream metadata
* Improved summary and description
* Unbundled sqlite3
* Added more files that can be opened to metadata file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468768] Review Request: domoticz - Open source Home Automation System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468768



--- Comment #5 from Michael Cronenworth  ---
Created attachment 1300687
  --> https://bugzilla.redhat.com/attachment.cgi?id=1300687=edit
Bundled javascript license check

Here's a detailed list of each bundled javascript license.

Will this line suffice?

License: GPLv3+ and ASL 2.0 and BSD and MIT

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421041] Review Request: deepin-gettext-tools - Deepin Gettext Tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421041



--- Comment #3 from sensor@gmail.com ---
Hi Zbigniew Jędrzejewski-Szmek

thank you for your package review. It's very useful for me.
About "_", i will delete them for a while.
Some other problems, i have fixed and submitted it to github. It looks okey. 

https://raw.githubusercontent.com/FZUG/repo/master/rpms/deepin_project/deepin-gettext-tools.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419317] Review Request: deepin-terminal - terminal emulation application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419317



--- Comment #2 from sensor@gmail.com ---
Hi Zbigniew Jędrzejewski-Szmek,

Thank your for you help.
I searched this error in the github. The error seems to be related to vala.
`rm vapi/gee-0.8.vapi` should fix it on fc26.

Some Requires may not be needed when using other desktop environments. This
requires further testing in the virtual machine.

```
# right-click menu style
Requires:   deepin-menu
# run command by create_from_commandline
Requires:   deepin-shortcut-viewer
Requires:   xdg-utils
Recommends: deepin-manual
```

Build test:
https://copr.fedorainfracloud.org/coprs/mosquito/deepin/build/580989/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468768] Review Request: domoticz - Open source Home Automation System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468768



--- Comment #4 from Michael Cronenworth  ---
Created attachment 1300552
  --> https://bugzilla.redhat.com/attachment.cgi?id=1300552=edit
Bundled fonts license check

Good catch on the fonts. I can unbundle DroidSans, but the rest are not
available in Fedora. Their licenses appear to be OK. I'm including the license
output from the fonts for review.

I will address the other issues shortly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1472405] New: Review Request: gdb-exploitable - GDB extension for exploitability

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1472405

Bug ID: 1472405
   Summary: Review Request: gdb-exploitable - GDB extension for
exploitability
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sgr...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://people.redhat.com/sgrubb/files/gdb-exploitable.spec

SRPM URL:
http://people.redhat.com/sgrubb/files/gdb-exploitable-1.32-1.20170717git35b742d.fc25.src.rpm

Description: 
'exploitable' is a GDB extension that classifies Linux application bugs
by severity. The extension inspects the state of a Linux application that
has crashed and outputs a summary of how difficult it might be for an
attacker to exploit the underlying software bug to gain control of the
system. The extension can be used to prioritize bugs for software developers
so that they can address the most severe ones first.

Fedora Account System Username: sgrubb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1472377] New: Review Request: perl-Locale-TextDomain-OO - Perl OO Interface to Uniforum Message Translation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1472377

Bug ID: 1472377
   Summary: Review Request: perl-Locale-TextDomain-OO - Perl OO
Interface to Uniforum Message Translation
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jples...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jplesnik.fedorapeople.org/perl-Locale-TextDomain-OO/perl-Locale-TextDomain-OO.spec
SRPM URL:
https://jplesnik.fedorapeople.org/perl-Locale-TextDomain-OO/perl-Locale-TextDomain-OO-1.028-1.fc27.src.rpm

Description:
This module provides a high-level interface to Perl message translation.

Fedora Account System Username: jples...@redhat.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421413



--- Comment #19 from Marek Cermak  ---
Thanks Frank, 

If I am not mistaken, you've forgotten to update the changelog to the newest
release. Could you correct that, please?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1443076



--- Comment #28 from jiri vanek  ---
updated:

Spec URL: https://jvanek.fedorapeople.org/openjdk9Review/V4/java-9-openjdk.spec
SRPM URL:
https://jvanek.fedorapeople.org/openjdk9Review/V4/java-9-openjdk-9.0.0.178-1.fc24.src.rpm
Description: OpenJDK Runtime Environment in implementation of java 9
specification
Fedora Account System Username: jvanek

https://koji.fedoraproject.org/koji/taskinfo?taskID=20597202 now should pass.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1443076



--- Comment #27 from jiri vanek  ---
> 
> But failed strangely  in koji. New built at:
>   https://koji.fedoraproject.org/koji/taskinfo?taskID=20595078

found the issue. Will respin as V4. Feel free to proceed with review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468768] Review Request: domoticz - Open source Home Automation System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468768



--- Comment #3 from Ben Rosser  ---
> They look compiled to me. :) I would include the BRs just to be safe.

On second thought there's really no reason to do this if the scripts are just
there for demonstration purposes, so maybe explicitly exclude the pyc and pyo
files in the file list to prevent RPM from including them (since as you say,
they shouldn't really be there).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421413



--- Comment #18 from Frank Crawford  ---
(In reply to Frank Crawford from comment #14)
> (In reply to Marek Cermak from comment #13)
> > NOTES
> > -
> > sysusage.src:101: W: rpm-buildroot-usage %build DESTDIR=%{buildroot}  -- see
> > the comment above from Jaroslav Skarvada and apply the patch, please. 
> > 
> > Otherwise OK!
> 
> Okay, I'll fix that up in the next day and up load a new spec file, and SRPM.

The new versions are now uploaded at:

Spec URL: https://fedorapeople.org/~frankcrawford/sysusage.spec

SRPM URL: https://fedorapeople.org/~frankcrawford/sysusage-5.5-3.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421413



--- Comment #17 from Frank Crawford  ---
(In reply to Jaroslav Škarvada from comment #16)

Jaroslav, thanks for the clarification.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1443076



--- Comment #26 from jiri vanek  ---
Spec URL: https://jvanek.fedorapeople.org/openjdk9Review/V4/java-9-openjdk.spec
SRPM URL:
https://jvanek.fedorapeople.org/openjdk9Review/V4/java-9-openjdk-9.0.0.178-1.fc24.src.rpm
Description: OpenJDK Runtime Environment in implementation of java 9
specification
Fedora Account System Username: jvanek

All should be fixed, except:
  *  the config files  are still in jdk. I need to resolve few more issues in
https://pagure.io/copy_jdk_configs/ before move with them (you can see that
work in progress)
   * also I need to find if to link whole conf dir, or individual configs.
  * it seems that crypto has changed between those two source tarbhalls, and
there is newly ../lib/libsunec.so 

The linked srpm passed for me locally: 
223610 Jul 18 11:45 java-9-openjdk-9.0.0.178-1.fc24.x86_64.rpm
  6878 Jul 18 11:49
java-9-openjdk-accessibility-9.0.0.178-1.fc24.x86_64.rpm
  6582 Jul 18 11:49
java-9-openjdk-accessibility-debug-9.0.0.178-1.fc24.x86_64.rpm
221534 Jul 18 11:45 java-9-openjdk-debug-9.0.0.178-1.fc24.x86_64.rpm
 119179042 Jul 18 11:50 java-9-openjdk-debuginfo-9.0.0.178-1.fc24.x86_64.rpm
614878 Jul 18 11:48 java-9-openjdk-demo-9.0.0.178-1.fc24.x86_64.rpm
615810 Jul 18 11:48 java-9-openjdk-demo-debug-9.0.0.178-1.fc24.x86_64.rpm
   3503706 Jul 18 11:46 java-9-openjdk-devel-9.0.0.178-1.fc24.x86_64.rpm
   3504478 Jul 18 11:46 java-9-openjdk-devel-debug-9.0.0.178-1.fc24.x86_64.rpm
  42696374 Jul 18 11:45 java-9-openjdk-headless-9.0.0.178-1.fc24.x86_64.rpm
  43759982 Jul 18 11:46
java-9-openjdk-headless-debug-9.0.0.178-1.fc24.x86_64.rpm
 241491838 Jul 18 11:47 java-9-openjdk-jmods-9.0.0.178-1.fc24.x86_64.rpm
 187679398 Jul 18 11:48 java-9-openjdk-jmods-debug-9.0.0.178-1.fc24.x86_64.rpm
  58877670 Jul 18 11:48 java-9-openjdk-src-9.0.0.178-1.fc24.x86_64.rpm
  58876934 Jul 18 11:49 java-9-openjdk-src-debug-9.0.0.178-1.fc24.x86_64.rpm

But failed strangely  in koji. New built at:
  https://koji.fedoraproject.org/koji/taskinfo?taskID=20595078

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1439894] Review Request: ddiskit - tool for building Driver Update Disk modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439894



--- Comment #21 from Stanislav Kozina  ---
https://admin.fedoraproject.org/pkgdb/package/requests/12968
https://admin.fedoraproject.org/pkgdb/package/requests/12967
https://admin.fedoraproject.org/pkgdb/package/requests/12966
https://admin.fedoraproject.org/pkgdb/package/requests/12965

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470057] Review Request: perl-Locale-Utils-PlaceholderNamed - Utils to expand named placeholders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470057

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Locale-Utils-Placehold
   ||erNamed-1.002-1.fc27
 Resolution|--- |RAWHIDE
Last Closed||2017-07-18 07:21:11



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1466844] Review Request: modtools - Utilities for creating and managing modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1466844



--- Comment #2 from dhodo...@redhat.com ---
Spec URL: https://dhodovsk.fedorapeople.org/modtools.spec
SRPM URL: https://dhodovsk.fedorapeople.org/modtools-0.0.1-2.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1439894] Review Request: ddiskit - tool for building Driver Update Disk modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439894



--- Comment #20 from Stanislav Kozina  ---
Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404895] Review Request: partclone - File System Clone Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404895



--- Comment #3 from Robert Scheck  ---
Eric, ping? Any thoughts or comments regarding my thoughts and comments?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460917] Review Request: rpkg - Command-line client tool to DistGit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460917



--- Comment #19 from Fedora Update System  ---
rpkg-client-0.6-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-52327d89db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460917] Review Request: rpkg - Command-line client tool to DistGit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460917

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465884] Review Request: golang-github-cznic-lex - Support for (f) lex-like tool on .l source files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465884



--- Comment #3 from Fabio Valentini  ---
Oops, sorry about that. Must have been a copy-paste error. Updated links:

Spec URL:
https://decathorpe.fedorapeople.org/packages/golang-github-cznic-lex.spec

SRPM URL:
https://decathorpe.fedorapeople.org/packages/golang-github-cznic-lex-0-0.1.20170112.git68050f5.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468971] Review Request: freshmaker - A service scheduling rebuilds of artifacts as new content becomes available

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468971



--- Comment #8 from Qixiang Wan  ---
Latest version:

Spec URL: https://fedorapeople.org/~qwan/freshmaker/freshmaker.spec
SRPM URL: https://fedorapeople.org/~qwan/freshmaker/freshmaker-0.0.4-1.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1464797] Review Request: trezor-common - udev rules and protobuf messages for the hardware wallet TREZOR

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1464797



--- Comment #6 from Jonny Heggheim  ---
Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1344276] Review Request: gdeploy - Tool to deploy GlusterFS clusters and other utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344276



--- Comment #25 from Sandro Bonazzola  ---
Ken?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450477] Review Request: ratbagd - the libratbag daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450477

Benjamin Tissoires  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(btissoir@redhat.c |
   |om) |
Last Closed||2017-07-18 02:50:39



--- Comment #5 from Benjamin Tissoires  ---
ratbagd has been merged into libratbag, so there is no point having a separate
package for it anymore. I'll update the requested changes in the libratbag RPM
once upstream settle on something.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org