[Bug 1432983] Review Request: camotics - Open-Source Simulation & Computer Aided Machining - A 3-axis CNC GCode simulator

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1432983



--- Comment #21 from Fedora Update System  ---
camotics-1.1.1-6.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1419332] Review Request: deepin-shortcut-viewer - deepin shortcut viewer

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1419332



--- Comment #2 from sensor@gmail.com ---
SPEC:
https://raw.githubusercontent.com/FZUG/repo/168a491b88b2796266ae1d6350a2e48065a6f4f2/rpms/deepin_project/deepin-shortcut-viewer.spec

Thanks, i fixed it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1468830



--- Comment #19 from Fedora Update System  ---
abbayedesmorts-gpl-2.0.1-3.20170709git.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1431745] Review Request: golang-github-cznic-lldb - Low-level database engine implementation in Go

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1431745



--- Comment #11 from Fedora Update System  ---
golang-github-cznic-lldb-1.1.0-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1465881] Review Request: golang-github-cznic-lexer - Run time generator of action less scanners written in Go

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1465881



--- Comment #8 from Fedora Update System  ---
golang-github-cznic-lexer-0-0.1.20141211.git52ae786.fc25 has been pushed to the
Fedora 25 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1473314] Review Request: rclone - rsync for cloud storage

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1473314

Robert-André Mauchin  changed:

   What|Removed |Added

 Depends On||1474536, 1474537



--- Comment #5 from Robert-André Mauchin  ---
It turns out that some dependencies that already are in Fedora need to be
updated to more recent version too. I file bug 1474537 and bug 1474536
accordingly.

>It would be great if you could show your packaging skills by preliminary 
>reviewing other package reviews

I can review other people's package even if I'm not a member of the package
team and a novice?


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1474536
[Bug 1474536] Please update to a more recent version
https://bugzilla.redhat.com/show_bug.cgi?id=1474537
[Bug 1474537] Please update the package to a more recent version
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1431745] Review Request: golang-github-cznic-lldb - Low-level database engine implementation in Go

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1431745



--- Comment #10 from Fedora Update System  ---
golang-github-cznic-lldb-1.1.0-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1473314] Review Request: rclone - rsync for cloud storage

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1473314



--- Comment #4 from Till Maas  ---
(In reply to Robert-André Mauchin from comment #3)
> I have almost packaged all of the bundle.

Awesome work, you are great!

> Thus, how shall I proceed? Open a Review request for each package? And then
> try to import them in pkgdb?

In the end there will have to be one review request for each package. Initially
I would suggest to update your copr repo to include all the packages including
an updated rclone package that used the dependencies. Then it would be good to
start with a few review request of the dependencies to see if there are any
common errors. You can mark the review requests to block this bug to make it
clear that they are dependencies.

> Another question, if you may help, if a package depends on another packages
> not yet included like golang-googlegolangorg-api above, how should one
> proceed to generate a mock build or a koji scratch build? Wait for the
> dependency to be imported via pkgdb, and then only afterwards try the mock
> build or koji build?

Using copr is the easiest way. AFAIK you can first build your dependencies in
copr and then use them to build the next packages.

> Also, it says pkgdb is retiring soon, replaced by pagure.io and fedrepo_req,
> is there detailed explanation on how to proceed to add a package then? I
> read https://pagure.io/fedrepo_req but it's still a bit confusing.

This is currently work in progress. Once pkgdb is retired there will be better
documentation. Your sponsor or other developers will help you to figure this
out.

It would be great if you could show your packaging skills by preliminary
reviewing other package reviews as documented here:
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Show_Your_Expertise_by_Commenting_on_other_Review_Requests

This helps sponsors to get convinced that you are ready to be sponsored.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1473314] Review Request: rclone - rsync for cloud storage

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1473314



--- Comment #3 from Robert-André Mauchin  ---
I have almost packaged all of the bundle.

Here's a summary of the dependency:

=
bazil.org/fuse (golang-bazil.org-fuse) PkgDB=False

 * Done
 * Tests disabled because it need fuse.ko module to be loaded
 * SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/2921/20712921/golang-bazil-fuse-0-0.1.git371fbbd.fc27.src.rpm
 * Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20712919

github.com/Unknwon/goconfig (golang-github-Unknwon-goconfig)

 * Done
 * SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/1738/20711738/golang-github-Unknwon-goconfig-0-0.1.git87a46d9.fc27.src.rpm
 * Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20711737

github.com/VividCortex/ewma (golang-github-VividCortex-ewma) 

 * Almost done: error in test for arch ppc64le and s390x, I don't know why
specifically these
 * SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/1994/20711994/golang-github-VividCortex-ewma-0-0.1.git4cc8cc5.fc27.src.rpm
 * Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20711992

github.com/billziss-gh/cgofuse (golang-github-billziss-gh-cgofuse) PkgDB=False

 * Done
 * Tests disabled because it needs fuse.ko module to be loaded
 * SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/2974/20712974/golang-github-billziss-gh-cgofuse-0-0.1.git35bcf03.fc27.src.rpm
 * Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20712973

github.com/jlaffaye/ftp (golang-github-jlaffaye-ftp) PkgDB=False

 * Done
 * Tests disabled because it needs a running ftp server
 * SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/3117/20713117/golang-github-jlaffaye-ftp-0-0.1.git769512c.fc27.src.rpm
 * Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20713116

github.com/ncw/dropbox-sdk-go-unofficial
(golang-github-ncw-dropbox-sdk-go-unofficial) PkgDB=False

 * Done
 * SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/3743/20713743/golang-github-ncw-dropbox-sdk-go-unofficial-0-0.1.git5d9f46f.fc27.src.rpm
 * Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20713742
github.com/ncw/go-acd (golang-github-ncw-go-acd) PkgDB=False

 * Done
cd ... * SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/3409/20713409/golang-github-ncw-go-acd-0-0.1.git96a49aa.fc27.src.rpm
 * Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20713408

github.com/nsf/termbox-go (golang-github-nsf-termbox-go) PkgDB=False

 * Done
 * SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/3806/20713806/golang-github-nsf-termbox-go-0-0.1.git4ed959e.fc27.src.rpm
 * Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20713805

github.com/rfjakob/eme (golang-github-rfjakob-eme) PkgDB=False

 * Done
 * SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/3974/20713974/golang-github-rfjakob-eme-1.1-1.fc27.src.rpm
 * Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20713973

github.com/xanzy/ssh-agent (golang-github-xanzy-ssh-agent) PkgDB=False

 * Done
 * SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/4134/20714134/golang-github-xanzy-ssh-agent-0-0.1.gitba9c9e3.fc27.src.rpm
 * Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20714132

google.golang.org/api (golang-googlegolangorg-api) PkgDB=False

 * Built locally
 * Depends on:

* golang.org/x/sync (golang-golangorg-sync) PkgDB=False

* Done
* SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/4633/20714633/golang-github-golang-sync-0-0.1.gitf52d181.fc27.src.rpm
* Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=20714632

* google.golang.org/appengine (golang-googlegolangorg-appengine)
PkgDB=False

* Done
* SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/4756/20714756/golang-github-golang-appengine-0-0.1.gitad2570c.fc27.src.rpm
* Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=20714755

google.golang.org/genproto (golang-googlegolangorg-genproto) PkgDB=False

* Done
* A error in a test that I can't explain + another one but bug filed
upstream
* SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/5394/20715394/golang-github-google-go-genproto-0-0.1.gitb0a3dcf.fc27.src.rpm
* Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=20715393

=

Thus, how shall I proceed? Open a Review request for each package? And then try
to import them in pkgdb?

Another question, if you may help, if a package depends on another packages not
yet included like golang-googlegolangorg-api above, how should one proceed to
generate a mock build or a koji scratch 

[Bug 1441023] Review Request: python-fontmake - Compile fonts from sources to binary

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1441023
Bug 1441023 depends on bug 1433757, which changed state.

Bug 1433757 Summary: Review Request: python-glyphsLib - A bridge from Glyphs 
source files to UFOs
https://bugzilla.redhat.com/show_bug.cgi?id=1433757

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1433757] Review Request: python-glyphsLib - A bridge from Glyphs source files to UFOs

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1433757

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-07-24 15:21:45



--- Comment #14 from Fedora Update System  ---
python-glyphsLib-1.7.5-2.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1468830

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-07-24 15:21:39



--- Comment #18 from Fedora Update System  ---
abbayedesmorts-gpl-2.0.1-3.20170709git.fc26 has been pushed to the Fedora 26
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1465881] Review Request: golang-github-cznic-lexer - Run time generator of action less scanners written in Go

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1465881

Fedora Update System  changed:

   What|Removed |Added

 Resolution|RAWHIDE |ERRATA



--- Comment #7 from Fedora Update System  ---
golang-github-cznic-lexer-0-0.1.20141211.git52ae786.fc26 has been pushed to the
Fedora 26 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1431748] Review Request: golang-github-cznic-ql - Embedded SQL database written in Go

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1431748
Bug 1431748 depends on bug 1431745, which changed state.

Bug 1431745 Summary: Review Request: golang-github-cznic-lldb - Low-level 
database engine implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1431745

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1431745] Review Request: golang-github-cznic-lldb - Low-level database engine implementation in Go

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1431745

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-07-09 10:33:59 |2017-07-24 15:21:00



--- Comment #9 from Fedora Update System  ---
golang-github-cznic-lldb-1.1.0-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1459693] Review Request: recap - Generates reports of various system information

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1459693



--- Comment #9 from Fedora Update System  ---
recap-1.0.0-2.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-b35db31d5d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1459693] Review Request: recap - Generates reports of various system information

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1459693

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1473384] Review Request: rubygem-jekyll-lunr-js-search

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1473384

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||vondr...@redhat.com,
   ||zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
rubygem-rubyracer was retired last year:
http://pkgs.fedoraproject.org/cgit/rpms/rubygem-therubyracer.git/diff/dead.package?id=4206bd0748385b34151f4f5f636dc1644f97ec95.
 

You wrote:
> The other option would be to patch upstream jekyll-lunr-js-search to rely
> for JS on rubygem-execjs instead of rubygem-therubyracer or strip out search
> completely (which is broken right now anyway in packaged version).

Yeah, that's an option too. How hard would it be?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1341662] Review Request: fedora-developer-portal - Offline Fedora Developer Portal

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1341662



--- Comment #16 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to František Zatloukal from comment #15)
> New SPEC:
> https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-
> portal/fedora-rawhide-x86_64/00583062-fedora-developer-portal/fedora-
> developer-portal.spec
> 
> New SRPM:
> https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-
> portal/fedora-rawhide-x86_64/00583062-fedora-developer-portal/fedora-
> developer-portal-0.9.4-0.1.git167ae09.fc27.src.rpm
> 
> I've bundled few gems to mitigate rubygem-therubyracer not being built and
> maintained in latest Fedoras. I think bundling only for build time is OK.
Sounds reasonable.

> The other option would be to patch upstream jekyll-lunr-js-search to rely
> for JS on rubygem-execjs instead of rubygem-therubyracer or strip out search
> completely (which is broken right now anyway in packaged version).
> 
> Regarding building the noarch package in Fedora infra - can I rely on x86_64
> builder or not? Cause bundled libv8 is architecture-specific (and %ifarch
> didn't work for me in mock, probably because of noarch package)

For a noarch package, you cannot rely on a specific builder architecture,
unless you use ExclusiveArch. See
https://fedoraproject.org/wiki/Packaging:Node.js#ExclusiveArch.
I think those instructions there should work for this case too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1473851] Review Request: docker-client-java - Java library to communicate with Docker daemon

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1473851



--- Comment #6 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/docker-client-java

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1460759] Review Request: python-daiquiri - Library to configure Python logging easily

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1460759

Pradeep Kilambi  changed:

   What|Removed |Added

 CC||karlthe...@gmail.com,
   ||pkila...@redhat.com
  Flags||needinfo?(karlthered@gmail.
   ||com)



--- Comment #1 from Pradeep Kilambi  ---
can we make this a priority. This is blocking us from using stable/4.0 gnocchi
for pike.

https://logs.rdoproject.org/45/7345/3/check/rdoinfo-DLRN-check/Z08be42071f3a47eda2b50ce23e590434/centos/repos/91/4e/914e9434b694e2dc5978d18b7172359352eda619_dev/rpmbuild.log

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1473851] Review Request: docker-client-java - Java library to communicate with Docker daemon

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1473851

Roland Grunberg  changed:

   What|Removed |Added

  Flags|fedora-review-  |fedora-review+



--- Comment #5 from Roland Grunberg  ---
Yup, this seems fixed now.

[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
2 packages and 0 specfiles checked; 0 errors, 0 warnings.


*** APPROVED ***


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1465006] Review Request: python-netmiko - Multi-vendor library to simplify Paramiko SSH connections to network devices

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1465006



--- Comment #9 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-netmiko

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1459693] Review Request: recap - Generates reports of various system information

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1459693



--- Comment #8 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/recap

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1341662] Review Request: fedora-developer-portal - Offline Fedora Developer Portal

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1341662



--- Comment #15 from František Zatloukal  ---
New SPEC:
https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-rawhide-x86_64/00583062-fedora-developer-portal/fedora-developer-portal.spec

New SRPM:
https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-rawhide-x86_64/00583062-fedora-developer-portal/fedora-developer-portal-0.9.4-0.1.git167ae09.fc27.src.rpm

I've bundled few gems to mitigate rubygem-therubyracer not being built and
maintained in latest Fedoras. I think bundling only for build time is OK.

The other option would be to patch upstream jekyll-lunr-js-search to rely for
JS on rubygem-execjs instead of rubygem-therubyracer or strip out search
completely (which is broken right now anyway in packaged version).

Regarding building the noarch package in Fedora infra - can I rely on x86_64
builder or not? Cause bundled libv8 is architecture-specific (and %ifarch
didn't work for me in mock, probably because of noarch package)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1473851] Review Request: docker-client-java - Java library to communicate with Docker daemon

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1473851



--- Comment #4 from Jeff Johnston  ---

> 
> It all looks fine to me. I would just change the usage of tabs to spaces on
> lines 6 and 7 to match with the rest of the file.

Done.  Please see update.

Spec URL: http://www.vermillionskye.com/work/docker-client-java.spec
SRPM URL:
http://www.vermillionskye.com/work/docker-client-java-6.2.5-3.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1465006] Review Request: python-netmiko - Multi-vendor library to simplify Paramiko SSH connections to network devices

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1465006

Haïkel Guémar  changed:

   What|Removed |Added

 Blocks||1427510 (RDO-PIKE)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1427510
[Bug 1427510] Tracker: Blockers and Review requests for new RDO Pike
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1465006] Review Request: python-netmiko - Multi-vendor library to simplify Paramiko SSH connections to network devices

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1465006

Haïkel Guémar  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Haïkel Guémar  ---
Approved, please proceed with packageDB request



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 91 files have
 unknown license. Detailed output of licensecheck in
 /home/haikel/1465006-python-netmiko/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-netmiko , python3-netmiko
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if 

[Bug 1474403] Review Request: perl-Env-ShellWords - Environment variables for arguments as a Perl array

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1474403

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1474425




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1474425
[Bug 1474425] Review Request: perl-Alien-Build - Build external
dependencies for use in CPAN
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1474392] Review Request: perl-Test-Exec - Test that some code calls exec without terminating testing

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1474392

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1474425




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1474425
[Bug 1474425] Review Request: perl-Alien-Build - Build external
dependencies for use in CPAN
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1474425] Review Request: perl-Alien-Build - Build external dependencies for use in CPAN

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1474425

Petr Pisar  changed:

   What|Removed |Added

 Depends On||1473712, 1474333, 1474403,
   ||1474392




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1473712
[Bug 1473712] Review Request: perl-Alien-Base - Base classes for Alien::
Perl modules
https://bugzilla.redhat.com/show_bug.cgi?id=1474333
[Bug 1474333] Review Request: perl-Config-INI-Reader-Multiline - Parser for
INI files with line continuations
https://bugzilla.redhat.com/show_bug.cgi?id=1474392
[Bug 1474392] Review Request: perl-Test-Exec - Test that some code calls
exec without terminating testing
https://bugzilla.redhat.com/show_bug.cgi?id=1474403
[Bug 1474403] Review Request: perl-Env-ShellWords - Environment variables
for arguments as a Perl array
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1473712] Review Request: perl-Alien-Base - Base classes for Alien:: Perl modules

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1473712

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1474425




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1474425
[Bug 1474425] Review Request: perl-Alien-Build - Build external
dependencies for use in CPAN
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1474333] Review Request: perl-Config-INI-Reader-Multiline - Parser for INI files with line continuations

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1474333

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1474425




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1474425
[Bug 1474425] Review Request: perl-Alien-Build - Build external
dependencies for use in CPAN
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1474425] New: Review Request: perl-Alien-Build - Build external dependencies for use in CPAN

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1474425

Bug ID: 1474425
   Summary: Review Request: perl-Alien-Build - Build external
dependencies for use in CPAN
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-Alien-Build/perl-Alien-Build.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-Alien-Build/perl-Alien-Build-0.66-1.fc27.src.rpm
Description:
This package provides tools for building external (non-CPAN) dependencies
for CPAN. It is mainly designed to be used at install time of a CPAN
client, and work closely with Alien::Base which is used at run time.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1465885] Review Request: golang-github-cznic-golex - Lex/ Flex-like utility written in Go

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1465885



--- Comment #5 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-cznic-golex

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1465006] Review Request: python-netmiko - Multi-vendor library to simplify Paramiko SSH connections to network devices

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1465006



--- Comment #7 from Haïkel Guémar  ---
Spec URL:
https://raw.githubusercontent.com/dtantsur/netmiko-distgit/master/python-netmiko.spec
SRPM URL:
https://hguemar.fedorapeople.org/reviews/python-netmiko-1.4.1-1.fc26.src.rpm

Previous SRPM link is invalid now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1465885] Review Request: golang-github-cznic-golex - Lex/ Flex-like utility written in Go

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1465885



--- Comment #4 from Fabio Valentini  ---
Damn. It seems I misunderstood the versioning guidelines. I just wanted to bump
the release for the changes I made according to your review, but well ...

I'll fix it before importing (sorry for the confusion - I'm on painkillers
right now).

And thank you for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1465885] Review Request: golang-github-cznic-golex - Lex/ Flex-like utility written in Go

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1465885

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Athos Ribeiro  ---
Hi Fabio,

I just realized that your Release tag has a '.1' appended to it. Is there a
reason for using the minorbump [1] here?

The pointed issues are fixed and the package looks good now. Approved.

[1]
https://fedoraproject.org/wiki/Packaging:Versioning#You_need_to_change_an_old_branch_without_rebuilding_the_others

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1474403] New: Review Request: perl-Env-ShellWords - Environment variables for arguments as a Perl array

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1474403

Bug ID: 1474403
   Summary: Review Request: perl-Env-ShellWords - Environment
variables for arguments as a Perl array
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-Env-ShellWords/perl-Env-ShellWords.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-Env-ShellWords/perl-Env-ShellWords-0.01-1.fc27.src.rpm
Description:
This Perl module provides an array-like interface to environment variables that
contain flags. For example Autoconf can uses the environment variables like
CFLAGS or LDFLAGS, and this allows you to manipulate those variables
without doing space quoting and other messy mucky stuff.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1465885] Review Request: golang-github-cznic-golex - Lex/ Flex-like utility written in Go

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1465885



--- Comment #2 from Fabio Valentini  ---
I think I've addressed all the issues with the new .spec and SRPM file.

- License and docs are also installed with the binary package.
- Added "Provides: golex = VERSION" to the binary package.
- Debuginfo package is built (forgot to flip the switch in line 6, stupid me).

Since the "calc" folder only contains yet another usage example (which isn't
shipped and/or used for building the package), I'll just ignore it for
packaging (and licensing).

Spec URL:
https://decathorpe.fedorapeople.org/packages/golang-github-cznic-golex.spec

SRPM URL:
https://decathorpe.fedorapeople.org/packages/golang-github-cznic-golex-0-0.1.20170310.gitd7f6f2b.fc26.1.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1474392] New: Review Request: perl-Test-Exec - Test that some code calls exec without terminating testing

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1474392

Bug ID: 1474392
   Summary: Review Request: perl-Test-Exec - Test that some code
calls exec without terminating testing
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ppisar.fedorapeople.org/perl-Test-Exec/perl-Test-Exec.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-Test-Exec/perl-Test-Exec-0.04-1.fc27.src.rpm
Description:
The Test::Exec Perl module provides the most simple possible tools for testing
code that might call exec function, which would otherwise end your test by
calling another program. This code should detect and capture exec calls, even
if they are inside an eval statement.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1419332] Review Request: deepin-shortcut-viewer - deepin shortcut viewer

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1419332

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
+ package name is OK
+ license is acceptable for Fedora (GPLv3)
+ license is specified correctly
+ builds and installs OK
+ Requires/Provides/BuildRequires look OK
+ no scriptlets necessary
+ build flags are honoured
+ rpmlint shows nothing useful
- no docs and no license: there's a LICENSE file, and some documentation files,
not sure if those are useful. Please add least add %license LICENSE.

CuteLogger is bundled. It is not packaged for Fedora, so according to the
guidelines [https://fedoraproject.org/wiki/Bundled_Software_policy], a tag
should be added:
  Provides: bundled(CuteLogger)
If you know the version, also add "= ", but from a quick look at the
sources, I don't see any version string there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/ Qt Developer work on Deepin

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1421047

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Zbigniew Jędrzejewski-Szmek  ---
Looks all good now. Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1474333] New: Review Request: perl-Config-INI-Reader-Multiline - Parser for INI files with line continuations

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1474333

Bug ID: 1474333
   Summary: Review Request: perl-Config-INI-Reader-Multiline -
Parser for INI files with line continuations
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-Config-INI-Reader-Multiline/perl-Config-INI-Reader-Multiline.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-Config-INI-Reader-Multiline/perl-Config-INI-Reader-Multiline-1.001-1.fc27.src.rpm
Description:
The Config::INI::Reader::Multiline Perl module is a subclass of
Config::INI::Reader that offers support for line continuations, i.e. adding
a backslash-newline at the end of a line to indicate the newline should be
removed from the input stream and ignored.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1362265] Review Request: yara - Malware identification tool

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1362265

Michal Ambroz  changed:

   What|Removed |Added

  Alias|yara|yara-review



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1293694] Review Request: byte-buddy - Runtime code generation for the Java virtual machine

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1293694

gil cattaneo  changed:

   What|Removed |Added

  Flags|needinfo?(puntogil@libero.i |
   |t)  |



--- Comment #9 from gil cattaneo  ---
(In reply to Raphael Groner from comment #8)
> awaitility (and so byte-buddy as dependency) is needed for some tests of
> rabbitmq-java-client version 4.1.1

if you need this library take the ownership, i no time at the moment and
various unresolved problems:
https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/thread/TWTHAKK6B5RBI5L6RQ2S543KHCGH4GHJ/
sorry

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1474301] New: Review Request: rubygem-aws-sigv4 - AWS Signature Version 4 library

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1474301

Bug ID: 1474301
   Summary: Review Request: rubygem-aws-sigv4 - AWS Signature
Version 4 library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: val...@civ.zcu.cz
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://scientific.zcu.cz/fedora/rubygem-aws-sigv4-1.0.1-1/rubygem-aws-sigv4.spec
SRPM URL:
http://scientific.zcu.cz/fedora/rubygem-aws-sigv4-1.0.1-1/rubygem-aws-sigv4-1.0.1-1.fc27.src.rpm
Description: Amazon Web Services Signature Version 4 signing library. Generates
sigv4 signature for HTTP requests.
Fedora Account System Username: valtri

COPR build: https://copr.fedorainfracloud.org/coprs/valtri/ruby/build/582977/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1470656] Review Request: perl-Regexp-Stringify - Stringify a Regexp object

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1470656

Petr Pisar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Petr Pisar  ---
URL and Source0 addresses are Ok.
Source0 archive (SHA-256:
7a82fe44a2658d7ccc57f51a69954719473f066bf9148396b9f49b86593b56f5) is original.
Ok.
Summary verified from lib/Regexp/Stringify.pm. Ok.
Description verified from lib/Regexp/Stringify.pm. Ok.
License verified from LICENSE and lib/Regexp/Stringify.pm. Ok.
No XS code, noarch BuildArch is Ok.
Test::Pod::Coverage and Pod::Coverage::TrustPod and Test::Pod are not used. Ok.

FIX: Build-require `perl(blib)' for tests (t/00-compile.t:19).

All tests pass. Ok.

$ rpmlint perl-Regexp-Stringify.spec
../SRPMS/perl-Regexp-Stringify-0.06-1.fc27.src.rpm
../RPMS/noarch/perl-Regexp-Stringify-0.06-1.fc27.noarch.rpm 
perl-Regexp-Stringify.src: W: spelling-error %description -l en_US
stringification -> stratification, transmogrification, gentrification
perl-Regexp-Stringify.noarch: W: spelling-error %description -l en_US
stringification -> stratification, transmogrification, gentrification
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Regexp-Stringify-0.06-1.fc27.noarch.rpm 
drwxr-xr-x2 rootroot0 Jul 24 12:53
/usr/share/doc/perl-Regexp-Stringify
-rw-r--r--1 rootroot  711 Oct 29  2016
/usr/share/doc/perl-Regexp-Stringify/Changes
-rw-r--r--1 rootroot  431 Oct 29  2016
/usr/share/doc/perl-Regexp-Stringify/README
drwxr-xr-x2 rootroot0 Jul 24 12:53
/usr/share/licenses/perl-Regexp-Stringify
-rw-r--r--1 rootroot18367 Oct 29  2016
/usr/share/licenses/perl-Regexp-Stringify/LICENSE
-rw-r--r--1 rootroot 2390 Jul 24 12:53
/usr/share/man/man3/Regexp::Stringify.3pm.gz
drwxr-xr-x2 rootroot0 Jul 24 12:53
/usr/share/perl5/vendor_perl/Regexp
-rw-r--r--1 rootroot 5221 Oct 29  2016
/usr/share/perl5/vendor_perl/Regexp/Stringify.pm
File layout and permissions are Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Regexp-Stringify-0.06-1.fc27.noarch.rpm | sort -f | uniq -c
  1 perl(:MODULE_COMPAT_5.26.0)
  1 perl(:VERSION) >= 5.10.1
  1 perl(Exporter)
  1 perl(re)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p
../RPMS/noarch/perl-Regexp-Stringify-0.06-1.fc27.noarch.rpm | sort -f | uniq -c
  1 perl(Regexp::Stringify) = 0.06
  1 perl-Regexp-Stringify = 0.06-1.fc27
Binary provides are Ok.

$ resolvedeps rawhide
../RPMS/noarch/perl-Regexp-Stringify-0.06-1.fc27.noarch.rpm 
Binary dependencies resolvable. Ok.

The package builds in F27
(https://koji.fedoraproject.org/koji/taskinfo?taskID=20711448). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct the `FIX' item before building this package.
Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1470656] Review Request: perl-Regexp-Stringify - Stringify a Regexp object

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1470656

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|ppi...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1120788] Review Request: Rex - Tool for Automation, Remote Execution and Configuration Deployment

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1120788



--- Comment #9 from Dominic Hopf  ---
Okay, the BuildRequires for this one should be better now (checked with
mockbuild myself):

Spec URL: https://dmaphy.fedorapeople.org/Rex/Rex.spec
SRPM URL: https://dmaphy.fedorapeople.org/Rex/Rex-1.4.1-2.fc26.src.rpm
RPM URL: https://dmaphy.fedorapeople.org/Rex/Rex-1.4.1-2.fc26.noarch.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1120788] Review Request: Rex - Tool for Automation, Remote Execution and Configuration Deployment

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1120788



--- Comment #8 from Robin Lee  ---
Mock build on Rawhide failed during test:

+ make test
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness"
"-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')"
t/*.t t/commands/*.t t/issue/*.t
Can't locate Devel/Caller.pm in @INC (you may need to install the Devel::Caller
module) (@INC contains: CODE(0x56488ff58ca8)
/builddir/build/BUILD/Rex-1.4.1/blib/lib
/builddir/build/BUILD/Rex-1.4.1/blib/arch /usr/local/lib64/perl5
/usr/local/share/perl5 /usr/lib64/perl5/vendor_perl
/usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .
/builddir/build/BUILD/Rex-1.4.1/lib
/builddir/build/BUILD/Rex-1.4.1/lib/perl/lib/perl5
/builddir/build/BUILD/Rex-1.4.1/lib/perl/lib/perl5/x86_64-linux
CODE(0x56488ff58e70) /builddir/.rex/recipes) at
/builddir/build/BUILD/Rex-1.4.1/blib/lib/Rex/Helper/Rexfile/ParamLookup.pm line
14.
BEGIN failed--compilation aborted at
/builddir/build/BUILD/Rex-1.4.1/blib/lib/Rex/Helper/Rexfile/ParamLookup.pm line
14.
Compilation failed in require at
/builddir/build/BUILD/Rex-1.4.1/blib/lib/Rex.pm line 580.
BEGIN failed--compilation aborted at t/0.31.t line 6.
# Looks like your test exited with 2 before it could output anything.
t/0.31.t . 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 139/139 subtests 
Can't locate Devel/Caller.pm in @INC (you may need to install the Devel::Caller
module) (@INC contains: CODE(0x55ca8e5d26f8)
/builddir/build/BUILD/Rex-1.4.1/blib/lib
/builddir/build/BUILD/Rex-1.4.1/blib/arch /usr/local/lib64/perl5
/usr/local/share/perl5 /usr/lib64/perl5/vendor_perl
/usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .
/builddir/build/BUILD/Rex-1.4.1/lib
/builddir/build/BUILD/Rex-1.4.1/lib/perl/lib/perl5
/builddir/build/BUILD/Rex-1.4.1/lib/perl/lib/perl5/x86_64-linux
CODE(0x55ca8e5d28c0) /builddir/.rex/recipes) at
/builddir/build/BUILD/Rex-1.4.1/blib/lib/Rex/Helper/Rexfile/ParamLookup.pm line
14.
BEGIN failed--compilation aborted at
/builddir/build/BUILD/Rex-1.4.1/blib/lib/Rex/Helper/Rexfile/ParamLookup.pm line
14.
Compilation failed in require at
/builddir/build/BUILD/Rex-1.4.1/blib/lib/Rex.pm line 580.
BEGIN failed--compilation aborted at t/0.54.t line 6.
# Looks like your test exited with 2 before it could output anything.
t/0.54.t . 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 13/13 subtests 
t/01.t ... ok
t/args.t . ok
t/auth.t . ok
t/author-critic.t  skipped: these tests are for testing by the
author
t/author-pod-syntax.t  skipped: these tests are for testing by the
author
#   Failed test 'use Rex::CLI;'
#   at /usr/share/perl5/vendor_perl/Test/UseAllModules.pm line 71.
# Tried to use 'Rex::CLI'.
# Error:  Can't locate Devel/Caller.pm in @INC (you may need to install the
Devel::Caller module) (@INC contains: CODE(0x561fe8dbe498) lib
/builddir/build/BUILD/Rex-1.4.1/blib/lib
/builddir/build/BUILD/Rex-1.4.1/blib/arch /usr/local/lib64/perl5
/usr/local/share/perl5 /usr/lib64/perl5/vendor_perl
/usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .
/builddir/build/BUILD/Rex-1.4.1/lib
/builddir/build/BUILD/Rex-1.4.1/lib/perl/lib/perl5
/builddir/build/BUILD/Rex-1.4.1/lib/perl/lib/perl5/x86_64-linux
CODE(0x561fe8dbe660) /builddir/.rex/recipes) at
lib/Rex/Helper/Rexfile/ParamLookup.pm line 14.
# BEGIN failed--compilation aborted at lib/Rex/Helper/Rexfile/ParamLookup.pm
line 14.
# Compilation failed in require at lib/Rex.pm line 580.
# BEGIN failed--compilation aborted at lib/Rex/CLI.pm line 44.
# Compilation failed in require at
/usr/share/perl5/vendor_perl/Test/UseAllModules.pm line 71.
# BEGIN failed--compilation aborted at
/usr/share/perl5/vendor_perl/Test/UseAllModules.pm line 71.
#   Failed test 'use Rex::Test::Base::has_service_stopped;'
#   at /usr/share/perl5/vendor_perl/Test/UseAllModules.pm line 71.
# Tried to use 'Rex::Test::Base::has_service_stopped'.
# Error:  Attempt to reload Rex/Helper/Rexfile/ParamLookup.pm aborted.
# Compilation failed in require at lib/Rex.pm line 580.
# BEGIN failed--compilation aborted at lib/Rex/Test/Base/has_service_stopped.pm
line 14.
# Compilation failed in require at
/usr/share/perl5/vendor_perl/Test/UseAllModules.pm line 71.
# BEGIN failed--compilation aborted at
/usr/share/perl5/vendor_perl/Test/UseAllModules.pm line 71.
#   Failed test 'use Rex::Resource::firewall;'
#   at /usr/share/perl5/vendor_perl/Test/UseAllModules.pm line 71.
# Tried to use 'Rex::Resource::firewall'.
# Error:  Attempt to reload Rex/Helper/Rexfile/ParamLookup.pm aborted.
# Compilation failed in require at lib/Rex.pm line 521.
# BEGIN failed--compilation aborted at lib/Rex/Resource/firewall.pm line 65.
# Compilation failed in require at
/usr/share/perl5/vendor_perl/Test/UseAllModules.pm line 71.
# 

[Bug 1120788] Review Request: Rex - Tool for Automation, Remote Execution and Configuration Deployment

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1120788



--- Comment #7 from Dominic Hopf  ---
I'm sorry for my unresponsiveness the last months, been busy with work and so
on. I now have vacations for some days and I'll be glad if you're still
interested in reviewing the package. I updated it to 1.4.1 today:

Spec URL: https://dmaphy.fedorapeople.org/Rex/Rex.spec
SRPM URL: https://dmaphy.fedorapeople.org/Rex/Rex-1.4.1-1.fc26.src.rpm
RPM URL: https://dmaphy.fedorapeople.org/Rex/Rex-1.4.1-1.fc26.noarch.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1474033] Review Request: ucx - Communication library implementing high-performance messaging

2017-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1474033



--- Comment #3 from Andrey Maslennikov  ---
Thanks a lot for the review! I'll be back with fixes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org