[Bug 1476440] Review Request: gimp-luminosity-masks - Luminosity mask channels plug-in for Gimp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476440



--- Comment #1 from Luya Tshimbalanga  ---
Scratch build result:
https://koji.fedoraproject.org/koji/taskinfo?taskID=20875267

rpmlint result:
rpmlint rpmbuild/RPMS/noarch/gimp-luminosity-masks-0-1.fc26.noarch.rpm 
gimp-luminosity-masks.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings

The reason for no-documentation is the package is an scriptfu addon for gimp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476440] New: Review Request: gimp-luminosity-masks - Luminosity mask channels plug-in for Gimp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476440

Bug ID: 1476440
   Summary: Review Request: gimp-luminosity-masks  - Luminosity
mask channels plug-in for Gimp
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: l...@fedoraproject.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://luya.fedorapeople.org/packages/SPECS/gimp-luminosity-masks.spec
SRPM URL:
https://luya.fedorapeople.org/packages/SRPMS/gimp-luminosity-masks-0-1.fc26.src.rpm
Description: Script-Fu script generating a full set of Light, Dark, and 
Midtone masks as channels for your image.
Fedora Account System Username: luya

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476438] Review Request: clustersos - collect multiple sosreports simultaneously

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476438

Jake Hunsaker  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476438] New: Review Request: clustersos - collect multiple sosreports simultaneously

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476438

Bug ID: 1476438
   Summary: Review Request: clustersos - collect multiple
sosreports simultaneously
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jhunsa...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://people.redhat.com/jhunsake/clustersos/clustersos.spec
SRPM URL:
http://people.redhat.com/jhunsake/clustersos/clustersos-1.1.1-1.fc25.src.rpm
Description: clustersos is a utility designed to capture sosreports from
multiple nodes at once and collect them into a single archive.
Fedora Account System Username: turboturtle


F25 koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20875013

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460917] Review Request: rpkg - Command-line client tool to DistGit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460917



--- Comment #29 from Fedora Update System  ---
rpkg-client-0.8-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-035046c4e8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476434] Review Request: Bstrlib - Better String Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476434

Ye Cheng <18969068...@163.com> changed:

   What|Removed |Added

 CC||18969068...@163.com
 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476434] New: Review Request: Bstrlib - Better String Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476434

Bug ID: 1476434
   Summary: Review Request: Bstrlib - Better String Library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: 18969068...@163.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: 
https://copr-be.cloud.fedoraproject.org/results/yecheng/bstrlib/fedora-26-i386/00584634-bstrlib/bstrlib.spec

SRPM URL: 
https://copr-be.cloud.fedoraproject.org/results/yecheng/bstrlib/fedora-26-i386/00584634-bstrlib/bstrlib-1.0.0-0.fc26.src.rpm

Description: A string data type abstraction superior to that of C standard
library.

Fedora Account System Username: yecheng

A makefile is supplied by packager to build this shared library.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460917] Review Request: rpkg - Command-line client tool to DistGit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460917



--- Comment #28 from Fedora Update System  ---
rpkg-client-0.8-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-fb518765d0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475778] Review Request: golang-github-google-go-genproto - Go generated proto packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475778



--- Comment #5 from Fedora Update System  ---
golang-github-google-go-genproto-0-0.1.git411e09b.fc26 has been pushed to the
Fedora 26 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-721e98e7f8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475778] Review Request: golang-github-google-go-genproto - Go generated proto packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475778

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-google-go-genproto-0-0.1.git411e09b.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f8525e32d4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460917] Review Request: rpkg - Command-line client tool to DistGit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460917

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #27 from Fedora Update System  ---
rpkg-client-0.8-1.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-570f1396db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475536] Review Request: python-pygments2 - Syntax highlighting engine written in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475536

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
python-pygments2-2.2.0-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-9ea1ba80aa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465130] Review Request: nuvola-app-8tracks - 8tracks for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465130



--- Comment #1 from mgans...@alice.de  ---
*** Bug 1476291 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476291] Review Request: nuvola-app-8tracks - 8tracks for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476291

mgans...@alice.de  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2017-07-28 14:09:01



--- Comment #1 from mgans...@alice.de  ---


*** This bug has been marked as a duplicate of bug 1465130 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043

Kevin Fenzi  changed:

   What|Removed |Added

 CC||ke...@scrye.com



--- Comment #33 from Kevin Fenzi  ---
So, the problem is actually that the old libibverbs package had no dependency
on perl, but this new one (subpackage of rdma-core) does. This results in the
rawhide composes failing because lorax prunes out perl and then the
/usr/bin/rxe_cfg script has no perl and errors out. 

So, very short term I have just untagged rdma-core again, so we can hopefully
get a rawhide compose today or this weekend. 

Slightly longer term, we have put in a PR to make lorax not prune perl: 
https://github.com/rhinstaller/lorax/pull/228 once thats merged and in a
rawhide lorax build we can retag or rebuild rdma-core

Longer term still, it would sure be nice if we didn't have to have perl on
minimal images. I don't know how important rxe_cfg is or if it could be
re-written to work with system-python or as a binary, but that would sure be
nice 
to drop the dep on perl here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476085] Review Request: libsemigroups - C++ library for semigroups and monoids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476085



--- Comment #5 from Michael Cullen  ---
Robert-André - Ah yeah I thought that might be the case

A few more comments:

* libsemigroups.x86_64: W: spelling-error %description -l en_US initialise ->
initialize

yeah I know, I'm british too but the package guidelines are for american
english spellings :-)

* libsemigroups.x86_64: W: undefined-non-weak-symbol
/usr/lib64/libsemigroups.so.0.0.0 pthread_create

looks to me like you're missing the -pthread compiler option

I'd agree about the docs going into a separate subpackage

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476085] Review Request: libsemigroups - C++ library for semigroups and monoids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476085



--- Comment #4 from Robert-André Mauchin  ---
No problem with me. I'm just helping around while hoping for a sponsor.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1466523] Review Request: python-blurb - Command-line tool to manage CPython Misc/NEWS.d entries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1466523

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-07-20 04:11:57 |2017-07-28 13:20:01



--- Comment #13 from Fedora Update System  ---
python-blurb-1.0.0-1.post1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476085] Review Request: libsemigroups - C++ library for semigroups and monoids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476085



--- Comment #3 from Michael Cullen  ---
Robert-André: if you want to take this to completion feel free, but since you
didn't claim it I will as part of a review swap with bug 1476014

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476085] Review Request: libsemigroups - C++ library for semigroups and monoids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476085

Michael Cullen  changed:

   What|Removed |Added

 CC||mich...@cullen-online.com
   Assignee|nob...@fedoraproject.org|mich...@cullen-online.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476014] Review Request: icemon - Icecream GUI monitor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476014



--- Comment #4 from Michael Cullen  ---
Thanks! I thought I saw something saying the iconcache update wasn't needed now
but I must have been mistaken.

Good spot on that build log download attempt!

You didn't mention it, but after taking a look at your review (which I'll keep
an eye on even though someone else got there before me with comments) I was
reminded to add gcc-c++ as a BuildRequires - I suspect it's already pulled in
via qt5-devel but it's probably better to be explicit!

updated spec/srpm:

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/mich181189/icemon/fedora-rawhide-ppc64le/00584520-icemon/icemon.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/mich181189/icemon/fedora-rawhide-ppc64le/00584520-icemon/icemon-3.1.0-4.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434750] Review Request: uom-systems - Units of Measurement Systems ( JSR 363)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434750

Dave Brolley  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|brol...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434746] Review Request: uom-se - Unit Standard (JSR 363) implementation for Java SE 8 and above

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434746

Dave Brolley  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|brol...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476325] python-stestr: A test runner runner similar to testrepository

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476325

Haïkel Guémar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Target Release|trunk   |---
 CC||karlthe...@gmail.com,
   ||package-review@lists.fedora
   ||project.org
  Component|Package Review  |Package Review
Version|trunk   |rawhide
   Assignee|hgue...@redhat.com  |karlthe...@gmail.com
Product|RDO |Fedora



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476085] Review Request: libsemigroups - C++ library for semigroups and monoids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476085



--- Comment #2 from Jerry James  ---
Thank you for the review, Robert-André.

(In reply to Robert-André Mauchin from comment #1)
>  - gcc-c++ is not needed as a BuildRequires. See:
> http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

That page is out of date.  See
https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B for the latest
guidelines.

>  - You can use the macro %{__rm} instead of rm alone.

I can, but I don't like those macros.  They seem to me to add verbosity for no
gain.

>  - You should use the %make_build macro instead of make %{?_smp_mflags}

Okay.

>  - Per guidelines, "large documentation must go in a -doc subpackage. Large
> could be size (~1MB) or number of files". Your documentation has a large
> number of files (320) and is nearly 3MB in size, it is thus considered
> "large" and should be in a separate -doc subpackage.

Okay, I will fix this when I get home from work and upload a new package. 
Thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476291] New: Review Request: nuvola-app-8tracks - 8tracks for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476291

Bug ID: 1476291
   Summary: Review Request: nuvola-app-8tracks - 8tracks for
Nuvola Player 3
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mgans...@online.de
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-8tracks.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-8tracks-5.2-1.fc26.src.rpm

Description: Integration of 8tracks into your linux desktop via Nuvola Player.
Fedora Account System Username: martinkg

rpmlint -i -v nuvola-app-8tracks.spec
/home/martin/rpmbuild/SRPMS/nuvola-app-8tracks-5.2-1.fc26.src.rpm
/home/martin/rpmbuild/RPMS/noarch/nuvola-app-8tracks-5.2-1.fc26.noarch.rpm
nuvola-app-8tracks.spec: I: checking
nuvola-app-8tracks.spec:30: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.

nuvola-app-8tracks.spec: I: checking-url
https://github.com/tiliado/nuvola-app-8tracks/archive/5.2.tar.gz#/nuvola-app-8tracks-5.2.tar.gz
(timeout 10 seconds)
nuvola-app-8tracks.src: I: checking
nuvola-app-8tracks.src: W: spelling-error %description -l en_US linux -> Linux
The value of this tag appears to be misspelled. Please double-check.

nuvola-app-8tracks.src: I: checking-url
https://github.com/tiliado/nuvola-app-8tracks (timeout 10 seconds)
nuvola-app-8tracks.src:30: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.

nuvola-app-8tracks.src: I: checking-url
https://github.com/tiliado/nuvola-app-8tracks/archive/5.2.tar.gz#/nuvola-app-8tracks-5.2.tar.gz
(timeout 10 seconds)
nuvola-app-8tracks.noarch: I: checking
nuvola-app-8tracks.noarch: W: spelling-error %description -l en_US linux ->
Linux
The value of this tag appears to be misspelled. Please double-check.

nuvola-app-8tracks.noarch: I: checking-url
https://github.com/tiliado/nuvola-app-8tracks (timeout 10 seconds)
nuvola-app-8tracks.noarch: W: desktopfile-without-binary
/usr/share/applications/eu.tiliado.NuvolaApp8tracks.desktop nuvola
the .desktop file is for a file not present in the package. You should check
the requires or see if this is not a error

2 packages and 1 specfiles checked; 0 errors, 5 warnings.

%changelog
* Fri Jul 28 2017 Martin Gansser  - 5.2-1
- initial build

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469331] Review Request: fedrepo-req - A CLI tool that provides an easy way to submit ticket requests for packaging tasks in Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469331



--- Comment #28 from Fedora Update System  ---
fedrepo-req-0.3.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6b16eeef6d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469331] Review Request: fedrepo-req - A CLI tool that provides an easy way to submit ticket requests for packaging tasks in Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469331



--- Comment #29 from Fedora Update System  ---
fedrepo-req-0.3.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5496b02e1a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469331] Review Request: fedrepo-req - A CLI tool that provides an easy way to submit ticket requests for packaging tasks in Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469331



--- Comment #27 from Fedora Update System  ---
fedrepo-req-0.3.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c83dab08bc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469331] Review Request: fedrepo-req - A CLI tool that provides an easy way to submit ticket requests for packaging tasks in Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469331



--- Comment #26 from Fedora Update System  ---
fedrepo-req-0.3.0-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-7cf013efdd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268360] Review Request: rubygem-simple_oauth - Simply builds and verifies OAuth headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268360

Pavel Valena  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #21 from Pavel Valena  ---
Everything looks fine now, therefore

I APPROVE this package.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1473314] Review Request: rclone - rsync for cloud storage

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1473314

Robert-André Mauchin  changed:

   What|Removed |Added

 Depends On||1476281




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1476281
[Bug 1476281] Please update the package to a more recent version
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476237] Review Request: perl-Graphics-TIFF - Perl extension for the LibTIFF library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476237

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1378895




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1378895
[Bug 1378895] 8-bpp TIFF images are broken in the resulting PDF document
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476237] New: Review Request: perl-Graphics-TIFF - Perl extension for the LibTIFF library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476237

Bug ID: 1476237
   Summary: Review Request: perl-Graphics-TIFF - Perl extension
for the LibTIFF library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-Graphics-TIFF/perl-Graphics-TIFF.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-Graphics-TIFF/perl-Graphics-TIFF-4-1.fc27.src.rpm
Description:
The Graphics::TIFF module allows a Perl developer to access TIFF images using
LibTIFF library in a Perlish and object-oriented way.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1473314] Review Request: rclone - rsync for cloud storage

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1473314
Bug 1473314 depends on bug 1475879, which changed state.

Bug 1475879 Summary: Review Request: golang-github-golang-appengine - Provides 
APIs for interacting with App Engine services
https://bugzilla.redhat.com/show_bug.cgi?id=1475879

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475879] Review Request: golang-github-golang-appengine - Provides APIs for interacting with App Engine services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475879

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-07-28 05:53:15



--- Comment #1 from Robert-André Mauchin  ---
Already packaged:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-golang-appengine/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476201] New: Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201

Bug ID: 1476201
   Summary: Review Request: qdirstat - Qt-based directory
statistics
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: zebo...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



SPEC: https://github.com/eclipseo/packaging/blob/69e572f/qdirstat.spec
SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/6379/20846379/qdirstat-1.4-3.fc27.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20846376t

Description: 
QDirStat is a graphical application to show where your disk space has gone
and to help you to clean it up.

This is a Qt-only port of the old Qt3/KDE3-based KDirStat, now based on the
 latest Qt 5. It does not need any KDE libs or infrastructure. It runs on
 every X11-based desktop on Linux, BSD and other Unix-like systems.

FAS username: eclipseo

I am looking for as sponsorship.

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476085] Review Request: libsemigroups - C++ library for semigroups and monoids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476085

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
Hello,


A couple of points regarding your package:

 - gcc-c++ is not needed as a BuildRequires. See:
http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

 - You can use the macro %{__rm} instead of rm alone.

 - You should use the %make_build macro instead of make %{?_smp_mflags}

 - Per guidelines, "large documentation must go in a -doc subpackage. Large
could be size (~1MB) or number of files". Your documentation has a large number
of files (320) and is nearly 3MB in size, it is thus considered "large" and
should be in a separate -doc subpackage.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "GPL", "GPL (v3 or later)", "Unknown or
 generated". 27 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/libsemigroups/review-
 libsemigroups/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in 

[Bug 1431298] Review Request: php-symfony3 - Symfony PHP framework ( version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431298

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC||zbys...@in.waw.pl
   Fixed In Version||php-symfony3-3.2.11-1.fc27
 Resolution|--- |RAWHIDE
Last Closed||2017-07-28 04:38:58



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1120788] Review Request: Rex - Tool for Automation, Remote Execution and Configuration Deployment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1120788



--- Comment #12 from Robin Lee  ---
The binary package requires perl(AWS::Signature4) which is not available in
Fedora.
You may submit another request for this module. Or filter out this requirement
if it is optional.

Under %files:
- The license text file should not be duplicated in %doc.
- man pages are not necessary marked explicitly as %doc.

The "make install" line can be replaced with "make pure_install
DESTDIR=$RPM_BUILD_ROOT";

BuildRequires "perl" is not necessary.

rpmlint error is not fixed:
Rex.noarch: E: non-executable-script
/usr/share/perl5/vendor_perl/Rex/Commands/templates/append_if_no_such_line.tpl.pl
444 /usr/bin/perl

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336168] Review Request: git-lfs - Git extension for versioning large files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336168

Igor Gnatenko  changed:

   What|Removed |Added

  Flags|needinfo?(ignatenko@redhat. |
   |com)|



--- Comment #10 from Igor Gnatenko  ---
Sorry, but golang packaging just cumbersome and I'm not interested in being POC
for any of golang packages.

Sorry, guys. Still happy to co-maintain, but not primary maintainer.

Feel free to takeover this review request (note that you don't need to create
new one, but just give direct links for specs/srpms here and continue review).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org