[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475228



--- Comment #8 from Yunying Sun  ---
SRPM URL should be:
https://github.com/yunyings/share/raw/master/tpm2-abrmd-1.1.0-3.el7.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475228



--- Comment #7 from Yunying Sun  ---
%changelog
* Tue Aug 1 2017 Sun Yunying  - 1.1.0-3
- Use config option with-systemdsystemunitdir to set systemd unit file location

Spec URL:
https://raw.githubusercontent.com/yunyings/share/master/tpm2-abrmd.spec
SRPM URL:
https://github.com/yunyings/share/raw/master/tpm2-abrmd-1.1.0-2.el7.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20938040

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476434] Review Request: Bstrlib - Better String Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476434



--- Comment #4 from Ye Cheng <18969068...@163.com> ---
(In reply to Ye Cheng from comment #0)
Sorry for changing URLs again

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/yecheng/bstrlib/fedora-rawhide-i386/00585332-bstrlib/bstrlib.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/yecheng/bstrlib/fedora-rawhide-i386/00585332-bstrlib/bstrlib-1.0.0-1.fc27.src.rpm

Rpmlint may complain about "shared-lib-calls-exit
/usr/lib64/libbstrsafe.so.1.0.0 exit@GLIBC_2.2.5" The exit call is necessary
for the safe moduli to function as it can terminate execution while returning
an error code -1 when the standard string library was accidentally called.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476014] Review Request: icemon - Icecream GUI monitor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476014



--- Comment #11 from Fedora Update System  ---
icemon-3.1.0-5.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6952a04673

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404883] Review Request: python-aiosmtpd - Asyncio-based SMTP server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404883

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
python-aiosmtpd-1.0-1.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-19db6a5d92

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475483] Review Request: qbs - Cross platform build tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475483



--- Comment #9 from Sandro Mani  ---
Just a plain

# dnf update

By the way, since there is a DSO dependency 

/usr/lib64/qtcreator/plugins/libQbsProjectManager.so -> libqbscore.so.1.8

it is already taken care of that updating qt-creator will also install the new
qbs. So actually I think no Obsoletes are even necessary.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475483] Review Request: qbs - Cross platform build tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475483



--- Comment #8 from Zbigniew Jędrzejewski-Szmek  ---
What was the command that gave this error?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475483] Review Request: qbs - Cross platform build tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475483



--- Comment #7 from Sandro Mani  ---
Uhm,

 Problem 1: both package qbs-1:1.9.0-0.1.gita2fd0f3.fc27.x86_64 and
qt-creator-4.4.0-0.1.beta1.fc27.x86_64 obsolete qt-creator < 4.4.0
  - cannot install the best update candidate for package
qbs-4.3.1-2.fc27.x86_64

Would that be one of the issues in #1261034?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476014] Review Request: icemon - Icecream GUI monitor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476014

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
icemon-3.1.0-5.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-76dcb9041c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476438] Review Request: clustersos - collect multiple sosreports simultaneously

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476438



--- Comment #4 from Jake Hunsaker  ---
I forgot to mention in c0, I will need a sponsor as this is my first package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431748] Review Request: golang-github-cznic-ql - Embedded SQL database written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431748



--- Comment #15 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-cznic-ql

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431748] Review Request: golang-github-cznic-ql - Embedded SQL database written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431748



--- Comment #14 from Fabio Valentini  ---
Well, in this case, I explicitly copied the file to a *different* filename
myself, because both files are named "LICENSE" in the tarball, which would
generate a conflict.

Using something like
 %license LICENSE
 %license foo/bar/LICENSE-foobar
should work just fine though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426972] Review Request: hugo - A Fast and Flexible Static Site Generator built with love in GoLang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426972



--- Comment #25 from Fabio Valentini  ---
I have found some issues:

1) The latest release is 0.25.1. Please update your package (v0.24) for the
latest version.

2) The "-unit-test-devel" subpackage Requires "%{name}-devel" (which doesn't
exist, and leads to installation errors), and this should be replaced by
"golang-%{provider}-%{project}-%{repo}-devel".

3) The "-devel" subpackage doesn't own all directories that it should
("/usr/share/gocode/src/github.com/gohugoio/hugo" - the hugo sources root
directory - and all subdirectories of it are unowned [1]). This shouldn't
happen when you use the scripts generated by gofed.

4) You should use %global instead of %define in line 32 of the .spec file
according to the packaging guidelines.


Otherwise, the package looks good.


[1] Note: Directories without known owners:
 /usr/share/gocode/src/github.com/gohugoio/hugo/helpers,
 /usr/share/gocode/src/github.com/gohugoio/hugo/commands,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/inflect,
 /usr/share/gocode/src/github.com/gohugoio/hugo/i18n,
 /usr/share/gocode/src/github.com/gohugoio/hugo/create,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/collections,
 /usr/share/gocode/src/github.com/gohugoio/hugo/releaser,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/tplimpl,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/math,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/transform,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/cast,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/strings,
 /usr/share/gocode/src/github.com/gohugoio,
 /usr/share/gocode/src/github.com/gohugoio/hugo/transform,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/safe,
 /usr/share/gocode/src/github.com/gohugoio/hugo/media,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/crypto,
 /usr/share/gocode/src/github.com/gohugoio/hugo,
 /usr/share/gocode/src/github.com/gohugoio/hugo/bufferpool,
 /usr/share/gocode/src/github.com/gohugoio/hugo/hugolib,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/fmt,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/data,
 /usr/share/gocode/src/github.com/gohugoio/hugo/cache,
 /usr/share/gocode/src/github.com, (this is expected)
 /usr/share/gocode/src, (this is expected)
 /usr/share/gocode/src/github.com/gohugoio/hugo/output,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/internal,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/compare,
 /usr/share/gocode/src/github.com/gohugoio/hugo/hugofs,
 /usr/share/gocode, (this is expected)
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl,
 /usr/share/gocode/src/github.com/gohugoio/hugo/source,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/encoding,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/os,
 /usr/share/gocode/src/github.com/gohugoio/hugo/parser,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/time,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/lang,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/partials,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/images,
 /usr/share/gocode/src/github.com/gohugoio/hugo/tpl/urls

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431748] Review Request: golang-github-cznic-ql - Embedded SQL database written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431748



--- Comment #13 from Athos Ribeiro  ---
(In reply to Fabio Valentini from comment #12)
> Thank you for the review! I'll have a look at hugo.
> 
> > Is there any reason for the second license file not being under %license?
> 
> Yes. Writing "%license LICENSE" and "%license foo/bar/LICENSE" will result
> in the second LICENSE file overwriting the first one, since they are copied
> to the same location (%{_licensedir}/%{name}).

Oh, I didn't now that. Will it happen even in this case, where the second
license name is LICENSE.sometring ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426972] Review Request: hugo - A Fast and Flexible Static Site Generator built with love in GoLang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426972

Fabio Valentini  changed:

   What|Removed |Added

 CC||decatho...@gmail.com
   Assignee|nob...@fedoraproject.org|decatho...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431748] Review Request: golang-github-cznic-ql - Embedded SQL database written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431748



--- Comment #12 from Fabio Valentini  ---
Thank you for the review! I'll have a look at hugo.

> Is there any reason for the second license file not being under %license?

Yes. Writing "%license LICENSE" and "%license foo/bar/LICENSE" will result in
the second LICENSE file overwriting the first one, since they are copied to the
same location (%{_licensedir}/%{name}).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476458] Review Request: paho-c - MQTT client library in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476458



--- Comment #6 from Otavio R. Piske  ---
> Sorry for not pointing this out earlier, but I just consulted the Licensing 
> Guidelines:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Valid_License_Short_Names

Thanks for pointing this out. I adjusted the License text as explained.

Latest Koji build is available here:
https://koji.fedoraproject.org/koji/taskinfo?taskID=20925743
Copr build:
https://copr.fedorainfracloud.org/coprs/orpiske/paho-testing/build/585162/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431748] Review Request: golang-github-cznic-ql - Embedded SQL database written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431748

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #11 from Athos Ribeiro  ---
Is there any reason for the second license file not being under %license?

Package looks good. Approved!

As part of the review swap email, if you can, it would be great to get hugo
review: https://bugzilla.redhat.com/show_bug.cgi?id=1426972

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 756780] Review Request: xosd - On-screen display library for X

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=756780

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2012-01-30 04:49:21 |2017-07-31 12:20:33



--- Comment #14 from Fedora Update System  ---
xosd-2.2.14-24.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434744] Review Request: uom-lib - Java Units of Measurement Libraries (JSR 363)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434744

Lukas Berk  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|lb...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475483] Review Request: qbs - Cross platform build tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475483



--- Comment #6 from Sandro Mani  ---
Okay, thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429804] Review Request: parfait - Java libraries for Performance Co-Pilot (PCP)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429804

Lukas Berk  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|lb...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434749] Review Request: si-units - International System of Units ( JSR 363)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434749

Lukas Berk  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|lb...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475483] Review Request: qbs - Cross platform build tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475483



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
OK, I wasn't aware of the subpackage in rawhide. But this doesn't really change
anything: dnf doesn't care from what srpm a binary subpackage originates. So
when you just move the subpackage from qt-creator to a new srpm, nothing needs
to be done (and the Obsoletes is not useful but harmless). So yeah, I still
think you need to add the two Obsoletes as described for F26→F27+ upgrades.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475483] Review Request: qbs - Cross platform build tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475483



--- Comment #4 from Sandro Mani  ---
The qbs subpackage is only f27+ with qt-creator-4.3.x, see [1]. This actually
makes it tricky now that I think of it though, since Obsoleting qbs will work
fine for current rawhide users, but users updating from f26 to f27 will indeed
hit the scenario you describe. So I think I actually have to obsolete both
qt-creator and qbs?

[1] https://koji.fedoraproject.org/koji/packageinfo?packageID=8039

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476790] Review Request: python-stestr - A test runner runner similar to testrepository

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476790



--- Comment #3 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-stestr

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475483] Review Request: qbs - Cross platform build tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475483

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
dnf does not care which srpm a subpackage is built from. But there's no qbs
package with a version < 0:4.4.0, so the Obsoletes line right now does nothing.

But there's a different consideration: when upgrading, users who had
qt-creator-4.2.rpm installed, should get *both* qt-creator-4.4.rpm and qbs.rpm.
For that to happen, you make both packages obsolete the old name:

qt-creator: Obsoletes: %{name} < 0:4.4.0
qbs: Obsoletes: qt-creator < 0:4.4.0

Then when upgrading, dnf should install both subpackages. At least that's what
happened at some time with yum and should happen with dnf. There are bugs open
for some corner cases, it seems it doesn't always work, but doing this better
than nothing: https://bugzilla.redhat.com/show_bug.cgi?id=1261034, "Scenario
C".

> http://wiki.qt.io/Qbs → https://
> http://download.qt.io/official_releases/ → https://
Still there.

Package is APPROVED. Please fix the http URL when uploading. I think you should
add the Obsoletes, push qt-creator-4.4 and qbs in a single bodhi update, and
test if the upgrades work as expected.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476489] Review Request: xfce4-statusnotifier-plugin - Panel area status notifier plugin for Xfce4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476489



--- Comment #4 from Zamir SUN  ---
(In reply to Robert-André Mauchin from comment #3)
> >What's more, it will fail to rpmbuild if a validate is added
> 
> Why would that be?

It shows 

> + desktop-file-validate 
> /home/zsun/rpmbuild/BUILDROOT/xfce4-statusnotifier-plugin-0.1.0-1.fc26.x86_64/usr/share/xfce4/panel/plugins/statusnotifier.desktop
> /home/zsun/rpmbuild/BUILDROOT/xfce4-statusnotifier-plugin-0.1.0-1.fc26.x86_64/usr/share/xfce4/panel/plugins/statusnotifier.desktop:
>  error: first group is not "Desktop Entry"
> /home/zsun/rpmbuild/BUILDROOT/xfce4-statusnotifier-plugin-0.1.0-1.fc26.x86_64/usr/share/xfce4/panel/plugins/statusnotifier.desktop:
>  error: file contains group "Xfce Panel", but groups extending the format 
> should start with "X-"
> error: Bad exit status from /var/tmp/rpm-tmp.YFI6nz (%install)

And if I look into the desktop file, it is not actually a desktop file format,
just a file with .desktop suffix.

> [Xfce Panel]
> Type=X-XFCE-PanelPlugin
> Encoding=UTF-8
> Name=Status Notifier Plugin
> Comment=Provides a panel area for status notifier items (application 
> indicators)
> Icon=xfce4-statusnotifier-plugin
> X-XFCE-Module=statusnotifier
> X-XFCE-Unique=TRUE
> X-XFCE-Internal=FALSE
> X-XFCE-API=2.0
> ~

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #7 from Zamir SUN  ---
(In reply to Robert-André Mauchin from comment #6)
> Ah indeed, I compiled locally insted of fedora-review and it passed fine.
> 
> Just one thing: you should use desktop-file-validate in %check.

Done. 

Spec URL: https://zsun.fedorapeople.org/pub/pkgs/danmaQ/danmaQ.spec
SRPM URL:
https://zsun.fedorapeople.org/pub/pkgs/danmaQ/danmaQ-0.2-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470678] Review Request: perl-Data-Dmp - Dump Perl data structures as Perl code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470678
Bug 1470678 depends on bug 1470656, which changed state.

Bug 1470656 Summary: Review Request: perl-Regexp-Stringify - Stringify a Regexp 
object
https://bugzilla.redhat.com/show_bug.cgi?id=1470656

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470656] Review Request: perl-Regexp-Stringify - Stringify a Regexp object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470656

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Regexp-Stringify-0.06-
   ||1.fc27
 Resolution|--- |RAWHIDE
Last Closed||2017-07-31 11:21:52



--- Comment #3 from Jitka Plesnikova  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474392] Review Request: perl-Test-Exec - Test that some code calls exec without terminating testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474392

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are almost ok
FIX: Please add build-requires 'make'

$ rpm -qp --requires perl-Test-Exec-0.04-1.fc27.noarch.rpm | sort | uniq -c
  1 perl(base)
  1 perl(Exporter)
  1 perl(:MODULE_COMPAT_5.26.0)
  1 perl(Return::MultiLevel)
  1 perl(strict)
  1 perl(Test2::API) >= 1.302015
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test-Exec-0.04-1.fc27.noarch.rpm | sort | uniq -c
  1 perl(Test::Exec) = 0.04
  1 perl-Test-Exec = 0.04-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Test-Exec*
perl-Test-Exec.noarch: W: spelling-error %description -l en_US eval -> veal,
vela, val
perl-Test-Exec.src: W: spelling-error %description -l en_US eval -> veal, vela,
val
2 packages and 1 specfiles checked; 0 errors, 2 warnings. 
Rpmlint is ok

Please correct 'FIX' issue.

Otherwise the package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474392] Review Request: perl-Test-Exec - Test that some code calls exec without terminating testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474392

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476489] Review Request: xfce4-statusnotifier-plugin - Panel area status notifier plugin for Xfce4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476489



--- Comment #3 from Robert-André Mauchin  ---
>What's more, it will fail to rpmbuild if a validate is added

Why would that be?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #6 from Robert-André Mauchin  ---
Ah indeed, I compiled locally insted of fedora-review and it passed fine.

Just one thing: you should use desktop-file-validate in %check.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476790] Review Request: python-stestr - A test runner runner similar to testrepository

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476790

Haïkel Guémar  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Haïkel Guémar  ---
I noted that running tests will require python-subunit2sql to be reviewed
first.
I hereby approve this package into Fedora Packages Collection, please proceed
with pkgdb request.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or
 generated", "*No copyright* Apache (v2.0)". 38 files have unknown
 license. Detailed output of licensecheck in /home/haikel/1476790
 -python-stestr/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-stestr , python3-stestr , python-stestr-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: 

[Bug 1476773] Review Request: python-subunit2sql - Command to Read a subunit file or stream and put the data in a SQL DB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476773

Haïkel Guémar  changed:

   What|Removed |Added

 CC||karlthe...@gmail.com
 Blocks||1427510 (RDO-PIKE)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1427510
[Bug 1427510] Tracker: Blockers and Review requests for new RDO Pike
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476489] Review Request: xfce4-statusnotifier-plugin - Panel area status notifier plugin for Xfce4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476489



--- Comment #2 from Zamir SUN  ---
Hi, thanks for the review.

> - If you're installing a .desktop file, you must validate it in %check: 

IMO this is not a general desktop file. It is for xfce use only. I checked
various xfce plugins, and none of them implement a validate. For example,
http://pkgs.fedoraproject.org/cgit/rpms/xfce4-calculator-plugin.git/tree/xfce4-calculator-plugin.spec
http://pkgs.fedoraproject.org/cgit/rpms/xfce4-battery-plugin.git/tree/xfce4-battery-plugin.spec
What's more, it will fail to rpmbuild if a validate is added.

> - debuginfo-without-sources:
The same as I stated in 1471806, rpmlint passed on Fedora 26.
> - hardcoded-library-path:
I know where this comes from. I have a line
> mv %{buildroot}/usr/lib %{buildroot}/%{_libdir}
I find the plugin always goes into /usr/lib regardless of architecture, so I
hardcoded a mv here.

The static library problem is fixed.
Updated in place.

Spec URL:
https://zsun.fedorapeople.org/pub/pkgs/xfce4-statusnotifier-plugin/xfce4-statusnotifier-plugin.spec
SRPM URL:
https://zsun.fedorapeople.org/pub/pkgs/xfce4-statusnotifier-plugin/xfce4-statusnotifier-plugin-0.1.0-1.fc26.src.rpm

HTH.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474333] Review Request: perl-Config-INI-Reader-Multiline - Parser for INI files with line continuations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474333

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Config-INI-Reader-Multiline-1.001-1.fc27.noarch.rpm |
sort | uniq -c
  1 perl(Config::INI::Reader) >= 0.024
  1 perl(:MODULE_COMPAT_5.26.0)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Config-INI-Reader-Multiline-1.001-1.fc27.noarch.rpm |
sort | uniq -c
  1 perl(Config::INI::Reader::Multiline) = 1.001
  1 perl-Config-INI-Reader-Multiline = 1.001-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Config-INI-Reader-Multiline*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #5 from Zamir SUN  ---
Updated.

Spec URL: https://zsun.fedorapeople.org/pub/pkgs/danmaQ/danmaQ.spec
SRPM URL:
https://zsun.fedorapeople.org/pub/pkgs/danmaQ/danmaQ-0.2-1.fc26.src.rpm

> danmaQ-debuginfo.x86_64: E: debuginfo-without-sources
After several hours test, I assume this is a bug with fedora-review. I assume
you configured your mock to use rawhide. If so, you can see it will generate a
danmaQ-debugsource-0.2-1.fc27.x86_64.rpm in results dir, while rpmlint
currently don't detect this one. RPMlint passed on Fedora 26.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476790] Review Request: python-stestr - A test runner runner similar to testrepository

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476790

Haïkel Guémar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||karlthe...@gmail.com
 Blocks||1427510 (RDO-PIKE)
   Assignee|nob...@fedoraproject.org|karlthe...@gmail.com
  Flags||fedora-review?




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1427510
[Bug 1427510] Tracker: Blockers and Review requests for new RDO Pike
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476790] Review Request: python-stestr - A test runner runner similar to testrepository

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476790

Chandan Kumar  changed:

   What|Removed |Added

 CC||chku...@redhat.com



--- Comment #1 from Chandan Kumar  ---
*** Bug 1476325 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476325] python-stestr: A test runner runner similar to testrepository

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476325

Chandan Kumar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2017-07-31 09:24:16



--- Comment #1 from Chandan Kumar  ---


*** This bug has been marked as a duplicate of bug 1476790 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476790] New: Review Request: python-stestr - A test runner runner similar to testrepository

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476790

Bug ID: 1476790
   Summary: Review Request: python-stestr - A test runner runner
similar to testrepository
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: chkumar...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://chandankumar.fedorapeople.org/python-stestr.spec
SRPM URL:
https://chandankumar.fedorapeople.org/python-stestr-0.5.0-1.fc26.src.rpm

Description: stestr is a fork of the testrepository that concentrates on being
a dedicated test runner for python projects. The generic abstraction layers 
which enabled testr to work with any subunit emitting runner are gone. 
stestr hard codes python-subunit-isms into how it works.

Fedora Account System Username: chandankumar

Successful scratch Build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=20921089

Note: python-subunit2sql package review is here:
https://bugzilla.redhat.com/show_bug.cgi?id=1476773

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474333] Review Request: perl-Config-INI-Reader-Multiline - Parser for INI files with line continuations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474333

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431748] Review Request: golang-github-cznic-ql - Embedded SQL database written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431748



--- Comment #10 from Fabio Valentini  ---
The previously missing dependencies have now been pushed to the rawhide
repositories and to the mirrors (which took some time due to the mass rebuild).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1120788] Review Request: Rex - Tool for Automation, Remote Execution and Configuration Deployment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1120788

Robin Lee  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #18 from Robin Lee  ---
This package is approved by cheeselee.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476014] Review Request: icemon - Icecream GUI monitor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476014

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476014] Review Request: icemon - Icecream GUI monitor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476014



--- Comment #9 from Fedora Update System  ---
icemon-3.1.0-5.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6952a04673

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476773] Review Request: python-subunit2sql - Command to Read a subunit file or stream and put the data in a SQL DB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476773

Matthias Runge  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mru...@redhat.com
   Assignee|nob...@fedoraproject.org|mru...@redhat.com
  Flags||fedora-review?



--- Comment #1 from Matthias Runge  ---
taking for review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1473663] Review Request: perl-Shell-Guess - Make an educated guess about the shell in use

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1473663

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Shell-Guess-0.06-1.fc27.noarch.rpm | sort | uniq -c
  1 perl(File::Spec)
  1 perl(:MODULE_COMPAT_5.26.0)
  1 perl(strict)
  1 perl(Unix::Process)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Shell-Guess-0.06-1.fc27.noarch.rpm | sort | uniq -c
  1 perl(Shell::Guess) = 0.06
  1 perl-Shell-Guess = 0.06-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Shell-Guess*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476773] New: Review Request: python-subunit2sql - Command to Read a subunit file or stream and put the data in a SQL DB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476773

Bug ID: 1476773
   Summary: Review Request: python-subunit2sql - Command to Read a
subunit file or stream and put the data in a SQL DB
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: chkumar...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://chandankumar.fedorapeople.org/python-subunit2sql.spec
SRPM URL:
https://chandankumar.fedorapeople.org/python-subunit2sql-1.8.0-1.fc26.src.rpm
Description: subunit2SQL is a tool for storing test results data in a SQL
database. Like it's name implies it was originally designed around converting
subunit streams to data in a SQL database and the packaged utilities assume a
subunit stream as the input format. However, the data model used for the DB
does not preclude using any test result format. Additionally the analysis
tooling built on top of a database is data format agnostic. However if you
choose to use a different result format as an input for the database additional
tooling using the DB api would need to be created to parse a different test
result output format. It's also worth pointing out that subunit has several
language library bindings available. So as a user you could create a small
filter to convert a different format to subunit.

Fedora Account System Username: chandankumar
Successful Koji Build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=20919605

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470656] Review Request: perl-Regexp-Stringify - Stringify a Regexp object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470656



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Regexp-Stringify

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421041] Review Request: deepin-gettext-tools - Deepin Gettext Tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421041



--- Comment #9 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/deepin-gettext-tools

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419332] Review Request: deepin-shortcut-viewer - deepin shortcut viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419332



--- Comment #4 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/deepin-shortcut-viewer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419317] Review Request: deepin-terminal - terminal emulation application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419317



--- Comment #9 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/deepin-terminal

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476014] Review Request: icemon - Icecream GUI monitor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476014



--- Comment #8 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/icemon

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1120788] Review Request: Rex - Tool for Automation, Remote Execution and Configuration Deployment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1120788



--- Comment #17 from Dominic Hopf  ---
Somehow the dependency management is a bit confusing to me today. Until today I
was assuming that everything I BuildRequire is a Require afterwards anyway.

The perl(Net::SSH2) requirement actually is there, defined as BuildRequires.
But that obviously wasn't enough, for whatever reason I didn't understand.

I now explicitly list that Require in the spec file, along with some other
stuff. Not sure why I need to mention those explicitly when the requirement to
AWS::Signature4 was generated automagically. Probably something within the
upstream build system I need to dig even deeper.  

Spec URL: https://dmaphy.fedorapeople.org/Rex/Rex.spec
SRPM URL: https://dmaphy.fedorapeople.org/Rex/Rex-1.4.1-6.fc26.src.rpm
RPM URL: https://dmaphy.fedorapeople.org/Rex/Rex-1.4.1-6.fc26.noarch.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457735] Review Request: rubygem-iniparse - Ruby library for parsing INI documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457735

František Dvořák  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
  Flags|fedora-review?  |
   |needinfo?(steve.traylen@cer |
   |n.ch)   |
Last Closed||2017-07-31 07:23:23



--- Comment #3 from František Dvořák  ---
This review seems dead, closing according to
https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews . Please
reopen, if needed.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457737] Review Request: rubygem-overcommit - Git hook manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457737
Bug 1457737 depends on bug 1457735, which changed state.

Bug 1457735 Summary: Review Request: rubygem-iniparse -  Ruby library for 
parsing INI documents
https://bugzilla.redhat.com/show_bug.cgi?id=1457735

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1473663] Review Request: perl-Shell-Guess - Make an educated guess about the shell in use

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1473663

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475483] Review Request: qbs - Cross platform build tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475483



--- Comment #2 from Sandro Mani  ---
Thanks for the comments and sorry for the late reply, I was trying to get the
tests working with upstream - still having some issues.

Uhm why obsoletes qt-creator? Qbs is currently a subpackage of qt-creator, it's
that package that should be obsoleted, not the entire qt-creator. Or am I
missing something?

Current version:
SPEC: https://smani.fedorapeople.org/review/qbs.spec
SRPM: https://smani.fedorapeople.org/review/qbs-1.8.1-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475228



--- Comment #6 from Yunying Sun  ---
Thanks Robert. I've updated SPEC & SRPMS to address the issues in comment 2:
Spec URL:
https://raw.githubusercontent.com/yunyings/share/master/tpm2-abrmd.spec
SRPM URL:
https://github.com/yunyings/share/raw/master/tpm2-abrmd-1.1.0-2.el7.src.rpm

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20917523

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460759] Review Request: python-daiquiri - Library to configure Python logging easily

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460759



--- Comment #6 from Alfredo Moralejo  ---
official package review:

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* Apache", "Unknown or generated", "*No
 copyright* Apache (v2.0)". 15 files have unknown license. Detailed
 output of licensecheck in /tmp/1460759-python-
 daiquiri/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.6/site-
 packages, /usr/lib/python3.6
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-daiquiri , python3-daiquiri , python-daiquiri-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should 

[Bug 1460759] Review Request: python-daiquiri - Library to configure Python logging easily

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460759

Alfredo Moralejo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|needinfo?(karlthered@gmail. |fedora-review+
   |com)|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475228



--- Comment #5 from Robert-André Mauchin  ---
Yes, in %install just move from the file from
%{buildroot}/%{_libdir}/systemd/system/tpm2-abrmd.service to
%{buildroot}/%{_unitdir}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475228



--- Comment #4 from Yunying Sun  ---
(In reply to Robert-André Mauchin from comment #2)
> Hello,
> 
> A couple of points first:
> 
>  - Systemd service files should be installed in %{_unitdir}. See
> https://fedoraproject.org/wiki/Packaging:Systemd#Filesystem_locations
> 
Hi Robert-Andre, one question here, without upstream change, is it possible to
set a different systemd service file installation path in spec file, to
override the upstream default(/usr/lib64/systemd/system/)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465889] Tracking: Deepin Desktop related package review tracker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465889

Zamir SUN  changed:

   What|Removed |Added

   Keywords||Tracking



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421605] Container Review Request: nginx - Platform for running nginx or building nginx-based application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421605

Pavel Zhukov  changed:

   What|Removed |Added

  Flags||needinfo?(hho...@redhat.com
   ||)



--- Comment #10 from Pavel Zhukov  ---
Any progress?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475228



--- Comment #3 from Yunying Sun  ---
Thanks Robert-Andre for the first review. 

With current upstream code base, tpm2-abrmd.service is installed at
/usr/lib64/systemd/system/tpm2-abrmd.service, not /lib/systemd/system. 

I created a ticket for upstream:
https://github.com/01org/tpm2-abrmd/issues/115,
and will update SPEC once this issue is fixed or clarified.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404883] Review Request: python-aiosmtpd - Asyncio-based SMTP server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404883

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404883] Review Request: python-aiosmtpd - Asyncio-based SMTP server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404883



--- Comment #6 from Fedora Update System  ---
python-aiosmtpd-1.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-19db6a5d92

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441728] Review Request: cld2 - Compact Language Detector 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441728

c72...@yahoo.de changed:

   What|Removed |Added

  Flags|fedora-review+  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441728] Review Request: cld2 - Compact Language Detector 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441728

c72...@yahoo.de changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #17 from c72...@yahoo.de ---
Dear Jan,
thank you very much for your review.
In the meantime I have been sponsored into the packager group.
Best regards
Wolfgang

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468665] Review Request: gsettings-qt - Qt/QML bindings for GSettings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468665

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-07-31 02:24:19



--- Comment #18 from Fedora Update System  ---
gsettings-qt-0-0.2.20170715bzr83.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/ Qt Developer work on Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421047
Bug 1421047 depends on bug 1468665, which changed state.

Bug 1468665 Summary: Review Request: gsettings-qt - Qt/QML bindings for 
GSettings
https://bugzilla.redhat.com/show_bug.cgi?id=1468665

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465889] Tracking: Deepin Desktop related package review tracker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
Bug 1465889 depends on bug 1468665, which changed state.

Bug 1468665 Summary: Review Request: gsettings-qt - Qt/QML bindings for 
GSettings
https://bugzilla.redhat.com/show_bug.cgi?id=1468665

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465884] Review Request: golang-github-cznic-lex - Support for (f) lex-like tool on .l source files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465884



--- Comment #11 from Fedora Update System  ---
golang-github-cznic-lex-0-0.1.20170112.git68050f5.fc26 has been pushed to the
Fedora 26 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468768] Review Request: domoticz - Open source Home Automation System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468768



--- Comment #13 from Fedora Update System  ---
domoticz-3.5877-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421065



--- Comment #6 from Robin Lee  ---
According to licensecheck output, this package should be "GPLv3+ and LGPLv2+"
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios

GPL (v3 or later)
-
dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/appupdateinfolist.cpp
dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/appupdateinfolist.h
dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/audioport.h
dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/audioportlist.h
dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/mirrorinfolist.cpp
dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/mirrorinfolist.h
dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/propertylist.cpp
dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/propertylist.h
dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/windowlist.cpp
dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/windowlist.h

LGPL (v2.1 or later)

dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/qtdbusextended/dbusextended.h
dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/qtdbusextended/dbusextendedabstractinterface.cpp
dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/qtdbusextended/dbusextendedabstractinterface.h
dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/qtdbusextended/dbusextendedpendingcallwatcher.cpp
dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/qtdbusextended/dbusextendedpendingcallwatcher_p.h

--
And the latest changelog entry version mis-matches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419330] Review Request: deepin-menu - deepin menu service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419330



--- Comment #16 from sensor@gmail.com ---
License tag and changelog entry were fixed.

SPEC:
https://raw.githubusercontent.com/FZUG/repo/master/rpms/deepin_project/deepin-menu.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421065



--- Comment #5 from sensor@gmail.com ---
SPEC:
https://raw.githubusercontent.com/FZUG/repo/master/rpms/deepin_project/deepin-qt-dbus-factory.spec

It's pretty good. Can i submit it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org